Description

The umask is set on more then one location with the suggested configuration. This is misleading and might lead to problems where the admin expects that the umask set in one place is used always.

Steps to reproduce

1. In the suggested configuration http://hg.moinmo.in/moin/1.9/file/1472141fa7be/wiki/server/moin.wsgi there is a comment to use

   • WSGIDaemonProcess daemonname user=someuser group=somegroup processes=5 threads=10 maximum-requests=1000 umask=0007

   • One would expect that this umask is always used by acceses via the web server (Exception: any command line calls, like xapian indexing) if it is set.

2. There is a configuration value, see http://moinmo.in/HelpOnConfiguration?highlight=%28umask%29#xapian

   • I am not sure but it looks to me as if the here configured umask is not only used for xapian (documentation fix ?).

   • With http://hg.moinmo.in/moin/1.9/rev/1472141fa7be this configured value is used for every request. If everything is fixed now then the configuration with WSGIDaemonProcess is dispensable or even misleading.

Example

Component selection

• general

Details

Workaround

Discussion

Well, the problem is that not every wsgi server / adaptor offers setting of umask. mod_wsgi does and then indeed it might be confusing, but others don't and then moin's config.umask is the only way to set an umask.

Hmm, I thought that with the new changes/bug fixes, the setting from config.umask will always be used. Only when something in the source might be wrong the default from the environment / mod_wsgi will be used?

config.umask is used after our code has made the umask call (which is rather early in request processing). In case some file gets created even before that (unclear what is affected, maybe logging - needs review), the system (or mod_wsgi) umask will be used.

Plan

• Priority:
• Assigned to:
• Status:

CategoryMoinMoinBug