Description

I installed the moinmoin_193.If i click on the "Recent Changes" OR "Find page" then i got the following script error window.

I am getting this error with IE-8. I tested on Firefox and there is no script error.

Steps to reproduce

1. Install the 1.9.3 version and click on the recent changes then got script error.

Example

Component selection

• general

Details

Workaround

replace the RecentChanges_193 with old RecentChanges_1.8.*

Discussion

If I understand this correctly, the error message says you have a long running script and asks if it should continue running the script or stop. Your workaround was to replace the 1.9.3 /macro/RecentChanges.py with the 1.8.0 version. The only change between 1.8.0 and 1.9.3 is this:

   1 === (+3,-3) MoinMoin/macro/RecentChanges.py ===
   2 @@ -172,7 +172,7 @@
   3      last_edits.sort()
   4 
   5      # set max size in days
   6 -    max_days = min(int(request.form.get('max_days', [0])[0]), _DAYS_SELECTION[-1])
   7 +    max_days = min(int(request.values.get('max_days', 0)), _DAYS_SELECTION[-1])
   8      # default to _MAX_DAYS for users without bookmark
   9      if not max_days:
  10          max_days = _MAX_DAYS
  11 @@ -269,7 +269,7 @@
  12          d['rc_update_bookmark'] = page.link_to(request, _("Set bookmark"), querystr={'action': 'bookmark', 'time': '%d' % version}, rel='nofollow')
  13 
  14      # set max size in days
  15 -    max_days = min(int(request.form.get('max_days', [0])[0]), _DAYS_SELECTION[-1])
  16 +    max_days = min(int(request.values.get('max_days', 0)), _DAYS_SELECTION[-1])
  17      # default to _MAX_DAYS for useres without bookmark
  18      if not max_days and not bookmark_usecs:
  19          max_days = _MAX_DAYS

I was unable to reproduce the problem on IE8 with Windows/7 with Python 2.6.5 and Apache 2.2.14. I copied the 1.8.0 version of RecentChanges.py to 1.9.3 and verified that it does work. But I cannot understand how your workaround would have any effect on any Javascript functions that would suppress the error.

Suggestions:

• Copy back the 1.9.3 version of RecentChanges.py and verify you can reproduce the error.

• Copy the common.js from http://moinmo.in/MoinMoinBugs/1.9.3IE7ScrollsToLeftUncontrollably to /htdocs/common/js/ and test again.

If you are running your wiki on an intranet, IE8 runs in IE7 compatibility mode by default. Click on Tools, Compatibility View Settings, and note the status of the Display Intranet Sites in Compatibility View checkbox. Unless you have a application that requires IE7 compatibility mode, you probably want to uncheck the box.

Please report your testing results back here.

• -- RogerHaase 2010-08-13 04:01:01

Plan

• Priority:
• Assigned to:
• Status:

CategoryMoinMoinBug