Description
If a MoinMoin wiki, like this one, has a base URL with no trailing part, some browsers repeatedly request favicon.ico which is passed to the wiki engine.
This has 2 main effects:
You can end up with spurious favicon.ico entries in the page trail (not sure how thats happening but I'm definitely seeing it)
Your wiki can be requested for one favicon.ico request for each page request because browsers just don't know when to quit
This is not so much a wiki as a browser bug that the wiki gets lumbered with. However getting favicon.ico in the page trail was very unexpected.
Example
I see this on this wiki using Firefox
Details
This Wiki.
Discussion
I'd like to suggest adding a mechanism to allow a predefined favicon.ico to be attached to the wiki in a similar way to the current way a logo can be attached, with some default shipped in the package.
- I absolutely agree. Some basic/default favicon should be included by default, not only to eliminate this possible annoyance, but also to deliver a more simple and "ready to go" package. It is simpler for the new user to replace the existing one that create and configure another.
- I'm not sure its a good idea, as we don't supply a default logo for the wiki. The default logo in 1.3 is the sitename, as you defined in wikiconfig.py. wikiadmin might add any html fragment instead of the simple name-logo we provide. We simply should fix the favicon bug in the page trail.
- I absolutely agree. Some basic/default favicon should be included by default, not only to eliminate this possible annoyance, but also to deliver a more simple and "ready to go" package. It is simpler for the new user to replace the existing one that create and configure another.
The problem would be solved if MoinMoin would allow #Redirects to external links or direct delivery. Besides that, I suggest that you configure your webserver to serve the .ico file and not let MoinMoin serve it.
Thats fine if you are running under a full web server when a specific redirect can be applied before the redirect/cgi/whatever to MoinMoin. Will that work under Twisted (ie on this wiki) or similar? If so we probably need to add a comment to the install docs.
- Yes, should work. Its undocumented currently, though. You know, Twisted is quite twisted, theoretically it supports everything.
This do happen with Firefox but not in Safari. The bug is in the code that create the trail. It is ready to put anything in the trail very early: non existent page, favicons etc. We should be more restrictive in what we put in the trail, and maybe update it later, as the las thing in a request, not as the first thing.
The old trail used to show the current page - so it has to build the trail before you send the wiki header. But now the trail does not show this page (the navibar show it), so the trail can be updated at the end of the output.
Patch
- offer favicon
- remove non-existing pages from trail
Plan
- Priority:
- Assigned to:
- Status: fixed in 1.3 patch-252