Details

Applies to

MoinMoin 1.8

Purpose

Make the docbook more usable, in particular make it use the caching framework

Description

docbook parser: Use the caching framework for the compiled XSL file.

This no longer requires the directory where docbook.xsl lives to be
writable, or any other writable directory.

This changes the docbook configuration. Instead of setting
docbook_html_dir to a writable directory containing docbook.xml, you now
set docbook_xsl directly to the path to docbook.xml. The old style is
still support though (but no longer requires a writable directory.

Patch

Patch consists of two commits:

• 1.patch

• 2.patch

Discussion

• Nice patch. Maybe you want to change the code to use a single CacheEntry, storing a pickle of a tuple (filename, timestamp, compiled_data).

  • Willdo. Why also store timestamp? Is there any advantage over using the existing needsUpdate method (which uses the timestamp of the cache file)?
    • Well, if you store filename and compiled_data into one cache, you have to load that cache anyway to check for filename change. Maybe some day we need to store that cache not into a cache FILE, but into some db or whatever. So that cache file won't have a filestamp any more to compare with, but maybe we'll transparently handle that, let's see...
  • I've changed the code to use a single cache entry as you proposed.

Plan

• Priority:
• Assigned to:
• Status:

CategoryMoinMoinPatch