Details

Applies to

MoinMoin 1.9.3, MoinMoin/wikisync.py

Purpose
Show an unhandled XMLRPC fault correctly when synchronizing between wikis.
Description
The xmlrpclib.Fault exception handling in the wikisync does not print the underlying error. Instead it shows an empty string.

Patch

   1 183c183
   2 <             raise UnsupportedWikiException("xmlrpclib.Fault: %s" % str(err))
   3 ---
   4 >             raise UnsupportedWikiException("XMLRPC fault occured: %s (Code: %d)" % (err.faultString, err.faultCode) )

XMLRPCFaultMessageFix.patch

Discussion

preferable is a unified patch (diff -u)

I tried str(err) for python 2.5 and 2.7 and both gave valid representations of the fault. -- ThomasWaldmann 2012-09-16 21:38:17

Plan

CategoryMoinMoinPatch

MoinMoin: MoinMoinPatch/SyncXMLRPCFaultMessageFix (last edited 2012-09-16 21:38:18 by ThomasWaldmann)