MoinMoin: FeatureRequests/LinkToDiffInSubscriptionMail

Short description

The subscription emails are pretty ugly. It´s difficult to see, what has changed. Would it be possible to send the output of "action=diff" to the user as HTML-mail?

A simple improvement is to put a link to the diff in the mail. A patch to v1.5.4. (Should I submit it to the patches page?)

Index: MoinMoin/PageEditor.py
===================================================================
RCS file: /cvs/TPS/moin/MoinMoin/PageEditor.py,v
retrieving revision 1.7
diff -u -r1.7 PageEditor.py
--- MoinMoin/PageEditor.py      3 Aug 2006 12:12:28 -0000       1.7
+++ MoinMoin/PageEditor.py      21 Aug 2006 14:01:59 -0000
@@ -562,12 +562,17 @@
         """
         _ = lambda s, formatted=True, r=self.request, l=email_lang: r.getText(s, formatted=formatted, lang=l)

+        pagelink = self.request.getQualifiedURL(self.url(self.request))
+        if len(revisions) >= 2:
+            pagelink += "?action=diff&rev2=%i&rev1=%i" % tuple(revisions[:2])
+
+
         mailBody = _("Dear Wiki user,\n\n"
             'You have subscribed to a wiki page or wiki category on "%(sitename)s" for change notification.\n\n'
             "The following page has been changed by %(editor)s:\n"
             "%(pagelink)s\n\n", formatted=False) % {
                 'editor': self.uid_override or user.getUserIdentification(self.request),
-                'pagelink': self.request.getQualifiedURL(self.url(self.request)),
+                'pagelink': pagelink,
                 'sitename': self.cfg.sitename or self.request.getBaseURL(),
         }

-- TobiasPolzin 2006-08-22 10:15:01

Committed to main-1.6, rev ac7e2218a298. -- AlexanderSchremmer 2006-09-03 00:41:25

CategoryFeatureImplemented