Description

The new toggle comment menu item shows a different mouse-hover behaviour than the other menu items: no text-decoration, a text cursor instead of the normal cursor for <a hrefs>

Steps to reproduce

1. do this...

Example

Component selection

• general

Details

Workaround

Discussion

Here's a patch of theme/_init_.py for moin-1-6-main-4cfb61592fe4

   1 --- __init__old.py	2007-02-28 23:24:50.000000000 +0100
   2 +++ __init__.py	2007-02-28 23:32:02.000000000 +0100
   3 @@ -1067,7 +1067,7 @@
   4                       editbar_actions.append(self.supplementation_page_nameLink(page))
   5               elif editbar_item == 'Comments':
   6                   # we just use <a> to get same style as other links: 
   7 -                 editbar_actions.append('<a id="toggleCommentsButton" onClick="toggleComments();">%s</a>' % _('Comments'))
   8 +                 editbar_actions.append('<a href="#" id="toggleCommentsButton" onClick="toggleComments();return false;">%s</a>' % _('Comments'))
   9               elif editbar_item == 'Edit':
  10                   editbar_actions.append(self.editorLink(page))
  11               elif editbar_item == 'Info':

_init_.diff

see also http://blog.reindel.com/2006/08/11/a-hrefjavascriptvoid0-avoid-the-void/ for an explanation of the given solution

InlineComments are a great idea. However one criteria for accessible sites is that the page should still be usable with css disabled. It's now the question whether a page is still usable for normal users if all expert-comments are inlined there without beeing (visually and textually) marked as comments anymore (Please try that in test.wikiwikiweb). Therefore I would prefer some serverside solution (like a switch to print-view) instead of a javascript based clientside solution. Maybe we can add also some extra text "Comment" ..."Comment end" wrapping the comments section. This text could be visually hidden but if stylesheets are disabled that text is nevertheless shown. At the same time comments would be also accessible since the marking of important things only by color is avoided since some extra information is introduced for screenreaders. I.e.

• Comment sections should not only be wrapped by a comment div class, they should also start/end with some span elements  <span class="screenreader_info">Comment:</span> and <span class="screenreader_info">Comment end</span> with

•         /* Visually hidden information for screenreaders,
          i.e. is read but not displayed */
          .screenreader_info {
              position: absolute;
              top: -10000px;
              left: -10000px;
          }

-- OliverSiemoneit 2007-02-28 23:07:09

And don't miss to add it to navibar in multiconfig. -- ReimarBauer 2007-03-01 07:41:26

Plan

• Priority:

• Assigned to: ThomasWaldmann

• Status: fixed in 1.6 branch (except the accessability stuff which should please go to another bug report)

CategoryMoinMoinBugFixed