Description

do_show in MoinMoin/actions/__init__.py doesn't handle request params.

Steps to reproduce

  1. add query params to url (with or without ?action=do_show, since show is default action)

Example

http://moinmo.in/?action=show&content_only=1

Component selection

Details

MoinMoin Version

1.9.0rc2

OS and Version

Python Version

Server Setup

Server Details

Language you are using the wiki in (set in the browser/UserPreferences)

Workaround

   1 --- moin-1.9.0rc2/MoinMoin/action/__init__.py   2009-11-29 04:03:10.000000000 +0300
   2 +++ moin-1.9.0rc2-changed/MoinMoin/action/__init__.py   2009-12-01 21:37:03.000000000 +0300
   3 @@ -252,6 +252,11 @@
   4          Page(request, pagename).send_page()
   5      else:
   6          mimetype = request.values.get('mimetype', mimetype)
   7 +        content_only = request.values.get('content_only', content_only)
   8 +        count_hit = request.values.get('count_hit', count_hit)
   9 +        cacheable = request.values.get('cacheable', cacheable)
  10 +        print_mode = request.values.get('print_mode', print_mode)
  11 +
  12          rev = request.rev or 0
  13          if rev == 0:
  14              request.cacheable = cacheable

Discussion

I don't think this is a bug. Those do_show() params are used by action=print, action=content etc.

Plan

CategoryMoinMoinNoBug

MoinMoin: MoinMoinBugs/DoShowDoesntHandleRequestArgs (last edited 2009-12-02 00:05:17 by ThomasWaldmann)