Description

Setting

editor_default = 'text' # optional
editor_force = True

does not hide or disable editing using the GUI editor. (Tested on 1.5.5a and 1.5.8 using modern and classic theme.)

Steps to reproduce

1. Edit your wikiconfig.py (or farmconfig.py). Add the line editor_force = True in an appropriate place.

2. Restart moinmoin.
3. Visit your wiki as an anonymous user.
4. Notice that there is an "Edit (GUI)" link. (These instructions assume modern theme.)

5. Click on "Edit (GUI)". Notice that you are now in the gui editor. (This was mistaken. Notice that you are now in the text editor.)

Example

A wiki running 1.5.5a (with some patches) exhibiting this can be found here.

A wiki running a fresh 1.5.8 install exhibiting this bug can be found here.

A wiki running a fresh 1.6.0 snapshot (changeset 2144:3dd9c15c6128) exhibiting this bug can be found here.

All of these set

editor_default = 'text'
editor_force = True

I've tested that the config file is getting read by changing the theme on the line prior to these settings.

This was reported earlier by someone else on the Unsorted Questions page. ReimarBauer suggested a workaround, but I don't think that works.

My attention was drawn to this again when I read about the Gui Editor XSS bug.

Component selection

• general

Details

Workaround

Discussion

I don't understand this bug report. When clicking on edit(gui) in all of the example you gave above, always text edit is shown an not gui edit. So forcing the editor works, right? If you want to remove it from the editbar, use edit_ui, which can either be set to 'freechoice' [means both links to edit(text) and edit(gui) are shown] or 'theonepreferred' [which causes the theme only to display editor_default]. Or am I making some mistake?

The question is rather: why do we have a edit_ui config var? Forcing the editor should suffice to change also the ui, or not? That's the trouble you have run in. So this is not a bug but a usability issue in my eyes.. -- OliverSiemoneit 2007-09-03 19:08:29

Oliver is right. I simply failed to recognize that I was in the text editor. D'oh! So editor_force does work, it just leaves the ui with Edit(GUI). (Setting editor_ui to 'theonepreferred' works for users who aren't logged in, but it seems to have some problems for logged in users, in my tests.) -- DavidMontgomery

logged in users may ave theire own preferences.

idea

• discover this is because JS action!

• fixed as '.../site-packages/MoinMoin/theme/init.py'

  def html_head(self, d):
      ...
      #self.guiEditorScript(d),

  is done ... -- ZoomQuiet

Plan

• Priority:

• Assigned to: ThomasWaldmann

• Status: fixed cosmetic issue by http://hg.moinmo.in/moin/1.6/rev/933222c86f9d, http://hg.moinmo.in/moin/1.7/rev/344e33587519

CategoryMoinMoinBugFixed