Description

Moin no longer emails the change comment out.

Steps to reproduce

1. Edit a page
2. Put a message in the Comment field
3. Save the page
4. Read notification email. The comment will be absent.

Example

Can't demonstrate absence!

Component selection

events/emailnotify.py

Details

Workaround

Fix by applying patch to MoinMoin/events/emailnotify.py:

--- emailnotify.py.orig 2009-07-31 12:17:50.000000000 +1000
+++ emailnotify.py      2009-07-31 12:44:34.000000000 +1000
@@ -51,7 +51,12 @@
             'username': page.uid_override or user.getUserIdentification(request),
         }
 
-    return {'subject': subject, 'text': change['text'] + pagelink + change['diff']}
+    if change.has_key('comment'):
+        comment = _("The comment on the change is:\n%(comment)s\n\n") % {'comment': change['comment']}
+    else:
+        comment = ''
+
+    return {'subject': subject, 'text': change['text'] + pagelink + comment + change['diff']}
 
 
 def send_notification(request, from_address, emails, data):

Discussion

Many translations seem to have string commented out.

Plan

• Priority:
• Assigned to:

• Status: fixed by http://hg.moinmo.in/moin/1.8/rev/02234c0ac784 (I used the string "Comment:" which is present in translations)

CategoryMoinMoinBugFixed