Description

util/__init__.py:IsWin9x() uses find() wrong way, so in almost cases it returns True

Steps to reproduce

Create any request and it will call IsWin9x(), returning with True

Example

This is the bug:

     elif os.environ.get('comspec', '').find('command'):
         return True

Details

MoinMoin Version

1.5.3

OS and Version

2.6.16-std26-up-alt7 #1 Mon Jun 19 01:40:30 MSD 2006 i686 GNU/Linux

Python Version

2.4.3

Server Setup

apache 1.3.36

Server Details

Language you are using the wiki in (set in the browser/UserPreferences)

ru

Workaround

This is the patch: moin.IsWin9x.patch

Discussion

This was fixed in the 1.6 branch already. It was me who broke and fixed it! -- AlexanderSchremmer 2006-07-01 17:59:49

But I backported it, so you will see it in 1.5.4 that might be published at this weekend.

Plan


CategoryMoinMoinBugFixed

MoinMoin: MoinMoinBugs/IsWin9xAlwaysTrue (last edited 2007-10-29 19:19:28 by localhost)