Description
If you create an attachment or a ULR link that has a closing parenthesis before the dot in the file name, the link on the page stops early.
Steps to reproduce
- create a file with the name foo(rev1.0).doc
- upload the file as an attachment to the page
create the attachment: link on the page.
- look at the link
or
edit a page and paste in ftp://ftp.org/Minutes(6-14-06).doc in 1.6 this renders correct.
- look at the "link" created on the page
Example
Component selection
- general
Details
MoinMoin Version |
|
OS and Version |
|
Python Version |
|
Server Setup |
|
Server Details |
|
Language you are using the wiki in (set in the browser/UserPreferences) |
|
Workaround
Write the Link differently: [ftp://ftp.org/Minutes(6-14-06).doc Minutes(6-14-06).doc] (1.5)
Write the Link differently: [[ftp://ftp.org/Minutes(6-14-06).doc|Minutes(6-14-06).doc]] (1.6)
or even simpler: [ftp://ftp.org/Minutes(6-14-06).doc] (1.5)
or even simpler: [[ftp://ftp.org/Minutes(6-14-06).doc]] (1.6)
Discussion
If we would "fix" that so that filenames don't terminate at ")", you would get "wrong" behaviour in cases like this
See the file on our ftp server (ftp://ftp.org/Minutes2006-12-12.doc). In 1.6 this renders correct as of 2007-12-22.
It is fixed by new link syntax in 1.6.
IMHO the best thing to do here would be: Require that URLs containing certain unreserved characters (like parentheses and asterisk—cf. RFC 2396, sec. 2.3) are put into brackets ([[]]), or these characters are escaped as described in section 2.4 of RFC2396 (e.g. ftp://example.org/Minutes%286-14-06%29.doc → ftp://example.org/Minutes%286-14-06%29.doc ). This is similar to what we require for links containing spaces (http://example.org/%20something.txt → http://example.org/%20something.txt or [[http://example.org/ something.txt]] → http://example.org/ something.txt). -- MartinBayer 2007-11-17 23:26:10
Plan
- Priority:
- Assigned to:
- Status: behaviour was changed in 1.6. problems can be also worked around by new link syntax of 1.6
Related issue(s): MoinMoinBugs/1.6LinksNotTerminatedOnRightParenthesis