Description

When you click on "Mail account data" on the SystemAdmin page, the protocol and host part is missing in the "Password reset URL" in the generated email.

Steps to reproduce

1. open SystemAdmin Page

2. click on "Mail account data" from a user
3. The mail contains an incomplete URL without the protocol and host part.

Example

Somebody has requested to email you a password recovery token.

If you lost your password, please go to the password reset URL below or
go to the password recovery page again and enter your username and the
recovery token.

Login Name: YourName

Password recovery token: 1260560246-02c9972f3c316966f6ad7f8e8fb9c2297f4b3b18

Password reset URL: /root/?action=recoverpass&name=YourName&token=1260560246-02c9972f3c316966f6ad7f8e8fb9c2297f4b3b18

Component selection

1.9.0 user.py code line 1019

Password reset URL: %s/?action=recoverpass&name=%s&token=%s
""") % (
                        self.name,
                        tok,
                        self._request.script_root,
                        url_quote_plus(self.name),
                        tok, )

has changed from moin 1.8.6 user.py code line 1031

Password reset URL: %s/?action=recoverpass&name=%s&token=%s
""") % (
                        self.name,
                        tok,
                        self._request.getBaseURL(),
                        url_quote_plus(self.name),
                        tok, )

Details

Workaround

change user.py to

Password reset URL: %s?action=recoverpass&name=%s&token=%s
""") % (
                        self.name,
                        tok,
                        self._request.getBaseURL(),
                        url_quote_plus(self.name),
                        tok, )

Discussion

This changeset needs a review: http://hg.moinmo.in/moin/1.9/rev/87d97510de79

Plan

• Priority:
• Assigned to:

• Status: fixed by http://hg.moinmo.in/moin/1.9/rev/4a406029ad23

CategoryMoinMoinBugFixed