Description

Trying to rename a non existing page fail with the wrong error.

Steps to reproduce

Click http://moinmoin.wikiwikiweb.de/NoSuchPage?action=RenamePage

The error say that "You are not allowed" instead "The page does not exists".

Component selection

Details

1.3 and later.

Discussion

Check if the page exists before checking acl rights.


I have tested this bug under moinmoin 1.7.1 and 1.9beta4:

  1. If the the has the rights to rename the page, then the error is:

    This page is already deleted or was never created!
  2. If the user don't have the rights to delete the page, then the actions menu isn't displayed at all. (So one can't click on "Rename page" !)
  3. If the user don't have the rights to delete the page, but manually type the URL with ?action=RenamePage Then the error message is :

    You are not allowed to do RenamePage on this page. Login and try again.

The normal behavior A and B are correct. The answer C might be a little bit misleading, but I doubt there's a plan to support the situation where the user manually tweaks the url ;)


Plan


CategoryMoinMoinBugFixed

MoinMoin: MoinMoinBugs/RenamingNonExistingPage (last edited 2009-09-30 20:40:33 by FranklinPiat)