Description

1. The dbw_hide_buttons function in .../wiki/htdocs/common/js/common.js in moin 1.7.2 fails when a form element does not have a name. This may cause other javascript functions loaded by themes to not be executed under certain conditions.

2. The problem is fixed in the 1.8.0 beta 2 version, but a var name; statement should be added after the var elem; statement.

The 1.7.2 version:

function dbw_hide_buttons() {
    var form;
    var elem;

    for (var fidx = 0; fidx < document.forms.length; fidx++) {
        form = document.forms[fidx];
        for (var eidx = 0; eidx < form.elements.length; eidx++) {
            elem = form.elements[eidx];
            name = elem.name;
            if (name.substr(0,4) == 'dbw.' && name.substr(-7) == '.submit')
                elem.style.display = 'none';
        }
    }
}

The version in 1.8.0 beta 2:

function dbw_hide_buttons() {
    var form;
    var elem;

    for (var fidx = 0; fidx < document.forms.length; fidx++) {
        form = document.forms[fidx];
        for (var eidx = 0; eidx < form.elements.length; eidx++) {
            elem = form.elements[eidx];
            name = elem.name;
                        if (name) {
                                if (name.substr(0,4) == 'dbw.' && name.substr(-7) == '.submit')
                                        elem.style.display = 'none';
                        }
        }
    }
}

Steps to reproduce

Edit a wiki page under 1.7.2 with Firefox and check the Javascript Error console. There will be a name is undefined error message.

Example

n/a

Component selection

Javascript

Details

Workaround

Copy the 1.8.0 version.

Discussion

Plan

• Priority:
• Assigned to:

• Status: fixed var declaration by http://hg.moinmo.in/moin/1.8/rev/ae088388d645, fixed bug in http://hg.moinmo.in/moin/1.7/rev/361c6d95ebf3

CategoryMoinMoinBugFixed