Short description
When we add a script by {{attachment:example.py}} to a page. Then it's source is shown. A link to the attached file is shown below. Because we see it already on the screen if we click there we want to download it.
It should not again be visualized. That is one step to much to do for downloading it.
It should be changed to get.
No, it should not. It is NOT a download link, it is a link to the embedded item.
Reason: all standard links that link to another item must link to the rendering action of that item (in that case, show the AttachFile page for the attachment, with the download button and maybe the rendering), but not directly trigger a download.
This is because when migrating to moin2, links will be transformed like this:
moin 1.9 moin 2.0 -------------------------------------------------------------------------------------------- [[foo]] [foo]] link to foo rendering [[foo||&action=raw]] [foo||&do=get]] link to foo download / raw content [[attachment:bar]] [[/bar]] link to bar rendering [[attachment:bar||&do=get]] [[/bar||&do=get]] link to bar download / raw content
For moin2, it is important to link to the item rendering, because only there the item is shown with the user interface so it can be manipulated / inspected (info, modify, delete, rename, ...).
There is no user interface if you directly trigger the download.