Description

Describe the bug...

Steps to reproduce

  1. Add a new event plugin, data/plugin/events/show_bug.py, with contents 

def handle(event):
  if event.name == "PagePreSaveEvent":
    event.new_text = "replace the old text!"
  1. Edit a page and save it
  2. The page text should be saved as "replace the old text!" rather than the actual saved text, and it isn't.

Component selection

Details

MoinMoin Version

1.8.4

OS and Version

Ubuntu 9.10

Python Version

2.6.4

Server Setup

Server Details

Language you are using the wiki in (set in the browser/UserPreferences)

Workaround

Not clear, other than patching Moin with the above patch.

Discussion

some on #moin 

   1 18:59 < ThomasWaldmann> i don't think the event system was designed to modify 
   2                         the saved text
   3 18:59 < ThomasWaldmann> so it might be rather a missing feature than a bug
   4 19:00 < ThomasWaldmann> but as soon as one starts to modify savetext, order 
   5                         gets important (and I don't think we currently have any 
   6                         special order or a way to influence it)
   7 19:03 < dreimark> if lock instead of warn is used parallel editing of the same 
   8                   page is impossible

Plan

CategoryMoinMoinBug

MoinMoin: FeatureRequests/PagePreSaveEventOverridesText (last edited 2010-01-11 19:32:07 by ThomasWaldmann)