1 21:16 < CIA-19> Dmitrijs Milajevs <dimazest@gmail.com> default * 4739:3f9147c23d9c 1.9-groups-dmilajevs/ (11 files in 9 dirs): Groups2009: MoinMoin.GroupDict became MoinMoin.groups.backends.wiki_pages.Backend. request.groups proviedes access to group definitions. request.dicts was removed.
2 21:24 < ThomasWaldmann> ah, new group code
3 21:25 < dimazest> is something wrong?
4 21:29 < ThomasWaldmann> i am looking at it right now :)
5 21:29 < ThomasWaldmann> 4.12 + except AttributeError:
6 21:29 < ThomasWaldmann> 4.13 + pass
7 21:29 < ThomasWaldmann> be careful with such stuff. noone tells that the AttributeError is due to the missing update_cache, it could also be an AttributeError within that method
8 21:31 < ThomasWaldmann> (and you'll never find that problem then, because you catch the exception...)
9 21:35 < ThomasWaldmann> in general, always be careful with except/pass
10 21:36 < ThomasWaldmann> btw, what's the difference between load_cache and update_cache?
11 21:38 < dimazest> load cahche reads it, and update writes it
12 21:38 < dimazest> are read, write better names?
13 21:38 < ThomasWaldmann> btw, I just killed that SystemPages*Group stuff, maybe use something else for testing
14 21:39 < dimazest> :) ok
15 21:39 < dimazest> btw, should i pull changes from 1.9?
16 21:39 < ThomasWaldmann> (you could create an own *Group page in test setup)
17 21:40 * dimazest hopes that doing small often merges is better then one and big
18 21:40 < ThomasWaldmann> maybe after you have fixed other stuff. in generall, pulling all 1..2 weeks or so is a good idea, so it doesn't get out of sync too much.
19 21:40 < ThomasWaldmann> yes, definitely.
20 21:41 < dimazest> btw, i think this commit was too big, because in the end it was hard for me to track changes :)
21 21:42 -!- ser
22 21:42 -!- ser
23 21:42 < ThomasWaldmann> btw, for longer code, it is often useful to start with: request = self.request, so you don't need the "self." all the time
24 21:43 -!- grzywacz
25 21:43 -!- grzywacz
26 21:43 < ThomasWaldmann> dimazest: testSystemPagesGroupInDicts < that looks strange. isn't that checking some code behaviour against same code's behaviour?
27 21:44 < ThomasWaldmann> maybe rather start with writing some own group page with a few members and then use your wiki_group code to check whether it is there
28 21:46 < ThomasWaldmann> btw, if the stuff isn't called "dicts" any more, the test shouldn't be named ...InDicts either
29 21:46 < dimazest> ok
30 21:47 < dimazest> there are some naming glitches, i'm fix them in the future
31 21:47 < ThomasWaldmann> grouppages = ... # but it isn't used later!?
32 21:47 < dimazest> group expanding is needed to be done. together i tried, but without any luck
33 21:47 < dimazest> ??
34 21:48 < ThomasWaldmann> see the test code, maybe read it again, line by line, word by word
35 21:50 < dimazest> what i did is codied Moinoin._test.test_wikidicts
36 21:50 -!- grzywacz
37 21:50 < ThomasWaldmann> and please refactor the code after doing the module restructuring
38 21:50 < dimazest> and then changed code in critical places, so i need to reread this tests
39 21:51 -!- grzywacz
40 21:51 < ThomasWaldmann> and kill that DictBase/DictDict
41 21:52 < ThomasWaldmann> also, wikidicts shall get removed in the end
42 21:53 * dimazest thinking to take Melitas backend
43 21:53 < dimazest> was it working?
44 21:54 < ThomasWaldmann> in general I would say "no", but that's maybe too general
45 21:55 < dimazest> ThomasWaldmann: http://host121-107-dynamic.5-87-r.retail.telecomitalia.it:8000 this is my local repo, changest there shows which files were moed or copied
46 21:55 < ThomasWaldmann> maybe just rewrite the code and don't stick too much at what you see somewhere.
47 21:55 < dimazest> *moved
48 21:55 < dimazest> :)
49 21:55 < ThomasWaldmann> having groups and members is not THAT complicated as the code that handles it currently.
50 22:07 < ThomasWaldmann> dimazest: 10.8 \ No newline at end of file (always have a newline at EOF)
51 22:09 < dennda> Is that part of PEP8? Oo
52 22:10 < ThomasWaldmann> no, that is part of having nice diffs with no complaints at the end :P
53 22:10 < dennda> aha
54 22:10 < dimazest> :)
