MoinMoin: MacroMarket/Hits/OldDiscussion

The macro isn't working for me, because it cannot find the event-log. Shouldn't the line

    filename ="./data/event-log"

be changed into

    filename = macro.request.rootpage.getPagePath('event-log', isfile=1)

That works for me. -- BenjaminVrolijk 2005-07-15 13:27:03

• changed

I think you use MoinMoin.macro.PageHits.PageHits, because he read hits from cache of log files

-- PavelSergeev 2005-09-07 16:36:10

Probably the code could be exchanged, I'll look on that -- ReimarBauer 2005-09-07 17:04:41

This macro only works on WikiName page. It does not work on pages whose names contain space or non-ascii characters. -- RuxLi 2006-05-01 04:10:03

Hits-1.5.3-4 uploaded bug fixed for quoting pagenames and some parts refactored -- ReimarBauer 2006-05-01 16:34:01

• Thanks! I have tested it and found another problem. It does not work on pages named with both space and Chinese characters. See table below! -- RuxLi 2006-05-02 04:02:38

  • Page Name	Test Result	Comment
    TestPage	OK
    Test Page	OK	with space
    Test頁	OK
    Test 頁	Fail	with space
    頁Test	OK
    頁 Test	Fail	with space

quoting used was different

Hits-1.5.3-5 uses the same quoting as was used for the log file

• Thanks! It works! BTW, I found a trivial bug: [[Hits(noframe=0)]] has no frame. I found it when I tried to modify the code to support "noframe=2", so that it is possible to embed the counter value in normal page text (without <div>). Maybe you can consider it as a standard feature. -- RuxLi 2006-05-03 01:34:40

  • Good idea -- ReimarBauer 2006-05-03 07:28:13

Hits-1.5.3-6 uses a bit different logic now see examples

• It's great! And one more question: I just wonder why the hit count displayed is different from what in PageHits. Say, [[[Hits]] reports 604 hits and PageHits shows 332. I noticed this problem since version 1.5.3-4. -- RuxLi 2006-05-05 03:33:07

Hits-1.5.3-7 bug fix only pagename=page& should be counted in the past refering pages were counted too. This was always wrong!