Description
With log_remote_addr = False the edit lock of anonymous users is not released.
Steps to reproduce
Have a wiki at http://wiki/
Configure it with log_remote_addr = False, hard edit locking (i.e. edit_locking = 'lock 2') and allow anonymous users to edit wiki pages.
Edit http://wiki/page .
Store http://wiki/page .
Try to edit http://wiki/page again .
- The page can not be edited as it still has an edit lock from the first anonymous edit.
Example
Component selection
- edit locking code / editlog
- Edit locking uses a single log line produced by editlog as the lock contents.
- If log_remote_addr is False, that log has no IP.
- When trying to release the lock, moin compares current IP to the IP in the lock (and never succeeds because there is no IP in the lock).
Details
MoinMoin Version |
1.9.1 |
OS and Version |
SunOS sun 5.10 Generic_142901-03 i86pc i386 i86pc |
Python Version |
2.6.1 |
Server Setup |
Apache 2.2.11 |
Server Details |
mod_wsgi 3.1, mpm_prefork |
Language you are using the wiki in (set in the browser/UserPreferences) |
de |
Workaround
- Don't allow anonymous users to edit wiki pages.
- or -
Use log_remote_addr = True
- or -
- Don't use edit locking.
Discussion
If edit locking will not work with log_remote_addr = False for anonymous users then it might be nice to document this side effect.
Tested with http://hg.moinmo.in/moin/1.9/rev/9241bdfaeb6d applied on 1.9.1 : The bug is gone.
Plan
- Priority:
- Assigned to:
- Status: fixed by, please test: