Description

Viewing a page with a highlight set can give a radically different page layout - not just highlighting (obvious) but page section appear to be re-ordered.

This happens when you go to a page via a search.

Example

On this wiki, at this time, the page HelpOnMacros looks very different if viewed with a highlight added as in http://moinmoin.wikiwikiweb.de/HelpOnMacros?highlight=helponmacros

Two png screenshots have been attached. ss.png is the normal view, ss-highlight.png is with highlighting.

  • [get | view] (2004-11-02 12:47:38, 101.5 KB) [[attachment:ss-highlight.png]]
  • [get | view] (2004-11-02 12:47:20, 70.2 KB) [[attachment:ss.png]]
 All files | Selected Files: delete move to page copy to page

This rather looks like some of the quoted macros get executed when highlighting. -- ThomasWaldmann 2004-11-02 21:08:57

This is not about highlighting but about caching. If the page was not cached, you will get the broken result. Broken means that the macro output is written at the wrong location of the page. Executing the macro is just right. But not writing the output of it into the table is a bug.

In order to reproduce this without highlighting the page, just disable caching.

In Nir's fix branch, we can't reproduce the problem (he has refactored search funcs). --> maybe the search funcs were broken and didn't handle the non-cached case correctly.

Test fix branch with search fixes: http://nirs.dyndns.org/fix/HelpOnMacros?highlight=Macro

the patch

Details

This Wiki.

MoinMoin Version

Release 1.3beta3 [Revision patch-225]

Workaround

Discussion

The HTML out appears to be significantly different so I am putting this down as a MoinMoin bug rather than a browser problem.

Plan


CategoryMoinMoinBugFixed

MoinMoin: MoinMoinBugs/CachingBreakSearchMacros (last edited 2007-10-29 19:09:01 by localhost)