Description

The variables cookie_lifetime and anonymous_session_lifetime have changed in an incompatible way in moin 1.9:

in moin 1.8 1, the variables use to be:

  cookie_lifetime = INTEGER
  anonymous_session_lifetime = INTEGER

in moin 1.9 2, the variables use to be:

  cookie_lifetime = TUPLE, like 
  anonymous_session_lifetime -> NOT USED.

This prevent moinmoin from working after upgrade.

--> Please, support smooth transition, by accepting old variables (and printing a warning).

Steps to reproduce

• Use on of the moin <1.9 variable in moin>1.9 configuration file

Example

  cookie_lifetime = 12
  anonymous_session_lifetime = 0

Component selection

• authentication
• Documentation

Details

.

[error] File "/usr/lib/pymodules/python2.5/MoinMoin/user.py", line 874, in _wantTrail
[error]    return (not self.valid and self._request.cfg.cookie_lifetime[0]  # anon sessions enabled
[error]  TypeError: 'int' object is unsubscriptable

Workaround

Discussion

There is a HINT: in docs/CHANGES about this change. The dropping of the old vars was intended, because they used quite different (and rather long) variable names for basically the same stuff. If you do an upgrade, you are expected to read docs/CHANGES, esp. the HINT: lines there, they point out such stuff. -- ThomasWaldmann 2009-12-10 11:39:19

Documentation needs to be updated:

• The following examples are incorrect, because they still use deprecated variables (cookie_lifetime, anonymous_session_lifetime)

• wiki/config/more_samples/auth_session_wikiconfig_snippet

• wiki/config/more_samples/ldap_wikiconfig_snippet

MoinMaster I18n Wiki pages need to be updated (search "cookie_lifetime").

• Spanish, Chinese, Ukrainian, Portuguese and French

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=560172

Plan

• Priority:
• Assigned to:

• Status: fixed by http://hg.moinmo.in/moin/1.9/rev/ad132d9bd526 (doesn't crash, but logs error/warning and tries to make up the new config value)

CategoryMoinMoinBugFixed