Description

When page with processing instructions is marked as deprecated, processing instructions from previous revision not parsed properly and are shown as part of a page (similiary to situation when they are not it the beginning of the page).

Steps to reproduce

  1. Create page with some PI's
  2. Mark it as deprecated
  3. PI's will be shown as part of page

Example

URL: http://master19.moinmo.in/SystemPagesGroup

Component selection

Details

MoinMoin Version

Master19 wiki

OS and Version

Python Version

Server Setup

Server Details

Language you are using the wiki in (set in the browser/UserPreferences)

Workaround

Delete all PI's before deprecation. This is not possible when page has acl's and deprecator has no admin rights. 

   1 # HG changeset patch
   2 # User Eugene Syromyatnikov <evgsyr@gmail.com>
   3 # Date 1261354602 -10800
   4 # Node ID cb4eff3da6044975e31480b7f6af78949298b216
   5 # Parent  581cdc260b90b6a7744fd9cc35b7237da44b44dc
   6 Page.py: fixed adding of page contents (only page data added now, without metadata)
   7 see MoinMoin:MoinMoinBugs/DeprecatedPageInclusionErrornousPageInstructionsProcessing for details.
   8 
   9 diff -r 581cdc260b90 -r cb4eff3da604 MoinMoin/Page.py
  10 --- a/MoinMoin/Page.py  Wed Dec 16 09:20:02 2009 +0100
  11 +++ b/MoinMoin/Page.py  Mon Dec 21 03:16:42 2009 +0300
  12 @@ -1070,7 +1070,7 @@
  13              revisions = self.getRevList()
  14              if len(revisions) >= 2: # XXX shouldn't that be ever the case!? Looks like not.
  15                  oldpage = Page(request, self.page_name, rev=revisions[1])
  16 -                body += oldpage.get_raw_body()
  17 +                body += oldpage.get_data()
  18                  del oldpage
  19  
  20          lang = self.pi.get('language', request.cfg.language_default)

Discussion

Plan

CategoryMoinMoinBugFixed

MoinMoin: MoinMoinBugs/DeprecatedPageInclusionErrornousPageInstructionsProcessing (last edited 2009-12-21 00:29:34 by EugeneSyromyatnikov)