Description

Wiki groups no longer preserve ordering.

Steps to reproduce

n/a

Example

http://wireless.kernel.org/en/developers/navi

my theme code relies on ordering -- the order should be that way in the theme (compare the two lists)

Component selection

• general

Details

Workaround

Discussion

Fix:

diff --git a/MoinMoin/datastruct/backends/__init__.py b/MoinMoin/datastruct/backends/__init__.py
index 3d4f96f..c336b1b 100644
--- a/MoinMoin/datastruct/backends/__init__.py
+++ b/MoinMoin/datastruct/backends/__init__.py
@@ -180,10 +180,20 @@ class GreedyGroup(BaseGroup):
         """
         Retrieve group data from the backend and filter it to members and group_members.
         """
-        members_retrieved = set(self._backend._retrieve_members(self.name))
-
-        member_groups = set(member for member in members_retrieved if self._backend.is_group_name(member))
-        members = members_retrieved - member_groups
+        members_retrieved = list(self._backend._retrieve_members(self.name))
+        
+        member_groups = []
+        members = []
+        already = set()
+        for m in members_retrieved:
+            if m in already:
+                continue
+            already |= set([m])
+
+            if self._backend.is_group_name(m):
+                member_groups.append(m)
+            else:
+                members.append(m)
 
         return members, member_groups

I think keeping order is important -- ReimarBauer 2010-02-08 21:54:32

TODO

• update docs

• use a member set additionally for __contains__ as it is O(1) while a list is O(n).

• research / implement same behaviour for BaseDict

• add tests

Plan

• Priority:
• Assigned to:
• Status:

CategoryMoinMoinBug