Description

ModPython doesn't seem to materialize the "if-modified-since" or "if-none-match" request members, causing RSS and attachments to fail in 1.5.5a.

Steps to reproduce

1. Install MoinMoin 1.5.5a with ModPython 3.1.3

2. Attempt to get an attachment or an RSS feed from the wiki

3. Attribute Error: 'RequestModPy' object has no attribute 'if_modified_since'

We need the traceback.html for this, please.

Details

Sorry...here's the traceback.

traceback.html

Workaround

Apply this patch to request.py:

1759,1762d1758
<             #DSS Patch:
<             self.if_modified_since = None
<             self.if_none_match = None
<             #End DSS Patch

That patch doesn't seem to fit into request.py:1759, can you please verify whether your request.py is identical with the one we provide in 1.5.5a archive?

Maybe also check whether you have old request.pyc (and other *.pyc).

Please provide a patch made by diff -u. -- ThomasWaldmann 2006-09-27 14:25:56

Hmmm...I'm puzzled. I installed 1.5.5a to upgrade an existing 1.5.4 installation, but when I compare my request.py with the one in the distribution, there are many differences (and I see where you're setting self.if_modified_since. I wonder if I made a critical mistake in the installation by only copying my 1.5.4 and not deleting it before running the setup.py from the distribution. There are many differences in other files, but request.py was identical in the installed 1.5.4 and 1.5.5a directories.

I'm going to try a clean install of 1.5.5a. -- DavidSinger 2006-09-27 15:21:00

Very strange. I did a clean install, and the only .py file which differed was, indeed, request.py, which had many many differences. I'll attach a log of the install/diff in hopes that it's useful; in the meantime, I'm back on the air (and there's no problem with if-modified-since, of course!).

install-diff-log.txt

Discussion

Those attributes should be set by _setup_vars_from_std_env(). We need the traceback to find out why they are not.

Plan

• Priority:
• Assigned to:
• Status: Some distutils issue ...

CategoryMoinMoinNoBug