Description

The (rather excellent) moinmoin theming system allows you to customise the output from the page header and footer, however the 'edit page' action sends the theme header without sending the footer.

Steps to reproduce

Go to edit a page, and see if the standard footer appears.

With the standard moinmoin themes, this isn't a big deal since they send the navigation aids in the header, however I'm working on a theme to send them in the footer and the effect is much worse.

Example

This wiki. Go to edit a page using the modern theme, and see that the page credits don't appear.

Details

This Wiki.

Workaround

I worked around this by changing PageEditor.py

448,450c448
<         self.request.theme.emit_custom_html(self.cfg.page_footer1)
<         self.request.theme.emit_custom_html(self.cfg.page_footer2)
<
---
>         wikiutil.send_footer(self.request, self.page_name, showpage=1)

Discussion

Yea, the footer should appear when editing. The only reason its not there is nobody complained about it...

Plan


CategoryMoinMoinBugFixed CategoryRelease1.3.5

MoinMoin: MoinMoinBugs/PageEditorIgnoresThemeFooter (last edited 2007-10-29 19:06:40 by localhost)