Description

It's possible to rename a page which someone is just now editing. This will result the loss of edited data.

Steps to reproduce

1. Create page, save it and edit again. Don't save.
2. Rename the page.
3. Try to save the page from 1.
4. Saving will give empty page with following warning:

   • Someone else saved this page while you were editing! Please review the page and save then. Do not save this page as it is! Have a look at the diff of FrontPage/Testisivu to see what has been changed. Other users will be warned until 2007-12-12 12:11:59 that you are editing this page. Use the Preview button to extend the locking period.

Example

Try to reproduce in your wiki.

Component selection

• general

Details

Still a problem with: -- ThomasArendsenHein 2017-03-01 13:22:25

Workaround

Save early, save often. Don't rename other people's pages.

Discussion

I had a look into the code at the relevant places, but I guess I rather won't change it.

It's quite twisted / messy, moin's "locking" is by default only "warn" (and not "lock", which would be a hard lock). That rename can be recursive doesn't make it easier either.

Also, if the lock owner (from edit) is the same person as the person wanting to rename, the lock could be acquired by rename also. So, in any case, it would not prevent shooting into one self's foot.

This would require a quite big change, too much for 1.9...

Plan

• Priority:
• Assigned to:
• Status:

CategoryMoinMoinBug