Description

If I save a wiki page with "trivial change" the Xapian index does not get updated. Because of this it's not possible to find this added or corrected content.

Steps to reproduce

1. create a page and save it
2. edit the page, add some text and save it with "trivial change"
3. make a fullsearch for this added text
4. you can't find it!

Example

Maybe not working; if somebody rebuild the index from time to time

• look for chuchichästli (in my page)

• Search for this Word with Fullsearch

• you can't find it this on "my" page.. only on this bugreport!

Component selection

• Indexer (I guess only Xapian Index)

Details

Workaround

• do not use "trivial change"
• rebuild the index from time to time...

Discussion

• It seems to me also, that if you just save a page with "trivial change" the whole page gets deleted from the index. Strange but I could verify this with my testpage (see above)

I can't reproduce it. -- ThomasWaldmann 2008-12-18 21:01:40

It looks to me that this is an encoding issue. If I use the following link I get a result.

search test

http://moinmo.in/RecentChanges?action=fullsearch&context=180&value=chuchichästli&fullsearch=Text

The question is now why in your example chuchichästli is written as chuchich%C3%A4stli ?

Another question is what does happened to the highlight in this result? Sometimes I do see only chuchichäst highlighted.

And sometimes i don't get a result by this search too.

Testing

This Wiki

On this Wiki I could reproduce this in this way: For example:

• This should show 6 pages (5 subpages and the main pages)  <<FullSearch(title:MarcelHäfner)>>  

• Now, editin a subpages and mark the change as trivial (made this with the page MarcelHäfner/Bleeding Edge and MarcelHäfner )

• Visit this Page again (reload and clean cache if you don't belive) and you will see that this two pages are missing (see my attachment screenshot.png )

• From time to time, on this wiki, those missed pages get displayed/founded again, I believe this is because maybe somewhere a cron-job is running, where rebuild the indexes...

Another Wikis

1.8 - without Umlauts

I also could reproduce the on my wiki http://lotek.heavy.ch/test (without any umlauts)

Python Version
    2.5 (r25:51908, Jun 8 2007, 06:03:36) [GCC 3.4.6 20060404 (Red Hat 3.4.6-8)]
MoinMoin Version
    Version 1.8.0 [Revision release]
Xapian-Suche
    Aktiviert, Xapian 1.0.4, Index verfügbar, zuletzt geändert: 2008-12-18 23:38:46

• editing and save the page with "trivial change"
• and till the next index rebuild you can't find the page

1.7

Another test with an old Moin 1.7... same behavior, saving page in "trivial mode" and the page could not found anymore (with titel or text search).

-- MarcelHäfner 2008-12-18 23:40:25

it looks to me that the event handler does miss an entry for the TrivialPageChangedEvent. -- ReimarBauer 2009-01-11 22:13:46

   1 diff -r 36f2b2adce52 MoinMoin/events/xapian_index.py
   2 --- a/MoinMoin/events/xapian_index.py	Fri Jan 09 00:50:09 2009 +0100
   3 +++ b/MoinMoin/events/xapian_index.py	Sun Jan 11 23:07:23 2009 +0100
   4 @@ -69,7 +69,7 @@
   5          handle_renamed(event)
   6      elif isinstance(event, ev.PageCopiedEvent):
   7          handle_copied(event)
   8 -    elif isinstance(event, ev.PageChangedEvent):
   9 +    elif isinstance(event, ev.PageChangedEvent) or isinstance(event, ev.TrivialPageChangedEvent):
  10          handle_changed(event)
  11      elif isinstance(event, ev.PageDeletedEvent):
  12          handle_deleted(event)

• Feedback: I add this patch to my wiki, and it works. Thanks! -- MarcelHäfner 2009-01-11 22:32:37

Plan

• Priority:
• Assigned to:
• Status: 1.7 3850:dffb00e59a3d / 1.8 4237:e44cb5ca7e9f

CategoryMoinMoinBugFixed