MoinMoin: MoinMoinChat/Logs/moin-dev/2006-02-03

2006-02-03T00:05:06  <xorAxAx> [PERIODIC ANNOUNCEMENT] Logs can be found on http://moinmoin.wikiwikiweb.de/MoinMoinChat/Logs/moin-dev
2006-02-03T00:24:50  <ThomasWaldmann> sure
2006-02-03T20:33:29  <ThomasWaldmann> moin
2006-02-03T21:16:16  <ThomasWaldmann> if someone has an idea for patch-414 text_html.url, feel free...
2006-02-03T21:18:19  <xorAxAx> you broke it?
2006-02-03T21:35:13  <ThomasWaldmann> broken since 1.3.0 at least
2006-02-03T21:35:31  <ThomasWaldmann> before that, there was no such arg
2006-02-03T21:39:00  <xorAxAx> you mean escape?
2006-02-03T21:39:15  <xorAxAx> nir introduced it and fabi changed the behaviour of it in the last few patches
2006-02-03T21:39:41  <xorAxAx> i am not sure if fabi was right because it had been working for months
2006-02-03T21:41:51  <ThomasWaldmann> unescaped=x
2006-02-03T21:42:01  <ThomasWaldmann> in text_html.url
2006-02-03T21:42:24  <ThomasWaldmann> there was no code at all doing something with that argument
2006-02-03T21:42:34  <xorAxAx> "fix projection CSS, fix win32 request init, revert Florian's langAttr fix (already done in refactor branch)" you seem to love painful merging :)
2006-02-03T21:42:50  <xorAxAx> ThomasWaldmann: check the 1.3 branch, there is some code, for sure
2006-02-03T21:42:57  <ThomasWaldmann> i did
2006-02-03T21:43:05  <ThomasWaldmann> so check yourself :)
2006-02-03T21:43:07  <xorAxAx> ok, then it was another arg i am talking about :)
2006-02-03T21:44:08  <xorAxAx> "   if not locking or locking and self.wlock.acquire(1.0):" you are missing an else branch here
2006-02-03T21:44:19  <xorAxAx> if you dont sense when locking fails, you are not failsafe
2006-02-03T21:44:29  <xorAxAx> same for all other calls
2006-02-03T21:44:54  <xorAxAx> (this broke lupy the neck - the lupy code seems to be missing those else branches as well
2006-02-03T21:45:04  <xorAxAx> it makes debugging nearly impossible
2006-02-03T21:45:09  <ThomasWaldmann> file, line
2006-02-03T21:45:25  <xorAxAx> MoinMoin/caching.py, multiple times
2006-02-03T21:45:50  <xorAxAx>   except:
2006-02-03T21:45:51  <xorAxAx>                      pass
2006-02-03T21:46:00  <xorAxAx> ummm
2006-02-03T21:46:06  <xorAxAx> (request.py)
2006-02-03T21:46:13  <ThomasWaldmann> file, line
2006-02-03T21:46:24  <xorAxAx> copy.copy({}) -- why not {}?
2006-02-03T21:46:35  <xorAxAx> empty dictionaries arent singletons in python %-)
2006-02-03T21:47:10  <ThomasWaldmann> i wasnt sure it does not use the same object ever
2006-02-03T21:47:38  <ThomasWaldmann> (that was the exploding moin time, btw)
2006-02-03T21:47:54  <xorAxAx> "time"?
2006-02-03T21:48:07  <xorAxAx> you need to merge "CHANGES.refactor"
2006-02-03T21:48:26  <ThomasWaldmann> at the time i was developing surge_protection, moin often exploded to beyond 1gb memory usage in few secs
2006-02-03T21:49:23  <xorAxAx> yeah, but this doesnt look like a workaround to that problem :)
2006-02-03T21:49:59  <ThomasWaldmann> and except: pass is intended. it shouldn't fuck up just because there is some corrupted line
2006-02-03T21:50:12  <xorAxAx> furthermore, version.py broke because of the merge
2006-02-03T21:50:24  <xorAxAx> ThomasWaldmann: do at least some logging
2006-02-03T21:50:55  <xorAxAx> and you want to catch StandardError only
2006-02-03T21:53:40  <ThomasWaldmann> fixed CHANGES, version
2006-02-03T21:54:02  <xorAxAx> hmm, we really need better logging
2006-02-03T21:54:11  <xorAxAx> there should be many logging frameworks outside
2006-02-03T21:58:04  <xorAxAx> i bet you dont know the content action :)
2006-02-03T21:58:18  <ThomasWaldmann> xorAxAx: what should happen it the lock can't be acquired?
2006-02-03T21:58:40  <xorAxAx> ThomasWaldmann: request.log("Could not aquire lock ....")
2006-02-03T22:01:47  <xorAxAx> hmm, i feel like cleaning up a few files
2006-02-03T22:09:13  <xorAxAx> helponautoadmin is still not linked on moinmaster - where could it fit?
2006-02-03T22:12:40  <ThomasWaldmann> ok, fixed error handlers
2006-02-03T22:13:13  <ThomasWaldmann> HelpOnAccessControlLists
2006-02-03T22:18:45  * ThomasWaldmann looks at dreimark's stuff now
2006-02-03T22:19:03  <dreimark> :)
2006-02-03T22:20:50  <starshine> xorAxAx: subpage of HelpOnAdministration?
2006-02-03T22:21:15  <xorAxAx> starshine: no idea, i didnt write it. feel free to put it there ":)"
2006-02-03T22:21:48  <starshine> you asked!
2006-02-03T22:22:02  <ThomasWaldmann> as it is acl related...
2006-02-03T22:22:35  <xorAxAx> starshine: yeah, i am whining about people putting pages into a wiki wihtout linking them
2006-02-03T22:22:40  <starshine> subpage of HelpOnAccessControlLists, mention and crosslink on HelpOnAdministration.
2006-02-03T22:22:58  <xorAxAx> ok, cleaning finished
2006-02-03T22:22:59  <starshine> yeah orphaned docs aren't much help yet are they :)
2006-02-03T22:23:11  <ThomasWaldmann> btw, i plan some 1.5.2 rsn
2006-02-03T22:23:21  <xorAxAx> rsn?
2006-02-03T22:23:28  <starshine> real soon now :)
2006-02-03T22:32:07  <ThomasWaldmann> dreimark: please read pep8
2006-02-03T22:32:48  <dreimark> ok blank lines?
2006-02-03T22:36:38  * xorAxAx added the fullsearchcached macro
2006-02-03T22:37:16  <ThomasWaldmann> blanks, where to place, where not
2006-02-03T22:44:00  * xorAxAx is fixing the docbook bugs
2006-02-03T22:48:34  <ThomasWaldmann> pity he's gone, just wanted to talk about bugs :)
2006-02-03T22:54:20  <xorAxAx> fixed.
2006-02-03T23:14:22  <ThomasWaldmann> wb dreimark :)
2006-02-03T23:16:26  <dreimark> moin thomas connection lost
2006-02-03T23:17:01  <ThomasWaldmann> nice "root" exploit :)
2006-02-03T23:18:10  <dreimark> better not store a switch back to superuser ?
2006-02-03T23:18:36  <dreimark> so changed user has to log out and superuser has to login again
2006-02-03T23:19:59  <ThomasWaldmann> what i mean is that you switch user just because someone has posted some form field
2006-02-03T23:20:23  <ThomasWaldmann> you need to add the == superuser check there, too
2006-02-03T23:20:30  <dreimark> oops
2006-02-03T23:20:50  <ThomasWaldmann> |-)
2006-02-03T23:28:04  <dreimark> Is always better someone else do read check code
2006-02-03T23:31:18  <ThomasWaldmann> btw, I committed your first patch
2006-02-03T23:32:13  <dreimark> that's fine
2006-02-03T23:40:42  <dreimark> probably I should add wikiutil.createTicket too
2006-02-03T23:55:49  <dreimark> ThomasWaldmann:We have no ticket like in DeletePage in userform by now
2006-02-03T23:59:07  <ThomasWaldmann> and?