2007-06-24T00:12:31 <grzywacz> Uh, stupid isp.
2007-06-24T00:12:33 <grzywacz> Stupid storms.
2007-06-24T00:14:49 <xorAxAx> hehe
2007-06-24T00:44:30 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2186:b97040fcd8e1 1.7-classify-mneagul/MoinMoin/ (8 files in 2 dirs): added some new tests, move util tests to MoinMoin/util/_tests
2007-06-24T00:44:43 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2187:05557f1ce219 1.7-classify-mneagul/MoinMoin/events/emailnotify.py: Fix sending of email notifications after changes to messages.py
2007-06-24T00:44:44 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2188:f153b3155240 1.7-classify-mneagul/ (4 files in 3 dirs): Send notifications about creation of users to Superusers with JID set.
2007-06-24T00:44:45 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2189:85854afc1aa2 1.7-classify-mneagul/ (5 files in 3 dirs): Merge with my devel branch.
2007-06-24T00:44:46 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2190:b01a6ef1be4c 1.7-classify-mneagul/MoinMoin/ (config/multiconfig.py events/jabbernotify.py): Get rid of the global xmlrpc Server object. Instantiate one in config.
2007-06-24T00:44:48 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2191:8181ec5cd86c 1.7-classify-mneagul/MoinMoin/ (config/multiconfig.py events/jabbernotify.py): Merge with my devel branch.
2007-06-24T00:44:53 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2192:7def1e49e757 1.7-classify-mneagul/jabberbot/config.py: Add a sample config for the notification bot.
2007-06-24T00:44:56 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2193:3417a1d559d0 1.7-classify-mneagul/MoinMoin/_tests/ (20 files): Merge the changes from main.
2007-06-24T00:44:59 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2194:dd3abe290142 1.7-classify-mneagul/MoinMoin/util/web.py: Add a makeMultiSelection() function which creates a multiple <select> element.
2007-06-24T00:45:04 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2195:cf4c4a3d6085 1.7-classify-mneagul/MoinMoin/ (config/multiconfig.py events/__init__.py user.py userform.py): Add a list of selectable events user wants to be notified about.
2007-06-24T00:45:08 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2196:8e772d72ec6e 1.7-classify-mneagul/MoinMoin/ (5 files in 4 dirs): Merge with my devel branch.
2007-06-24T00:45:13 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2197:f2ae2f08958d 1.7-classify-mneagul/MoinMoin/events/jabbernotify.py:
2007-06-24T00:45:16 <CIA-27> moin: Honor event subscriptions when sending jabber notifications. Fix missing import.
2007-06-24T00:45:18 <CIA-27> moin: Also don't send empty JIDs to the jabber bot.
2007-06-24T00:45:20 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2198:4138e1f06617 1.7-classify-mneagul/MoinMoin/userform.py: Make it possible to unset user's jid in preferences.
2007-06-24T00:45:27 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2199:e2aa8372c4bf 1.7-classify-mneagul/jabberbot/xmppbot.py: Warn if a command with empty user jid has been received.
2007-06-24T00:45:30 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2200:c3bf2fa18b9a 1.7-classify-mneagul/jabberbot/xmppbot.py: Backed out changeset e2aa8372c4bf462dde0fe18fb647d782c3f1f615
2007-06-24T00:45:37 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2201:22a7080b4ac5 1.7-classify-mneagul/jabberbot/xmppbot.py: Don't process commands with no jid and issue a warning. That's a proper fix.
2007-06-24T00:45:40 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2202:a8941968efa1 1.7-classify-mneagul/ (3 files in 3 dirs): Merge with my devel branch.
2007-06-24T00:45:43 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2203:7c8ee12f8c1d 1.7-classify-mneagul/MoinMoin/ (config/multiconfig.py events/jabbernotify.py): Fix an error with missing bot_host attribute. Use more descriptive names.
2007-06-24T00:45:49 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2204:af1eb45c937e 1.7-classify-mneagul/wiki/config/more_samples/jabber_wikiconfig.py: Fix the sample config to use new attribute name.
2007-06-24T00:45:52 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2205:e6dd69d3ac69 1.7-classify-mneagul/MoinMoin/ (config/multiconfig.py events/jabbernotify.py): Merge with my devel branch.
2007-06-24T00:46:01 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2206:93e8ba421a88 1.7-classify-mneagul/ (10 files in 6 dirs): merge jabber branch
2007-06-24T00:46:04 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2207:7fed5edaa2a5 1.7-classify-mneagul/MoinMoin/_tests/ (test_formatter.py test_wikiutil.py): tests: some fixes
2007-06-24T00:46:07 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2208:eed1c7da25eb 1.7-classify-mneagul/MoinMoin/ (_tests/test_user.py user.py): test_user: fix wrong subscription tests and a few other problems
2007-06-24T00:46:14 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2209:2a7b535b1e44 1.7-classify-mneagul/MoinMoin/_tests/test_xmlrpc_multicall.py: Add a test for xmlrpc Fault serialization.
2007-06-24T00:46:17 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2210:37e16cdc3a84 1.7-classify-mneagul/jabberbot/ (xmlrpcbot.py xmppbot.py): Make the output of GetPageInfo command human-readable
2007-06-24T00:46:26 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2211:f10336f74a6e 1.7-classify-mneagul/MoinMoin/events/emailnotify.py: Make function names pep8-compatible.
2007-06-24T00:46:29 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2212:8aad85519f76 1.7-classify-mneagul/MoinMoin/userform.py: Fix error occuring when user has no subscribed events.
2007-06-24T00:46:32 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2213:3cfc01315d3a 1.7-classify-mneagul/ (5 files in 4 dirs): Merge with my devel branch.
2007-06-24T00:46:37 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2214:a3a19bdc0b9a 1.7-classify-mneagul/ (5 files in 4 dirs): merge jabber branch
2007-06-24T00:46:40 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2215:c15ec6a2c69e 1.7-classify-mneagul/MoinMoin/_tests/ (test_request.py test_security.py test_wikiutil.py): reduce number of failing tests
2007-06-24T00:46:49 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2216:789c1a37e4ab 1.7-classify-mneagul/MoinMoin/_tests/ (test_formatter.py test_wikiutil.py): don't run docbook formatter test when we have no 4suite installed, add test for non-empty SystemPagesGroup
2007-06-24T00:46:53 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2217:f5f4dbbd0c51 1.7-classify-mneagul/MoinMoin/ (_tests/maketestwiki.py action/backup.py support/tarfile.py): added tarfile.py from py 2.5.1 (backported to work with py 2.3/2.4), fix imports to use it for tests/backup (ported from 1.6)
2007-06-24T00:47:01 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2218:7a3f7ac4f6e0 1.7-classify-mneagul/MoinMoin/ (_tests/test_formatter.py conftest.py formatter/text_xml.py): fix formatter setup for tests, skip broken dom_xml formatter test, add small/big to text_xml formatter (ported from 1.6)
2007-06-24T00:47:05 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2219:7917222e0e05 1.7-classify-mneagul/MoinMoin/util/_tests/test_util.py: MoinMoin.util: some tests added
2007-06-24T00:47:12 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2220:3719548ae9a2 1.7-classify-mneagul/MoinMoin/_tests/ (macro/test_Action.py macro/test_Hits.py test_macro_Hits.py): test of Hits moved to macro and converted for py.test, a test for the Action macro added
2007-06-24T00:47:16 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2221:e35adb666eca 1.7-classify-mneagul/MoinMoin/_tests/macro/test_ImageLink.py: test_ImageLink: some tests for ImageLink
2007-06-24T00:47:21 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2222:e81af778f99d 1.7-classify-mneagul/MoinMoin/logfile/editlog.py: fixed cleaning of edit comments
2007-06-24T00:47:24 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2223:80fc914af5c8 1.7-classify-mneagul/docs/ (CHANGES CHANGES.fpletz): integrated CHANGES.fpletz into main CHANGES, TODOs/unclear stuff went to MoinMoin:XapianIntegration
2007-06-24T00:47:28 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2224:340ae0e7529e 1.7-classify-mneagul/ (3 files in 3 dirs): replace xmlrpc getUser by getUserProfile, auth can be done by getAuthToken/applyAuthToken in the same multicall, use for interwiki auth
2007-06-24T00:47:34 <CIA-27> (70 lines omitted)
2007-06-24T01:03:18 <grzywacz> A richer web controls would be welcomed in user preferences.
2007-06-24T01:03:36 <grzywacz> Like a tabbed widget to hold subscribed events list for both email and jabber...
2007-06-24T01:13:22 <grzywacz> xorAxAx, if I'm adding new checkboxes to UserPreferences, I should also add the appropriate fields to User class, because there won't be any default values, right?
2007-06-24T01:15:10 <xorAxAx> i guess so
2007-06-24T01:15:43 <grzywacz> Lovely, works.
2007-06-24T02:04:10 <dreimark> moin
2007-06-24T02:07:10 <dreimark> grzywacz: notification_server=None in wikiconfig missing blanks
2007-06-24T02:08:09 <dreimark> hmm sorry may be a mistake by neagulm
2007-06-24T02:22:15 <grzywacz> Hm, I might have broken sending i18n email notifications. Will take a closer look at it later on - added a todo entry.
2007-06-24T02:25:52 <xorAxAx> write a test :)
2007-06-24T02:27:35 <grzywacz> Hm, good idea.
2007-06-24T02:43:11 <grzywacz> I'm going to push stuff tomorrow.
2007-06-24T02:43:21 <grzywacz> (Or today, after some sleep)
2007-06-24T02:43:41 <grzywacz> Night. 8)
2007-06-24T02:45:55 <dreimark> gn
2007-06-24T11:54:07 <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2098:7f9a2e91c662 1.7-storage-hwendel/MoinMoin/ (PageEditor.py packages.py): remove unused clean_acl_cache
2007-06-24T11:54:26 <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2099:0ccf41b07722 1.7-storage-hwendel/MoinMoin/Page.py: remove unused clean_acl_cache
2007-06-24T12:00:47 <ThomasWaldmann> moin
2007-06-24T12:02:38 <dreimark> moin
2007-06-24T12:36:18 <xorAxAx> lanius: why do you instantiate all item collections in the page class?
2007-06-24T12:39:27 <xorAxAx> lanius: + self.__item = self.__items_all[self.page_name_fs]
2007-06-24T12:39:30 <xorAxAx> lanius: thats broken
2007-06-24T12:39:37 <xorAxAx> lanius: the collection must get the unquoted name
2007-06-24T12:41:16 <xorAxAx> dreimark: your student still doesnt use the event framework :)
2007-06-24T12:41:38 <xorAxAx> dreimark: he should rip out all modifications related to the page edit path and use events
2007-06-24T12:42:55 <dreimark> xorAxAx: I will tell him
2007-06-24T12:43:13 <xorAxAx> somehow he is never online when i am
2007-06-24T12:45:33 <dreimark> yep sometimes its difficult
2007-06-24T12:47:49 <xorAxAx> grzywacz: why do you check for a list in jabberbot commands? why arent calles allowed to pass in iterables? (This message has been postponed.)
2007-06-24T12:49:14 <dreimark> bbl 2h
2007-06-24T12:54:33 <grzywacz> You're partially right, but this command class is used with data coming directly via xmlrpc, which supports lists only anyway.
2007-06-24T12:54:41 <xorAxAx> ok
2007-06-24T12:54:47 <grzywacz> Throwing an exception makes it easier to spot a programming error.
2007-06-24T12:55:06 <xorAxAx> btw, TypeError is the right one
2007-06-24T12:55:23 <grzywacz> Ok.
2007-06-24T13:49:41 <lanius> xorAxAx: i thought i need all of them, but currently i don't need them
2007-06-24T13:49:54 <lanius> xorAxAx: the collection must get the quoted name because that's the name of the items
2007-06-24T13:52:11 <xorAxAx> lanius: no, its not
2007-06-24T13:52:18 <xorAxAx> the quotation of the name is internal
2007-06-24T13:52:25 <xorAxAx> the item has the name that is user-visible
2007-06-24T13:52:44 <lanius> xorAxAx: no, the file system storage uses the names of the files on the disk as names
2007-06-24T13:53:10 <xorAxAx> lanius: why TH?
2007-06-24T13:53:36 <lanius> xorAxAx: because i don't unquote them, of course i could do that...
2007-06-24T13:53:42 <xorAxAx> that sounds severely broken
2007-06-24T14:02:49 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2264:c142804478c7 1.7-jabber-knowak/MoinMoin/config/multiconfig.py: Add checkboxes that allow user to select means of notification.
2007-06-24T14:02:51 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2265:741ab277616a 1.7-jabber-knowak/MoinMoin/ (events/emailnotify.py events/jabbernotify.py user.py): Honor the user setting of notification methods.
2007-06-24T15:35:44 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2261:0893eaf60bbf 1.7-maninfo-vpv/MoinMoin/_tests/ (test_packages.py test_wikisync.py): Added legacy warning to test_wikisync, fixed packages test by deleting the page, gaining enough permissions before trying so and checking for the output pagename in the messages (this was added by reimar in 10c60d1131dd.
2007-06-24T15:35:46 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2262:d782b0db4757 1.7-maninfo-vpv/MoinMoin/ (_tests/test_wikidicts.py wikidicts.py): wikidicts: more comments, minor cleanup, converted tests to py.test
2007-06-24T15:35:47 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2263:0131f0aabb18 1.7-maninfo-vpv/MoinMoin/_tests/ (test_packages.py test_wikisync.py): merged main
2007-06-24T15:35:48 <CIA-27> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2264:2dacfe5936ce 1.7-maninfo-vpv/MoinMoin/ (4 files in 2 dirs): merge from main
2007-06-24T15:42:06 <dreimark> bb
2007-06-24T16:27:49 <Fabi> moin
2007-06-24T16:31:01 <ThomasWaldmann> moin
2007-06-24T16:31:33 <ThomasWaldmann> lanius: if you want to iterate over the keys, you don't need .keys()
2007-06-24T16:36:51 <ThomasWaldmann> lanius: and if you call .keys() to get a list of the keys, this list is uncoupled from the dict, so you don't need [:] to clone it again.
2007-06-24T16:42:23 <ThomasWaldmann> lanius: + revisions.remove(0) why do you remove that?
2007-06-24T16:43:40 <ThomasWaldmann> lanius: + return 99999999 this stuff is obviously a dirty hack and should rather get handled by e.g. an exception
2007-06-24T16:45:16 <ThomasWaldmann> (except for the attachments, they use this number in the revision field because they don't have revisions)
2007-06-24T16:50:14 <ThomasWaldmann> lanius: + return os.path.getsize(self.read_file_name) for the fs_moin16 backend, there is not much other ways for doing this, but in future, we could store the item length in metadata, esp. for the storage methods where we can't get it easily from the layer below
2007-06-24T16:52:13 <ThomasWaldmann> e.g. if the pages live in a *sql db and you do info action for the last 100 revs of them (displaying the size of every rev), you don't want to fetch all content from the db, just to run len() on it
2007-06-24T16:53:56 <ThomasWaldmann> so maybe generate some "virtual metadata" for fs_moin16 for "size"
2007-06-24T16:56:22 <vpv> I can't get xmlrpc getAuthToken to work, it says "global name \'_generate_auth_token\' is not defined"
2007-06-24T16:59:23 <vpv> And this is if I give it the correct username/pass. With incorrect ones it does what it should, returns an empty token.
2007-06-24T17:00:01 <ThomasWaldmann> this is a bug, there are some self. missing
2007-06-24T17:02:32 <ThomasWaldmann> grzywacz@2122 broke it :)
2007-06-24T17:09:40 <xorAxAx> lanius: yes, you will fail if i see any sequence of nines that is longer than two digits :)
2007-06-24T17:11:53 <zenhase> moin
2007-06-24T17:12:18 <zenhase> uha .. i did an 'unexpected reboot' yesterday
2007-06-24T17:12:21 <ThomasWaldmann> hi zenhase
2007-06-24T17:12:39 <ThomasWaldmann> zenhase: of yourself?
2007-06-24T17:12:42 <zenhase> yes
2007-06-24T17:13:22 * ThomasWaldmann hopes all services are up again and running well :)
2007-06-24T17:13:31 <zenhase> i was reading .send_page and the like until 1:00 and then figured that i need to get out to clean up my mind a little and get distracted
2007-06-24T17:14:06 <zenhase> i ended up in bed at about 5:30 o_O
2007-06-24T17:14:19 <zenhase> yes, they are up and running again
2007-06-24T17:14:23 * ThomasWaldmann .oO(in soviet russia, send_page doesn't get killed, it kills you!)
2007-06-24T17:15:10 <zenhase> hope not
2007-06-24T17:16:10 <zenhase> i started assembling the proxy-objects for themes
2007-06-24T17:17:10 <zenhase> as a starting point i will do the output capturing there, lazy evaluated in a .content property
2007-06-24T17:18:09 <ThomasWaldmann> sounds ok
2007-06-24T17:18:23 <zenhase> then i can differentiate in the show action between oldstyle themes and newstyle themes for example
2007-06-24T17:18:53 <zenhase> old-style: current code, new-style: render template
2007-06-24T17:19:13 <ThomasWaldmann> this is for about everything, not only for show
2007-06-24T17:19:18 <zenhase> yes
2007-06-24T17:19:21 <zenhase> btw.
2007-06-24T17:20:03 <zenhase> i was wondering about requested mimetype and formatter-stuff
2007-06-24T17:20:20 <zenhase> not every action supports every format right?
2007-06-24T17:20:36 <ThomasWaldmann> sure
2007-06-24T17:21:41 <CIA-27> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2265:5fdc953c8961 1.7-maninfo-vpv/MoinMoin/xmlrpc/__init__.py: fix xmlrpc_getAuthToken
2007-06-24T17:22:58 <zenhase> especially actions like raw or RenderAsDocbook explicitly force a certain format
2007-06-24T17:23:36 <ThomasWaldmann> vpv: thanks
2007-06-24T17:24:38 <zenhase> so in the process of killing .send_page (which looks up the actual format to render) it would a logical step to put the formatting of the page in the action, right?
2007-06-24T17:24:42 <ThomasWaldmann> raw should output some "as is" format (or some internally defined "native" format)
2007-06-24T17:25:22 <ThomasWaldmann> show should usually render some nice html
2007-06-24T17:25:36 <ThomasWaldmann> and everything else should be explicitely requested
2007-06-24T17:26:14 <zenhase> yes
2007-06-24T17:26:33 <xorAxAx> zenhase: an action is usually decides which format it needs
2007-06-24T17:26:39 <zenhase> or differentiate on the mimetype accept settings of the user-agent?
2007-06-24T17:26:44 <xorAxAx> zenhase: 99% of the actions are not compatible to anythig else than html
2007-06-24T17:26:56 <zenhase> xorAxAx: yep
2007-06-24T17:26:57 <xorAxAx> and RenderAsDocbook is a quirk to have better usability
2007-06-24T17:27:20 <zenhase> but they often just set the format to a specified mimetype and then call .send_page ;>
2007-06-24T17:27:32 <ThomasWaldmann> zenhase: no, mimetype accept doesnt help us
2007-06-24T17:28:35 <xorAxAx> zenhase: "specified"?
2007-06-24T17:30:03 <zenhase> xorAxAx: well, like docbook for example :>
2007-06-24T17:30:17 <zenhase> redirect to show with mimetype set to text/docbook
2007-06-24T17:37:34 <Fabi> moin zenhase
2007-06-24T17:38:15 <Fabi> other question for everyone: I saw yesterday that other SOC projects are also killing/reducing send_page, right?
2007-06-24T17:38:26 <Fabi> is there any need to coordiante the work?
2007-06-24T17:38:46 <ThomasWaldmann> other?
2007-06-24T17:40:09 <Fabi> IIRC someone stated to have reduced size of send_page by 100 LOCs
2007-06-24T17:40:29 <zenhase> lanius perhaps?
2007-06-24T17:40:37 <Fabi> but I didn't follow the thread completly
2007-06-24T17:41:00 <zenhase> actually i was wondering if i should merge his work
2007-06-24T17:41:11 <Fabi> may be
2007-06-24T17:41:27 <zenhase> this could already help a lot
2007-06-24T17:41:36 <Fabi> we should definetly have an eye one that
2007-06-24T17:41:39 <zenhase> hmm
2007-06-24T17:41:52 <Fabi> having a simplified send_page would help a lot
2007-06-24T17:41:58 <zenhase> yep
2007-06-24T17:42:06 <zenhase> 100locs is half of sendpage
2007-06-24T17:42:11 <zenhase> its 215 iirc
2007-06-24T17:42:37 <Fabi> ThomasWaldmann, do you know what's the status of the storage branch in this respect?
2007-06-24T17:45:03 <zenhase> i should have checked out all the other SOC-branches too
2007-06-24T17:45:17 <zenhase> i do a quick look there
2007-06-24T17:48:17 <ThomasWaldmann> Fabi: the storage branch mostly affects the storage code in Page/PageEditor
2007-06-24T17:48:43 <Fabi> so modification of send_page is minimal?
2007-06-24T17:48:47 <ThomasWaldmann> so there shouldn't be too much conflicts
2007-06-24T17:49:16 <Fabi> guess the PI metadata things will change in the future (if they have not yet)
2007-06-24T17:49:29 <ThomasWaldmann> Fabi: it doesn't matter. because we can't merge NOW anyway.
2007-06-24T17:49:42 <Fabi> ok, so we just keep separate and do the merge by hand after the SOC
2007-06-24T17:50:19 <ThomasWaldmann> Fabi: the pi stuff was refactored by me before soc start
2007-06-24T17:50:41 <ThomasWaldmann> so it is not in send_page any more
2007-06-24T17:50:45 * Fabi is too far off the moin development...
2007-06-24T17:50:50 <Fabi> good to here
2007-06-24T17:51:01 <Fabi> s/here/hear/
2007-06-24T17:51:32 <Fabi> .oO(215 LOCs seamed to be small)
2007-06-24T17:51:57 <zenhase> hmm
2007-06-24T17:52:16 <zenhase> in language where it's advised to not have functions longer than 20 locs? :>
2007-06-24T17:54:53 <Fabi> only one order of magnitude off isn't that bad ;)=
2007-06-24T17:56:35 <Fabi> see http://xkcd.com/c271.html
2007-06-24T17:58:09 <Fabi> zenhase, what you need to do is finding a new border/API between send_page_content and send_page
2007-06-24T17:58:42 <Fabi> to get the issues separated that are merged into send_page
2007-06-24T17:58:58 <Fabi> to get to a cleaner code
2007-06-24T18:01:15 <zenhase> Fabi: border api?
2007-06-24T18:01:23 <zenhase> erm
2007-06-24T18:01:51 <Fabi> find a new way to separate the code into methods
2007-06-24T18:01:51 <zenhase> nevermind :>
2007-06-24T18:01:55 <zenhase> yes
2007-06-24T18:02:06 <zenhase> that's what i am currently trying to figure out
2007-06-24T18:02:46 <zenhase> perhaps i should take the whole .send_page* code and make an annotated version on which parts would belong where
2007-06-24T18:03:00 <zenhase> and then start pulling them out into the appropriate places
2007-06-24T18:03:23 <Fabi> yes, that could help
2007-06-24T18:10:34 <lanius> zenhase: no, i try to avoid that ;)
2007-06-24T18:13:06 <xorAxAx> well
2007-06-24T18:13:15 <xorAxAx> you can merge as often as you like from other branches
2007-06-24T18:13:21 <xorAxAx> mercurial can cope with that
2007-06-24T18:13:31 <xorAxAx> and i think its encouraged to do so
2007-06-24T18:13:47 <xorAxAx> so lanius and zenhase can colaborate on that somehow :)
2007-06-24T18:14:51 <ThomasWaldmann> but they should not block each other with unfinished code
2007-06-24T18:15:31 <xorAxAx> hmm, yes
2007-06-24T18:15:47 <xorAxAx> indeed, thats not very stable yet
2007-06-24T18:16:15 <xorAxAx> of course you can always create a new branch and do the changes there then merge it into both branches
2007-06-24T18:16:34 <xorAxAx> (that aux branch would be merged off main)
2007-06-24T18:16:47 <xorAxAx> s/merged/based/
2007-06-24T18:21:51 <ThomasWaldmann> xorAxAx: + msg = msg + "<p>%s %s</p>" % (info, ",".join(recipients)) karol should use ", " for making it breakable
2007-06-24T18:22:03 <xorAxAx> ok
2007-06-24T18:31:59 <ThomasWaldmann> + self.notify_be_email = True
2007-06-24T18:31:59 <ThomasWaldmann> + self.notify_be_jabber = False
2007-06-24T18:32:23 <ThomasWaldmann> i guess that should be "...by..."? :)
2007-06-24T18:32:47 <xorAxAx> looks like that :)
2007-06-24T18:37:20 <zenhase> xorAxAx: you mean like an "1.7-SOC-accumulated"-branch?
2007-06-24T18:37:37 <xorAxAx> zenhase: i dont mean a new repo
2007-06-24T18:37:49 <xorAxAx> mercurial has named branches, you can push as many as you like
2007-06-24T18:37:54 <zenhase> ah ok
2007-06-24T18:38:06 <zenhase> i thought those were branches
2007-06-24T18:38:13 <xorAxAx> nope :)
2007-06-24T18:38:23 <xorAxAx> a repo can contain as many branches as you like
2007-06-24T18:38:28 <xorAxAx> nowadays they can even have names
2007-06-24T18:39:07 <zenhase> i see, i still have much too learn about mercurial
2007-06-24T18:40:10 <xorAxAx> the new (named) branch model is feature-equivalent to git
2007-06-24T18:51:55 <CIA-27> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2266:5bb8fcd8be13 1.7-maninfo-vpv/MoinMoin/script/xmlrpc/manimport.py: Use authentication (auth token in a multicall), also add an option to control verbose xmlrpc output
2007-06-24T18:52:16 <xorAxAx> wow, now i am seeing the colours
2007-06-24T18:52:26 <xorAxAx> after disabling my local colour filter
2007-06-24T19:13:33 <dreimark> FeatureRequests/ParsersCanNotContain{{{}}}, I will be able to fix that, currently I do write some tests for that
2007-06-24T19:13:58 <dreimark> I think it should go into 1.6 too, ok?
2007-06-24T19:15:11 <ThomasWaldmann> that depends on how big your patch is and how sure you are it doesnt break other stuff
2007-06-24T19:15:17 <xorAxAx> where did you start the nesting changes, dreimark?
2007-06-24T19:15:39 <xorAxAx> in 1.6? then it should go there as it is basically a bug report, no?
2007-06-24T19:20:43 <dreimark> FeatureRequests/ParsersCanNotContain{{{}}} someone added it as FR but its a bug
2007-06-24T19:20:58 <Fabi> btw: Could that be possible anti spam measure for moin? http://xkcd.com/c233.html
2007-06-24T19:21:08 <xorAxAx> dreimark: yes
2007-06-24T19:25:52 <dreimark> Its not a big change endpos = line.index("}}}") goes wrong it must be extended to something like if line.endswith("}}}"): endpos = len(line) - 3
2007-06-24T19:27:00 <dreimark> in the section if self.in_pre == 'found_parser': line 1055
2007-06-24T19:34:48 <lanius> ThomasWaldmann: what do you mean by iterate over the keys?
2007-06-24T19:35:36 <xorAxAx> lanius: usually, mapping objects are iterables
2007-06-24T19:35:43 <xorAxAx> lanius: and they iterate over the keys
2007-06-24T19:35:50 <xorAxAx> so you should make it an iterable as well
2007-06-24T19:36:13 <lanius> but i want to remove the zero
2007-06-24T19:36:27 <lanius> because that's not a real revision
2007-06-24T19:36:32 <lanius> but just a pointer to the last one
2007-06-24T19:36:40 <xorAxAx> thats unrelated here i think
2007-06-24T19:36:50 <xorAxAx> i mean, to his keys thing
2007-06-24T19:36:57 <lanius> i don't think?
2007-06-24T19:37:06 <dreimark> Fabi: that is old and I believe we have it now twice in the logs, hehe
2007-06-24T19:37:23 <lanius> xorAxAx: because if i remove the 0 from the dict it won't be there anymore
2007-06-24T19:38:05 <ThomasWaldmann> lanius: there are multiple things
2007-06-24T19:38:20 <ThomasWaldmann> don't write: for i in somedict.keys(): ...
2007-06-24T19:38:26 <xorAxAx> lanius: yes, ok :)
2007-06-24T19:38:32 <ThomasWaldmann> but just: for i in somedict:
2007-06-24T19:38:41 <xorAxAx> lanius: but you are using keys() somewhere else as well
2007-06-24T19:38:52 <lanius> ThomasWaldmann: where do i do that?
2007-06-24T19:39:00 <ThomasWaldmann> use grep :)
2007-06-24T19:39:53 <lanius> found one match, is that enough ;)
2007-06-24T19:40:03 <ThomasWaldmann> use grep -r :)
2007-06-24T19:40:11 <xorAxAx> lanius: have you read my 9-warning? :)
2007-06-24T19:40:27 <lanius> xorAxAx: yes, currently it's just to emulate the old behaviour
2007-06-24T19:40:33 <xorAxAx> yes
2007-06-24T19:40:39 <ThomasWaldmann> another thing is: don't use keylist = somedict.keys()[:]
2007-06-24T19:40:40 <lanius> ThomasWaldmann: i did eclipse pydev search
2007-06-24T19:41:02 <xorAxAx> yes, keys() should return a copy
2007-06-24T19:41:03 <lanius> yes
2007-06-24T19:41:22 <ThomasWaldmann> pydev sarch sometimes gives incomplete results
2007-06-24T19:42:32 * ThomasWaldmann tries new pycallgraph version
2007-06-24T20:21:53 * ThomasWaldmann .o(pycallgraph is nice to get 100% CPU load)
2007-06-24T20:34:47 <ThomasWaldmann> 500 Internal Server Error (Submission rejected as potential spam (Akismet says content is spam))
2007-06-24T20:35:14 * ThomasWaldmann wanted to file a ticket at pycallgraph's trac
2007-06-24T20:36:00 <dreimark> btw. what was the reason for the 500 on MM yesterday ?
2007-06-24T20:36:13 <ThomasWaldmann> the same as usual I guess
2007-06-24T20:42:30 <dreimark> hmm, pytest does not like to show ERROR: EOF in multi-line statement
2007-06-24T20:44:21 <ThomasWaldmann> gimp does not like to show pngs that are 31000px wide :)
2007-06-24T20:46:34 <dreimark> aha, I need to use the right parser
2007-06-24T21:27:26 <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2100:855d373fb385 1.7-storage-hwendel/MoinMoin/ (4 files in 2 dirs): fix up key() usage; make size a metadata value
2007-06-24T21:27:27 <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2101:5db111ca8907 1.7-storage-hwendel/MoinMoin/storage/ (_tests/test_fs_moin16.py fs_moin16.py interfaces.py): fix up key() usage; make size a metadata value
2007-06-24T21:53:05 <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2102:168fb28a8ea2 1.7-storage-hwendel/MoinMoin/ (Page.py storage/fs_moin16.py): move the unquote and quoting of page names to the storage layer
2007-06-24T21:56:06 <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2103:59e4a2f5f28f 1.7-storage-hwendel/MoinMoin/Page.py: move the unquote and quoting of page names to the storage layer
2007-06-24T21:58:00 <lanius> ThomasWaldmann: xorAxAx: how should i handle the case that there is no revision?
2007-06-24T21:59:12 <xorAxAx> lanius: well
2007-06-24T21:59:23 <xorAxAx> in which case?
2007-06-24T22:00:32 <lanius> return value, exception, what?
2007-06-24T22:00:47 <xorAxAx> i mean, in which api call
2007-06-24T22:00:55 <ThomasWaldmann> if the storage backend gets a request for rev x and there is no rev x, it should raise an exception
2007-06-24T22:00:58 <xorAxAx> yes
2007-06-24T22:01:21 <lanius> in the Page.py api call
2007-06-24T22:01:48 <lanius> because there you can init the Page without it existing
2007-06-24T22:01:57 <lanius> that's why there currently is 99999
2007-06-24T22:02:00 <lanius> 9
2007-06-24T22:02:45 * ThomasWaldmann looks ...
2007-06-24T22:03:14 <xorAxAx> lanius: well, 9 shouldnt be necessary anymore
2007-06-24T22:03:25 <xorAxAx> in most cases, Page should delegate in the current version
2007-06-24T22:03:56 <xorAxAx> and some calls will raise an exception. for a not existing page, everything should fail besides exists() i think
2007-06-24T22:05:12 <lanius> well, anything must happen, and there are just some checks for the 9s
2007-06-24T22:05:55 <ThomasWaldmann> some places in moin code also create page objects that are not existing on disk
2007-06-24T22:06:22 <xorAxAx> ThomasWaldmann: yes, and they are just used as page text marshallers
2007-06-24T22:07:36 <xorAxAx> and because that shouldnt call any backend method that raises an exception, thats fine
2007-06-24T22:10:35 <dreimark> bbl
2007-06-24T22:10:43 <lanius> so, i still don't know what the current_rev() method return now ;)
2007-06-24T22:11:47 <ThomasWaldmann> as a first step, you could s/99999999/None/ in Page.py
2007-06-24T22:12:37 <ThomasWaldmann> then you'll see what needs fixing :D
2007-06-24T22:12:41 <xorAxAx> lanius: an exception
2007-06-24T22:12:54 <xorAxAx> ThomasWaldmann: bad idea IMHO
2007-06-24T22:13:10 <ThomasWaldmann> why?
2007-06-24T22:13:23 <xorAxAx> because we dont have enough unit tests
2007-06-24T22:13:30 <xorAxAx> to figure out all edge cases
2007-06-24T22:14:09 <ThomasWaldmann> that's not quite rarely used code
2007-06-24T22:16:42 <xorAxAx> i can imagine some rare places :)
2007-06-24T22:31:33 <ThomasWaldmann> btw, using serverClass = 'SimpleServer' makes eclipse termination work
2007-06-24T22:32:34 <grzywacz> re
2007-06-24T22:35:25 <lanius> xorAxAx: can you comment about the 9999999 in wikisync.py?
2007-06-24T22:36:24 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2249:d48a4d0a0c70 1.7/ (MoinMoin/server/STANDALONE.py moin.py): pycallgraph support
2007-06-24T22:43:01 <xorAxAx> lanius: thats easy ... the page list that was returned by moin included invalid pages
2007-06-24T22:43:08 <xorAxAx> lanius: and i had to filter them out
2007-06-24T22:43:31 <xorAxAx> i.e. a sane storage backend shouldnt ever return invalid page names for getpagelist
2007-06-24T22:43:42 <xorAxAx> (which was the case here)
2007-06-24T22:44:56 <lanius> why did it return invalid pages?
2007-06-24T22:46:43 <grzywacz> xorAxAx: I won't be able to push from here, because I've forgotten to take my ssh key with me, so I'll probably export a repo for interested parties
2007-06-24T22:46:50 <xorAxAx> lanius: because thats how it works
2007-06-24T22:46:57 <xorAxAx> lanius: broken by design ...
2007-06-24T22:47:13 <lanius> xorAxAx: i want to find out if my current implementation also returns invalid pages
2007-06-24T22:47:17 <xorAxAx> grzywacz: when will you push? :)
2007-06-24T22:47:19 <lanius> xorAxAx: how can i identify invalid pages
2007-06-24T22:47:31 <grzywacz> xorAxAx: when I'm back home. 3 days or so.
2007-06-24T22:47:41 <xorAxAx> lanius: it was yielding any directory name if i asked for a page list and said that it shouldnt filter deleted pages
2007-06-24T22:47:57 <grzywacz> I'm downloading eclipse&stuff atm.
2007-06-24T22:48:07 <xorAxAx> grzywacz: please part and join because of a bug in the perl scripts in my irssi
2007-06-24T22:48:13 <lanius> xorAxAx: what directories can there be if they aren't pages
2007-06-24T22:48:30 <xorAxAx> lanius: pages that were created because somebody pressed preview but not save
2007-06-24T22:48:44 <xorAxAx> lanius: in that case, there is no current file, so it should not considered to be a page
2007-06-24T22:48:47 <xorAxAx> but moin does so
2007-06-24T22:49:04 <xorAxAx> at least on that level
2007-06-24T22:49:15 <xorAxAx> (and this is nothing that should be kept)
2007-06-24T22:49:28 <xorAxAx> grzywacz: it cant handle nick renames
2007-06-24T22:49:57 <xorAxAx> (this is to avoid to confuse yourself next time you would join :))
2007-06-24T22:50:31 <xorAxAx> grzywacz: you should use (info, ", ".join(recipients)) instead of (info, ",".join(recipients)) to make it breakable by the browser (This message has been postponed.)
2007-06-24T22:50:38 <xorAxAx> :-)
2007-06-24T22:50:41 <grzywacz> :>
2007-06-24T22:50:46 <ThomasWaldmann> grzywacz: i can give you your public key, you just have to find some matching private key then :)
2007-06-24T22:51:01 <grzywacz> ThomasWaldmann: I know :PPP
2007-06-24T22:51:20 <xorAxAx> grzywacz: dont you have your private key in base64 on your belly?
2007-06-24T22:51:26 <xorAxAx> as a tattoo
2007-06-24T22:51:34 <grzywacz> xorAxAx: sorry, no. ;]
2007-06-24T22:51:44 <xorAxAx> you are not surveillance-compatible
2007-06-24T22:52:02 <grzywacz> Because I run Linux and surveillance is windows-based. :P
2007-06-24T22:52:40 <xorAxAx> hehe
2007-06-24T22:59:12 <grzywacz> To install Mercurial from sources under Windows, you need
2007-06-24T22:59:26 <grzywacz> a C compiler (this is needed to compile some extensions used by Mercurial, so it's needed at setup-time only and not to run Mercurial itself)
2007-06-24T22:59:29 <grzywacz> wtf...
2007-06-24T23:02:30 <xorAxAx> there are binaries
2007-06-24T23:03:07 <grzywacz> I see.
2007-06-24T23:06:07 <grzywacz> Cloning in progress.
2007-06-24T23:19:25 <lanius> xorAxAx: filtering all invalid pages would be a very expensive list_items() because it has to do a os.path.exists("current") for each item
2007-06-24T23:21:18 <xorAxAx> lanius: well, in the default case it checks for existence of items, thats more expensive
2007-06-24T23:21:54 <lanius> xorAxAx: no, it just does a listdir()
2007-06-24T23:24:07 <xorAxAx> lanius: why do you think that it is sane to list invalid items by default?
2007-06-24T23:24:22 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2250:07fdbda38be2 1.7/MoinMoin/ (Page.py config/__init__.py): move split_regex to config (so it is compiled only once)
2007-06-24T23:24:31 <xorAxAx> IMHO thats a serious violation of the API that the backend is allowed to return item names that do not exist
2007-06-24T23:24:58 <xorAxAx> but you can have some kw_arg like "allow_invalid" that would enable it
2007-06-24T23:25:16 <xorAxAx> (for callers that can cope with it)
2007-06-24T23:25:25 <lanius> i don't think it is sane, i just notice that the 1.6 compatible backend will be slow if i only return valid items
2007-06-24T23:25:30 <xorAxAx> sanity should not be defeated by premature optimisations
2007-06-24T23:25:50 <xorAxAx> i dont think so
2007-06-24T23:26:08 <lanius> like i said one exists() for each item
2007-06-24T23:26:24 <xorAxAx> not an item exists, just a stat() on the current file
2007-06-24T23:26:31 <xorAxAx> IMHO you should introduce shortcuts in the end after profiling
2007-06-24T23:26:31 <ThomasWaldmann> lanius: it doesnt matter if moin_fs16 is a bit slow, but it shouldnt do silly things when used for the migration
2007-06-24T23:32:08 <lanius> xorAxAx: shortcuts?
2007-06-24T23:33:35 <xorAxAx> lanius: yes, this is a shortcut through the API, you are having a cheese hole in it only because you think that upper layers can handle this ugly breakage
2007-06-24T23:39:19 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2251:4197965b0820 1.7/MoinMoin/config/__init__.py: fix: use re.UNICODE for split_regex
2007-06-24T23:43:41 <grzywacz> Ooh, done.
2007-06-24T23:44:07 <ThomasWaldmann> is it windows or your connection that is so slow? :-P
2007-06-24T23:45:13 <grzywacz> Connection.
2007-06-24T23:45:50 <grzywacz> ThomasWaldmann: actually, I can generate a new ssh key for the next 2-3 days if you want to bother with swapping them. ;)
2007-06-24T23:47:12 <grzywacz> Anyway, good night. I'm too tired after the travel to write anything today. :\
2007-06-24T23:47:24 <ThomasWaldmann> gn :)
2007-06-24T23:47:45 <ThomasWaldmann> you can send me the key if you want to have it installed MoinMoin: MoinMoinChat/Logs/moin-dev/2007-06-24 (last edited 2007-10-29 19:08:21 by localhost)
