1 2009-11-27T00:05:48 *** JosefMeier
2 2009-11-27T00:09:50 *** JosefMeier
3 2009-11-27T00:10:26 <JosefMeier> ThomasWaldmann: Thanks for reviewing. I will process your comments tomorrow.
4 2009-11-27T00:14:01 *** JosefMeier
5 2009-11-27T00:38:04 *** tpfennig
6 2009-11-27T00:51:10 *** awilkins
7 2009-11-27T02:31:29 *** grzywacz
8 2009-11-27T02:58:47 *** awilkins
9 2009-11-27T04:36:55 *** dreimark_
10 2009-11-27T04:40:50 *** dreimark
11 2009-11-27T04:45:49 *** waldi
12 2009-11-27T04:47:01 *** waldi
13 2009-11-27T07:42:15 *** dreimark_
14 2009-11-27T09:21:00 *** dreimark_
15 2009-11-27T10:36:18 * ThomasWaldmann reviewed the GetSubscribersSlow patch
16 2009-11-27T11:11:52 *** dreimark_
17 2009-11-27T11:13:40 *** dreimark_
18 2009-11-27T12:42:36 <dreimark_> moin
19 2009-11-27T12:42:52 *** dreimark_
20 2009-11-27T12:53:50 <dreimark> http://moinmo.in/MoinMoinBugs/1.6.1LineBreakMacroMakesUnintendedBreaks
21 2009-11-27T12:53:59 <dreimark> looks fixed or ?
22 2009-11-27T13:14:45 * dreimark looks at bugreports
23 2009-11-27T13:19:23 * ThomasWaldmann won't touch anything <p> or <br> related
24 2009-11-27T13:20:50 * dreimark won't too
25 2009-11-27T13:21:05 <dreimark> ThomasWaldmann: but I can't see a line break in that report
26 2009-11-27T13:21:29 <dreimark> so we have fixed it already or I don't understand the report
27 2009-11-27T13:34:03 <ThomasWaldmann> if you can't reproduce it, close it
28 2009-11-27T15:16:04 *** dreimark
29 2009-11-27T15:20:40 *** dreimark
30 2009-11-27T16:11:20 *** serek
31 2009-11-27T16:22:33 *** ser
32 2009-11-27T16:32:33 *** waldi
33 2009-11-27T16:32:33 *** ronny
34 2009-11-27T16:32:33 *** vpv
35 2009-11-27T16:32:33 *** dennda
36 2009-11-27T16:32:41 *** ronny
37 2009-11-27T16:32:57 *** vpv
38 2009-11-27T16:32:57 *** dennda
39 2009-11-27T16:33:25 *** waldi
40 2009-11-27T16:34:11 *** dennda
41 2009-11-27T16:34:11 *** vpv
42 2009-11-27T16:34:14 *** dennda_
43 2009-11-27T16:34:53 *** waldi
44 2009-11-27T16:38:27 <ThomasWaldmann> moin dennda_ :)
45 2009-11-27T16:38:59 *** vpv
46 2009-11-27T16:39:09 <ThomasWaldmann> ah, netsplit time
47 2009-11-27T16:40:18 *** waldi__
48 2009-11-27T16:43:01 *** vpv_
49 2009-11-27T16:55:25 *** JosefMeier
50 2009-11-27T16:56:27 <JosefMeier> Moin
51 2009-11-27T17:28:11 <ThomasWaldmann> moin josef
52 2009-11-27T17:39:12 *** JosefMeier
53 2009-11-27T17:39:49 *** JosefMeier
54 2009-11-27T17:41:06 *** JosefMeier
55 2009-11-27T17:42:51 *** JosefMeier
56 2009-11-27T18:00:02 *** |JosefMeier|
57 2009-11-27T18:00:22 <ThomasWaldmann> JosefMeier: may i suggest ssh -> server -> screen -> irssi? :)
58 2009-11-27T18:00:23 *** JosefMeier
59 2009-11-27T18:00:27 <ThomasWaldmann> much less trouble :)
60 2009-11-27T18:01:13 <|JosefMeier|> ThomasWaldmann: I installed kvirc just a minute ago. Chatzilla doesn't like me ;-) Your suggestions are welcome
61 2009-11-27T18:01:44 * dreimark suggest also the same as thomas did
62 2009-11-27T18:01:47 <ThomasWaldmann> the point is running the stuff on a permanently connected machine
63 2009-11-27T18:01:56 <ThomasWaldmann> so you don't miss anything :)
64 2009-11-27T18:02:16 <|JosefMeier|> Thats why you and Reimar always seem to be logged in?
65 2009-11-27T18:02:37 <ThomasWaldmann> has the slight disadvantage of having to use a text mode tool, but you'll get used to it
66 2009-11-27T18:02:49 <ThomasWaldmann> yes
67 2009-11-27T18:03:50 <|JosefMeier|> ThomasWaldmann: I tried it out. It's not mine. I always look into the chatlog on the moin page since a few days. Every message posted in the irc channel here will be put on the chatlog on your moin server immediately. Isn't it?
68 2009-11-27T18:04:11 <ThomasWaldmann> not immediately, but almost
69 2009-11-27T18:07:00 <|JosefMeier|> ThomasWaldmann: Is the attachment dialogs look and feel ok now? If yes, I would concentrate on cleaning the code and put in your remarks from yesterday.
70 2009-11-27T18:08:34 <ThomasWaldmann> |JosefMeier|: yeah, look and feel is nearly perfect
71 2009-11-27T18:09:02 <ThomasWaldmann> (see my remarks about the "nearly")
72 2009-11-27T18:09:07 <|JosefMeier|> ok
73 2009-11-27T18:09:28 <ThomasWaldmann> you'll get rid of quite some strange code soon :)
74 2009-11-27T18:10:50 <|JosefMeier|> What's the replacement for getscriptname?
75 2009-11-27T18:16:55 <dreimark> http://moinmo.in/MoinMoinBugs/1.6GuiEditorRemovesLinkOptions Is that fixed?
76 2009-11-27T18:17:19 <dreimark> |JosefMeier|: do you need the | signs?
77 2009-11-27T18:18:45 <|JosefMeier|> dreimark: what do you mean if I need the | signs? In attachments?
78 2009-11-27T18:20:47 <dreimark> in your namne
79 2009-11-27T18:21:07 <|JosefMeier|> Oh
80 2009-11-27T18:22:19 *** |JosefMeier|
81 2009-11-27T18:24:54 <ThomasWaldmann> JosefMeier: look at getScriptName docstring in 1.9 (that does not apply to 1.8)
82 2009-11-27T18:36:11 <JosefMeier> ThomasWaldmann: dreimark: Do you know that there is a python book available which was completely written in MoinMoin ? ("Das Python Praxisbuch" from Farid Hajji) ?
83 2009-11-27T18:38:25 <dreimark> yes
84 2009-11-27T18:39:31 <JosefMeier> Did he use the same wiki -> latex formatter which is in the official moin release?
85 2009-11-27T18:51:34 <ThomasWaldmann> there is no latex formatter in the moin release
86 2009-11-27T18:53:38 <dreimark> JosefMeier: that was likly docbook or rest
87 2009-11-27T18:53:47 <dreimark> bbl
88 2009-11-27T18:55:11 <JosefMeier> ThomasWaldmann: What's the problem with "hardcoded colors" in Javascript. "gray" and "black" are valid color names. Or do you want to assign the color strings to variables before?
89 2009-11-27T19:02:30 *** grzywacz
90 2009-11-27T19:05:41 <ThomasWaldmann> JosefMeier: the problem with color hardcoding is that you are assuming that this color is usable together with other (theme) colours you don't even know
91 2009-11-27T19:06:30 <ThomasWaldmann> i guess that is why css was invented a few years ago :)
92 2009-11-27T19:09:08 <ThomasWaldmann> also, doesn't the browser grey out stuff if you disable it anway?
93 2009-11-27T19:27:56 <JosefMeier> you can't disable text
94 2009-11-27T19:28:24 <JosefMeier> I was crawling through google about how to gray oout text and one solution was to change the color.
95 2009-11-27T19:28:39 <JosefMeier> I will look again if there is another way
96 2009-11-27T20:06:37 <JosefMeier> ThomasWaldmann: Disabling text and labels is only possible with IE. So all people recommand to setting the color directly to the text's style.
97 2009-11-27T20:08:44 *** grzywacz
98 2009-11-27T20:13:15 <dreimark> JosefMeier: http://www.codetoad.com/javascript/enable_disable_form_element.asp
99 2009-11-27T20:14:30 <dreimark> that works for me using ff
100 2009-11-27T20:15:25 <JosefMeier> dreimark: It disables also text?
101 2009-11-27T20:15:39 <JosefMeier> I'm not talking about the edit box
102 2009-11-27T20:15:47 <JosefMeier> text = label of an edit box
103 2009-11-27T20:17:48 <JosefMeier> I removed the code which grays out the label of the attachment list. It's always default black now.
104 2009-11-27T20:18:42 <dreimark> JosefMeier: if you would have spoken about the label i don't have sent an example for text
105 2009-11-27T20:19:13 <JosefMeier> text != text box
106 2009-11-27T20:19:34 <JosefMeier> ThomasWaldmann: http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/a29572a266ca
107 2009-11-27T20:19:50 <JosefMeier> http://s15358202.onlinehome-server.info/1.9_modified/attachtest
108 2009-11-27T20:20:34 <ThomasWaldmann> is that implementing all my review results?
109 2009-11-27T20:21:17 <JosefMeier> yes
110 2009-11-27T20:21:46 <JosefMeier> One question: if something = "":
111 2009-11-27T20:21:49 <JosefMeier> a = b
112 2009-11-27T20:21:51 <JosefMeier> else:
113 2009-11-27T20:21:55 <JosefMeier> a = c
114 2009-11-27T20:21:58 <JosefMeier> is the same as :
115 2009-11-27T20:22:38 <JosefMeier> ahm
116 2009-11-27T20:22:46 <JosefMeier> if b = "":
117 2009-11-27T20:22:52 <JosefMeier> a = c
118 2009-11-27T20:22:53 <JosefMeier> else:
119 2009-11-27T20:22:56 <JosefMeier> a = b
120 2009-11-27T20:23:00 <JosefMeier> is the same as
121 2009-11-27T20:23:03 <dreimark> use a pastebin
122 2009-11-27T20:23:05 <JosefMeier> a = b or c
123 2009-11-27T20:23:09 <JosefMeier> right?
124 2009-11-27T20:23:23 <ThomasWaldmann> yes
125 2009-11-27T20:24:15 <JosefMeier> ok
126 2009-11-27T20:24:24 <ThomasWaldmann> that's a result of short-circuit eval
127 2009-11-27T20:39:22 <ThomasWaldmann> is that script_root modification needed?
128 2009-11-27T20:39:31 <ThomasWaldmann> 55/56?
129 2009-11-27T20:46:34 <ThomasWaldmann> langAlertMissing* is still half there
130 2009-11-27T20:47:51 <JosefMeier> you are right. missed that
131 2009-11-27T20:48:25 <JosefMeier> don't know if that script_root mod is needed. I remember that I copied it from somewhere else
132 2009-11-27T20:48:48 <ThomasWaldmann> yeah, that's what i suspected :)
133 2009-11-27T20:48:52 <ThomasWaldmann> so please check
134 2009-11-27T20:49:55 <JosefMeier> changed it
135 2009-11-27T20:50:03 <ThomasWaldmann> did you check it?
136 2009-11-27T20:50:36 <JosefMeier> and before you ask me: py.test has ran without errors :-)
137 2009-11-27T20:51:16 <ThomasWaldmann> did you check it?
138 2009-11-27T20:52:07 <JosefMeier> what? If script_root is needed?
139 2009-11-27T20:53:46 <JosefMeier> It seems to work without the modification.
140 2009-11-27T20:54:07 <JosefMeier> One last thing: you have spoken about some href "problem". Didn't understand what you ment
141 2009-11-27T21:03:21 *** vpv_
142 2009-11-27T21:07:15 <JosefMeier> ThomasWaldmann: ^
143 2009-11-27T21:20:00 <ThomasWaldmann> look into the html
144 2009-11-27T21:20:16 <ThomasWaldmann> or into your src
145 2009-11-27T21:29:14 <dreimark> ThomasWaldmann: http://moinmo.in/MoinMoinBugs/ConfidentialPagesContentSentToSubscribers
146 2009-11-27T21:29:24 <dreimark> I can't create the category
147 2009-11-27T21:29:48 <JosefMeier> ThomasWaldmann: I set the href the same way as it was set before.
148 2009-11-27T21:30:04 <JosefMeier> before = moin < 1.9
149 2009-11-27T21:31:54 <dreimark> JosefMeier: does it change if you change the name
150 2009-11-27T21:32:36 * JosefMeier checking that
151 2009-11-27T21:33:02 <ThomasWaldmann> JosefMeier: well, did you read my comment? it might be working, because it just uses the title attr when converting to wiki.
152 2009-11-27T21:34:35 <JosefMeier> yes. it's using the title attribute thus it works
153 2009-11-27T21:35:52 <JosefMeier> But I will change the way href is built
154 2009-11-27T21:36:09 <JosefMeier> The image dialog creates href with action=... in it
155 2009-11-27T21:36:15 <JosefMeier> I'll use the code from there
156 2009-11-27T21:39:16 *** waldi
157 2009-11-27T21:39:25 *** waldi__
158 2009-11-27T22:41:26 <JosefMeier> ThomasWaldmann: You were absolutely right: The setting of href was wrong. I changed it.
159 2009-11-27T22:43:23 <JosefMeier> ThomasWaldmann: http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/72f9f5288a85
160 2009-11-27T23:14:26 <ThomasWaldmann> JosefMeier: 1.140..143
161 2009-11-27T23:14:48 <ThomasWaldmann> how about boolean expressions in js?
162 2009-11-27T23:15:31 <JosefMeier> what's with them?
163 2009-11-27T23:19:18 <ThomasWaldmann> in general, if you use the pattern: if expr: x = true; else x = false that can be optimized
164 2009-11-27T23:19:31 <ThomasWaldmann> to x = expr
165 2009-11-27T23:21:00 <JosefMeier> GetE('sctAttachments').disabled = GetE('requestedPagename').value != StripWhitespace(GetE('attachmentsPagename').value
166 2009-11-27T23:21:01 <JosefMeier> ?
167 2009-11-27T23:21:17 <JosefMeier> I thought, that if ... else ... is more readable
168 2009-11-27T23:22:49 <ThomasWaldmann> i don't know whether that works in js, but i suspect so
169 2009-11-27T23:23:01 <JosefMeier> Maybe you can ignore that? Cause it's more a matter of personal taste. Ok?
170 2009-11-27T23:23:20 <JosefMeier> At least this is my own opinion
171 2009-11-27T23:24:08 <ThomasWaldmann> ok. did you check the escaping?
172 2009-11-27T23:24:57 <JosefMeier> I added <script>alert("test");</script> to both the page name and the attachment name. Nothing wrong happened
173 2009-11-27T23:26:11 <ThomasWaldmann> i mean you implemented your own (un)escapeHtml
174 2009-11-27T23:26:25 <ThomasWaldmann> doesn't that already exist?
175 2009-11-27T23:27:32 <JosefMeier> no
176 2009-11-27T23:28:21 <JosefMeier> there is a escape method. But that only creates %xx out of special characters. As far as I understood, the translation should make > out of '>' and so on.
177 2009-11-27T23:29:30 <JosefMeier> http://www.w3schools.com/jsref/jsref_escape.asp
178 2009-11-27T23:29:32 <ThomasWaldmann> strange. that's standard stuff.
179 2009-11-27T23:30:13 <JosefMeier> is the escape function there what you need? also python doesn't have it I think cause werkzeug implements its own escapehtml
180 2009-11-27T23:30:14 <ThomasWaldmann> ok, back to python. you noted the escape methods quote= param?
181 2009-11-27T23:32:51 <JosefMeier> ThomasWaldmann: Yes. I noted it. And I also use it somewhere. Why?
182 2009-11-27T23:34:28 <JosefMeier> What's wrong with it?
183 2009-11-27T23:35:15 <ThomasWaldmann> maybe review your escape calls?
184 2009-11-27T23:37:51 <JosefMeier> Could you be more concrete, please?
185 2009-11-27T23:38:39 <JosefMeier> quote is by default false. But I like to escape also the quotes
186 2009-11-27T23:40:33 <ThomasWaldmann> 73 +''' % "\n".join(['<option value="%s">%s</option>' % (wikiutil.escape(attachment), wikiutil.escape(attachment))
187 2009-11-27T23:41:47 <JosefMeier> ok. 1:0 for you
188 2009-11-27T23:41:53 <JosefMeier> 2:0 :-)
189 2009-11-27T23:43:54 <ThomasWaldmann> 1.206 vs. 1.211 also looks suspicious
190 2009-11-27T23:44:03 <ThomasWaldmann> check order of 1.211
191 2009-11-27T23:46:16 <JosefMeier> hm... does it make a difference, which characters are unescaped first?
192 2009-11-27T23:46:49 <ThomasWaldmann> &gt
193 2009-11-27T23:48:04 <ThomasWaldmann> maybe checking 1.206 to be correct and then just using reverse order would make sense
194 2009-11-27T23:54:47 <JosefMeier> changed the order in escape, reversed it in unescape and tested it. its ok
195 2009-11-27T23:54:58 <JosefMeier> ThomasWaldmann: ^
MoinMoin: MoinMoinChat/Logs/moin-dev/2009-11-27 (last edited 2009-11-26 23:15:02 by IrcLogImporter)
