1 2010-05-27T00:00:43 <TheSheep> diofeher: but the theme is used at the end of request's life, so it's not that important to know the details
2 2010-05-27T00:01:28 <TheSheep> diofeher: look at the MoinMoin.theme.render_content()
3 2010-05-27T00:01:39 <diofeher> okay... i saw this in load_theme (at theme/__init__.py)
4 2010-05-27T00:01:44 <TheSheep> diofeher: that's where the theme is used
5 2010-05-27T00:02:21 <TheSheep> diofeher: with the original, pre-2.0 themes, it just calls a bunch of methods
6 2010-05-27T00:02:31 <TheSheep> diofeher: there is also a switch to use a template instead
7 2010-05-27T00:02:53 <TheSheep> diofeher: can you see it?
8 2010-05-27T00:02:57 <diofeher> oh, point me to this switch, guys talked about it yesterday, but i didn't found
9 2010-05-27T00:04:08 <TheSheep> I'm pointing
10 2010-05-27T00:04:18 <TheSheep> MoinMoin.theme.render_content()
11 2010-05-27T00:04:44 <TheSheep> line 1541 in MoinMoin/theme/__init__.py
12 2010-05-27T00:05:04 <diofeher> TheSheep: oooooh ok!
13 2010-05-27T00:06:51 <diofeher> another question... where is the content rendered with jinja that they talk about in docs... like show, diff, modify
14 2010-05-27T00:06:58 <CIA-47> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8225:cceeeb2204a4 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/ (_tests/test_html_in.py _tests/test_html_out.py html_in.py): Fix PEP8 mistakes
15 2010-05-27T00:07:09 <diofeher> they are in actions, right? with name execute
16 2010-05-27T00:07:19 <valeuf> ok, so my problem with tabs are fixed now
17 2010-05-27T00:07:22 <TheSheep> diofeher: the content is not rendered with jinja, you get it as a parameter to the template
18 2010-05-27T00:07:33 * valeuf should remember to use always vim, and not open his files with other editor ...
19 2010-05-27T00:07:50 <valeuf> dreimark: so what was your explain about regression test ?
20 2010-05-27T00:08:04 <TheSheep> diofeher: the actions just call that render method
21 2010-05-27T00:08:34 <valeuf> dreimark: I did not understand what you mean by regression test, I am writting something new, do I need such of tests ?
22 2010-05-27T00:08:54 <TheSheep> diofeher: at least that's how they should behave, if they don't we will fix them
23 2010-05-27T00:09:10 <TheSheep> diofeher: now, with that switch is's kind of all-or-nothing solution
24 2010-05-27T00:09:18 <diofeher> hmm
25 2010-05-27T00:09:43 <TheSheep> diofeher: but I would prefer you to switch to jinja gradually, piece by piece, whicle still having a working theme
26 2010-05-27T00:09:53 <diofeher> yes.. me too
27 2010-05-27T00:09:59 <TheSheep> diofeher: so I think it will be better to not use that switch just yet
28 2010-05-27T00:10:35 <TheSheep> diofeher: instead, you will make a separate theme, and you will be replacing the inherited methods with ones that use jinja for rendering
29 2010-05-27T00:10:43 <TheSheep> diofeher: what do you think?
30 2010-05-27T00:10:54 <diofeher> humm, I'm thinking the same
31 2010-05-27T00:11:07 <TheSheep> diofeher: one by one, for example, you can start with the search form
32 2010-05-27T00:11:30 <diofeher> I thought that I can make a new theme (design), show them to you all, if you like, I can start the rendering
33 2010-05-27T00:11:55 <ThomasWaldmann> but in the end, we'll all merge it into a complete thing independent of the old theme infrastructure?
34 2010-05-27T00:12:16 <diofeher> this would be nice
35 2010-05-27T00:12:18 <diofeher> :D
36 2010-05-27T00:12:21 <TheSheep> ThomasWaldmann: yes
37 2010-05-27T00:12:31 <ThomasWaldmann> (this would rather be required I think :)
38 2010-05-27T00:12:33 <TheSheep> ThomasWaldmann: I just want to have something working in the mean time
39 2010-05-27T00:12:37 <ThomasWaldmann> sure
40 2010-05-27T00:12:53 <ThomasWaldmann> maybe we can have some sort of modularization that way also
41 2010-05-27T00:13:08 <TheSheep> ThomasWaldmann: it would suck to spend a month working on the template, and then see that it doesn't work in the end
42 2010-05-27T00:14:10 <diofeher> TheSheep: that's why i would know about theme rendering... to make this in right way :x
43 2010-05-27T00:14:58 <TheSheep> diofeher: nobody guesses the right way at the first try, that's why we need to keep checking what is coming out of it
44 2010-05-27T00:15:22 <TheSheep> diofeher: you will probably have to reorganize it several times along the way
45 2010-05-27T00:15:29 <diofeher> yes...
46 2010-05-27T00:15:50 <TheSheep> diofeher: for the start, you can just put every part in a separate template file, later you will move them into functions in one template
47 2010-05-27T00:16:14 <diofeher> so, at first part i will concentrate in move theme functions to a new class rendered by jinja
48 2010-05-27T00:17:08 <TheSheep> diofeher: it would beg reat if there was at least ne comit a day, so that we can see how you are doing and can comment on your code
49 2010-05-27T00:17:16 <TheSheep> s/beg/best
50 2010-05-27T00:17:30 <TheSheep> s/beg reat/be great
51 2010-05-27T00:17:31 <TheSheep> sorry
52 2010-05-27T00:17:35 <diofeher> hehe
53 2010-05-27T00:18:08 <diofeher> okay, i will try at least one commit in one day
54 2010-05-27T00:18:19 <TheSheep> also, whenever you don't know something or are blocked in any way, ask on the channel
55 2010-05-27T00:18:32 <TheSheep> either me or someone else will answer as soon as possible
56 2010-05-27T00:19:23 <ThomasWaldmann> diofeher: doodle? :)
57 2010-05-27T00:19:25 <TheSheep> keep the plugins at the back of your head too, we will come back to them at some point
58 2010-05-27T00:20:00 <TheSheep> diofeher: please mark when you are available: http://doodle.com/participation.html?pollId=47ezp4cbn6n34b8t
59 2010-05-27T00:20:28 <TheSheep> diofeher: we will have a weekly meeting at the time that is best for everyone
60 2010-05-27T00:20:35 <diofeher> oh ok
61 2010-05-27T00:21:44 <diofeher> this time is in gmt 0?
62 2010-05-27T00:21:56 <diofeher> oh, sorry for the dumb question
63 2010-05-27T00:22:00 <diofeher> i saw now
64 2010-05-27T00:23:19 <ThomasWaldmann> diofeher: you can set your timezone
65 2010-05-27T00:24:01 <CIA-47> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8226:f03655db1733 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_html_in.py: Rewrite test_html_in with lxml
66 2010-05-27T00:24:13 <diofeher> yes :) answered
67 2010-05-27T00:24:48 <TheSheep> diofeher: do you have anything else to discuss? if not, I will go to sleep :)
68 2010-05-27T00:25:43 <diofeher> wait wait :D
69 2010-05-27T00:26:44 <diofeher> i'm gonna create a class in jinja2.py in theme... and then make rendering
70 2010-05-27T00:26:52 <diofeher> but it's best to do the new layout first or later?
71 2010-05-27T00:27:43 <valeuf> xorAxAx: I am going to sleep, I will continue tomorrow by adding basic test, and see if I can code the ground of the converter to pass these tests
72 2010-05-27T00:27:52 <TheSheep> diofeher: later, we will copy the default one for now
73 2010-05-27T00:28:04 <TheSheep> diofeher: well, you can clean it up once you are at it, of course
74 2010-05-27T00:28:30 <TheSheep> diofeher: remember to work at one thing at a time, commit and then work on the next ne
75 2010-05-27T00:28:34 <TheSheep> ne
76 2010-05-27T00:28:36 <TheSheep> one
77 2010-05-27T00:28:45 <diofeher> okay
78 2010-05-27T00:28:50 <diofeher> i'm gonna start now
79 2010-05-27T00:28:51 <TheSheep> of course, test it before you commit
80 2010-05-27T00:29:01 <diofeher> i think i'm too late :(
81 2010-05-27T00:29:41 <TheSheep> it's just a few days, you will catch up, hopefully
82 2010-05-27T00:30:00 <diofeher> yes, hopefullly :D
83 2010-05-27T00:30:24 <TheSheep> in the worst case you fail and I will have to do all the work :(
84 2010-05-27T00:30:33 <diofeher> well, i've made test without touch anything
85 2010-05-27T00:30:36 <diofeher> and 32 faield ;x
86 2010-05-27T00:30:45 <diofeher> s/faield/failed
87 2010-05-27T00:31:02 <TheSheep> let me take a look
88 2010-05-27T00:31:03 <diofeher> well, 33
89 2010-05-27T00:33:20 <TheSheep> hmm... you are right
90 2010-05-27T00:33:28 <TheSheep> well, keep that number constant
91 2010-05-27T00:33:43 <TheSheep> also, by testing I meant looking at the generated html
92 2010-05-27T00:33:56 <TheSheep> we will talk about automating that next time
93 2010-05-27T00:35:30 <xorAxAx> gn valeuf
94 2010-05-27T00:35:48 <diofeher> TheSheep: http://paste.pocoo.org/show/218714/
95 2010-05-27T00:36:03 <diofeher> okay so TheSheep
96 2010-05-27T00:36:31 <diofeher> thanks :D
97 2010-05-27T00:37:05 <ThomasWaldmann> TheSheep: or descending :)
98 2010-05-27T00:40:01 *** mivert
99 2010-05-27T00:42:54 *** mivert_
100 2010-05-27T00:45:19 <diofeher> TheSheep good night so! tomorrow I will appear with doubts :D
101 2010-05-27T01:57:01 *** franklin
102 2010-05-27T01:57:33 *** franklin
103 2010-05-27T03:02:59 *** ei-grad
104 2010-05-27T05:08:01 <diofeher> gn
105 2010-05-27T09:13:53 <dreimark> moin
106 2010-05-27T09:17:58 <dreimark> valeuf: not necessary for the new stuff but you may change some other places too or we do and it would be good to know if something becomes broken after you merged 2.0-dev
107 2010-05-27T09:18:22 <dreimark> into your repo. You should do this regulary.
108 2010-05-27T09:54:19 <valeuf> dreimark: I agree, however, in my last commit I was adding a new converter, and I did not change anything else, so there was no reason to broke something else
109 2010-05-27T09:56:38 <dreimark> that is right you can decide when to run all tests it is just i want to sensibilize to run more than only own tests in general
110 2010-05-27T09:57:49 <valeuf> dreimark: sure, especially PEP8 !!! I should not forget PEP8 ^ ^
111 2010-05-27T10:07:28 * dreimark one problem less I found out why my interwikiname inm1 was shown as inm - bad order of regexes in farmconfig. inm must be at the end of the list
112 2010-05-27T10:48:36 *** Faxe
113 2010-05-27T10:54:41 <ThomasWaldmann> diofeher: why didn't you fill out the doodle yet?
114 2010-05-27T10:56:22 <aa_> ThomasWaldmann: any idea when?
115 2010-05-27T10:56:34 <aa_> ThomasWaldmann: I need to plan my day
116 2010-05-27T10:57:28 <ThomasWaldmann> well, the times with most green are most likely, there is a counter below the doodle
117 2010-05-27T10:57:57 <aa_> ThomasWaldmann: can you just pick one please?
118 2010-05-27T10:59:39 <ThomasWaldmann> i will, but one student is missing still, see above
119 2010-05-27T10:59:46 <aa_> k
120 2010-05-27T10:59:56 <ThomasWaldmann> but currently, it looks like sat/sun/mon evening is likely
121 2010-05-27T11:32:31 <eSyr> dreimark: shared underlay doesn't solve your problem?
122 2010-05-27T11:34:24 <dreimark> eSyr: in my farm i don't share underlay. it can be solved by underlay if there would be more than one layer posible
123 2010-05-27T11:35:07 <dreimark> +s
124 2010-05-27T11:36:12 <dreimark> i guess in 2.0 i can have a routerbackend defined in farmconfig and add from that route pages to any instance
125 2010-05-27T11:36:39 <dreimark> which lives than only on one backend.
126 2010-05-27T11:36:46 * dreimark lunch
127 2010-05-27T14:51:25 *** DmitryAndreev
128 2010-05-27T14:51:38 *** DmitryAndreev
129 2010-05-27T14:59:33 <diofeher> hey guys, i'm having problem trying to push: remote: ssl required
130 2010-05-27T14:59:58 <diofeher> i've tried to push_ssl=False, but didn't worked...
131 2010-05-27T15:06:04 <TheSheep> what's your push url?
132 2010-05-27T15:06:18 <TheSheep> make sure you push over ssh
133 2010-05-27T15:06:33 <TheSheep> not http
134 2010-05-27T15:08:06 <TheSheep> diofeher: see http://moinmo.in/MoinDev/MercurialGuide#Write_access_to_main_repository
135 2010-05-27T15:08:45 <diofeher> oh, forgot to add this :P
136 2010-05-27T15:08:49 <diofeher> thanks TheSheep
137 2010-05-27T15:08:55 <diofeher> gonna try
138 2010-05-27T15:10:27 <CIA-47> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 8219:74764ef123cc 2.0-dev-jinja2-plugins-dfeher/ (MoinMoin/theme/templating.py docs/2.0-JINJA2-TODO): add a function that render using jinja2 and TODO DOCS
139 2010-05-27T15:11:28 <TheSheep> :)
140 2010-05-27T15:12:06 <diofeher> worked :D
141 2010-05-27T15:18:18 <CIA-47> Dmitry Andreev <klieg.polar@gmail.com> default * 8223:53c2467f220a 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/moinwiki_out.py: DOM->Moinwiki converter: conversion of tables with attributes
142 2010-05-27T15:26:07 <ThomasWaldmann> diofeher: your name is causing troubles for hgweb
143 2010-05-27T15:26:17 <ThomasWaldmann> http://hg.moinmo.in/moin/2.0-dev-jinja2-plugins-dfeher/rev/74764ef123cc
144 2010-05-27T15:26:33 <ThomasWaldmann> see 1.9 - maybe transcribe it using ascii only
145 2010-05-27T15:26:50 <ThomasWaldmann> also, you may want to fix all those typos
146 2010-05-27T15:28:12 <ThomasWaldmann> and please use """ for multiline docstrings
147 2010-05-27T15:29:25 <ThomasWaldmann> also, please fix the path for TEMPLATES_DIR - noone will create /templates on his filesystem
148 2010-05-27T15:30:20 <ThomasWaldmann> hmm, why is my name in the (c) of that code?
149 2010-05-27T15:30:36 <ThomasWaldmann> @license is missing
150 2010-05-27T15:30:36 <moinBot> ThomasWaldmann: Error: "license" is not a valid command.
151 2010-05-27T15:30:49 <ThomasWaldmann> hah
152 2010-05-27T15:31:21 <ThomasWaldmann> the standard header is in MoinMoin/_template.py btw.
153 2010-05-27T15:32:19 <diofeher> hah ok
154 2010-05-27T15:32:21 <ThomasWaldmann> hg mv 2.0-JINJA2-TODO CHANGES.jinja2-templating # and for the "CHANGES" part of that, please use exact same formatting as in CHANGES
155 2010-05-27T15:32:23 <diofeher> sry
156 2010-05-27T15:33:50 <ThomasWaldmann> please fix that stuff now and post your fixed file to a pastebin
157 2010-05-27T15:34:46 <diofeher> ok, just a min
158 2010-05-27T15:34:48 <ThomasWaldmann> http://hg.moinmo.in/moin/2.0-dev-jinja2-plugins-dfeher/file/74764ef123cc/MoinMoin/web/static/__init__.py#l55
159 2010-05-27T15:35:05 <ThomasWaldmann> have a look there about how to create a path that makes sense
160 2010-05-27T15:36:13 * ThomasWaldmann wonders - didn't I have code for such stuff already?
161 2010-05-27T15:37:14 <ThomasWaldmann> http://hg.moinmo.in/moin/2.0-dev-jinja2-plugins-dfeher/file/74764ef123cc/MoinMoin/theme/__init__.py#l154
162 2010-05-27T15:38:49 <diofeher> hmm
163 2010-05-27T15:39:28 <TheSheep> diofeher: __file__ is the path of the currently executed file
164 2010-05-27T15:39:41 <diofeher> it's true..
165 2010-05-27T15:40:48 <ThomasWaldmann> it looks like all you need is already there, right?
166 2010-05-27T15:41:21 <diofeher> yes
167 2010-05-27T15:41:35 <diofeher> i will push the fixes and then modify the code
168 2010-05-27T15:42:25 <ThomasWaldmann> do you need that code at all?
169 2010-05-27T15:43:39 <ThomasWaldmann> if you start with modifying a theme base on ThemeBase, you just need to use self.env
170 2010-05-27T15:45:12 <diofeher> i don't have a maaster plan how to do my project yet, but i think i'm gonna need this function... but i will use yours :)
171 2010-05-27T15:47:36 <ThomasWaldmann> if you want to avoid that 2-liner template = self.env.get_template("something") ; template.render(**context), use some theme method similar to the function you have right now
172 2010-05-27T15:51:39 <ThomasWaldmann> (maybe just call it "render" [or something else short], "render_jinja2" is somehow hard to type all the time)
173 2010-05-27T15:53:00 <TheSheep> .oO(render_my_jinja2_template_now_pretty_please_with_a_cherry_on_top)
174 2010-05-27T15:53:16 <diofeher> :P
175 2010-05-27T15:54:06 * ThomasWaldmann wants the moin man-with-a-sign on top
176 2010-05-27T15:54:34 <diofeher> ThomasWaldmann, hey i've improved that patch (wikiutil) yesterday, with only one error test...
177 2010-05-27T15:55:02 <ThomasWaldmann> if that is +1, it is 1 too much :)
178 2010-05-27T15:55:32 <diofeher> hehe ok, i will try to fix later :D
179 2010-05-27T15:55:32 <ThomasWaldmann> TheSheep: which widget is first? search form?
180 2010-05-27T15:55:50 <ThomasWaldmann> and maybe concentrate on the core task, don't get distracted
181 2010-05-27T15:55:52 <diofeher> Theme is gonna be deprecated, right?
182 2010-05-27T15:56:05 <ThomasWaldmann> in the end, yes
183 2010-05-27T15:57:40 <diofeher> ops, i wanted to mean ThemeBase
184 2010-05-27T15:57:51 <ThomasWaldmann> all that
185 2010-05-27T15:58:13 <diofeher> ok :)
186 2010-05-27T15:58:53 * ThomasWaldmann needs to go again
187 2010-05-27T16:44:28 *** gwork
188 2010-05-27T16:53:12 <diofeher> thanks dreimark, what you writted here is exactly what i'm need MoinAPI/Beispiele
189 2010-05-27T16:53:13 <diofeher> :D
190 2010-05-27T17:06:42 <diofeher> going to college, bye
191 2010-05-27T17:27:10 <CIA-47> Diogenes Augusto <diofeher@gmail.com> default * 8220:0873000120c7 2.0-dev-jinja2-plugins-dfeher/ (4 files in 3 dirs): Adding templates structures and modifying JinjaTheme class with some method of ThemeBase
192 2010-05-27T17:28:24 <CIA-47> Diogenes Augusto <diofeher@gmail.com> default * 8221:9e8277f4ed71 2.0-dev-jinja2-plugins-dfeher/MoinMoin/theme/templating.py: fixing my name at docstrings
193 2010-05-27T17:30:08 <CIA-47> Diogenes Augusto <diofeher@gmail.com> default * 8222:b5c0784d6a4e 2.0-dev-jinja2-plugins-dfeher/MoinMoin/theme/templating.py: changing functinos to class functions and fixing typo
194 2010-05-27T18:00:23 <ThomasWaldmann> diofeher: please read http://hg.moinmo.in/moin/2.0-dev-jinja2-plugins-dfeher/rev/0873000120c7
195 2010-05-27T18:00:47 <ThomasWaldmann> as you see there, hg complains a lot about "\ No newline at end of file
196 2010-05-27T18:01:00 <ThomasWaldmann> " - so please have newlines at the end of your files
197 2010-05-27T18:24:29 <ThomasWaldmann> DmitryAndreev: do you have a MonthCalendar as a wiki diary already?
198 2010-05-27T18:24:46 <ThomasWaldmann> if not, please create one and update it daily.
199 2010-05-27T18:27:42 <ThomasWaldmann> diofeher: http://doodle.com/participation.html?pollId=47ezp4cbn6n34b8t how long do you expect us to wait for you updating this doodle?
200 2010-05-27T18:28:41 <ThomasWaldmann> you just have to tell the times when you usually have time (times that are not fixed allocated for something else)
201 2010-05-27T18:43:13 <ThomasWaldmann> valeuf: you should not do copy&paste coding
202 2010-05-27T18:43:33 <ThomasWaldmann> valeuf: add a blank after # (comments)
203 2010-05-27T18:45:07 <ThomasWaldmann> valeuf: http://hg.moinmo.in/moin/2.0-dev-docbook-html-vjaniaut/rev/f03655db1733 after commas, there is usually a blank
204 2010-05-27T18:46:01 <ThomasWaldmann> (with copy&paste i am referring to those _Iter and _Stack classes)
205 2010-05-27T18:46:03 <eSyr> ThomasWaldmann: yes, Dmitry does
206 2010-05-27T18:47:17 <eSyr> btw, about month calendar: maybe it would be better to add several monthcalendar macro with fixed month argument? Diaries from previos GSoCs rather difficult to read.
207 2010-05-27T18:48:37 <ThomasWaldmann> eSyr: yes, could be also 3 fixed MCs, good idea :)
208 2010-05-27T18:49:14 <ThomasWaldmann> eSyr: so, where is it (URL?)
209 2010-05-27T18:49:42 <eSyr> ThomasWaldmann: http://moinmo.in/DmitryAndreev/GSoC2010/Diary
210 2010-05-27T18:49:57 * eSyr reading it via mail notifications
211 2010-05-27T18:50:13 <eSyr> *reads
212 2010-05-27T18:50:23 <eSyr> (and all other diaries)
213 2010-05-27T18:50:41 <ThomasWaldmann> Your search query "linkto:"DmitryAndreev/GSoC2010/Diary"" didn't return any results
214 2010-05-27T18:50:58 <ThomasWaldmann> maybe he should de-orphan that page
215 2010-05-27T18:51:12 <eSyr> hehe, i'll tell him.
216 2010-05-27T18:51:21 <ThomasWaldmann> DmitryAndreev: ^^
217 2010-05-27T18:52:17 <eSyr> he is offline in jabber, may be he is away.
218 2010-05-27T18:54:02 <ThomasWaldmann> btw, if you have some time for hacking, you wanted to look at that jabber unicode issues
219 2010-05-27T18:54:06 <ThomasWaldmann> -s
220 2010-05-27T18:56:08 <eSyr> yes, sure.
221 2010-05-27T18:56:20 <eSyr> but at the moment i'm rather busy.
222 2010-05-27T18:59:45 <eSyr> ThomasWaldmann: also i've asked Dmitry to use h1's for diary pages, may be make this common rule?
223 2010-05-27T19:01:52 <ThomasWaldmann> yes, it is better for js preview
224 2010-05-27T19:02:58 <eSyr> yes, for that purpose.
225 2010-05-27T19:03:57 <eSyr> I've replaced MC's for gsoc 2009 diaries. Haven't diaries been used in previous years?
226 2010-05-27T19:04:02 <eSyr> (beause i haven
227 2010-05-27T19:04:07 <eSyr> 't found any)
228 2010-05-27T19:05:29 <ThomasWaldmann> looks much better :)
229 2010-05-27T19:06:11 <ThomasWaldmann> i don't remember exactly, but we have changed some stuff over the years, mostly to avoid deadline scheduling by students
230 2010-05-27T19:14:27 <ThomasWaldmann> anyone going to GPN10 (Karlsruhe, Germany)?
231 2010-05-27T19:25:52 <dreimark> OMG 14660951 files in sendcache folders
232 2010-05-27T19:30:38 <dreimark> ah, no stringlenth it is only 148197 files
233 2010-05-27T19:33:36 <eSyr> lol
234 2010-05-27T19:33:48 <valeuf> ThomasWaldmann: I will have a look to use Month Calendar for my diary, I did not know this macro, it looks cool
235 2010-05-27T19:33:50 <ThomasWaldmann> DmitryAndreev: attrib.append('tablestyle="'+self.table_tablestyle+'"')
236 2010-05-27T19:33:51 <eSyr> 148k is still rather big number.
237 2010-05-27T19:34:09 <eSyr> valeuf: http://moinmo.in/HelpOnMacros/MonthCalendar
238 2010-05-27T19:34:18 <ThomasWaldmann> please -> 'tablestyle="%s"' % self.table_tablestyle
239 2010-05-27T19:34:32 <eSyr> valeuf: http://moinmo.in/4ct10n/diff/Admin2009/Diary?action=diff
240 2010-05-27T19:34:38 <valeuf> ThomasWaldmann: yep, copy&paste is not so good, but it was just to have a base, I will modify it over the time, I just need to understand well the purpose of the _Stack and _Iter class
241 2010-05-27T19:38:11 <ThomasWaldmann> valeuf: ask the right person :)
242 2010-05-27T19:43:13 <valeuf> ThomasWaldmann: yep :)
243 2010-05-27T19:43:41 <valeuf> ThomasWaldmann: but my main worry was to write the test yesterday
244 2010-05-27T19:43:55 <valeuf> I want to write tests before I start coding the converter ^ ^
245 2010-05-27T19:44:55 <CIA-47> Diogenes Augusto <diofeher@gmail.com> default * 8223:3365f04f5bba 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (templates/header.html theme/__init__.py theme/templating.py): deleted jinjatheme and now modifying old Theme... search form is now rendered with jinja, template at header.html
246 2010-05-27T20:01:57 <DmitryAndreev> moin
247 2010-05-27T20:04:04 <ThomasWaldmann> hi dmitry
248 2010-05-27T20:07:42 <DmitryAndreev> strange, pep8 test didn't not found my attrib.append('tablestyle="'+self.table_tablestyle+'"')
249 2010-05-27T20:08:20 <ThomasWaldmann> yes, the tester is not perfect
250 2010-05-27T20:08:55 <dreimark> re
251 2010-05-27T20:08:58 <DmitryAndreev> ok, i'll change it to % style.
252 2010-05-27T20:09:35 <dreimark> what is line 620 in common.js used for
253 2010-05-27T20:11:25 <dreimark> http://hg.moinmo.in/moin/1.9/annotate/e45e3ae9e540/MoinMoin/web/static/htdocs/common/js/common.js#l479
254 2010-05-27T20:11:46 <dreimark> this function seems to block large tables
255 2010-05-27T20:11:56 <dreimark> on page loading
256 2010-05-27T20:12:13 <dreimark> without editing involed
257 2010-05-27T20:17:24 <ThomasWaldmann> define "block"
258 2010-05-27T20:28:28 <dreimark> now it stops in line 554
259 2010-05-27T20:29:00 <dreimark> i get a form where i can kill its activity
260 2010-05-27T20:29:12 <ThomasWaldmann> wait
261 2010-05-27T20:29:54 <dreimark> that is now the doublecick improvement
262 2010-05-27T20:30:27 <dreimark> that page is a table with 3782 lines
263 2010-05-27T20:41:18 <dreimark> the page loads much faster with common.js from 1.9.2
264 2010-05-27T20:56:30 <ThomasWaldmann> no feature is for free
265 2010-05-27T20:56:50 <Faxe> really? :)
266 2010-05-27T21:00:21 <dreimark> because it doesn't find the right line it should may be ignore tables
267 2010-05-27T21:33:36 <valeuf> waldi: can you explain me why do you need _Iter and _Stack for the converters ? It is not really clear for me
268 2010-05-27T21:49:07 <diofeher> TheSheep: finally i understood what is happening in Theme :)
269 2010-05-27T21:49:23 <diofeher> searchform and logo are now generated by jinja
270 2010-05-27T21:52:10 <CIA-47> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8227:d60a4723c3fb 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/html_in.py: Add spaces after # in comment
271 2010-05-27T22:05:17 <valeuf> ThomasWaldmann: did you choose a date for the meeting finally ?
272 2010-05-27T22:12:14 <ThomasWaldmann> diofeher: update doodle now
273 2010-05-27T22:20:47 <dreimark> .oO where is ei-grad
274 2010-05-27T22:23:55 <diofeher> ThomasWaldmann: oush, i answered yesterday :( my data is gone?
275 2010-05-27T22:25:46 <dreimark> hmm, everywhere are bugs
276 2010-05-27T22:25:55 <ThomasWaldmann> there is no data from you
277 2010-05-27T22:27:46 <diofeher> answered again
278 2010-05-27T22:27:47 <diofeher> :)
279 2010-05-27T22:27:52 <diofeher> TheSheep is here?
280 2010-05-27T22:28:21 <diofeher> i've did some modifications in Theme and i just wanna know if i'm in the right way
281 2010-05-27T22:32:38 <CIA-47> Diogenes Augusto <diofeher@gmail.com> default * 8224:5bd7fca4de44 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (templates/header.html theme/__init__.py): now logo, interwiki and searchform is rendered by jinja
282 2010-05-27T22:41:35 <ThomasWaldmann> looks like nobody subscribed to GoogleSoc2010 page
283 2010-05-27T22:41:53 <ThomasWaldmann> (except esyr, who subscribed to .* or so)
284 2010-05-27T22:42:12 <valeuf> ThomasWaldmann: done ^ ^
285 2010-05-27T22:42:25 <ThomasWaldmann> http://moinmo.in/GoogleSoc2010 weekly meeting sundays 17:00 UTC
286 2010-05-27T22:42:45 <TheSheep> diofeher: back
287 2010-05-27T22:42:58 <TheSheep> diofeher: speak your mind
288 2010-05-27T22:43:04 <TheSheep> :)
289 2010-05-27T22:43:25 <ThomasWaldmann> aa_: diofeher: DmitryAndreev: dreimark: eSyr: TheSheep: valeuf: waldi: xorAxAx: ^^^
290 2010-05-27T22:43:46 <valeuf> ThomasWaldmann: ^ ^
291 2010-05-27T22:44:30 <ThomasWaldmann> aa_: waldi: that time doesn't fit the free times you announced, but it fits most other people
292 2010-05-27T22:44:32 * dreimark reads regulary RC
293 2010-05-27T22:44:47 * TheSheep regualrly skips RC
294 2010-05-27T22:45:01 <dreimark> huh
295 2010-05-27T22:45:15 <aa_> ThomasWaldmann: I can do this sunday, but all other sundays I am specifically somewhere else at that time
296 2010-05-27T22:45:25 <dreimark> TheSheep: did you fix his css id problems?
297 2010-05-27T22:45:33 <TheSheep> dreimark: whose?
298 2010-05-27T22:46:43 <dreimark> that e.g. = preview = becomes rendered because of its id for TOC
299 2010-05-27T22:47:01 <TheSheep> I have a fix I didn't test yet
300 2010-05-27T22:47:39 <TheSheep> I keep putting things off
301 2010-05-27T22:47:50 <TheSheep> it's getting pretty bad
302 2010-05-27T22:48:20 <diofeher> Thesheep: hello :) some functions are now rendering with jinja
303 2010-05-27T22:48:32 <diofeher> can u take a look at code to see if i'm in the right way?
304 2010-05-27T22:48:43 <diofeher> TheSheep: http://hg.moinmo.in/moin/2.0-dev-jinja2-plugins-dfeher/rev/5bd7fca4de44
305 2010-05-27T22:48:51 <TheSheep> yes
306 2010-05-27T22:49:47 <diofeher> comments in header is just to help me to know where i have to put the functions
307 2010-05-27T22:49:50 <TheSheep> by the way, we will need to prefix all ids and classes with 'moin-'
308 2010-05-27T22:49:56 <diofeher> s/header/header.html
309 2010-05-27T22:50:45 <TheSheep> diofeher: say, desn't jinja have functions?
310 2010-05-27T22:51:09 <diofeher> no, i meaned functions that renders parts of header
311 2010-05-27T22:51:15 <diofeher> like ThemeBase.logo()
312 2010-05-27T22:51:43 <diofeher> it's better to rename all ids and classes with theme name, no?
313 2010-05-27T22:51:56 <TheSheep> oh, they call them blocks in jinja
314 2010-05-27T22:52:16 <diofeher> hehe i know
315 2010-05-27T22:52:42 <TheSheep> and macros
316 2010-05-27T22:52:48 <diofeher> but i'm not talking about blocks of jinja... just about "blocks" of rendering in ThemeBase
317 2010-05-27T22:53:52 <TheSheep> yeah, I think I see what you mean
318 2010-05-27T22:54:29 <TheSheep> it's ok for now, but ultimately we will want a 'master' template, like the themebase, that's built in in moin, and templates in themes that inherit from it
319 2010-05-27T22:54:41 <TheSheep> so that you don't have all this boilerplate
320 2010-05-27T22:55:09 <diofeher> oh, nice idea! ok so
321 2010-05-27T22:55:36 <TheSheep> for now lets just get a working template-based theme
322 2010-05-27T22:55:39 <diofeher> i will try to finish this conversion of header and footer today
323 2010-05-27T22:55:44 <TheSheep> we will think about the structure later
324 2010-05-27T22:55:48 <diofeher> okay
325 2010-05-27T22:55:50 <diofeher> thanks
326 2010-05-27T22:57:01 <TheSheep> diofeher: do you also have th pythn code that calls them?
327 2010-05-27T22:57:11 <TheSheep> diofeher: or do you use the code from themebase?
328 2010-05-27T22:58:08 <diofeher> i'm using themebase for while
329 2010-05-27T22:58:26 <TheSheep> ok
330 2010-05-27T22:58:38 <TheSheep> we want it that way ultimately anyways
331 2010-05-27T22:59:30 <TheSheep> k, I see you use inheritance after all :)
332 2010-05-27T22:59:37 <CIA-47> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8228:93c457c46bff 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_html_in.py: Add more tests for html_in
333 2010-05-27T23:00:40 <ThomasWaldmann> diofeher: TheSheep: we maybe want to have a different method to feed the templates soon
334 2010-05-27T23:00:57 <ThomasWaldmann> that d dictionary method is a bit ugly imho
335 2010-05-27T23:01:02 <TheSheep> yes, only passing what is required
336 2010-05-27T23:01:47 *** Faxe
337 2010-05-27T23:02:05 <dreimark> gn
338 2010-05-27T23:03:33 <TheSheep> diofeher: one of the tasks is looking through the templates and making a list of all variables they need to use
339 2010-05-27T23:03:58 <TheSheep> diofeher: config is probably a separate whle variable
340 2010-05-27T23:05:04 <ThomasWaldmann> diofeher: 1.37 \ No newline at end of file
341 2010-05-27T23:05:40 <ThomasWaldmann> if you get improvement suggestions, maybe try to follow them
342 2010-05-27T23:06:11 <TheSheep> diofeher: actually, I kinda expected that you'd make a new theme inheriting from ThemeBase and override the methods in there, leaving the themebase as it was
343 2010-05-27T23:06:27 <TheSheep> diofeher: not modifying it all in place
344 2010-05-27T23:08:57 <eSyr> btw, using vim with provided somewhere on moinmoin site python syntax file keeps from making simple mistakes about pep-8 and newlines.
345 2010-05-27T23:09:55 <eSyr> dreimark: what is your fix to id names clash problem?
346 2010-05-27T23:10:17 <eSyr> i think about adding important to styles inside content.
347 2010-05-27T23:10:36 <diofeher> TheSheep: yes.. it's better to inherit from it and override... my mistake
348 2010-05-27T23:11:03 <eSyr> (because other ad-hoc solution for 1.9 is to rewrite all other css selectors and force theme makers to do so)
349 2010-05-27T23:11:34 <eSyr> (anyway, third-party themes should take such css-related bugs into account, though)
350 2010-05-27T23:11:36 <diofeher> ThomasWaldmann : what you suggest to feed the templates? I always do this with dicts :)
351 2010-05-27T23:12:15 <ThomasWaldmann> what you currently do is a beginning, not the final state
352 2010-05-27T23:12:18 <eSyr> ThomasWaldmann: btw, what do you think about forcing standart lexer/syntax parser library in moin2 bundle?
353 2010-05-27T23:12:36 <ThomasWaldmann> e.g. link generation for easy stuff can be done in the template
354 2010-05-27T23:13:20 <eSyr> i've asked Dmitry to do little research about what can be suitable for moin2 converters.
355 2010-05-27T23:13:43 <eSyr> (and try to write simple csv parser using most suitable of them)
356 2010-05-27T23:14:54 <ThomasWaldmann> diofeher: also, we are getting lots of stuff from request.* which kind of blocks refactoring request object
357 2010-05-27T23:15:34 <ThomasWaldmann> (we currently have a mixed-together request/response object, which was causing lots of trouble recently)
358 2010-05-27T23:16:49 <ThomasWaldmann> werkzeug offers "local" objects (and a manager class for them) so stuff could be handled in a way similar to globals
359 2010-05-27T23:17:23 <ThomasWaldmann> (but every request (and every thread) see's only the locals correct for it)
360 2010-05-27T23:17:30 <diofeher> hmm
361 2010-05-27T23:17:55 <ThomasWaldmann> cfg, user, request could be such locals
362 2010-05-27T23:17:56 <diofeher> i'm gonna search about this object from werkzeug
363 2010-05-27T23:19:47 <ThomasWaldmann> http://werkzeug.pocoo.org/documentation/0.6.2/local.html
364 2010-05-27T23:20:13 <ThomasWaldmann> it's just an idea, but it looks like made for it
365 2010-05-27T23:21:37 <diofeher> ok Thomas... when i finish this first part, i'm go in in this link :)