1 2010-06-29T00:09:28 <ei-grad> waldi: oh, sorry, I did not understand what kind of questions you meant ) so, three basic questions, as I guess, should be
2 2010-06-29T00:09:30 <ei-grad> 1. List of groups
3 2010-06-29T00:09:33 <ei-grad> 2. List of members of specified group
4 2010-06-29T00:09:34 <ei-grad> 3. The group contains the specified member? (not required, but influence on the performance)
5 2010-06-29T00:11:06 <waldi> ei-grad: 1. list of groups. 2. list of groups of a users. 3. list of users in a group. the first two are usually fast, the last one not
6 2010-06-29T00:36:14 *** TheSheep
7 2010-06-29T00:38:04 *** TheSheep
8 2010-06-29T00:40:08 <dreimark> gn
9 2010-06-29T00:41:48 *** RogerHaase
10 2010-06-29T00:58:05 *** TheSheep
11 2010-06-29T02:33:13 *** diofeher
12 2010-06-29T03:13:05 *** diofeher
13 2010-06-29T05:31:51 *** kursor
14 2010-06-29T06:46:18 *** kursor
15 2010-06-29T07:18:02 *** franklin
16 2010-06-29T07:44:31 *** DmitryAndreev
17 2010-06-29T08:29:23 <ThomasWaldmann> moin
18 2010-06-29T08:31:35 *** gwork
19 2010-06-29T08:45:19 *** grzywacz
20 2010-06-29T08:52:03 <dreimark> moin
21 2010-06-29T10:04:42 <waldi> moin
22 2010-06-29T10:09:27 *** valeuf
23 2010-06-29T10:13:45 <valeuf> moin
24 2010-06-29T10:35:37 *** grzywacz
25 2010-06-29T10:58:05 <valeuf> waldi: there is some unclear point with the IRI and the object !
26 2010-06-29T10:58:39 <valeuf> waldi: should I convert the URL of a img, a or object tag into an IRI ?
27 2010-06-29T10:58:52 <valeuf> waldi: or can I just keep the unicode representation of the URL ?
28 2010-06-29T10:59:03 <valeuf> in the html_out converter, there is some questions about it
29 2010-06-29T11:03:12 <waldi> please first answer the question what you could do with an URL. if the answer is "no", just don't try to do anything
30 2010-06-29T11:12:16 <valeuf> I can convert the URL into IRI it is not a problem
31 2010-06-29T11:14:30 <waldi> this is a nop
32 2010-06-29T11:15:42 <valeuf> not really, I agree that the representation is the same, but for the converter, an IRI will be different than a unicode object
33 2010-06-29T11:21:38 <waldi> it is a nop. everything have to cope with a unicode-representation anyway
34 2010-06-29T11:26:35 <valeuf> waldi: well, in this case why do we have "target = Iri(object_url)" in the moinwiki_in converter
35 2010-06-29T11:26:55 <valeuf> and a test in the html_out converter to handle differently the conversion if we have a unicode or an Iri
36 2010-06-29T11:28:40 <waldi> valeuf: because this code is two years old and the rest evolved in the meantime. also the moinmoin input may not include complete uri
37 2010-06-29T11:29:08 <valeuf> ok, so I keep unicode
38 2010-06-29T11:29:37 <waldi> the rule is easy: don't handle things you don't know about and you don't need to do
39 2010-06-29T11:29:43 <waldi> 2/away
40 2010-06-29T11:29:55 <waldi> and the uris are opaque for this converter
41 2010-06-29T11:30:07 <valeuf> ok
42 2010-06-29T11:30:15 <valeuf> thanks, it is more clear now
43 2010-06-29T12:52:58 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8492:c97407d0f63b 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_html_in_out.py: Add tests for tables in the HTML roundtrip unit test
44 2010-06-29T12:52:59 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8493:81c0d8cf2bf0 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_html_in_out.py: Add tests for objects for the HTML roundtrip
45 2010-06-29T12:53:01 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8494:249eda1112d5 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/html_in.py: Ensure that the href attribute of the object is an unicode string
46 2010-06-29T12:53:03 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8495:5efb00f9459f 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_html_in.py: Add a more complex test for the list in the HTML_IN converter
47 2010-06-29T13:34:38 *** gwork
48 2010-06-29T13:43:58 *** ei-grad
49 2010-06-29T13:46:13 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8496:e20c2a9ee1ce 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_html_in.py: Update tests for the list in HTML_IN converter, since the previous syntax was wrong
50 2010-06-29T13:46:14 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8497:6a4137edd712 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/html_in.py: Change the list conversion in HTML_IN converter, since the previous syntax mas wrong
51 2010-06-29T13:46:14 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8498:2187641f3010 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_html_in_out.py: Add more complex test for the list for the HTML roundtrip
52 2010-06-29T13:46:14 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8499:e92ad07ac426 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/ (_tests/test_html_in_out.py html_in.py): Minor fix to fulfill the PEP8
53 2010-06-29T15:15:46 *** aa_
54 2010-06-29T15:18:18 *** kursor
55 2010-06-29T16:48:25 *** ei-grad
56 2010-06-29T16:48:45 <ei-grad> moin
57 2010-06-29T17:06:40 <dreimark> moin ei-grad
58 2010-06-29T17:07:17 <dreimark> valeuf: do you know a convertor for odt to docbook or reST?
59 2010-06-29T17:09:23 *** RogerHaase
60 2010-06-29T17:10:35 <valeuf> dreimark: I know that there is a lot, but I never get the need to do it ... so I have no idea which will be the best
61 2010-06-29T17:13:24 *** ei-grad
62 2010-06-29T17:14:18 *** ei-grad
63 2010-06-29T17:17:44 *** ei-grad
64 2010-06-29T17:40:13 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8500:7eafd64443fe 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_html_in_out.py: Add tests for a bug with newline character inside a list
65 2010-06-29T17:40:16 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8501:bf64ce25402a 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_html_in_out.py: Add more test to show the bug with newline in a list for the HTML_IN converter
66 2010-06-29T17:40:16 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8502:b941d31895cb 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/html_in.py: Refactor the code to convert the lists in order to fix bug with newline in the HTML_IN converter
67 2010-06-29T17:42:35 *** ei-grad
68 2010-06-29T17:53:19 <ThomasWaldmann> diofeher: what are you working on right now?
69 2010-06-29T17:53:56 * ThomasWaldmann misses some quick small changesets to fix the easy stuff on your todo
70 2010-06-29T17:54:43 <valeuf> waldi: in the HTML_OUT converter, string outside of any tag within a table tag, and a list tag will return an error during the conversion
71 2010-06-29T17:55:26 <valeuf> waldi: I fixed my HTML_IN converter to avoid string outside of tag inside <table> and <list>
72 2010-06-29T17:56:08 <valeuf> waldi: but maybe should I also add some fix in the HTML_OUT converter, to avoid error (maybe just print debug information)
73 2010-06-29T18:13:20 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8503:439e27c6acb2 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_html_in_out.py: Add test to show bug with extra string in table tag for HTML conversion
74 2010-06-29T18:13:26 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8504:88f50ede7dcf 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/html_in.py: Fix bug with extra string in the table tag for the HTML_IN converter
75 2010-06-29T19:07:00 *** grzywacz
76 2010-06-29T20:58:22 *** kursor
77 2010-06-29T22:41:49 <CIA-98> Andrew Grigorev <andrew@ei-grad.ru> default * 5761:68a6a033cbb8 1.9-ldap-kerberos-agrigorev/MoinMoin/datastruct/backends/_tests/test_ldap_groups.py: [LDAP2010] missed import py.test in test_ldap_groups.py
78 2010-06-29T22:59:40 <valeuf> wow :)
79 2010-06-29T23:00:14 <valeuf> except style problem, all the elements of the WYSIWYG editor are working correctly in roundtrip conversion
80 2010-06-29T23:00:53 <valeuf> I will do some cleaning, and read again my code tomorrow to be sure that everything is correct
81 2010-06-29T23:01:19 <ThomasWaldmann> great :)
82 2010-06-29T23:02:02 <valeuf> I hope that I will be faster to do the DocBook converter, now I have experience ^ ^
83 2010-06-29T23:02:25 <valeuf> xorAxAx: feel you free to review my code whenever you want
84 2010-06-29T23:04:16 <xorAxAx> sure
85 2010-06-29T23:12:19 <dreimark> ei-grad: please can you document differences between AD and openldap
86 2010-06-29T23:12:29 <dreimark> in the wiki
87 2010-06-29T23:25:15 <ThomasWaldmann> valeuf: http://moinmo.in/ValentinJaniaut/GSoC/Diary/2010-06-29?action=AttachFile&do=view&target=html_out.diff line 8/9?
88 2010-06-29T23:25:35 <valeuf> fail ....
89 2010-06-29T23:26:29 <valeuf> I did it quickly, I will do it again more carefully tomorrow
90 2010-06-29T23:26:41 <ThomasWaldmann> is it really "downer-"?
91 2010-06-29T23:27:32 <valeuf> maybe lower would be more adequate
92 2010-06-29T23:27:41 <ei-grad> dreimark: ok
93 2010-06-29T23:27:47 <valeuf> ThomasWaldmann: A downer is a slang term, referring to a person who is
94 2010-06-29T23:27:47 <valeuf> down, or depressed, particularly if their mood brings other people down
95 2010-06-29T23:27:56 <valeuf> ThomasWaldmann: you ae right, it was not the best word
96 2010-06-29T23:29:30 <ThomasWaldmann> lower-?
97 2010-06-29T23:29:46 *** TheSheep
98 2010-06-29T23:29:58 <valeuf> ThomasWaldmann: yes, lower, it seems that we say lower case,
99 2010-06-29T23:30:06 <valeuf> I should not follow my intuition
100 2010-06-29T23:30:22 <ThomasWaldmann> http://moinmo.in/ValentinJaniaut/GSoC/Diary/2010-06-29?action=AttachFile&do=view&target=html_out.diff#CA-804a02f63a4c9a9c585fed1bc06375dfd8c8f3f9_50
101 2010-06-29T23:30:45 <ThomasWaldmann> you use html.ins few lines above, is there now html.del for this?
102 2010-06-29T23:30:48 <ThomasWaldmann> -w
103 2010-06-29T23:31:48 <valeuf> ThomasWaldmann: yep, I need to review all this code tomorrow, there is too many mistakes, I will try to produce a better quality diff next time
104 2010-06-29T23:32:31 <ThomasWaldmann> :)
105 2010-06-29T23:32:59 <valeuf> ThomasWaldmann: I removed the file from the wiki, and I will do it again correctly
106 2010-06-29T23:32:59 * ThomasWaldmann usually does hg diff, repeat until happy
107 2010-06-29T23:33:57 <valeuf> ThomasWaldmann: it was the result of many changes, I did not check before I posted the file, shame on me ! we should always check twice !
108 2010-06-29T23:34:53 <ThomasWaldmann> yes, and remove the blanks left of !
109 2010-06-29T23:35:02 <ThomasWaldmann> :P
110 2010-06-29T23:35:11 <dreimark> valeuf: some of my colleagues use a clone of the repo for working
111 2010-06-29T23:35:12 <valeuf> but it is weird that PEP8 checker did not complain about it
112 2010-06-29T23:35:31 <valeuf> dreimark: ?
113 2010-06-29T23:35:33 <dreimark> and they review by this two times before they commit to the official one
114 2010-06-29T23:35:39 <valeuf> dreimark: aah I see
115 2010-06-29T23:35:54 <valeuf> actually this is something I was really missing during my last job
116 2010-06-29T23:36:33 <valeuf> it was an internship in the game company, nobody was reviewing the code, we was just trusting each other
117 2010-06-29T23:37:19 <valeuf> but many times, even advanced programmer forget big error in their code ... which could be easily avoided if someone else was reading their code before they commit
118 2010-06-29T23:40:45 *** ei-grad
119 2010-06-29T23:41:11 <ThomasWaldmann> iirc guido worked on a code review tool at google not long ago :)
120 2010-06-29T23:41:18 <dreimark> valeuf: people have to learn this first.
121 2010-06-29T23:41:46 <valeuf> dreimark: problem is that at first it takes time ... and in company it seems that we are always rushing
122 2010-06-29T23:42:06 <valeuf> even if finally at the end you waste probably more time to fix a lot of bugs
123 2010-06-29T23:54:46 * dreimark knows that too. currently it seems that they watch me more. Lets see how long it takes that they run there usual way.
124 2010-06-29T23:56:44 *** grzywacz
125
