1 2010-08-01T00:09:26 *** RogerHaase
2 2010-08-01T00:20:27 *** ebo^
3 2010-08-01T00:38:52 <ThomasWaldmann> waldi: hmm, do we maybe need another sort of href conversion for stuff that needs to point to "raw" get url?
4 2010-08-01T00:39:32 <ThomasWaldmann> wiki.local converts to the "render" url, but that's not what we need for images
5 2010-08-01T01:12:15 *** grzywacz
6 2010-08-01T02:12:00 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9227:4144fc1f06cd 2.0-dev/MoinMoin/ (items/__init__.py converter2/image_in.py): add image_in (jpeg/png/gif) converter, use converter to render images
7 2010-08-01T02:12:29 <ThomasWaldmann> (almost)
8 2010-08-01T02:12:39 <ThomasWaldmann> waldi: any feedback on the conversion?
9 2010-08-01T02:13:31 <ThomasWaldmann> problem: object element in dom uses href, href gets converted to show url
10 2010-08-01T02:14:26 <ThomasWaldmann> suggestion: use data attribute for object, convert data attrs to get url
11 2010-08-01T02:45:31 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9228:a37cce0dafb6 2.0-dev/MoinMoin/items/__init__.py: items: deduplicate, call internal_representation from _render_data
12 2010-08-01T02:53:18 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9229:9c1d5acf4550 2.0-dev/MoinMoin/items/__init__.py: cosmetic: moving classes / grouping similar stuff
13 2010-08-01T03:47:01 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9230:ea2c06711e32 2.0-dev/MoinMoin/ (converter2/image_in.py items/__init__.py): items: move converter to base class
14 2010-08-01T03:57:09 *** ronny
15 2010-08-01T07:49:32 *** ei-grad
16 2010-08-01T07:50:17 *** ei-grad
17 2010-08-01T09:42:37 *** grzywacz
18 2010-08-01T11:36:27 <ThomasWaldmann> moin
19 2010-08-01T12:04:45 <valeuf> moin
20 2010-08-01T12:05:19 <valeuf> ThomasWaldmann: I almost did not open my pink netbook since I came back from the europython
21 2010-08-01T12:05:47 <valeuf> ThomasWaldmann: and I did not test more the packaging stuffs
22 2010-08-01T12:05:58 <valeuf> *stuff
23 2010-08-01T12:06:06 <valeuf> but I will try to do it in the upcoming days
24 2010-08-01T12:12:06 <ThomasWaldmann> great :)
25 2010-08-01T12:12:37 <ThomasWaldmann> btw, it won't be stolen :D
26 2010-08-01T12:12:44 <valeuf> :D
27 2010-08-01T12:13:44 <ThomasWaldmann> i am currently thinking about writing some converters
28 2010-08-01T12:13:53 <valeuf> ThomasWaldmann: which one?
29 2010-08-01T12:14:40 <ThomasWaldmann> e.g. we could have one that converts application/x-unknown (which maybe should be rather x-nonexistent)
30 2010-08-01T12:15:01 <valeuf> converts to which format?
31 2010-08-01T12:15:06 <ThomasWaldmann> dom tree
32 2010-08-01T12:15:36 <ThomasWaldmann> it would get the NAME of the item (not the content, same as image converter i wrote yesterday)
33 2010-08-01T12:16:49 <ThomasWaldmann> and its output would be a link to that item, link text either just item name in grey or some hint that the transcluded item does not exist, click to create or so
34 2010-08-01T12:17:18 <valeuf> ThomasWaldmann: hum ok why not
35 2010-08-01T12:17:50 <ThomasWaldmann> then maybe a tar/zip converter, listing contents
36 2010-08-01T12:18:02 <ThomasWaldmann> (code already exists in items)
37 2010-08-01T12:18:36 <ThomasWaldmann> btw, look into items, i reduced converter code there a lot
38 2010-08-01T12:19:24 <valeuf> ThomasWaldmann: ok, a lot of things on my ToDo list for today ^^
39 2010-08-01T12:20:20 <ThomasWaldmann> you can maybe do same thing for _convert after making it generic
40 2010-08-01T12:21:54 <ThomasWaldmann> hmm, why is convert in HTML class although it emits docbook/xml?
41 2010-08-01T12:22:48 <valeuf> ThomasWaldmann: wooow weird
42 2010-08-01T12:22:58 <valeuf> this code should be in docbook
43 2010-08-01T12:24:24 <valeuf> I will see to fix that now
44 2010-08-01T12:24:37 <ThomasWaldmann> afterwards think about moving it to Binary
45 2010-08-01T12:24:57 <valeuf> move what? the _convert method?
46 2010-08-01T12:25:02 <ThomasWaldmann> yes
47 2010-08-01T12:25:04 *** ebo^
48 2010-08-01T12:25:30 <valeuf> ThomasWaldmann: hum, each type should have his convert method
49 2010-08-01T12:25:49 <valeuf> there is maybe some generic method for binary, but it is quite specific for each text mimetype
50 2010-08-01T12:26:10 <ThomasWaldmann> what is specific?
51 2010-08-01T12:27:04 <valeuf> ThomasWaldmann: namespace for all
52 2010-08-01T12:27:15 <valeuf> ThomasWaldmann: some format will need to emit a doctype
53 2010-08-01T12:27:35 <valeuf> we can have some generic convert in Text, but probably not in Binary
54 2010-08-01T12:27:46 <valeuf> conversion of an image is really different than conversion of a text
55 2010-08-01T12:29:06 <ThomasWaldmann> well, the conversion itself is done by converter (if there is one)
56 2010-08-01T12:29:34 <ThomasWaldmann> so the only different stuff is what's needed additionally for some reason
57 2010-08-01T12:30:13 <valeuf> ThomasWaldmann: well, there is another solution, give some parameters to the converter to let the converter add specific element if we want a full document
58 2010-08-01T12:30:22 <ThomasWaldmann> and just using self.mimetype instead of hardcoded mimetype would be rather generic already
59 2010-08-01T12:30:48 <ThomasWaldmann> valeuf: yeah
60 2010-08-01T12:31:01 <valeuf> for instance, with the DOM-->HTML converter we do not want a DocType if we are going to print the code within the template
61 2010-08-01T12:31:18 <valeuf> but if we want to download an HTML page, we need to add doctype, html, body and so...
62 2010-08-01T12:31:42 <valeuf> I thought that it would be better to put this in the items module, but maybe it is better to add this in the converter
63 2010-08-01T12:31:42 <ThomasWaldmann> hmm, isn't there a different mimetype for full doc vs. content doc?
64 2010-08-01T12:32:08 <valeuf> ThomasWaldmann: I do not know
65 2010-08-01T12:33:52 <valeuf> but other example, if we want to convert different item into one DocBook element, we are going to use the DOM-->DocBook converter on different DOM tree, but we should emit just once the namespace, and the root element
66 2010-08-01T12:34:15 <valeuf> (but for this situtation, maybe the include converter can be used before we launch the Docbook_out converter?)
67 2010-08-01T12:34:48 <ThomasWaldmann> yeah, after someone fixed it :)
68 2010-08-01T12:35:39 <ThomasWaldmann> it is rather old code still, using Page...
69 2010-08-01T12:37:02 <ThomasWaldmann> btw, fixing that in the right way would solve showing images in markups also
70 2010-08-01T12:38:00 <ThomasWaldmann> because img, object, transclude, include is all kind of same concept
71 2010-08-01T12:39:48 <ThomasWaldmann> http://moinmo.in/BastianBlank/TreeOutputFormatter see under "Types"
72 2010-08-01T12:40:36 <ThomasWaldmann> valeuf: btw, maybe merge main
73 2010-08-01T12:42:57 <valeuf> ThomasWaldmann: ok ... many things :p
74 2010-08-01T12:43:45 <valeuf> I want to fix the problem of the _converter method in HTML, it means that maybe all my code for the conversion was wrong :s
75 2010-08-01T12:43:51 <valeuf> then I merge
76 2010-08-01T12:44:37 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9231:587a0aff83c5 2.0-dev/MoinMoin/items/ (__init__.py _tests/test_Item.py): change mimetype x-unknown to x-nonexistent (we use it for non-existing items)
77 2010-08-01T12:45:08 <ThomasWaldmann> well, maybe merging before has less conflicts, not sure
78 2010-08-01T12:45:28 * ThomasWaldmann moved around quite some stuff
79 2010-08-01T12:45:43 <valeuf> ok I see for application/x-xhtml-moin-page, I need to see where it is used and how
80 2010-08-01T12:45:58 <valeuf> you are really active these last days ThomasWaldmann ^ ^
81 2010-08-01T13:00:41 <ThomasWaldmann> hmm, i guess i need to shuffle more stuff in items
82 2010-08-01T13:01:39 <ThomasWaldmann> currently the show handler displays the menu for type selection for nonexistent items
83 2010-08-01T13:02:44 <ThomasWaldmann> but to be consistent with converter approach, show should just convert the item to a rendering
84 2010-08-01T13:03:19 <ThomasWaldmann> and the rendering of a non-existing item should be a link to create it (not a menu)
85 2010-08-01T13:04:24 <ThomasWaldmann> one of the not-yet solved problems in converters are the different kinds of item links
86 2010-08-01T13:04:32 <ThomasWaldmann> (show, get, modify)
87 2010-08-01T14:23:45 *** ronny
88 2010-08-01T14:30:20 * ThomasWaldmann .oO(only one do_show left)
89 2010-08-01T14:39:40 <ThomasWaldmann> valeuf: waldi: http://paste.pocoo.org/show/244081/
90 2010-08-01T14:39:48 <ThomasWaldmann> is there something wrong there?
91 2010-08-01T14:40:08 <ThomasWaldmann> in the html output, i get a <a> with no href attr
92 2010-08-01T14:41:33 <waldi> ThomasWaldmann: the uri is wrong, it needs to be wiki:///name
93 2010-08-01T14:42:18 <ThomasWaldmann> i thought wiki.local is for local wiki items
94 2010-08-01T14:43:17 <waldi> no, this is for wiki-style relative links, however the item name is an uri-style one
95 2010-08-01T14:45:01 <ThomasWaldmann> ah!
96 2010-08-01T14:46:32 <ThomasWaldmann> <a xmlns="http://www.w3.org/1999/xhtml">LanguageSetupuuu does not exist. Create it?</a>
97 2010-08-01T14:46:43 <ThomasWaldmann> this is with scheme='wiki'
98 2010-08-01T14:49:46 <waldi> puh, no idea
99 2010-08-01T14:50:57 <ThomasWaldmann> the only place i see 'wiki' being used is for interwiki links
100 2010-08-01T14:55:51 <waldi> where? it check the authority part then
101 2010-08-01T14:56:58 <ThomasWaldmann> in some moinwiki input converter
102 2010-08-01T15:13:42 *** valeuf
103 2010-08-01T15:14:12 *** valeuf
104 2010-08-01T15:17:55 <ThomasWaldmann> strange, in some other part (image_in converter) where it already worked yesterday, it also stopped having target urls in the output :|
105 2010-08-01T15:22:44 <ThomasWaldmann> waldi: while I search that bug, any ideas about url generation? currently it resolves to show url, we need get and modify also.
106 2010-08-01T15:37:59 <ThomasWaldmann> valeuf: it currently looks like the smiley converter in main repo kills href attrs
107 2010-08-01T15:43:10 <waldi> ThomasWaldmann: i never committed them ...
108 2010-08-01T15:43:59 <ThomasWaldmann> you never committed what?
109 2010-08-01T15:59:36 <valeuf> ThomasWaldmann: definitely smiley converter was not good ^^ I am sorry about it
110 2010-08-01T15:59:41 <valeuf> I will see to fix it
111 2010-08-01T16:03:54 <ThomasWaldmann> i told you, do not mistreat children :D
112 2010-08-01T16:04:13 <ThomasWaldmann> but it's great to finally have one :)
113 2010-08-01T16:04:49 <valeuf> ThomasWaldmann: they can call SOS mistreat Children if they are not happy
114 2010-08-01T16:07:16 *** RogerHaase
115 2010-08-01T16:20:14 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9218:3180d569b74f 2.0-dev-docbook-html-vjaniaut/MoinMoin/ (46 files in 10 dirs): Merged moin/2.0-dev
116 2010-08-01T16:20:17 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9219:f68dbee38855 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/smiley.py: Add more comments to explain the code in the smiley converter
117 2010-08-01T16:20:18 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9220:a00a9bd16982 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_out.py: Fix bug with section creation for DocBook_OUT converter
118 2010-08-01T16:20:20 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9221:78890f7ae68a 2.0-dev-docbook-html-vjaniaut/MoinMoin/items/__init__.py: Move _convert method at the right place for items/__init__.py
119 2010-08-01T16:35:03 <ThomasWaldmann> diofeher: you are working on what currently?
120 2010-08-01T16:39:56 *** valeuf
121 2010-08-01T16:47:33 <ThomasWaldmann> dreimark: diofeher: ei-grad: eSyr: TheSheep: waldi: xorAxAx: meeting at 17:00 UTC (that is in about 2h 12mins)
122 2010-08-01T16:48:26 <ThomasWaldmann> dreimark: eSyr: contact your students please and tell them to show up
123 2010-08-01T17:08:51 *** kursor
124 2010-08-01T17:13:51 *** valeuf
125 2010-08-01T17:15:34 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9232:1673074e0423 2.0-dev/MoinMoin/ (8 files in 4 dirs): (log message trimmed)
126 2010-08-01T17:15:34 <CIA-50> items: cleanup showing vs. creation of items
127 2010-08-01T17:15:34 <CIA-50> Before this changeset, "show" was also responsible for rendering the type
128 2010-08-01T17:15:34 <CIA-50> selection menu for non-existing items (so one can choose the type if one wants
129 2010-08-01T17:15:34 <CIA-50> to create it) - this was moved to "modify".
130 2010-08-01T17:15:35 <CIA-50> "show" is much simpler now: it always renders the item.
131 2010-08-01T17:15:36 <CIA-50> If the item does not exist, we have a dummy item of "application/x-nonexistent"
132 2010-08-01T17:16:22 <eSyr> ThomasWaldmann: done.
133 2010-08-01T17:16:38 <valeuf> wow big storm, and no electricity for a couple of time!
134 2010-08-01T17:29:34 <ThomasWaldmann> laptops rule :D
135 2010-08-01T17:30:11 <ThomasWaldmann> valeuf: big changeset in main
136 2010-08-01T17:32:48 <ThomasWaldmann> valeuf: you didn't find the smiley problem yet, right?
137 2010-08-01T17:38:43 <valeuf> ThomasWaldmann: no my working directory did not like the sudden cut off due to the storm ^ ^
138 2010-08-01T17:38:53 <valeuf> ThomasWaldmann: I cloning from a fresh repo
139 2010-08-01T17:39:06 <valeuf> ThomasWaldmann: I was going to merge my repos with the main one, should I wait?
140 2010-08-01T17:39:17 <ThomasWaldmann> no, should be fine
141 2010-08-01T17:39:20 <ThomasWaldmann> return self.do_children(child)
142 2010-08-01T17:39:30 <ThomasWaldmann> that line is likely the cause of most trouble
143 2010-08-01T17:39:37 <valeuf> ThomasWaldmann: hm interesting :)
144 2010-08-01T17:39:47 <valeuf> ThomasWaldmann: I was looking for other problem before
145 2010-08-01T17:44:00 <valeuf> I have hard time to follow all your changes ThomasWaldmann ^ ^
146 2010-08-01T17:44:16 <valeuf> my items/__init__.py is completely messed up
147 2010-08-01T17:49:37 <valeuf> ThomasWaldmann: you disabled the smiley in the main branch?
148 2010-08-01T17:51:03 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9238:fc0e40ea75d6 2.0-dev-docbook-html-vjaniaut/ (50 files in 13 dirs): Merged with moin/dev-2.0
149 2010-08-01T17:51:06 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9233:c40edc77ab93 2.0-dev/MoinMoin/items/__init__.py: items: add some converter-related TODO
150 2010-08-01T17:51:31 <ThomasWaldmann> valeuf: yes, added a # in front
151 2010-08-01T17:51:46 <valeuf> ok :)
152 2010-08-01T17:52:03 <valeuf> so you said there was a problem with href attributes, right?
153 2010-08-01T17:52:05 <ThomasWaldmann> sorry for moving around such a lot, but it had to be done :)
154 2010-08-01T17:52:15 <ThomasWaldmann> yes, it kills them
155 2010-08-01T17:52:46 <valeuf> ThomasWaldmann: no problem, I will try to follow ^ ^ I will try to be helpful instead of always adding bug with my stuff ^ ^
156 2010-08-01T17:53:02 <ThomasWaldmann> the problem is that "return" jumps out of the loop, no matter what childs you had before or would have afterwards
157 2010-08-01T17:53:34 <valeuf> I assumed that if it was not an ET.Element it was naturally a text node
158 2010-08-01T17:53:45 <ThomasWaldmann> also, even with "return", you would also have to add that ET child to the new childs list or it'll be gone if your clear all childs
159 2010-08-01T17:53:46 <valeuf> but I am probably wrong
160 2010-08-01T17:54:00 <ThomasWaldmann> without*
161 2010-08-01T17:54:56 <ThomasWaldmann> yes, it is either ET or text, but that is not the problem
162 2010-08-01T17:55:28 <valeuf> ok I get confused with something, I will try to understand the mess
163 2010-08-01T17:55:28 <ThomasWaldmann> the problem is that if you discover an ET child, you forget about all others
164 2010-08-01T17:56:26 <ThomasWaldmann> (sounds a bit like from spielberg)
165 2010-08-01T18:02:27 <diofeher> moin!
166 2010-08-01T18:02:33 <valeuf> ThomasWaldmann: hey, I have funny recursion, with picture
167 2010-08-01T18:02:55 <valeuf> ThomasWaldmann: instead of the picture, there is a "frame" with the same moin page :)
168 2010-08-01T18:03:08 <valeuf> ThomasWaldmann: I do not get any bug with href and the smiley otherwise
169 2010-08-01T18:03:47 <ThomasWaldmann> known, see todo in image_in
170 2010-08-01T18:03:52 <ThomasWaldmann> hi diofeher
171 2010-08-01T18:04:18 <ThomasWaldmann> valeuf: if you edit the html and add the /+get it works :)
172 2010-08-01T18:04:20 <diofeher> sorry for not appeared yesterday, my stabilizer (from modem/router) burned :/
173 2010-08-01T18:04:26 <valeuf> ThomasWaldmann: ad ok
174 2010-08-01T18:04:40 <diofeher> i've borrowed one today ^^
175 2010-08-01T18:04:49 <ThomasWaldmann> diofeher: you mean the power supply?
176 2010-08-01T18:05:23 <diofeher> yes... didn't know the name in english.. we call "estabilizador" here
177 2010-08-01T18:05:24 <ThomasWaldmann> or a UPS?
178 2010-08-01T18:06:11 <diofeher> http://www.info-shop.net/loja/images/estabilizador.jpg
179 2010-08-01T18:06:58 <ThomasWaldmann> are there heavy batteries inside?
180 2010-08-01T18:07:41 <diofeher> they are used to work with different tensions
181 2010-08-01T18:07:55 <ThomasWaldmann> (then it is called UPS, uninteruptible power supply)
182 2010-08-01T18:07:59 <diofeher> modem/router are 110V and energy is 220V
183 2010-08-01T18:08:03 <diofeher> ah no no
184 2010-08-01T18:08:13 <diofeher> it's not UPS, i think i wil buy one
185 2010-08-01T18:08:23 <ThomasWaldmann> ah, a transformer / voltage converter
186 2010-08-01T18:08:48 <diofeher> yes ^^
187 2010-08-01T18:08:56 <diofeher> transformer, the right name haha
188 2010-08-01T18:09:26 <ThomasWaldmann> btw, that stuff is sometimes not very energy efficient
189 2010-08-01T18:09:32 <diofeher> about moin css classes... did you mean classes part of layout?
190 2010-08-01T18:09:39 <valeuf> ThomasWaldmann: the link to create a new item is broken too
191 2010-08-01T18:09:49 <ThomasWaldmann> valeuf: same reason :)
192 2010-08-01T18:09:49 <diofeher> yes :( UPS is nice
193 2010-08-01T18:10:41 <ThomasWaldmann> that's why I wanted to get some ideas for url generation from waldi :)
194 2010-08-01T18:10:48 <valeuf> ThomasWaldmann: ok if I understand well I should always use +get, +modify from now?
195 2010-08-01T18:11:12 <ThomasWaldmann> nothing = render the thing within the theme
196 2010-08-01T18:11:25 <ThomasWaldmann> +get = get raw revision data
197 2010-08-01T18:11:39 <ThomasWaldmann> +modify = modify / create it
198 2010-08-01T18:12:14 <ThomasWaldmann> (was ?do=... before)
199 2010-08-01T18:12:47 <ThomasWaldmann> diofeher: i don't understand what exactly you want to know
200 2010-08-01T18:12:50 <valeuf> ok
201 2010-08-01T18:13:26 <valeuf> \o/ I have been able to reproduce your bug with href and smiley
202 2010-08-01T18:14:11 <diofeher> ThomasWaldmann, what css classes/id were you talking about... to rename to moin-*
203 2010-08-01T18:14:31 <ThomasWaldmann> the stuff from the theme / framework
204 2010-08-01T18:15:07 <ThomasWaldmann> (because it otherwise can easily collide with ids/classes from content or extensions)
205 2010-08-01T18:15:29 <diofeher> hmm understood! it was my doubt if content was in this too... but this answered me
206 2010-08-01T18:16:21 <valeuf> ThomasWaldmann: wow, the console output is full
207 2010-08-01T18:16:21 <ThomasWaldmann> (we create IDs for content headlines, try some headline = comment =)
208 2010-08-01T18:16:43 <ThomasWaldmann> it could looks strange because we have css for id comment
209 2010-08-01T18:16:56 <ThomasWaldmann> (not sure if it was comment, but you get the idea)
210 2010-08-01T18:17:18 <diofeher> hehe get it
211 2010-08-01T18:18:57 <ThomasWaldmann> diofeher: you likely should also merge
212 2010-08-01T18:20:12 <ThomasWaldmann> <ns0:object ns0:data="http://localhost:8080/png" xmlns:ns0="http://www.w3.org/1999/xhtml" />
213 2010-08-01T18:20:30 <ThomasWaldmann> this is what comes out for doc.write(..., method="xml")
214 2010-08-01T18:21:33 <valeuf> ThomasWaldmann: you should specify the namespace if you want to get rid of the ns0
215 2010-08-01T18:26:16 <valeuf> ThomasWaldmann: do you know some way to turn off some debug message, it is impossible to find my debug message in the mass of messages :p
216 2010-08-01T18:27:08 <ThomasWaldmann> that needs improvement, right
217 2010-08-01T18:27:20 <ThomasWaldmann> somehow flask and moin are logging right now
218 2010-08-01T18:29:23 <ThomasWaldmann> moin's logging is configurable, flask's is just debug or not
219 2010-08-01T18:30:54 <valeuf> Well, where can I turn off flask logging (I won't commit it, just to help me working at this time)
220 2010-08-01T18:31:48 <ThomasWaldmann> wikiserver.py, maybe
221 2010-08-01T18:32:03 <ThomasWaldmann> but you also lose reloading then and the builtin debugger
222 2010-08-01T18:32:17 <valeuf> /o\
223 2010-08-01T18:34:36 <valeuf> EmeraldTree was the problem for the smiley, clear() method was supposed to clear only the chidl, but it clears also the attrib
224 2010-08-01T18:34:36 <ThomasWaldmann> waldi: anything speaking against switching to xml output? http://paste.pocoo.org/show/244194/
225 2010-08-01T18:35:36 <waldi> no
226 2010-08-01T18:35:46 <ThomasWaldmann> valeuf: but what happens if children = [text, ET, text] ?
227 2010-08-01T18:35:54 <valeuf> ThomasWaldmann: fixed
228 2010-08-01T18:36:04 <valeuf> (there was not only one problem ^ ^ )
229 2010-08-01T18:37:20 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9234:ff27f7c0a643 2.0-dev/MoinMoin/items/__init__.py: switch converter output to xml
230 2010-08-01T18:37:29 <diofeher> http://paste.pocoo.org/show/244196/
231 2010-08-01T18:39:34 <ThomasWaldmann> ok, what about the code (py/js) and css?
232 2010-08-01T18:40:10 <valeuf> ThomasWaldmann: or wald : could you apply this patch to emeraldtree repo? http://paste.pocoo.org/show/244199/
233 2010-08-01T18:40:24 <ThomasWaldmann> btw, this is maybe first time moin had sane xml output \o/
234 2010-08-01T18:40:35 <valeuf> (and then push it to the support module in the main moin2.0 repo)
235 2010-08-01T18:40:44 <diofeher> ah gonna change yet.. just want to know if they are the right classes/ids ^^
236 2010-08-01T18:41:38 <ThomasWaldmann> valeuf: "an"
237 2010-08-01T18:43:10 <valeuf> ThomasWaldmann: sorry http://paste.pocoo.org/show/244201/
238 2010-08-01T18:46:03 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8551:8def2a820853 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/mediawiki_in.py: Mediawiki->DOM based on mwlib: convertion of basic nodes
239 2010-08-01T18:46:07 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8552:4f4b8757416b 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/mediawiki_in.py:
240 2010-08-01T18:46:07 <CIA-50> remove Mediawiki->DOM based on mwlib: mwlib internal tree doesn't correspond
241 2010-08-01T18:46:07 <CIA-50> it's own specification
242 2010-08-01T18:46:09 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8553:8ed9d1bf845a 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/mediawiki_in.py: Mediawiki->DOM based on regexp parsing, like Moinwiki->DOM converter
243 2010-08-01T18:46:10 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8554:4cd7aad9f9c8 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/_tests/test_mediawiki_in.py: Mediawiki->DOM: tests
244 2010-08-01T18:46:12 <CIA-50> Dmitry Andreev <klieg.polar@gmail.com> default * 8555:5c5abd171da1 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/_tests/test_rst_out.py: DOM->ReStructuredText: more tests
245 2010-08-01T18:46:36 <ThomasWaldmann> \o/
246 2010-08-01T18:46:36 <valeuf> oh Dmitry!
247 2010-08-01T18:56:40 *** DmitryAndreev
248 2010-08-01T19:01:17 <ThomasWaldmann> ok, welcome to today's meeting
249 2010-08-01T19:01:34 <eSyr> hi
250 2010-08-01T19:01:44 <DmitryAndreev> .
251 2010-08-01T19:01:58 <ThomasWaldmann> please note that SOC pencils down date is in 8 days, so this is one of the last ones.
252 2010-08-01T19:02:25 <ThomasWaldmann> DmitryAndreev: if you are ready, please begin.
253 2010-08-01T19:02:35 <valeuf> o/
254 2010-08-01T19:02:38 <diofeher> o/
255 2010-08-01T19:02:46 <ThomasWaldmann> (everybody please give some life signs)
256 2010-08-01T19:02:57 <TheSheep> o/
257 2010-08-01T19:03:00 * diofeher alive
258 2010-08-01T19:03:33 <ThomasWaldmann> xorAxAx: ?
259 2010-08-01T19:03:42 <xorAxAx> yes? :)
260 2010-08-01T19:03:46 <ThomasWaldmann> dreimark: ?
261 2010-08-01T19:03:58 <ThomasWaldmann> ei-grad: ?
262 2010-08-01T19:04:24 <DmitryAndreev> i have a hard two weeks f*king with year sciens report, but this in not about moin) two weeks ago i've started to write mediawiki->dom converter. i tried to use mwlib
263 2010-08-01T19:05:13 <dreimark> re
264 2010-08-01T19:06:22 <ThomasWaldmann> DmitryAndreev: and, did it work?
265 2010-08-01T19:06:24 <DmitryAndreev> but when i've tested it, i've found, that it's outputed tree doesn't correspond it's specification, i've droped it and wrote basic implementation if mediawiki->dom converter based on regexp parsing, like moinwiki->dom
266 2010-08-01T19:07:13 <ThomasWaldmann> btw, it would be quite nice if you don't just disappear without any word.
267 2010-08-01T19:07:24 <DmitryAndreev> know works basic syntax(mostly equal in moinwiki and mediawiki) and lists, tables
268 2010-08-01T19:07:53 <DmitryAndreev> vary slow typing in english language
269 2010-08-01T19:08:20 <dreimark> DmitryAndreev: python is also english
270 2010-08-01T19:08:20 <DmitryAndreev> very*
271 2010-08-01T19:08:37 <dreimark> DmitryAndreev: we will understand its syntax
272 2010-08-01T19:08:43 <dreimark> try: want to work
273 2010-08-01T19:08:45 <DmitryAndreev> dreimark, i mean in native english.)
274 2010-08-01T19:08:54 <dreimark> raise "problems because...
275 2010-08-01T19:09:56 <dreimark> DmitryAndreev: i learned on irc too
276 2010-08-01T19:10:03 <dreimark> +it
277 2010-08-01T19:10:40 <ThomasWaldmann> what's the state of the ReST stuff?
278 2010-08-01T19:11:05 <DmitryAndreev> so, i need to done with link|object conversion, and attributs in table, and some inline syntax like <tt>
279 2010-08-01T19:11:18 <ThomasWaldmann> eSyr: feel free to ask questions also :)
280 2010-08-01T19:11:44 <dreimark> DmitryAndreev: are there tests done?
281 2010-08-01T19:11:48 <ThomasWaldmann> DmitryAndreev: tt is gone due to html5
282 2010-08-01T19:12:33 <ThomasWaldmann> DmitryAndreev: ah, and if you didn't merge recently, be prepared for a lot of changes
283 2010-08-01T19:12:44 <DmitryAndreev> ThomasWaldmann, ReST is good, maybe i missed some specific syntax like styles, but i've not found some tests for it
284 2010-08-01T19:13:13 <ThomasWaldmann> is the fsm vs. stack thing resolved?
285 2010-08-01T19:13:29 <eSyr> DmitryAndreev: have you base on some formal grammar describing mw syntax?
286 2010-08-01T19:13:33 <dreimark> DmitryAndreev: eSyr do you have seen the ReST feature on the mailinglist
287 2010-08-01T19:13:56 <DmitryAndreev> but, i still have to choose between recursive and nonrecursive implementation. both works
288 2010-08-01T19:13:57 <eSyr> dreimark: doubt so.
289 2010-08-01T19:15:02 <eSyr> DmitryAndreev: if both work and pass all tests then version which is most maintainable should be chosen.
290 2010-08-01T19:15:31 <ThomasWaldmann> DmitryAndreev: ok, then discuss this asap, I want to merge back the rest stuff as soon as it is decided
291 2010-08-01T19:15:39 <dreimark> eSyr: DmitryAndreev http://gist.github.com/49758
292 2010-08-01T19:15:53 <DmitryAndreev> dreimark, if you talking about parsers in rst, i've add it in converter.
293 2010-08-01T19:15:57 <dreimark> this is a extension for rest syntax from a user discussed on the ml
294 2010-08-01T19:16:13 <dreimark> DmitryAndreev: ok, may be have a look at it. if there are differences
295 2010-08-01T19:16:28 <ThomasWaldmann> DmitryAndreev: are you finished with science/university duties now and free in the final 2 weeks?
296 2010-08-01T19:16:29 <dreimark> in matter of implementation
297 2010-08-01T19:16:33 <eSyr> dreimark: Gist has been deleted
298 2010-08-01T19:16:44 <eSyr> *"Gist has been deleted"
299 2010-08-01T19:17:09 <dreimark> arg
300 2010-08-01T19:17:25 <ThomasWaldmann> (about 1 week left for heavy work until pencils down, maybe few days more while stuff is getting evaluated)
301 2010-08-01T19:17:51 <DmitryAndreev> ThomasWaldmann, i need only few things in university, thats not take much time
302 2010-08-01T19:18:10 <diofeher> yes, this week is for very very heavy work :S
303 2010-08-01T19:18:38 <dreimark> DmitryAndreev: how much of your current code is covered by tests
304 2010-08-01T19:18:58 <ThomasWaldmann> DmitryAndreev: ok, just make sure you set priorities right, from SOC perspective, you have lost lots of time
305 2010-08-01T19:20:03 <ThomasWaldmann> ok, DmitryAndreev: next week, blockers?
306 2010-08-01T19:20:22 <DmitryAndreev> dreimark, ~85-90% (some code with exeptions are not testet) of moinwiki_out and rst_*. no full tests for mediawiki->dom
307 2010-08-01T19:20:49 <ThomasWaldmann> btw, tests in main are rather broken :|
308 2010-08-01T19:21:08 <ThomasWaldmann> so if you heavily rely on tests, be careful
309 2010-08-01T19:21:13 <valeuf> ThomasWaldmann: I found the way to test with flask just now ^ ^ so it can be fix soon
310 2010-08-01T19:21:23 <ThomasWaldmann> valeuf: great :)
311 2010-08-01T19:21:31 <dreimark> valeuf: :)
312 2010-08-01T19:22:04 <DmitryAndreev> next week -> done with mediawiki: links, objects, atrributs in tables and somethings i've missed
313 2010-08-01T19:22:23 <ThomasWaldmann> valeuf: you're next after dmitry has finished
314 2010-08-01T19:22:32 <valeuf> ok
315 2010-08-01T19:23:12 <DmitryAndreev> and i still did'n create xpath tests
316 2010-08-01T19:23:49 *** diofeher
317 2010-08-01T19:23:54 *** diofeher
318 2010-08-01T19:24:01 <ThomasWaldmann> blockers?
319 2010-08-01T19:24:02 <DmitryAndreev> done
320 2010-08-01T19:24:03 <DmitryAndreev> no
321 2010-08-01T19:24:08 <DmitryAndreev> not now
322 2010-08-01T19:24:16 <ThomasWaldmann> ok, thanks, valeuf please :)
323 2010-08-01T19:24:20 <valeuf> ok
324 2010-08-01T19:24:34 <valeuf> Added smiley converter (Many bugs found after the first commit, but it should be almost done now)
325 2010-08-01T19:24:37 <valeuf> Refactored _convert action to use DocBook_out converter (not completely clean since a lot of things are moving with flask)
326 2010-08-01T19:24:41 <valeuf> DocBook_OUT converter done. Need test with image and other media object, but it needs some work in items module to be completely done.
327 2010-08-01T19:24:42 <ThomasWaldmann> ei-grad: it would be nice if more than your IRC client would be here.
328 2010-08-01T19:24:44 <valeuf> Added some elements to DocBook_IN converter, but still a lot to support!
329 2010-08-01T19:24:54 <valeuf> (to support the full specification of DocBook document I mean)
330 2010-08-01T19:25:22 <valeuf> but the most usual stuff are correctly handle in the converter (table, section, list ...)
331 2010-08-01T19:25:46 <valeuf> plan for the next week
332 2010-08-01T19:26:06 <valeuf> fix the smiley converter
333 2010-08-01T19:26:42 <valeuf> finish the convert action correctly, so we can see the result of the different OUT converter
334 2010-08-01T19:27:21 <valeuf> finalize the DocBook_OUT converter (eg: add more tests, fix the last issues I can find ...)
335 2010-08-01T19:27:40 <valeuf> and add more docbook element supported in DocBook_in converter
336 2010-08-01T19:27:48 <xorAxAx> ThomasWaldmann: s/would/was/
337 2010-08-01T19:28:15 <xorAxAx> valeuf: do you think that you are ontime?
338 2010-08-01T19:29:12 <valeuf> xorAxAx: compare to my initial schedule, definitely not, since I won't have time to work on XSL-FO converter
339 2010-08-01T19:29:42 <valeuf> however I worked on different unexpected task, and I also underestimate the complexity of the DocBook specification
340 2010-08-01T19:29:52 <xorAxAx> yeah
341 2010-08-01T19:30:14 <ThomasWaldmann> (it has to be noted that he worked on quite some stuff that are not strictly in-scope with his project, but were needed urgently)
342 2010-08-01T19:30:34 <valeuf> I think that what I have done was more important than the XSL-FO converter
343 2010-08-01T19:30:48 <xorAxAx> yeah, me too
344 2010-08-01T19:31:24 <valeuf> however, I think that XSL-FO converter would be really nice to output nice PDF document, so I think I will work about it after the SoC
345 2010-08-01T19:31:24 <ThomasWaldmann> blockers?
346 2010-08-01T19:31:48 <valeuf> ThomasWaldmann: except children who complain to be mistreaten, I am quite ok
347 2010-08-01T19:32:01 <ThomasWaldmann> ok :)
348 2010-08-01T19:32:14 <diofeher> me now?
349 2010-08-01T19:32:19 <ThomasWaldmann> any more for valeuf?
350 2010-08-01T19:32:23 <dreimark> diofeher: wait
351 2010-08-01T19:33:45 <ThomasWaldmann> ok, i take that as a no. diofeher, you're next.
352 2010-08-01T19:33:53 <ThomasWaldmann> thanks valeuf
353 2010-08-01T19:33:56 <diofeher> ok
354 2010-08-01T19:35:12 <diofeher> well, first i want to explain why i was not in the last meeting... i'm attending an open source conference far from my city here in brazil...at the meeting time, me and my friends were in the airport without free internet connection :/
355 2010-08-01T19:35:48 * ThomasWaldmann too :)
356 2010-08-01T19:36:03 * dreimark too
357 2010-08-01T19:36:15 <diofeher> hehe
358 2010-08-01T19:36:43 <diofeher> this explained
359 2010-08-01T19:36:56 <diofeher> what i did this week:
360 2010-08-01T19:36:56 <diofeher> * moved atom_feed action to flask view
361 2010-08-01T19:36:57 <diofeher> * reviewed page/item and url_for/href usage in theme/templates
362 2010-08-01T19:36:57 <diofeher> * refactored templates to use whitespace control
363 2010-08-01T19:36:57 <diofeher> * replaced left usage of ThemeBase.add_msg() + ThemeBase.msg_list to flash messages of Flask
364 2010-08-01T19:36:57 <diofeher> plans to this week:
365 2010-08-01T19:36:59 <diofeher> * cleanup css
366 2010-08-01T19:37:01 <diofeher> * rename internal classes of moinmoin layout
367 2010-08-01T19:37:03 <diofeher> * start to convert some moin js code to use jquery
368 2010-08-01T19:38:23 <ThomasWaldmann> does the "cleanup css" mean all on your highlevel todo list?
369 2010-08-01T19:38:45 <diofeher> hm, mean css not used :S
370 2010-08-01T19:38:59 <diofeher> sorry for misleaded phrase
371 2010-08-01T19:40:01 <ThomasWaldmann> http://moinmo.in/DiogenesAugusto/GSoC2010/TODO there is quite some more stuff there
372 2010-08-01T19:40:56 <ThomasWaldmann> TheSheep: you wanted to review that and set some deadlines
373 2010-08-01T19:41:00 <dreimark> do you have minmize implemented too ?
374 2010-08-01T19:41:16 <dreimark> minimize
375 2010-08-01T19:41:37 <TheSheep> ThomasWaldmann: yes, I will do it this evening, I had an unexpected travel yesterday
376 2010-08-01T19:41:53 <TheSheep> dreimark: minify?
377 2010-08-01T19:42:16 <dreimark> compact output of html
378 2010-08-01T19:42:18 <dreimark> yes
379 2010-08-01T19:42:27 <ThomasWaldmann> esp. the extensions stuff would be important
380 2010-08-01T19:43:20 <diofeher> dreimark, not implemented, but i started to search about... it would be nice if we have this in moin
381 2010-08-01T19:43:34 <ThomasWaldmann> imho, minimize stuff is not important now
382 2010-08-01T19:43:42 <ThomasWaldmann> premature optimization
383 2010-08-01T19:43:45 <dreimark> agreed
384 2010-08-01T19:43:51 <ThomasWaldmann> the stuff has to be in sane state first
385 2010-08-01T19:43:55 <diofeher> maybe after SoC? :)
386 2010-08-01T19:44:17 <diofeher> (minimize)
387 2010-08-01T19:44:26 <ThomasWaldmann> stuff like how moin's css should be structured
388 2010-08-01T19:44:43 <ThomasWaldmann> how it is made extensible, sub-themable
389 2010-08-01T19:44:48 <diofeher> what do you mean with extension stuff?
390 2010-08-01T19:44:50 <ThomasWaldmann> same for js
391 2010-08-01T19:45:12 <ThomasWaldmann> often some moin extension wants to have a bit of css or js
392 2010-08-01T19:45:24 <ThomasWaldmann> that must be easily possible and at the right place
393 2010-08-01T19:45:45 <diofeher> ah... this is related to plugin system (man, i really behind my schedule :S)
394 2010-08-01T19:46:05 <ThomasWaldmann> also, if someone wants other fonts or colours, he shouldn't need to write a new theme
395 2010-08-01T19:46:19 <ThomasWaldmann> and how new themes should work is also still unclear
396 2010-08-01T19:47:14 <ThomasWaldmann> so expect your "next week" todo from above to be rather your monday todo :)
397 2010-08-01T19:47:31 <diofeher> ok ^^
398 2010-08-01T19:47:55 <ThomasWaldmann> also keep your todo cleaned up and your diary uptodate
399 2010-08-01T19:48:18 <ThomasWaldmann> blockers?
400 2010-08-01T19:48:23 <ThomasWaldmann> questions?
401 2010-08-01T19:48:50 <ThomasWaldmann> ei-grad: last chance to give a life sign for this meeting
402 2010-08-01T19:49:16 <diofeher> one: "admin configurable" what exactly mean?
403 2010-08-01T19:49:30 <ThomasWaldmann> that means in the wiki config
404 2010-08-01T19:49:41 <ThomasWaldmann> user configurable is in user profile
405 2010-08-01T19:50:14 <dreimark> in wikiconfig on fs system level
406 2010-08-01T19:50:30 <diofeher> ah ok ^^
407 2010-08-01T19:50:55 <ThomasWaldmann> TheSheep: any more questions from you? anybody else?
408 2010-08-01T19:52:22 <TheSheep> ThomasWaldmann: no, we will resolve pproblems as they arise
409 2010-08-01T19:52:58 <ThomasWaldmann> ok, then thanks to everybody who was here. meeting officially over. have a successful next week.
410 2010-08-01T19:53:05 <TheSheep> diofeher: I will try to be available more this week, so don't hesitate to ask anything
411 2010-08-01T19:53:31 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9239:777d84cee295 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/smiley.py: Fix bug in smiley_converter with element with mixed children
412 2010-08-01T19:53:36 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9240:4a16ca7e7b7e 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_smiley.py: Fix smiley tests to be used with flask, however use hard-coded url for the test which is not good
413 2010-08-01T19:53:37 <diofeher> ok TheSheep ^^
414 2010-08-01T19:53:51 <ThomasWaldmann> for the theming i think esp. the infrastructure kind of stuff should be addressed and discussed first.
415 2010-08-01T19:54:08 <valeuf> waldi: can you apply my patchs for the EmeraldTree?
416 2010-08-01T19:54:34 <diofeher> btw, how is going session stuff with flask?
417 2010-08-01T19:57:13 <ThomasWaldmann> i had a short try, but didn't work
418 2010-08-01T19:57:36 <ThomasWaldmann> all this request object related stuff will be still quite some refactoring work
419 2010-08-01T19:59:01 <diofeher> hm :/
420 2010-08-01T19:59:12 * ThomasWaldmann reviews ET patch
421 2010-08-01T20:02:11 <valeuf> ThomasWaldmann: http://paste.pocoo.org/show/244201/ and http://paste.pocoo.org/show/242986/ ^ ^
422 2010-08-01T20:02:36 <valeuf> ThomasWaldmann: the second one is not a big emergency, but the first one will allow me to fix the latest bug in the smiley converter
423 2010-08-01T20:05:50 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 79:922bd718352b EmeraldTree/emeraldtree/tree.py: added remove_all method to remove all subelements without clearing attr (like clear method does)
424 2010-08-01T20:06:08 <valeuf> \o/
425 2010-08-01T20:06:16 <ThomasWaldmann> (i renamed it as there already is a remove method)
426 2010-08-01T20:06:23 <valeuf> ThomasWaldmann: no problem
427 2010-08-01T20:09:35 <ThomasWaldmann> about the other patch: what is encoding if not given like that?
428 2010-08-01T20:11:16 <valeuf> ThomasWaldmann: you mean enc keyword parameter?
429 2010-08-01T20:11:23 <ThomasWaldmann> yes
430 2010-08-01T20:11:55 <valeuf> ThomasWaldmann: well, for instance if someone want to use emerald-tree with another encoding (ko-8, latin9 ...)
431 2010-08-01T20:12:03 <ThomasWaldmann> and it looks like the code you modified was expecting str
432 2010-08-01T20:12:26 <ThomasWaldmann> now it only works when giving unicode, because str doesn't have .encode()
433 2010-08-01T20:12:33 <valeuf> ThomasWaldmann: yes
434 2010-08-01T20:13:03 <valeuf> ThomasWaldmann: normally we do not have str, only bytestring
435 2010-08-01T20:13:19 <ThomasWaldmann> str is bytestring (in py2)
436 2010-08-01T20:15:12 <dreimark> bbl
437 2010-08-01T20:16:39 <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9234:d853a473d6b9 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (10 files in 3 dirs): [templating] renamed internal classes/ids of moin theme giving them "moin-" prefix
438 2010-08-01T20:16:53 <ThomasWaldmann> valeuf: and in the docs you still tell "string", which rather sounds like str than unicode
439 2010-08-01T20:17:48 <diofeher> is there any flash message that can be tested in this new code? to work with its css :)
440 2010-08-01T20:18:20 <diofeher> found one: logout ^^ (these flash messages are so awesome)
441 2010-08-01T20:18:38 <valeuf> ThomasWaldmann: well, actually we are giving already encoded string to the converter (using encode method)
442 2010-08-01T20:18:58 <valeuf> ThomasWaldmann: waldi thought it would be better to encode the string directly in ET
443 2010-08-01T20:19:43 <ThomasWaldmann> well, maybe he should review and apply this.
444 2010-08-01T20:20:06 <ThomasWaldmann> in principle I am also rather for unicode, but api and docs have to be consistent
445 2010-08-01T20:20:15 <valeuf> our string are always unicode, and I guess the idea was to ensure we have unicode string
446 2010-08-01T20:20:27 <valeuf> ThomasWaldmann: ok it is not emergency,
447 2010-08-01T20:21:04 <valeuf> ThomasWaldmann: can you just pull ET to the support module in the moin/2.0-dev when you have time?
448 2010-08-01T20:24:07 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9235:9ec5af58beb8 2.0-dev/MoinMoin/support/emeraldtree/tree.py: upgrade emeraldtree to rev 922bd718352b
449 2010-08-01T20:24:55 <valeuf> \o/ thanks a lot
450 2010-08-01T20:26:31 <ThomasWaldmann> just tell when the smiley stuff works and I'll merge your stuff into main again
451 2010-08-01T20:27:33 <valeuf> ThomasWaldmann: done ^ ^
452 2010-08-01T20:27:35 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9244:a934574debc9 2.0-dev-docbook-html-vjaniaut/MoinMoin/items/__init__.py: Enable again smiley conversion
453 2010-08-01T20:27:37 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9245:f6ab0c7f236f 2.0-dev-docbook-html-vjaniaut/MoinMoin/ (items/__init__.py support/emeraldtree/tree.py): Merged against moin/dev-2.0
454 2010-08-01T20:28:12 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9246:389f5d68f01a 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/smiley.py: Fix bug with attribute deleted with the smiley converter
455 2010-08-01T20:28:54 <ThomasWaldmann> 1.8 + doc = smiley_conv(doc) # XXX kills hrefs!
456 2010-08-01T20:29:07 <valeuf> ThomasWaldmann: I need to remove the comment
457 2010-08-01T20:29:08 <valeuf> sorry
458 2010-08-01T20:30:38 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9247:499f3e48820d 2.0-dev-docbook-html-vjaniaut/MoinMoin/items/__init__.py: Delete obsolete comment
459 2010-08-01T20:30:56 <valeuf> I am going ta add more tests later
460 2010-08-01T20:30:57 <valeuf> bbl
461 2010-08-01T20:31:22 <ThomasWaldmann> there are prints inside
462 2010-08-01T20:32:06 <ThomasWaldmann> and did you hear guido when he told that one shouldn't abuse tuples for immutable lists?
463 2010-08-01T20:32:10 <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9235:48c5da1539e6 2.0-dev-jinja2-plugins-dfeher/MoinMoin/static/modernized/css/ (common.css screen.css): [templating] converted message css stuff to flash messages
464 2010-08-01T20:35:40 <valeuf> ThomasWaldmann: for tags_to_ignore?
465 2010-08-01T20:36:17 <ThomasWaldmann> in the smiley conv
466 2010-08-01T20:36:52 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9248:b4c6523112a1 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/smiley.py: Remove debug print statement
467 2010-08-01T20:36:56 <ThomasWaldmann> also fix the len > 0
468 2010-08-01T20:37:32 <valeuf> ThomasWaldmann: yes but for the smileys dictionnary or the tags_to_ignore set? with what would you replace it?
469 2010-08-01T20:39:35 <ThomasWaldmann> http://hg.moinmo.in/moin/2.0-dev-docbook-html-vjaniaut/rev/777d84cee295
470 2010-08-01T20:39:47 <ThomasWaldmann> 1.19 1.21
471 2010-08-01T20:40:09 <ThomasWaldmann> 1.29 1.30
472 2010-08-01T20:40:19 <ThomasWaldmann> 1.40
473 2010-08-01T20:40:43 <ThomasWaldmann> and 1.42 is remove_all() now?
474 2010-08-01T20:41:20 <valeuf> you do not have my last changeset
475 2010-08-01T20:41:28 <ThomasWaldmann> 1.31 smells like extend
476 2010-08-01T20:41:52 <valeuf> ThomasWaldmann: you have always one item, so it is append
477 2010-08-01T20:42:22 <ThomasWaldmann> no, you have a list
478 2010-08-01T20:42:33 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9249:3263b3e72049 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/smiley.py: Fix small issue with children computation for the smiley converter
479 2010-08-01T20:43:13 <valeuf> ThomasWaldmann: I append each item of the list return by do_smiley
480 2010-08-01T20:43:25 <ThomasWaldmann> and we have 2010 :)
481 2010-08-01T20:43:54 <ThomasWaldmann> valeuf: do_smiley returns a list, so we don't you give that to extend()
482 2010-08-01T20:44:10 <ThomasWaldmann> instead of appending all single list items?
483 2010-08-01T20:44:21 <valeuf> ThomasWaldmann: good point
484 2010-08-01T20:44:45 <ThomasWaldmann> (line 7)
485 2010-08-01T20:45:29 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9250:f40de6a482ee 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/smiley.py: Use extend method instead of the ugly append on each item
486 2010-08-01T20:45:49 <valeuf> brb
487 2010-08-01T20:45:50 <ThomasWaldmann> also spellcheck and/or reduce comments
488 2010-08-01T20:47:49 <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9236:31e22292281c 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/ (layout.html show.html): [templating] fixed header identation. now editbar is in header in an extensible way.
489 2010-08-01T20:47:51 <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9237:5adadd2e3699 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/ (layout.html show.html): [templating] refactored footer block and way the editbar put into
490 2010-08-01T20:49:00 <valeuf> ThomasWaldmann: I fix this after my dinner, sorry I rushed to give back my patch, but it was quite useless
491 2010-08-01T20:52:20 <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9238:67159d5dff11 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/layout.html: [templating] changed comments and place of them in layout.html
492 2010-08-01T21:15:11 *** kursor
493 2010-08-01T21:27:18 <ThomasWaldmann> valeuf: i asked already, does docbook converter support some kind of wiki item link?
494 2010-08-01T21:38:12 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9236:e746fd6e66de 2.0-dev/MoinMoin/items/__init__.py: items: remove transclude() usage
495 2010-08-01T21:38:14 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9237:68f20bdb83d7 2.0-dev/MoinMoin/items/__init__.py: items: remove transclude method (must be done by converter) and some other useless classes/attrs
496 2010-08-01T21:46:10 <valeuf> ok back from my dinner,
497 2010-08-01T21:46:30 <valeuf> ThomasWaldmann: I need to check, but I am not sure about what you mean
498 2010-08-01T21:46:45 <valeuf> ThomasWaldmann: you want that MoinMoin in a text is converted into a link?
499 2010-08-01T21:47:31 <valeuf> ThomasWaldmann: what was this transclude method for? Should I change some stuffs in my converter?
500 2010-08-01T21:49:40 <valeuf> I will review my code for the smiley converter, and try to take my time instead of rushing
501 2010-08-01T21:56:51 <ThomasWaldmann> valeuf: like [[foo]] in moin wiki markup
502 2010-08-01T21:57:11 <ThomasWaldmann> i need to know because of the itemlinks
503 2010-08-01T21:57:52 <ThomasWaldmann> if a markup has such a concept, its item class needs to be derived from a class that collects links to other wiki items and stores them into revision metadata
504 2010-08-01T21:58:54 <ThomasWaldmann> transclude was likely use by the old parser, but as of now, it was not used any more
505 2010-08-01T22:02:57 <valeuf> ThomasWaldmann: Well, it would not be really clear how we can do such of things with docbook
506 2010-08-01T22:04:16 <valeuf> Indeed, to do a link with docbook you should use <link> element, which accept xlink attribute, so it should be an href
507 2010-08-01T22:05:43 <valeuf> however, we can maybe do something with linkend attribute, which point on another element of the document, but it would not be really compliant to the specification IMHO
508 2010-08-01T22:09:07 <ThomasWaldmann> wiki:///foo?
509 2010-08-01T22:09:48 <ThomasWaldmann> can you try? could work :)
510 2010-08-01T22:10:33 <valeuf> ThomasWaldmann: huum nice :) I will try
511 2010-08-01T22:16:32 * ThomasWaldmann works on improved Dummies
512 2010-08-01T22:19:21 <valeuf> ThomasWaldmann: btw, what was the problem with if len(new_children) > 0: ?
513 2010-08-01T22:19:27 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9238:55b4980ca8a7 2.0-dev/MoinMoin/items/__init__.py: improved DummyRev/Item, improved detection of them
514 2010-08-01T22:19:28 <ThomasWaldmann> unpythonic
515 2010-08-01T22:19:36 <ThomasWaldmann> if new_children:
516 2010-08-01T22:19:46 <valeuf> ThomasWaldmann: it works ? ooOO
517 2010-08-01T22:19:52 <ThomasWaldmann> sure
518 2010-08-01T22:20:00 <ThomasWaldmann> everything empty is falsy
519 2010-08-01T22:20:17 <valeuf> hhmmmm coool :)
520 2010-08-01T22:28:19 * ThomasWaldmann kills do_show
521 2010-08-01T22:28:41 <valeuf> *pan*
522 2010-08-01T22:32:51 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9239:97ec8509093f 2.0-dev/MoinMoin/ (apps/frontend/views.py items/__init__.py): move do_show code to frontend.views.show_item
523 2010-08-01T22:36:43 * ThomasWaldmann fixes the atomic collateral damage
524 2010-08-01T22:42:02 *** grzywacz
525 2010-08-01T22:53:07 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9251:9887033bb0a8 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/smiley.py: Clean the smiley converter
526 2010-08-01T22:53:10 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9252:0770ab223320 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/smiley.py: Clean the comments of the smiley converter
527 2010-08-01T22:53:11 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9253:c4f04de615cb 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_smiley.py: Add tests to check the attribute are correctly handled with the smiley converter
528 2010-08-01T22:53:47 <valeuf> ok I cleaned the smiley converter, it should be better (although not perfect)
529 2010-08-01T22:58:10 <valeuf> ThomasWaldmann: docbook document are not shown anymore :p
530 2010-08-01T23:05:03 <ThomasWaldmann> oops
531 2010-08-01T23:06:12 <ThomasWaldmann> was it me?
532 2010-08-01T23:06:38 <valeuf> ThomasWaldmann: I do not know, I try to see what's going on
533 2010-08-01T23:07:01 <valeuf> ThomasWaldmann: but I always have weird conflictn with my _convert method in the items/__init__.py
534 2010-08-01T23:12:10 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9258:8947fa482caf 2.0-dev-docbook-html-vjaniaut/MoinMoin/ (apps/frontend/views.py items/__init__.py): Merged against moin/dev-2.0
535 2010-08-01T23:12:16 <valeuf> hum not better :p
536 2010-08-01T23:17:04 <ThomasWaldmann> anyone using atom feed?
537 2010-08-01T23:17:13 <ThomasWaldmann> what's expected content in a feed?
538 2010-08-01T23:17:22 <ThomasWaldmann> full new revision content?
539 2010-08-01T23:17:23 <valeuf> ThomasWaldmann: for the recent changes?
540 2010-08-01T23:17:24 <ThomasWaldmann> diffs?
541 2010-08-01T23:17:35 <ThomasWaldmann> global or just single item feed
542 2010-08-01T23:18:06 <valeuf> on google sites (which is a wiki) the feed is the diff, I should say it was really convenient
543 2010-08-01T23:19:27 <ThomasWaldmann> but how do those planets work? they don't process diffs I assume?
544 2010-08-01T23:19:47 <ThomasWaldmann> or shall there be 2 kinds of feed: full content and diffs?
545 2010-08-01T23:20:11 <valeuf> ThomasWaldmann: I do not really know
546 2010-08-01T23:21:16 <ThomasWaldmann> input converter seems to by None for docbook?
547 2010-08-01T23:21:21 <ThomasWaldmann> be*
548 2010-08-01T23:21:36 <ThomasWaldmann> my feed crashes at a docbook item :)
549 2010-08-01T23:21:41 <valeuf> ThomasWaldmann: I do not understand yet what you did
550 2010-08-01T23:21:43 <dreimark> lol
551 2010-08-01T23:21:55 <valeuf> but I do not see where you convert the data in to the dom tree
552 2010-08-01T23:22:10 <ThomasWaldmann> _render_data method
553 2010-08-01T23:22:11 <valeuf> hum internal_representation?
554 2010-08-01T23:22:13 <dreimark> re
555 2010-08-01T23:22:18 <dreimark> ei-grad: ping
556 2010-08-01T23:22:26 <ThomasWaldmann> yes, it calls internal repr
557 2010-08-01T23:22:32 <valeuf> ok got
558 2010-08-01T23:22:33 <valeuf> it
559 2010-08-01T23:23:55 <valeuf> I still think it is quite weird to have internal representation for Binary items
560 2010-08-01T23:25:09 <dreimark> eSyr: DmitryAndreev http://blog.nyaruka.com/making-moinmoin-pygments-and-codemirror-all-p
561 2010-08-01T23:25:26 <ThomasWaldmann> well, show contents = transcluded contents = expected view of a transcluded item
562 2010-08-01T23:26:07 <ThomasWaldmann> for a non-renderable binary item that might be just a link to the item, maybe some icon
563 2010-08-01T23:26:20 <valeuf> ThomasWaldmann: ok, I think we will need some documentation to explain correctly the architecture for the future developer!
564 2010-08-01T23:26:35 <ThomasWaldmann> yes :)
565 2010-08-01T23:26:56 <ThomasWaldmann> we can write some as soon as we know how it works
566 2010-08-01T23:27:45 <valeuf> dreimark: cool :)
567 2010-08-01T23:27:58 <valeuf> ThomasWaldmann: :)
568 2010-08-01T23:28:29 <ThomasWaldmann> as soon as the url generation is fixed, we can have image feeds :D
569 2010-08-01T23:28:52 <valeuf> diofeher: http://blog.nyaruka.com/making-moinmoin-pygments-and-codemirror-all-p --> the last part of the post is especially for you ^ ^
570 2010-08-01T23:31:26 * dreimark clones dmitries repo
571 2010-08-01T23:32:27 <valeuf> wow it seems I have a big bug in my DocBook_IN converter
572 2010-08-01T23:32:34 <valeuf> I do not know when this happened
573 2010-08-01T23:33:52 <valeuf> hum maybe not in the converter in fact
574 2010-08-01T23:33:58 <dreimark> DmitryAndreev: please use the coverage_modules = [] syntax in yout tests e.g. http://hg.moinmo.in/moin/2.0-dev/file/97ec8509093f/MoinMoin/items/_tests/test_Item.py#l146
575 2010-08-01T23:34:08 <diofeher> "MoinMoin really, really needs to adopt a templating language" :P
576 2010-08-01T23:34:17 <diofeher> valeuf, nice ^^
577 2010-08-01T23:34:21 <ThomasWaldmann> if the renderer crashes, the feed will now just tell that MoinMoin feels unhappy. :D
578 2010-08-01T23:35:19 <ThomasWaldmann> diofeher: you see, your work is highly appreciated. :)
579 2010-08-01T23:35:24 <valeuf> diofeher: many people are waiting for your job
580 2010-08-01T23:35:38 <dreimark> diofeher: this blog was introduced by a discussion on the mailing list
581 2010-08-01T23:35:52 <dreimark> you could add a comment there
582 2010-08-01T23:37:38 <dreimark> http://www.mail-archive.com/moin-user@lists.sourceforge.net/msg03010.html
583 2010-08-01T23:38:07 <dreimark> DmitryAndreev: too
584 2010-08-01T23:38:53 * valeuf is considering to kill the smiley_converter :p
585 2010-08-01T23:39:39 <ThomasWaldmann> hehe
586 2010-08-01T23:39:55 <diofeher> dreimark, oh nice, didn't see
587 2010-08-01T23:40:08 <diofeher> i'm subscribed to mailing list, but now I see i'm not receiving e-mails
588 2010-08-01T23:40:25 <diofeher> ThomasWaldmann, it's nice to see this what you said ^^
589 2010-08-01T23:40:41 <diofeher> brb, lunch
590 2010-08-01T23:40:53 <dreimark> DmitryAndreev: http://hg.moinmo.in/moin/2.0-dev-wiki-rest-dandreev/file/4cd7aad9f9c8/MoinMoin/converter2/_tests/test_mediawiki_in.py#l100
591 2010-08-01T23:41:00 <dreimark> don't overwrite foile
592 2010-08-01T23:41:05 <dreimark> *file
593 2010-08-01T23:41:41 <dreimark> DmitryAndreev: http://hg.moinmo.in/moin/2.0-dev-wiki-rest-dandreev/file/4cd7aad9f9c8/MoinMoin/converter2/_tests/test_mediawiki_in.py#l106
594 2010-08-01T23:42:08 <dreimark> there is a print
595 2010-08-01T23:44:12 <dreimark> DmitryAndreev: please avoid i as variable name http://hg.moinmo.in/moin/2.0-dev-wiki-rest-dandreev/file/tip/MoinMoin/converter2/_tests/test_rst_out.py#l27
596 2010-08-01T23:44:59 <dreimark> http://hg.moinmo.in/moin/2.0-dev-wiki-rest-dandreev/file/tip/MoinMoin/converter2/_tests/test_rst_out.py#l32 overwrites file
597 2010-08-01T23:45:39 <dreimark> http://hg.moinmo.in/moin/2.0-dev-wiki-rest-dandreev/file/tip/MoinMoin/converter2/_tests/test_rst_out.py#l38 print
598 2010-08-01T23:49:39 *** ebo^
599 2010-08-01T23:51:00 <dreimark> DmitryAndreev: http://hg.moinmo.in/moin/2.0-dev-wiki-rest-dandreev/file/5c5abd171da1/MoinMoin/converter2/_tests/test_rst_out.py#l32 file overwritten
600 2010-08-01T23:51:20 <dreimark> http://hg.moinmo.in/moin/2.0-dev-wiki-rest-dandreev/file/5c5abd171da1/MoinMoin/converter2/_tests/test_rst_out.py#l38 print
601 2010-08-01T23:52:47 <valeuf> \o/ another bug fixed in the smiley converter
602 2010-08-01T23:52:59 <valeuf> did I ever told you that this converter was really crappy ^ ^
603 2010-08-01T23:54:31 * ThomasWaldmann fights with atom
604 2010-08-01T23:54:44 <dreimark> valeuf: please write tests for all of these findings if you haven't already
605 2010-08-01T23:55:28 <valeuf> dreimark: I do :)
606 2010-08-01T23:55:59 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9259:32ec7cf12a73 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/ (_tests/test_smiley.py smiley.py): Fix issue with children mistreatment in the smiley converter
607 2010-08-01T23:57:15 <valeuf> there is another issue with ignored_tag in the smiley converter,
608 2010-08-01T23:57:31 <valeuf> but I am going to bed, I am falling asleep in front of my computer, I will fix it tomorrow
609 2010-08-01T23:59:17 <valeuf> ThomasWaldmann: I also added at the top of my todo list the wiki links in the DocBook converter
610 2010-08-01T23:59:32 <valeuf> ThomasWaldmann: if you think to something else, feel you free to ping me on IRC or add this on my todo list
