1 2010-08-02T00:00:46 <ThomasWaldmann> ok, gn valeuf
2 2010-08-02T00:22:41 <dreimark> gn
3 2010-08-02T00:26:44 *** RogerHaase
4 2010-08-02T01:25:59 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9240:92e80e4c7b5d 2.0-dev/MoinMoin/ (apps/feed/views.py items/__init__.py): cleaned up atom feed, don't use do_diff/do_show, added _render_data_diff_text method to items
5 2010-08-02T01:46:46 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9241:3211c9e7bef6 2.0-dev/MoinMoin/ (apps/feed/views.py user.py): add text mode to get_printable_editor method, use it for atom feed
6 2010-08-02T02:00:29 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9242:c144ac06e8e4 2.0-dev/MoinMoin/items/__init__.py: items: get rid of the formatter
7 2010-08-02T02:03:24 <diofeher> these docs of python in pdf are awesome
8 2010-08-02T02:03:46 <diofeher> a many of how to ^^
9 2010-08-02T02:08:41 <diofeher> gn
10 2010-08-02T06:22:38 *** franklin
11 2010-08-02T07:05:19 *** kursor
12 2010-08-02T07:07:24 *** kursor_
13 2010-08-02T07:09:54 *** kursor
14 2010-08-02T07:09:54 *** kursor_
15 2010-08-02T07:20:50 *** ebo^
16 2010-08-02T07:27:56 *** grzywacz
17 2010-08-02T07:55:53 *** ebo^
18 2010-08-02T08:19:33 *** DmitryAndreev
19 2010-08-02T08:42:25 *** ebo^
20 2010-08-02T09:07:27 *** kursor
21 2010-08-02T09:17:50 *** DmitryAndreev
22 2010-08-02T09:26:38 *** ebo^
23 2010-08-02T09:28:19 *** ebo^
24 2010-08-02T09:28:28 <ThomasWaldmann> moin
25 2010-08-02T09:30:26 *** ebo^
26 2010-08-02T09:32:05 *** ebo^
27 2010-08-02T09:54:02 *** kursor
28 2010-08-02T09:58:26 <ThomasWaldmann> valeuf: maybe try the docbook conversion with some invalid document, exception should be catched
29 2010-08-02T10:00:16 <ThomasWaldmann> valeuf: the doc==None problem seems to be related to documents invalid in some other way (tried a book with no xml decl)
30 2010-08-02T10:01:20 <ThomasWaldmann> s/conversion/item rendering/
31 2010-08-02T10:08:57 <valeuf> moin
32 2010-08-02T10:09:19 <valeuf> the main bug yesterday with docbook was coming from the smiley converter ^ ^ as always
33 2010-08-02T10:09:41 <valeuf> but proper exception for invalid document is one of my tasks for today
34 2010-08-02T10:09:41 <ThomasWaldmann> :)
35 2010-08-02T10:10:34 <ThomasWaldmann> maybe the converters should either return a valid dom tree or raise an Exception
36 2010-08-02T10:11:40 <ThomasWaldmann> and maybe the Exception class could have some dom tree as attribute (with some error msg representation), so that this can be fed into the processing, if wanted
37 2010-08-02T10:13:41 <valeuf> ThomasWaldmann: aaah that would a good approach to return a DomTree with the error messay if the converter raise an exception
38 2010-08-02T10:14:09 <valeuf> so I can handle the exception directly in the converter, instead of the items module
39 2010-08-02T10:17:02 <ThomasWaldmann> yes, that was the idea anyway. your converter knows better what can go wrong than the code calling it.
40 2010-08-02T10:18:03 <ThomasWaldmann> bbl
41 2010-08-02T10:58:40 *** grzywacz
42 2010-08-02T11:11:48 *** kursor
43 2010-08-02T11:22:21 <valeuf> waldi: I saw an <error> element in the DOM tree, was it intended to use it to display error message to the user?
44 2010-08-02T11:25:40 <waldi> valeuf: yes
45 2010-08-02T11:34:25 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9260:cae2546425fa 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_smiley.py: Add tests to check that the smiley converter do not convert smiley within the ignored_tags
46 2010-08-02T11:34:36 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9261:51f141503222 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/smiley.py: Fix bug with the handling of the ingored tags in the smiley converter
47 2010-08-02T11:34:43 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9262:77ac57907709 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_smiley.py: Add more tests to the smiley converter
48 2010-08-02T11:51:22 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9263:15be6805bef7 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_docbook_in.py: Add tests for invalid XML document for DocBook_IN converter
49 2010-08-02T11:51:29 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9264:e41bc89aa200 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Handle correctly invalid XML document for DocBook_IN converter
50 2010-08-02T12:20:37 <ThomasWaldmann> valeuf: when stuff is in good state for merge back, tell me
51 2010-08-02T12:21:08 <valeuf> ThomasWaldmann: for the smiley, I think it should be fine now, but I want to finish the exception before any merge
52 2010-08-02T12:21:29 <valeuf> I am fighting with namespace ^ ^
53 2010-08-02T12:27:21 <ThomasWaldmann> ok
54 2010-08-02T12:27:34 * ThomasWaldmann fights with crappy sata1 controllers
55 2010-08-02T12:38:52 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9265:99f6e49da359 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_docbook_in.py: Add test for namespace for the DocBook_IN converter
56 2010-08-02T12:39:04 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9266:7b2ab7ff4bc6 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Add namespace error handling for DocBook_IN converter
57 2010-08-02T12:39:05 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9267:4cc6cc914524 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Refactor code to handle exception in the DocBook_IN converter
58 2010-08-02T12:39:17 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9268:ecfda7c14f50 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_docbook_in.py: Fix minor issue in the test for the DocBook_IN converter
59 2010-08-02T12:39:24 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9269:90b65dfb34a8 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Fix minor issue in DocBook_IN converter
60 2010-08-02T12:43:43 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9270:186feb4fba53 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Change error message for NameSpaceError to be more exact
61 2010-08-02T12:44:07 <valeuf> ok now I correctly handle Invalid XML and Uknown Namespace error
62 2010-08-02T12:44:40 <valeuf> if you input a DocBook document not correct, you will get a nice red-color error message instead of the Traceback
63 2010-08-02T12:44:50 <valeuf> smiley converter seems to be much better too
64 2010-08-02T12:45:05 <valeuf> ThomasWaldmann: so you can have a look to merge if you want
65 2010-08-02T12:45:12 <valeuf> ThomasWaldmann: I will check the wikilinks now
66 2010-08-02T12:52:56 <valeuf> Here is some notes about the exception I added to the DocBook_IN converter : http://moinmo.in/DOM%20DocBook%20and%20HTML%202010/DocBook-DOM#Exceptions
67 2010-08-02T12:53:48 <valeuf> I am probably going to see to add some warning if people are creating obviously wrong DocBook document
68 2010-08-02T12:54:31 <valeuf> however, I think it should not block the converter to try to convert the Document into the DOM Tree, I do not want to be strict with the DocBook specification,
69 2010-08-02T12:54:49 <ThomasWaldmann> well, maybe describe what the usual causes of these errors are and how a valid doc looks like / how to fix them
70 2010-08-02T13:04:25 <valeuf> ThomasWaldmann: ok
71 2010-08-02T13:04:33 <valeuf> bbl lunch time ^ ^
72 2010-08-02T13:38:50 *** valeuf
73 2010-08-02T13:40:33 *** valeuf
74 2010-08-02T14:26:31 <valeuf> ThomasWaldmann: you were right, wiki:/// link work with DocBook document
75 2010-08-02T14:27:13 <valeuf> ThomasWaldmann: http://paste.pocoo.org/show/244646/ will wok :)
76 2010-08-02T14:27:41 <valeuf> it is really nice ^ ^
77 2010-08-02T14:33:26 <ThomasWaldmann> valeuf: can you try interwiki?
78 2010-08-02T14:33:44 <valeuf> I am not sure I now how it works in moin2
79 2010-08-02T14:33:51 <ThomasWaldmann> wiki://MoinMoin/FrontPage ?
80 2010-08-02T14:33:51 <valeuf> I should create an interwikipage?
81 2010-08-02T14:34:10 <ThomasWaldmann> just try it, not sure if that part of the code already works
82 2010-08-02T14:34:27 <valeuf> ThomasWaldmann: no difference ^ ^
83 2010-08-02T14:34:27 <ThomasWaldmann> maybe you need some interwiki map, see diofeher's todo page in the wiki
84 2010-08-02T14:34:39 <valeuf> I will try with an interwiki map
85 2010-08-02T14:39:28 <valeuf> well it seems not working
86 2010-08-02T14:40:08 <valeuf> I add the three lines indicated by diofeher in my wikiconfig, I added "MoinMoin http://moinmo.in/" in an intermap.txt file
87 2010-08-02T14:40:11 <valeuf> but no any change
88 2010-08-02T14:40:23 <ThomasWaldmann> what link is generated?
89 2010-08-02T14:40:55 <valeuf> the same than if I use wiki:///FrontPage
90 2010-08-02T14:41:03 <valeuf> adding MoinMoin/ does not change anything
91 2010-08-02T14:41:54 <ThomasWaldmann> + if not 'nonamespace' in args:
92 2010-08-02T14:42:03 <ThomasWaldmann> you know that ... not in ... also works?
93 2010-08-02T14:42:12 <valeuf> ah I did not know
94 2010-08-02T14:42:14 <valeuf> I will change
95 2010-08-02T14:42:51 <ThomasWaldmann> wait
96 2010-08-02T14:43:12 <ThomasWaldmann> that stuff could be maybe also a param with default value
97 2010-08-02T14:43:32 <valeuf> ThomasWaldmann: it could be yes, but it seems that default value are not so great
98 2010-08-02T14:43:58 <ThomasWaldmann> like handle_output(self, input, nonamespace=..., **kw) ?
99 2010-08-02T14:44:46 <valeuf> you mean nonamespace=False or do you really mean nonamespace=... ?
100 2010-08-02T14:45:08 <ThomasWaldmann> try to remove those blanks before the punctuation
101 2010-08-02T14:45:23 <ThomasWaldmann> ... = whatever you need :)
102 2010-08-02T14:45:41 <valeuf> ok I will change that
103 2010-08-02T14:45:58 <ThomasWaldmann> btw, some stuff you do in your tests should be done in conftest.py
104 2010-08-02T14:46:50 <valeuf> hum I did not know about conftest.py
105 2010-08-02T14:47:15 <valeuf> maybe I can create a class for the converter test, there is a lot of redundant code there
106 2010-08-02T14:47:42 <ThomasWaldmann> if other errors than NameSpaceError could happen there, maybe we need some intermediate base class for the exceptions
107 2010-08-02T14:48:03 <ThomasWaldmann> like class ConverterException(Exception) or so
108 2010-08-02T14:48:09 <valeuf> ok
109 2010-08-02T14:50:45 <ThomasWaldmann> DocBook item class needs to be derived from Markup item class
110 2010-08-02T14:51:01 <ThomasWaldmann> so it saves the itemlinks into metadata
111 2010-08-02T14:51:05 <valeuf> ThomasWaldmann: ok
112 2010-08-02T14:52:18 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9274:b3b4c69ce31e 2.0-dev/MoinMoin/ (6 files in 3 dirs): merged moin/2.0-dev-docbook-html-vjaniaut
113 2010-08-02T14:52:41 <valeuf> I was going to commit the change you asked me, but it can wait ^ ^
114 2010-08-02T14:53:08 * ThomasWaldmann reviewed all the changes after hg merge :)
115 2010-08-02T14:53:22 <valeuf> ThomasWaldmann: thanks :)
116 2010-08-02T14:54:11 <ThomasWaldmann> diofeher: we need some less ugly style for default rendering of items
117 2010-08-02T14:54:49 <ThomasWaldmann> so it is not Data: .... <hr>Meta: ..., but something more visually attractive
118 2010-08-02T14:55:15 <valeuf> ThomasWaldmann: I checked for the Markup class, you are sure we should consider DocBook as a Markup item?
119 2010-08-02T14:55:28 <ThomasWaldmann> also not Item: itemname (itemname is in location breadcrumbs)
120 2010-08-02T14:56:24 <ThomasWaldmann> maybe it could check whether data / meta is non-empty and if yes, make a div class="meta"/"data" for them and some css to style it?
121 2010-08-02T15:01:22 <ThomasWaldmann> valeuf: do you always create that TOC for docbook articles?
122 2010-08-02T15:01:40 <valeuf> ThomasWaldmann: currently yes, but it is something I should fix
123 2010-08-02T15:02:26 <valeuf> ThomasWaldmann: there is no way to specify in a DocBook document we want a ToC, so I decided to display one only if there is section in the document
124 2010-08-02T15:06:26 <valeuf> ThomasWaldmann: when you said some stuff I do in my test should be done in conftest.py
125 2010-08-02T15:06:50 <valeuf> ThomasWaldmann: you mean to create a class in conftest to handle the generic stuff of the converter tests
126 2010-08-02T15:07:01 <valeuf> ThomasWaldmann: something like that : http://paste.pocoo.org/show/244669/ ?
127 2010-08-02T15:07:29 <valeuf> (if it is right, I will naturally make this more generic to be usable with all the converter tests)
128 2010-08-02T15:08:59 <ThomasWaldmann> no, ConverterBase is just something for converters, so it should be in some comon file in the tests/ dir
129 2010-08-02T15:09:17 <ThomasWaldmann> what I meant is having a working wsgi app object :)
130 2010-08-02T15:11:14 <ThomasWaldmann> interwiki stuff seems to be mostly broken somehow
131 2010-08-02T15:11:23 *** franklin
132 2010-08-02T15:12:20 <ThomasWaldmann> diofeher: same wish for the editor page
133 2010-08-02T15:14:01 *** valeuf
134 2010-08-02T15:14:50 *** valeuf
135 2010-08-02T15:20:56 <diofeher> ThomasWaldmann, back, my internet connection got lost again :S
136 2010-08-02T15:26:25 <ThomasWaldmann> btw, current moin2 is quite faster than 1.9
137 2010-08-02T15:27:03 <ThomasWaldmann> HelpOnAccessControlLists: moin2 13reqs/s moin1.9 8reqs/s
138 2010-08-02T15:27:21 <valeuf> ThomasWaldmann: :)
139 2010-08-02T15:27:40 <ThomasWaldmann> moin2 was with wikiserver, moin1.9 with apache/modwsgi
140 2010-08-02T15:28:50 <ThomasWaldmann> moin1.9 with wikiserver: 4reqs/s
141 2010-08-02T15:30:04 <diofeher> nice ^^
142 2010-08-02T15:30:51 <ThomasWaldmann> (and moin2 is far from being optimized :)
143 2010-08-02T15:32:17 <ThomasWaldmann> empty page 1.9 wikiserver: 14/s
144 2010-08-02T15:33:24 *** DmitryAndreev
145 2010-08-02T15:33:30 <ThomasWaldmann> empty page 2.0 wikiserver: 33/s
146 2010-08-02T15:34:45 <valeuf> ThomasWaldmann: do you think it is ok to add metadata to an item from the converter?
147 2010-08-02T15:34:54 <valeuf> I feel like it is not really right with our design
148 2010-08-02T15:35:10 <ThomasWaldmann> i feel the same :)
149 2010-08-02T15:35:27 <ThomasWaldmann> what did you think about exactly?
150 2010-08-02T15:36:58 <ThomasWaldmann> hmm, shall we have a separate view for the metadata?
151 2010-08-02T15:37:08 <valeuf> DocBook document should have an <articleinfo> section
152 2010-08-02T15:37:38 <valeuf> in this part you can find elements like <title>, <author> ...
153 2010-08-02T15:38:08 <valeuf> it is usually meta-information, sometimes it can be displayed but the DocBook processor (for instance, the name of the company can be added on all the pages ...)
154 2010-08-02T15:38:28 <valeuf> I do not know what I should do with these information for a DocBook document
155 2010-08-02T15:38:33 <valeuf> I see different solutions
156 2010-08-02T15:38:42 <valeuf> 1- add these information to the metadata
157 2010-08-02T15:39:02 <ThomasWaldmann> well, that could get handled like the itemlinks stuff
158 2010-08-02T15:39:06 <valeuf> 2- Add these information in the Dom tree using a definition list or a table (or any other format)
159 2010-08-02T15:39:10 <ThomasWaldmann> but i am not sure whether we want that
160 2010-08-02T15:39:17 <valeuf> 3- Ignore these datas
161 2010-08-02T15:39:46 <ThomasWaldmann> because editor for moin is the moin user saving the document
162 2010-08-02T15:40:03 <ThomasWaldmann> that is not necessarily same guy as author of some docbook document
163 2010-08-02T15:40:09 <valeuf> It will start te get really complicate to handle all the conversion step : link, smiley, metadata include ...
164 2010-08-02T15:40:47 <valeuf> yep but I was thinking to add these information with a kind of namespace, like db:author, d
165 2010-08-02T15:40:53 <valeuf> db:title ...
166 2010-08-02T15:42:35 <ThomasWaldmann> not sure about how to handle (not handle) that best
167 2010-08-02T15:43:11 <valeuf> I will ask the question on #docbook channel to see if someone get an idea
168 2010-08-02T15:43:28 <ThomasWaldmann> this is a generic problem btw, we could also extract metadata from mp3 and do something with them
169 2010-08-02T15:43:42 <valeuf> ThomasWaldmann: good point
170 2010-08-02T15:44:15 <valeuf> this would mean we should think to some way to process metadata for a document
171 2010-08-02T15:49:32 *** DmitryAndreev
172 2010-08-02T15:55:59 <ThomasWaldmann> either that or leave it :)
173 2010-08-02T15:58:34 * diofeher thinking in a way to improve moin style
174 2010-08-02T16:04:05 <ThomasWaldmann> valeuf: maybe extraction of "inner" metadata from items is not in scope of the basic feature set we need for 2.0 release
175 2010-08-02T16:04:30 <valeuf> ThomasWaldmann: seems to be reasonable, but we can keep it for later release
176 2010-08-02T16:04:30 <ThomasWaldmann> so we maybe should rather work on improving the basic stuff
177 2010-08-02T16:10:27 <diofeher> hey guys, i modified content style a little... let me ask you what do you think ^^ (just basic idea here) http://img251.imageshack.us/i/screenshot20100802at110.png/
178 2010-08-02T16:10:57 <diofeher> name of item with background color equals to border of content...
179 2010-08-02T16:13:01 <ThomasWaldmann> the "FrontPage" must not be there in the end. it just was there for development.
180 2010-08-02T16:13:25 <diofeher> name of item won't appear? hm
181 2010-08-02T16:13:41 <ThomasWaldmann> you have it in the navigation
182 2010-08-02T16:13:50 <ThomasWaldmann> just imagine a word processor
183 2010-08-02T16:14:11 <ThomasWaldmann> it also does not show the name of your document file inside / at top of the document
184 2010-08-02T16:14:17 <diofeher> hm, so my idea won't work without item name in page
185 2010-08-02T16:14:25 <diofeher> got it ^^
186 2010-08-02T16:15:10 <ThomasWaldmann> (and if we don't have it there, i don't have to deal with "i want to have a nicer/different title there" kind of requests :)
187 2010-08-02T16:15:57 <ThomasWaldmann> btw, maybe we can steal some ideas from mediawiki.org :)
188 2010-08-02T16:16:33 <diofeher> hehe
189 2010-08-02T16:16:36 <diofeher> gonna look
190 2010-08-02T16:16:45 <ThomasWaldmann> e.g. I like the Page Discussion Read View Source View History tab stuff
191 2010-08-02T16:17:11 <diofeher> metadata going to show? or just to dev?
192 2010-08-02T16:17:42 <ThomasWaldmann> well, we need some solution that can stay for later also
193 2010-08-02T16:18:13 <ThomasWaldmann> for development, having it on-page is nice, but users rather would not like to see that all the time
194 2010-08-02T16:19:08 <ThomasWaldmann> so either we need another view or something that hides. maybe another view is cleaner (and faster).
195 2010-08-02T16:19:29 <diofeher> we can use debug settings of flask. if debug is on, we show the box
196 2010-08-02T16:20:13 <diofeher> if is not, well, production mode won't show this to users
197 2010-08-02T16:20:23 <ThomasWaldmann> not sure about that, maybe app behaviour shouldn't change with debug setting
198 2010-08-02T16:20:48 <ThomasWaldmann> see heisenbugs :)
199 2010-08-02T16:21:22 <diofeher> http://en.wikipedia.org/wiki/Unusual_software_bug
200 2010-08-02T16:21:27 <diofeher> strange names for strange bugs :P
201 2010-08-02T16:24:53 <ThomasWaldmann> i also like that slight frame around the page contents (see mediawiki) and how it shows stuff below it
202 2010-08-02T16:27:02 <ThomasWaldmann> I would like to keep the "at-top" AND "at-bottom" way of having the important "editbar" links, though, so if these are going to be tabs, we need bottom-tabs also
203 2010-08-02T16:28:05 <ThomasWaldmann> just much less scrolling when you decide that you need to edit the page or view some diffs after reading through a longer page
204 2010-08-02T16:29:56 <diofeher> agreed with that
205 2010-08-02T16:29:59 <ThomasWaldmann> http://techblog.wikimedia.org/ uhoh
206 2010-08-02T16:31:54 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9271:596b58dc1712 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_docbook_in.py: Add test for <quote> element for DocBook_IN converter
207 2010-08-02T16:31:56 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9272:53636eeb7b96 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Add support for <quote> element for DocBook_in converter
208 2010-08-02T16:31:57 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9273:4af3fedaa3c9 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_docbook_in.py: Add tests for <blockquote> element for DocBook_IN converter
209 2010-08-02T16:31:59 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9274:6acfa34fe997 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Add support for <blockquote> element for DocBook_IN converter
210 2010-08-02T16:33:14 <diofeher> should i go with this tab idea?
211 2010-08-02T16:34:39 <ThomasWaldmann> what does one need for it? just css?
212 2010-08-02T16:34:40 <diofeher> btw, we should change this header, trail + navibar + editbar + title + userprefs is too much information together
213 2010-08-02T16:34:54 <diofeher> TheSheep, what do you think?
214 2010-08-02T16:35:08 <TheSheep> diofeher: yes, I'm lobbying for it since a while
215 2010-08-02T16:35:43 <ThomasWaldmann> yes, i think we can do that now. moin2 is very different anyway. :)
216 2010-08-02T16:36:10 <TheSheep> diofeher: then again, it has lower priority than, for example, having pluggable themes
217 2010-08-02T16:36:15 <ThomasWaldmann> always keep scalability in mind though
218 2010-08-02T16:36:46 <ThomasWaldmann> the nice thing about doing something horizontally across the screen is that there is much more space than in a sidebar
219 2010-08-02T16:37:30 <ThomasWaldmann> yes, getting infrastructure right is more important
220 2010-08-02T16:37:54 <ThomasWaldmann> so just do some small things for design now
221 2010-08-02T16:40:59 * ThomasWaldmann thinks about too long item names for example or too many entries in trail or ...
222 2010-08-02T16:45:41 <ThomasWaldmann> TheSheep: can item name shortening be done with JS to fit into the current width of some container element?
223 2010-08-02T16:46:08 <ThomasWaldmann> (like e.g. a sidebar)
224 2010-08-02T16:46:41 <diofeher> i think this is possible
225 2010-08-02T16:47:11 <ThomasWaldmann> (i mean one never knows what would fit on the server side, because one doesn't know clientside font size, container size, etc.)
226 2010-08-02T16:50:58 <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9239:95eadecc60fb 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/show.html: [templating] removed "item:", "meta" and "data" from content, and created div to stylize these parts
227 2010-08-02T17:02:38 <diofeher> Data: FrontPage/test10 does not exist. Create it?
228 2010-08-02T17:02:59 <diofeher> strange, it's not showing templates (creole, text/html) anymore
229 2010-08-02T17:03:21 <ThomasWaldmann> you need to insert /+modify in the url line of your browser
230 2010-08-02T17:03:37 <ThomasWaldmann> this is a bug in url generation still
231 2010-08-02T17:04:00 <ThomasWaldmann> (in the converter)
232 2010-08-02T17:04:11 <diofeher> ah ok!
233 2010-08-02T17:06:29 <diofeher> we have a bug tracker here in moin that i don't know? :S
234 2010-08-02T17:08:23 <ThomasWaldmann> http://moinmo.in/MoinMoinIdeas/BetterDefaultTheme some rather old page, but maybe still useful
235 2010-08-02T17:08:38 <ThomasWaldmann> we use the wiki for bugs :)
236 2010-08-02T17:08:44 *** ebo^
237 2010-08-02T17:09:00 <ThomasWaldmann> but you don't need to file the modify link bug, that's pretty obvious :)
238 2010-08-02T17:10:39 <diofeher> hehe, it's just to know if i caused this bug when modifying some thing in my project... if i saw in bug page, i was sure that it's not me^^
239 2010-08-02T17:14:42 <valeuf> diofeher: too many things are moving in the code these days, so always expect bug ^ ^
240 2010-08-02T17:14:52 <ThomasWaldmann> btw, page name can be displayed in the footer, like
241 2010-08-02T17:15:07 <ThomasWaldmann> ThisPageName was last edited by ... at ...
242 2010-08-02T17:15:54 <ThomasWaldmann> to have something easy to click on, we'll need a "Show" tab (link)
243 2010-08-02T17:16:10 <ThomasWaldmann> aside from that, there is breadcrumbs
244 2010-08-02T17:16:25 <ThomasWaldmann> *are
245 2010-08-02T17:25:42 *** grzywacz
246 2010-08-02T17:27:26 <diofeher> valeuf, you are right
247 2010-08-02T17:28:16 <diofeher> ThomasWaldmann, page name is already show in footer... you are suggesting to put a link to "show" page ?
248 2010-08-02T17:33:40 *** DmitryAndreev_
249 2010-08-02T17:37:04 *** DmitryAndreev
250 2010-08-02T17:39:41 <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9240:a7e9254e290b 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/ (modify_applet.html modify_binary.html): [templating] removed duplicated code in modify_binary.html. now exteding from modify_applet
251 2010-08-02T17:49:23 <diofeher> lunch time, brb
252 2010-08-02T17:51:05 <ThomasWaldmann> about displaying of revision: maybe we can do that, when the /+show/<revno>/<itemname> view is called
253 2010-08-02T17:51:19 <ThomasWaldmann> and not do it, when /<itemname> is called
254 2010-08-02T17:52:28 <ThomasWaldmann> for the first case, there could be also some tiny navigation there <-- Older Diff Newer -->
255 2010-08-02T17:54:36 <ThomasWaldmann> for the footer (always): ThisPageName (rev ###) was edited by ... at ...
256 2010-08-02T18:03:37 <ThomasWaldmann> diofeher: http://hg.moinmo.in/moin/2.0-dev-jinja2-plugins-dfeher/rev/31e22292281c when looking at that hard-to-read diff (because of the indentation changes being in same diff as other changes), I ask myself "if you do it for header, what's up with the navibar in footer?"
257 2010-08-02T18:09:25 <diofeher> ThomasWaldmann, didn't get it your question... they're in correct identation (editbar in header and in footer)
258 2010-08-02T18:09:46 *** DmitryAndreev_
259 2010-08-02T18:14:14 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9275:29f1ecfc57e9 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_docbook_in.py: Add tests for ignored tags for DocBook_IN converter
260 2010-08-02T18:14:16 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9276:c804f3849d63 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Add support for ignored tags for DocBook_IN converter
261 2010-08-02T18:17:02 <diofeher> ThomasWaldmann, ah, if you talking about {{ super() }} call in header, I fixed structure of footer in next commits too
262 2010-08-02T18:24:27 * dreimark thinks meta data should have a section for document specific meta info
263 2010-08-02T18:28:15 <dreimark> moin
264 2010-08-02T18:28:42 <diofeher> moin dreimark ^^
265 2010-08-02T18:40:51 <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9241:b2f8fd8dc4d3 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/show.html: [templating] change text of footer (put revision)
266 2010-08-02T18:44:11 <diofeher> gonna work in this tiny navigation between diffs
267 2010-08-02T18:54:08 * dreimark nothing new from ei-grad
268 2010-08-02T18:55:01 *** ebo^
269 2010-08-02T19:02:49 <dreimark> bbl
270 2010-08-02T19:07:38 <diofeher> navigation working = http://paste.pocoo.org/show/244854/
271 2010-08-02T19:08:19 <ThomasWaldmann> when was your last merge?
272 2010-08-02T19:08:28 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9277:79e72dbc17ff 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Add bibliography and callout elements to the ignored tags list in DocBook_IN converter
273 2010-08-02T19:08:31 <diofeher> hm, i think yesterday
274 2010-08-02T19:08:35 <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9278:95b43f6737e3 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Remove mediaobject from the ignored_tags in the DocBook_IN converter
275 2010-08-02T19:08:56 <ThomasWaldmann> maybe keep that diff, but first merge (with a clean workdir)
276 2010-08-02T19:10:41 <ThomasWaldmann> and the navigation code is not considering boundary conditions
277 2010-08-02T19:11:42 <diofeher> ThomasWaldmann, it's true... i have to treat this
278 2010-08-02T19:15:42 <ThomasWaldmann> also, think about preparing for i18n
279 2010-08-02T19:18:22 <ThomasWaldmann> and dmitry is gone again...
280 2010-08-02T19:20:04 <ThomasWaldmann> http://hg.moinmo.in/moin/2.0-dev-wiki-rest-dandreev/rev/8ed9d1bf845a and this is how revision control does not work
281 2010-08-02T19:20:51 *** DmitryAndreev_
282 2010-08-02T19:20:55 *** DmitryAndreev_
283 2010-08-02T19:21:07 <ThomasWaldmann> hehe, telepathy
284 2010-08-02T19:21:24 <ThomasWaldmann> hi DmitryAndreev
285 2010-08-02T19:21:28 <valeuf> ThomasWaldmann: :)
286 2010-08-02T19:21:54 <ThomasWaldmann> DmitryAndreev: http://hg.moinmo.in/moin/2.0-dev-wiki-rest-dandreev/rev/8ed9d1bf845a how does it come that this is a single commit?
287 2010-08-02T19:21:55 <DmitryAndreev> hello.
288 2010-08-02T19:22:13 <ThomasWaldmann> and what's from juergen hermann? :)
289 2010-08-02T19:22:31 <diofeher> is there any hg command to cleanup workdir?
290 2010-08-02T19:22:51 <ThomasWaldmann> if you want to throw away all changes in workdir it is hg revert --all
291 2010-08-02T19:23:19 <diofeher> ah nice! tks ThomasWaldmann
292 2010-08-02T19:24:18 <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9283:5e173832c27f 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (10 files in 7 dirs): [templating] merge with main repo
293 2010-08-02T19:24:20 <DmitryAndreev> ThomasWaldmann, well, syntax of mediawiki is similar to moinwiki, so i've copied moinwiki_in and commit only when delete and fix difference
294 2010-08-02T19:25:11 <DmitryAndreev> i've leave all authors from moinwiki_in
295 2010-08-02T19:26:14 <DmitryAndreev> i think some of them wrote regexps for moinmoin ver < 2, but used in moinwiki_in converter
296 2010-08-02T19:26:18 <ThomasWaldmann> DmitryAndreev: the dom version is one single commit
297 2010-08-02T19:26:53 <ThomasWaldmann> if you have based it on the other, it would've been nice if it was 1. original copy, 2. .. n. your modifications
298 2010-08-02T19:29:42 <DmitryAndreev> and there would be commit, where deleting a half of the code.) maybe you right, maybe hg cp is better.
299 2010-08-02T19:30:44 <ThomasWaldmann> well, usually one does one thing after the other
300 2010-08-02T19:31:07 <ThomasWaldmann> so, e.g. if you do inline markup first, implement changes for it, commit
301 2010-08-02T19:31:13 <ThomasWaldmann> then lists, tests, commit
302 2010-08-02T19:31:15 <ThomasWaldmann> then ...
303 2010-08-02T19:31:35 <ThomasWaldmann> you don't have to pay for commits :)
304 2010-08-02T19:32:59 <ThomasWaldmann> please don't forget fixing the tests for mediawiki_in, including the docstring line 2
305 2010-08-02T19:34:06 <ThomasWaldmann> why are there tests for * and *_recursive ?
306 2010-08-02T19:34:22 <ThomasWaldmann> shouldn't the tests be mostly the same?
307 2010-08-02T19:34:59 <diofeher> failed to apply patch :S
308 2010-08-02T19:35:26 <ThomasWaldmann> diofeher: sure, because that code isn't there any more
309 2010-08-02T19:35:51 <ThomasWaldmann> look into the view code
310 2010-08-02T19:36:15 <DmitryAndreev> different imports, but same tests. one version (recursive or not) must be deleted.
311 2010-08-02T19:36:26 <DmitryAndreev> version of converter
312 2010-08-02T19:36:33 <DmitryAndreev> and tests for it
313 2010-08-02T19:37:11 <diofeher> changed a lot.. but fixing here
314 2010-08-02T19:37:55 * ThomasWaldmann thinks about from othertest import * ; from thisconverter import Converter<EOF>
315 2010-08-02T19:39:54 <ThomasWaldmann> eSyr: waldi: can you check the code and choose the better implementation?
316 2010-08-02T19:42:42 <ThomasWaldmann> DmitryAndreev: it looks like you duplicated the support code also in mediawiki_in, maybe rather import _Iter and _Stack from the place where you copied it from
317 2010-08-02T19:45:30 <ThomasWaldmann> brb
318 2010-08-02T19:45:49 <DmitryAndreev> ThomasWaldmann, ok. but if somebody delete _Iter and _Stack from moinwiki_in, he would also rewrite mediawiki_in.)
319 2010-08-02T19:46:10 <ThomasWaldmann> that is why we want to have working tests
320 2010-08-02T19:46:34 <valeuf> xorAxAx: I re-organize my wiki page about DocBook converter, because it was getting to big, so I split the information in different page
321 2010-08-02T19:46:40 <ThomasWaldmann> and as the stuff is generic support code, it shouldn't be in moinwiki_in either, but moved to some support module
322 2010-08-02T19:46:55 <valeuf> xorAxAx: check http://moinmo.in/DOM%20DocBook%20and%20HTML%202010/DocBook%20Converter for a starting point
323 2010-08-02T19:49:13 <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9284:be01a10d46ec 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (apps/frontend/views.py templates/show.html): [templating] navigation between versions of item show when +show/<rev>/<itemname> is called
324 2010-08-02T19:49:39 <diofeher> now i have to stylish them
325 2010-08-02T19:49:48 <diofeher> ThomasWaldmann, with boundary now ^^
326 2010-08-02T19:54:51 <valeuf> bbl
327 2010-08-02T20:04:48 <ThomasWaldmann> diofeher: btw, 1.9 has such code already, see action/diff.py there
328 2010-08-02T20:07:45 <diofeher> ThomasWaldmann, hm, i have to show diff or item in rev?
329 2010-08-02T20:08:18 <ThomasWaldmann> item
330 2010-08-02T20:08:55 <ThomasWaldmann> i just mean the navigation code
331 2010-08-02T20:09:52 <ThomasWaldmann> and it looks like that should be some macro/widget kind of thing
332 2010-08-02T20:18:04 <xorAxAx> valeuf: ok
333 2010-08-02T20:18:15 <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9285:8f190f548a42 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (static/modernized/css/common.css templates/show.html): [templating] refactored rev navigation html and put a bit of css
334 2010-08-02T20:20:20 <diofeher> ThomasWaldmann, ah ok... but navigation code is working well ^^ (i think :) )
335 2010-08-02T20:22:00 <ThomasWaldmann> diofeher: if you stull is in a good state, then tell so, so i can merge it back
336 2010-08-02T20:22:12 <ThomasWaldmann> stuff* :)
337 2010-08-02T20:29:46 <diofeher> ThomasWaldmann, k ^^
338 2010-08-02T20:29:47 <diofeher> brb
339 2010-08-02T20:34:55 <ThomasWaldmann> waldi: http://paste.pocoo.org/show/244895/ is that the right way to fix it or is there some better way?
340 2010-08-02T20:36:22 <ThomasWaldmann> image_in converter would then get '/+get/'+itemname for the src attr url
341 2010-08-02T20:45:27 <ThomasWaldmann> hmm, for 'wiki', this works, for 'wiki.local' it doesn't work that way
342 2010-08-02T20:45:41 <waldi> no, this is not
343 2010-08-02T20:46:32 <waldi> the urls references items and several parts assumes that. any additional information needs to go into the query string or so
344 2010-08-02T20:46:50 <ThomasWaldmann> abuse query part? __do__='get'?
345 2010-08-02T20:47:51 <ThomasWaldmann> or '+get'
346 2010-08-02T20:48:08 <waldi> the query part can already contain things
347 2010-08-02T20:48:25 <ThomasWaldmann> sure, but unlikely __foo__
348 2010-08-02T20:48:43 <waldi> yes
349 2010-08-02T20:49:08 <ThomasWaldmann> and of course the link converter would remove it from the Iri
350 2010-08-02T20:50:13 <ThomasWaldmann> maybe just do='get', that would be compatible with 1.9 for direct attachment download then
351 2010-08-02T20:51:03 <ThomasWaldmann> with the only downside that we can not use do=... for something else
352 2010-08-02T20:53:44 <diofeher> have to go to college now :/ brb
353 2010-08-02T20:59:52 <waldi> ThomasWaldmann: it have to, because it needs to handle it
354 2010-08-02T21:16:16 *** eSyr
355 2010-08-02T21:23:38 *** eSyr
356 2010-08-02T22:11:02 *** ebo^
357 2010-08-02T22:11:25 *** ebo^
358 2010-08-02T22:12:37 <valeuf> Still a lot of wait, but the coverage is going faster ^ ^ http://moinmo.in/DOM%20DocBook%20and%20HTML%202010/DocBook-DOM%20Equivalences
359 2010-08-02T22:13:40 <dreimark> re
360 2010-08-02T22:16:06 <dreimark> ThomasWaldmann: do we need to take care on 1.9 compatibility for attachments do=get
361 2010-08-02T22:16:19 <dreimark> they are gone.
362 2010-08-02T22:21:04 <dreimark> DmitryAndreev: http://hg.moinmo.in/moin/2.0-dev-wiki-rest-dandreev/rev/8ed9d1bf845a why don't you have copyright?
363 2010-08-02T22:24:19 <dreimark> ThomasWaldmann: +get my vote no compatiblity flags when everything else is changed
364 2010-08-02T22:24:20 <DmitryAndreev> dreimark, lost while copying .) thx
365 2010-08-02T22:24:57 <dreimark> DmitryAndreev: do you have seen my comments on irc to pring statements in tests yesterday
366 2010-08-02T22:25:11 <dreimark> and also the coverage settings?
367 2010-08-02T22:25:32 <DmitryAndreev> dreimark, yes.
368 2010-08-02T22:25:57 <DmitryAndreev> and about not rewrite file
369 2010-08-02T22:26:51 <dreimark> ok, don't make a mass fix commit for all
370 2010-08-02T22:27:44 <dreimark> and everything, parts fixed changesets of similiar issues are welcome
371 2010-08-02T22:27:51 * ThomasWaldmann works on link converter
372 2010-08-02T22:27:52 <dreimark> e.g. removing all prints in one
373 2010-08-02T22:29:19 <DmitryAndreev> dreimark, like "rename variable 'file'"?
374 2010-08-02T22:29:40 <dreimark> DmitryAndreev: yes
375 2010-08-02T22:31:55 <dreimark> after you are satisfied with the tests please merge moin-2.0-dev
376 2010-08-02T22:32:42 <dreimark> testing was fixed there some hours ago
377 2010-08-02T22:33:23 <DmitryAndreev> can i specify a range of lines with changes for file in hg commit?
378 2010-08-02T22:34:56 <dreimark> i don't think this works, but haven't searched for that
379 2010-08-02T22:35:27 <dreimark> usually diffs are based on a file
380 2010-08-02T22:36:01 <ThomasWaldmann> dreimark: tests are fixed? by which changeset?
381 2010-08-02T22:36:34 <dreimark> ThomasWaldmann: py.test runs currently
382 2010-08-02T22:36:35 <valeuf> DmitryAndreev: the best is usually to do hg diff, save the result in a file
383 2010-08-02T22:36:50 <dreimark> i expected valeuf has fixed it and the merge did it for 2.0-dev
384 2010-08-02T22:37:09 <valeuf> DmitryAndreev: then, hg revert on the file you interested and add your change gradually, and commit after each iteration
385 2010-08-02T22:37:21 <valeuf> DmitryAndreev: so you can check mor carefully what you are doing
386 2010-08-02T22:37:31 <valeuf> dreimark: I om not sure we was talking about the same tests ^ ^
387 2010-08-02T22:37:53 <valeuf> dreimark: I just fixed test_smileys which wan broken due to the use of url_for method in the smiley converter
388 2010-08-02T22:38:26 <dreimark> ah ok, sorry i misread that but anyway py.test is not completly broken
389 2010-08-02T22:38:35 <valeuf> dreimark: actually converter tests works ine anyway
390 2010-08-02T22:38:57 <valeuf> however ThomasWaldmann proposed some refactoring based on conftest ^^
391 2010-08-02T22:39:52 <dreimark> 12 failed, 1436 passed, 28 skipped, 2 error in 139.43 seconds
392 2010-08-02T22:40:08 <valeuf> not that bad
393 2010-08-02T22:40:13 * dreimark fixes some pep8 failings
394 2010-08-02T22:40:20 <valeuf> there is a lot of failing tests because of PEP8 failing
395 2010-08-02T22:40:21 <DmitryAndreev> valeuf, good idea, thanks
396 2010-08-02T22:40:22 <valeuf> dreimark: :p
397 2010-08-02T22:42:48 <dreimark> what is print >> ?
398 2010-08-02T22:43:18 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9275:2dd287192989 2.0-dev/MoinMoin/converter2/ (link.py nonexistent_in.py):
399 2010-08-02T22:43:18 <CIA-50> link converter: if a Iri has do=xxx in query, remove it, prepend +xxx/ to item name in path
400 2010-08-02T22:43:18 <CIA-50> nonexistent_in converter: use do=modify qs
401 2010-08-02T22:43:31 <dreimark> from . import default_registry ??
402 2010-08-02T22:44:04 <valeuf> dreimark: from . import default_registry is from waldi design, to import the registry for the factory pattern
403 2010-08-02T22:44:25 <valeuf> dreimark: default_registry in defined in the __init__.py of the module, which explain the from .
404 2010-08-02T22:45:13 <ThomasWaldmann> dreimark: py.test fails rather fundamentally for me
405 2010-08-02T22:45:26 <ThomasWaldmann> if it doesn't for you, clean your workdir :)
406 2010-08-02T22:45:52 <ThomasWaldmann> waldi: ^^
407 2010-08-02T22:47:09 <valeuf> ThomasWaldmann: does not fail here :p
408 2010-08-02T22:53:15 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9276:e7dce0e083cf 2.0-dev/MoinMoin/converter2/image_in.py: fix image_in converter url generation
409 2010-08-02T22:53:45 <ThomasWaldmann> yay! :)
410 2010-08-02T22:55:27 <ThomasWaldmann> E ImportError: No module named wsgiapp
411 2010-08-02T22:55:34 <ThomasWaldmann> how does this work for you?
412 2010-08-02T22:55:52 * ThomasWaldmann just runs py.test from workdir
413 2010-08-02T22:56:13 <valeuf> ThomasWaldmann: ok :p I had still the pyc file :p
414 2010-08-02T22:56:18 <ThomasWaldmann> the flask import is also failing, but that can be fixed by sys.path
415 2010-08-02T22:57:01 <valeuf> yerk, I deleted the file and now I cannot run any test, it is really annyoing
416 2010-08-02T22:57:08 <valeuf> ThomasWaldmann: any clue to fix that?
417 2010-08-02T22:58:33 <ThomasWaldmann> by putting quite some work into conftest.py etc.
418 2010-08-02T22:59:03 <ThomasWaldmann> anyone feel free :)
419 2010-08-02T22:59:12 * ThomasWaldmann works on converters :)
420 2010-08-02T22:59:31 <CIA-50> Reimar Bauer <rb.proj AT googlemail DOT com> default * 9277:a7b531904782 2.0-dev/MoinMoin/ (7 files in 7 dirs): PEP8 whitespace fix
421 2010-08-02T22:59:33 <CIA-50> Reimar Bauer <rb.proj AT googlemail DOT com> default * 9278:1073f21f398d 2.0-dev/MoinMoin/_tests/test_sourcecode.py: test_sourcecode: adjusted the path for static files
422 2010-08-02T22:59:35 <CIA-50> Reimar Bauer <rb.proj AT googlemail DOT com> default * 9279:796ecb9f6dd9 2.0-dev/MoinMoin/converter2/ (image_in.py link.py nonexistent_in.py): merged main
423 2010-08-02T23:00:06 <ThomasWaldmann> yay, image transclusion works
424 2010-08-02T23:00:57 <ThomasWaldmann> {{pngitem|works|&w=100,&h=100}}
425 2010-08-02T23:05:12 <grzywacz> O_o;
426 2010-08-02T23:05:28 <dreimark> ronny: do you have started refactoring moin-2.0 conftest already?
427 2010-08-02T23:05:33 <dreimark> hi grzywacz
428 2010-08-02T23:05:43 <grzywacz> hey dreimark
429 2010-08-02T23:06:48 <dreimark> do you like to work on some moin related project?
430 2010-08-02T23:07:01 <dreimark> e.g. jabber for moin-2?
431 2010-08-02T23:07:23 <grzywacz> Does anyone need it?
432 2010-08-02T23:09:06 <dreimark> some people do, current moin core not. but while we refactor all other parts we should not rip to much communication parts
433 2010-08-02T23:09:23 <dreimark> from the future of moin
434 2010-08-02T23:10:08 <grzywacz> Does anyone use the current impl?
435 2010-08-02T23:10:10 <grzywacz> ;)
436 2010-08-02T23:12:17 <valeuf> ThomasWaldmann: how would use the image transclusion in docbook document?
437 2010-08-02T23:12:31 <valeuf> ThomasWaldmann: can I use something like wiki:///myPics ?
438 2010-08-02T23:14:09 <grzywacz> Anyway, night.
439 2010-08-02T23:14:28 *** grzywacz
440 2010-08-02T23:15:26 <dreimark> gn
441 2010-08-02T23:18:44 <ronny> dreimark: nop
442 2010-08-02T23:21:36 <ThomasWaldmann> valeuf: you just transclude an image item
443 2010-08-02T23:22:06 <ThomasWaldmann> query='do=get' is important if you just want the raw image url
444 2010-08-02T23:30:23 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9280:34c24b3264d8 2.0-dev/MoinMoin/converter2/creole_in.py: creole converter: fix transclusion, make it similar to link
445 2010-08-02T23:30:25 <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9281:13cdd0384cbd 2.0-dev/MoinMoin/ (8 files in 8 dirs): merged main
446 2010-08-02T23:33:00 <valeuf> ThomasWaldmann: ok I will try tomorrow, I am on something else
447 2010-08-02T23:38:27 *** ebo^
448 2010-08-02T23:44:31 <ThomasWaldmann> hmm, transclusion needs to work differently
449 2010-08-02T23:45:34 <ThomasWaldmann> currently, it emits a <object data="target_get_url">
450 2010-08-02T23:46:30 <ThomasWaldmann> works ok for images, but browsers are too stupid for lots of other stuff
451 2010-08-02T23:47:33 <ThomasWaldmann> so I think what it really needs (for internal wiki items, for external URLs there is no big choice),
452 2010-08-02T23:48:49 <ThomasWaldmann> is to call the converter for the target item, get the dom tree and include it in place
453 2010-08-02T23:50:18 <ThomasWaldmann> then we can transclude python listings, tar listing, images, other wiki pages, ...
454 2010-08-02T23:51:34 <ThomasWaldmann> does that sound ok? :)
455 2010-08-02T23:59:32 <ThomasWaldmann> valeuf: i guess we have to move around internal_repr again :)
