1 2011-07-23T01:25:50 <dreimark> ThomasWaldmann: http://test.moinmo.in/preview in that quality we can use webkit2png for previews
2 2011-07-23T01:27:32 <dreimark> at the time it is avalable it can be used e.g. on RC mouse over
3 2011-07-23T01:27:47 <dreimark> or at index as a thumbnail
4 2011-07-23T01:28:20 <dreimark> I try to find out how fast it is on a server
5 2011-07-23T01:30:13 <dreimark> it is also interesting for a future arnica if we want something for all kind of items
6 2011-07-23T01:30:23 <dreimark> +like that
7 2011-07-23T01:47:55 *** brunomartin
8 2011-07-23T05:59:29 *** MattMaker
9 2011-07-23T07:38:09 <Marchael> moin
10 2011-07-23T07:38:24 <Marchael> ThomasWaldmann: oh, great thanks!
11 2011-07-23T07:42:47 <Marchael> ThomasWaldmann: but what about access to Item class, iirc I can't access to revisions content at moin start up
12 2011-07-23T08:36:01 *** pkumar
13 2011-07-23T08:54:21 <dreimark> ThomasWaldmann: ckeditor seems not to work
14 2011-07-23T08:54:35 <dreimark> I try to fix that
15 2011-07-23T08:55:31 <dreimark> hmm strange - may be cache
16 2011-07-23T10:35:49 *** pkumar
17 2011-07-23T11:20:30 <ThomasWaldmann> moin
18 2011-07-23T11:21:06 <ThomasWaldmann> Marchael: see that new function in MoinMoin/converter/__init__.py (merge main repo)
19 2011-07-23T11:22:11 <Marchael> ThomasWaldmann: hm, this function can access to item content?
20 2011-07-23T11:29:08 <ThomasWaldmann> you give the rev to it
21 2011-07-23T11:29:49 <Marchael> ok
22 2011-07-23T11:39:26 *** raignarok
23 2011-07-23T12:03:52 <ThomasWaldmann> dreimark: the xstatic package has a newer ckeditor than what we used before, so maybe clear the cache
24 2011-07-23T13:54:11 *** pkumar
25 2011-07-23T14:47:05 <ThomasWaldmann> waldi: i am thinking about whether we should have some converter-chain lookup in the registry, with some sort of mode for what we want the converter chain
26 2011-07-23T14:49:17 <ThomasWaldmann> e.g. lookup('text/x-rst', 'text/plain') would return chained rst -> dom -> plain converters
27 2011-07-23T14:57:22 *** pkumar
28 2011-07-23T16:34:23 <Marchael> ThomasWaldmann: seems like I found reason why highlighting fails for item_name_analyzer()
29 2011-07-23T16:44:36 <Marchael> as you remember I used IntraWordFilter working in one of two modes "index" or "query". And for using this analyzer one of them must be specified. But, when whoosh do highlighting it don't know about "mode"
30 2011-07-23T16:45:07 <Marchael> s/I used//
31 2011-07-23T16:57:24 *** pkumar
32 2011-07-23T16:59:15 <ThomasWaldmann> Marchael: can you point at some place in the whoosh src where it goes wrong?
33 2011-07-23T17:00:33 <Marchael> sec
34 2011-07-23T17:01:44 <Marchael> ThomasWaldmann: 540 in highlights.py
35 2011-07-23T17:01:56 <Marchael> tokens = copyandmatchfilter(termset, analyzer(text, chars=True,
36 2011-07-23T17:01:56 <Marchael> keeporiginal=True))
37 2011-07-23T17:02:16 <Marchael> so tokenks always will be ''
38 2011-07-23T17:03:40 * ThomasWaldmann looks
39 2011-07-23T17:04:02 <Marchael> so for other types it won't fail
40 2011-07-23T17:05:23 <Marchael> ThomasWaldmann: may be write small path to whoosh which pass "mode" to highlights?
41 2011-07-23T17:05:47 <Marchael> I try first
42 2011-07-23T17:10:46 <ThomasWaldmann> if you know how to fix it, show a patch including an explanation why it is correct
43 2011-07-23T17:17:52 <Marchael> ThomasWaldmann: yes, it's working!
44 2011-07-23T17:18:16 <Marchael> hm, but how I can export it?
45 2011-07-23T17:19:19 <ThomasWaldmann> diff original modified
46 2011-07-23T17:19:25 <ThomasWaldmann> diff -u original modified
47 2011-07-23T17:19:55 <Marchael> ok, I try
48 2011-07-23T17:24:18 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/444900/
49 2011-07-23T17:24:49 <Marchael> it's quite simple
50 2011-07-23T17:32:31 <ThomasWaldmann> yeah, but rather big patch and no docstrings for mode param. please file a whoosh bug for this.
51 2011-07-23T17:33:32 <ThomasWaldmann> maybe a smaller patch would be as good, because only mode='query' makes sense here? so one could also hardcode it in line 541.
52 2011-07-23T17:33:34 <Marchael> ok, I'll do it
53 2011-07-23T17:33:54 <ThomasWaldmann> matt shall decide this
54 2011-07-23T17:34:23 <Marchael> hm, but I guess he doesn't accept this because it for 1.8.4
55 2011-07-23T17:35:08 <Marchael> so I think that I should update whoosh to 2.0 first
56 2011-07-23T17:35:21 <ThomasWaldmann> if he did not fix it meanwhile, it'll likely be there in 2.0 also
57 2011-07-23T17:39:45 <ThomasWaldmann> same problem in whoosh2
58 2011-07-23T17:41:12 <Marchael> hm, before I submit bug I'll update to 2.0
59 2011-07-23T17:50:21 *** pkumar
60 2011-07-23T17:51:12 *** greg_f
61 2011-07-23T17:51:22 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 09d1d55dc8e6 r349 moin-2.0/setup.py: Update whoosh to 2.0
62 2011-07-23T17:52:49 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 5158f027bb3f r350 moin-2.0/MoinMoin/ (converter/__init__.py apps/frontend/views.py): (log message trimmed)
63 2011-07-23T17:52:49 <CIA-114> use converters to convert a rev to indexable content
64 2011-07-23T17:52:49 <CIA-114> revision data may contain all sorts of content-types, e.g.:
65 2011-07-23T17:52:49 <CIA-114> - markup text (moin, creole, docbook, rst, html, ...)
66 2011-07-23T17:52:49 <CIA-114> - plain text (code, docs, ...)
67 2011-07-23T17:52:50 <CIA-114> - images, audio
68 2011-07-23T17:52:51 <CIA-114> - archives and other binary stuff
69 2011-07-23T17:52:51 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 72009982fc8d r351 moin-2.0/MoinMoin/converter/ (__init__.py text_out.py): add a dom -> text/plain output converter, use it to create indexable content
70 2011-07-23T17:52:52 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 369af927b0a8 r352 moin-2.0/MoinMoin/ (3 files in 2 dirs): Merged
71 2011-07-23T18:01:47 <ThomasWaldmann> i get tracebacks with current stuff
72 2011-07-23T18:02:19 <Marchael> could you paste them?
73 2011-07-23T18:04:06 <ThomasWaldmann> did you run "moin" and "moin index"?
74 2011-07-23T18:04:12 <Marchael> yes
75 2011-07-23T18:05:09 <Marchael> My moin started normally
76 2011-07-23T18:05:19 <ThomasWaldmann> http://paste.pocoo.org/show/444917/
77 2011-07-23T18:10:26 <Marchael> i try figure out this
78 2011-07-23T18:14:29 <Marchael> ThomasWaldmann: seems like you doing something wrong because i use fres clone of my repo and it's working.
79 2011-07-23T18:16:07 <Marchael> btw, I don't applied that whoosh-patch
80 2011-07-23T18:18:25 <ThomasWaldmann> i also have a clean repo, but there was still a pre whoosh2 index. after removing that, it works.
81 2011-07-23T18:20:28 <Marchael> ok
82 2011-07-23T18:22:06 <Marchael> ThomasWaldmann: what is pre whoosh2 index?
83 2011-07-23T18:26:16 <ThomasWaldmann> an index from whoosh 1.8.4
84 2011-07-23T18:26:33 <Marchael> ah
85 2011-07-23T18:27:27 <Marchael> mm. index files from 1.8.4 incompatable to 2.0?
86 2011-07-23T18:27:40 <Marchael> s/to/with/
87 2011-07-23T18:28:12 *** pkumar
88 2011-07-23T18:31:00 <Marchael> http://packages.python.org/Whoosh/releases/2_0.html#compatibility
89 2011-07-23T18:31:23 <Marchael> Matt recomends use Index.optimize() for updating old index files
90 2011-07-23T18:33:39 <ThomasWaldmann> i used rm -rf :)
91 2011-07-23T18:33:55 <Marchael> oh, such dirty hack :)
92 2011-07-23T18:39:13 <ThomasWaldmann> btw, except you have reason to do otherwise, you can specify e.g. whoosh >= 2.0.0
93 2011-07-23T18:41:05 <ThomasWaldmann> and check if whoosh184-fix.patch is still required, if not hg rm it
94 2011-07-23T18:41:38 <Marchael> ok
95 2011-07-23T18:47:33 <ThomasWaldmann> (and add a new patch for the stuff you discovered until it is fixed upstream)
96 2011-07-23T18:48:16 <Marchael> hm, I cloned whoosh repo and made changes but don't see them in hg diff
97 2011-07-23T18:50:19 * Marchael looks in wrong repo
98 2011-07-23T18:51:03 <Marchael> ehrn, I patched old whoosh =\
99 2011-07-23T18:52:26 *** raignarok
100 2011-07-23T19:03:33 <Marchael> ThomasWaldmann: this is a patch http://paste.pocoo.org/show/444936/
101 2011-07-23T19:08:31 <ThomasWaldmann> as i said...
102 2011-07-23T19:08:55 <Marchael> I added docstring
103 2011-07-23T19:08:59 <ThomasWaldmann> for just locally fixing until something is done upstream, you could also do that simpler fix
104 2011-07-23T19:09:03 <Marchael> s/docstring/comment/
105 2011-07-23T19:09:13 <Marchael> yes
106 2011-07-23T19:09:39 <ThomasWaldmann> and the comment is wrong
107 2011-07-23T19:10:26 <Marchael> what wrong with that?
108 2011-07-23T19:11:17 <ThomasWaldmann> you are referring to a specific problem case, but that is not relevant there
109 2011-07-23T19:11:39 <ThomasWaldmann> so the comment is not really needed
110 2011-07-23T19:11:55 <Marchael> ok I'll remove it.
111 2011-07-23T19:11:56 <ThomasWaldmann> but the check should be "if mode is not None"
112 2011-07-23T19:12:23 <ThomasWaldmann> btw, in whoosh mode is often defaulted to ''
113 2011-07-23T19:12:57 <Marchael> ok
114 2011-07-23T19:12:59 <ThomasWaldmann> but don't waste too much time on this, matt can fix that better. just write a reasonable bug report.
115 2011-07-23T19:35:38 *** raignarok
116 2011-07-23T19:37:40 <Marchael> ThomasWaldmann: https://bitbucket.org/mchaput/whoosh/issue/156/with-patch-highlighting-fails-for
117 2011-07-23T19:43:55 *** greg_f
118 2011-07-23T20:11:12 <Marchael> Old bugs gone, but new incoming
119 2011-07-23T20:11:37 <Marchael> now I can't use masks like *,? in search query =\
120 2011-07-23T20:14:09 <Marchael> something tells me that search start working worstly
121 2011-07-23T20:14:43 *** sinha
122 2011-07-23T20:15:22 <Marchael> If I search for "Home" then I can't find "Homeland" or "sweethome"
123 2011-07-23T20:30:47 <Marchael> whoosh using rather strange html markup style for highlighting
124 2011-07-23T20:30:50 <Marchael> <b class="match term0">Home</b>
125 2011-07-23T20:31:43 <Marchael> so I just see <b class="match term0">Home</b>
126 2011-07-23T20:31:52 <Marchael> instead of bold "Home"
127 2011-07-23T20:55:36 *** pkumar
128 2011-07-23T21:08:35 <Marchael> ThomasWaldmann: whoosh returns <b class="match term0">Home</b> and I see it on searh result page, but how I can point flatland to show me bold "Home"?
129 2011-07-23T21:09:08 <Marchael> it's just show me markup instead of bold "Home"
130 2011-07-23T21:20:01 <Marchael> gn/bbl
