1 2011-08-02T00:26:18 <dreimark> ThomasWaldmann: http://hg.moinmo.in/moin/2.0/file/7ed1945aeb03/MoinMoin/items/__init__.py#l1082
2 2011-08-02T00:27:06 <dreimark> we have at Image item_registry.register(Image._factory, Type('image/*'))
3 2011-08-02T00:27:58 <dreimark> what makes the selection.
4 2011-08-02T00:29:48 <ThomasWaldmann> iirc it chooses the more special match
5 2011-08-02T01:02:20 *** Marchael
6 2011-08-02T05:54:52 *** Marchael
7 2011-08-02T05:56:36 <Marchael> moin
8 2011-08-02T06:39:53 *** m4k3r
9 2011-08-02T08:05:56 *** pkumar
10 2011-08-02T08:17:40 *** brunomartin
11 2011-08-02T08:43:33 *** raignarok
12 2011-08-02T09:06:58 <dreimark> moin
13 2011-08-02T10:04:38 *** m4k3r_
14 2011-08-02T10:06:06 *** m4k3r
15 2011-08-02T10:19:41 *** m4k3r
16 2011-08-02T10:19:46 *** m4k3r_
17 2011-08-02T10:21:27 *** Marchael
18 2011-08-02T10:25:09 *** brunomartin
19 2011-08-02T10:34:46 *** m4k3r_
20 2011-08-02T10:37:44 *** m4k3r
21 2011-08-02T10:39:59 *** m4k3r_
22 2011-08-02T10:41:59 *** m4k3r
23 2011-08-02T10:43:40 *** pkumar
24 2011-08-02T10:48:08 *** pkumar
25 2011-08-02T10:53:40 *** pkumar
26 2011-08-02T10:57:37 *** m4k3r_
27 2011-08-02T10:59:10 *** m4k3r
28 2011-08-02T10:59:40 *** pkumar
29 2011-08-02T11:06:31 *** pkumar
30 2011-08-02T11:09:02 *** Marchael
31 2011-08-02T11:39:31 *** greg_f
32 2011-08-02T11:50:13 *** greg_f
33 2011-08-02T11:50:55 *** greg_f
34 2011-08-02T12:13:36 *** m4k3r_
35 2011-08-02T12:14:12 *** m4k3r
36 2011-08-02T12:19:03 *** sinha
37 2011-08-02T12:19:41 *** m4k3r
38 2011-08-02T12:24:29 *** m4k3r
39 2011-08-02T12:32:46 *** m4k3r_
40 2011-08-02T12:34:52 *** m4k3r
41 2011-08-02T12:44:37 *** m4k3r
42 2011-08-02T12:46:05 *** m4k3r_
43 2011-08-02T12:54:25 *** m4k3r_
44 2011-08-02T12:55:57 *** m4k3r
45 2011-08-02T13:20:06 *** m4k3r_
46 2011-08-02T13:21:01 *** m4k3r
47 2011-08-02T13:34:45 <ThomasWaldmann> Marchael: what are you working on currently?
48 2011-08-02T13:40:27 <Marchael> mm, I wait your comments to http://codereview.appspot.com/4808067
49 2011-08-02T13:40:42 <Marchael> I posted traceback yerstaday
50 2011-08-02T13:41:23 *** m4k3r_
51 2011-08-02T13:43:34 *** m4k3r
52 2011-08-02T13:49:18 <ThomasWaldmann> Marchael: we already talked about that you never should wait for something. if you can't continue on something without feedback, just work on something else meanwhile.
53 2011-08-02T13:52:54 <CIA-114> Akash Sinha <akash2607@gmail.com> * db121105bbc3 r345 default/MoinMoin/ (3 files in 3 dirs): updated file upload script, drag and drop zone is changed to entire white area.
54 2011-08-02T13:53:28 <ThomasWaldmann> Marchael: review done
55 2011-08-02T13:54:11 <ThomasWaldmann> btw, I think you should do more self-review. I am sure you can find the trivial stuff yourself.
56 2011-08-02T13:55:25 <ThomasWaldmann> just use hg diff | less often and ask yourself "is this what I really want?", "is this complete?", "did I change something unrelated / unwanted / accidentally?"
57 2011-08-02T13:55:59 <sinha> dreimark: there is still some bug in sending the uniques files only, what i am doing is i am saving the filenames which are selected for upload, and when all upload is done, i am clearing the filenames, but it got some issues, how about i do it this way, on a page one can upload unique files unless he refeshes the page again (here i wont be clearing the fileNames array ) ?
58 2011-08-02T14:09:04 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 302:3a4d2982006f 2.0/MoinMoin/storage/ (8 files in 3 dirs):
59 2011-08-02T14:09:04 <CIA-114> storage Revisions (NewRevision as well as StoredRevision) now support read/seek/tell
60 2011-08-02T14:09:04 <CIA-114> added test for read / seek / tell (for NewRevision as well as for StoredRevision)
61 2011-08-02T14:09:04 <CIA-114> sqlalchemy backend is a bit broken still, added a comment there.
62 2011-08-02T14:09:04 <CIA-114> fileserver and flatfile backends: added missing tell()
63 2011-08-02T14:09:05 <CIA-114> fs: set rev._datastart attr for NewRevision
64 2011-08-02T14:09:06 <CIA-114> fs2: fixed mode to wb+ so that read is also possible (after seek)
65 2011-08-02T14:09:15 <ThomasWaldmann> Marchael: ^^
66 2011-08-02T14:09:26 *** m4k3r_
67 2011-08-02T14:09:51 * Marchael looks
68 2011-08-02T14:10:04 <dreimark> sinha: you mean if there are alredy existing items which you can overwrite withe uploading new ones?
69 2011-08-02T14:10:32 <dreimark> this is a feature and likly welcome, we should be able to create a new revision this way
70 2011-08-02T14:10:37 <sinha> no not that
71 2011-08-02T14:10:39 *** m4k3r
72 2011-08-02T14:10:50 <sinha> as you earlier said to just send unique files on a upload
73 2011-08-02T14:11:04 <sinha> so i added some check in the script
74 2011-08-02T14:11:19 <sinha> but there are other cases which werent handled (plugin works differently)
75 2011-08-02T14:11:53 <dreimark> ok, try to rephrase this part. how or where
76 2011-08-02T14:12:05 <Marchael> ThomasWaldmann: I'll merge with your repo after dealing with acl
77 2011-08-02T14:12:32 <sinha> so what i am saying is to implement this, on being on index page user can only upload the unique files, suppose i uploaded "file1" then i try to upload "file1" it will restrict it unless user refreshes the page
78 2011-08-02T14:13:20 <sinha> what we hae now is, for the upload, if i select "file1" and again i wish to select "file1", then this selection wont happen
79 2011-08-02T14:13:30 <sinha> /s/hae/have
80 2011-08-02T14:13:32 <dreimark> ok, currently we don't use the message bar to give this hint
81 2011-08-02T14:13:48 <sinha> no
82 2011-08-02T14:14:04 <sinha> but the current solution fails in some cases
83 2011-08-02T14:15:43 <dreimark> i understand it didn't clear the state before the next request
84 2011-08-02T14:16:43 <dreimark> and we have to describe this.
85 2011-08-02T14:17:32 <sinha> so as you have seen i am saving the fileNames in an array and i am clearing this when a all file in queue is uploaded
86 2011-08-02T14:17:48 <sinha> for that i used the onCompleteAll handler
87 2011-08-02T14:18:21 <sinha> but plugin is calling this onCompleteAll handler when any file in queue is getting uploaded and thus my Array containing fileNames get cleared
88 2011-08-02T14:18:37 <sinha> so what i am suggesting now is, i dont clear this fileName array anywhere, is it ok ?
89 2011-08-02T14:19:05 <dreimark> so it starts with an empty one on a new request only?
90 2011-08-02T14:19:09 <sinha> yes
91 2011-08-02T14:19:26 <sinha> but yet this may got some issue
92 2011-08-02T14:19:55 <sinha> when someone just selects the filename and dont upload it, then its entry remain there
93 2011-08-02T14:20:21 <dreimark> can we remove the uploaed name from the list?
94 2011-08-02T14:20:54 <dreimark> if everything is uploaded the list is also empty
95 2011-08-02T14:21:20 <dreimark> if he adds more files before all is uploaded the list becomes longer
96 2011-08-02T14:22:32 <dreimark> if he selects some from the list only these becomes removed
97 2011-08-02T14:23:04 <sinha> is i am trying to remove the uploaded name when everything is uploaded and for that i am calling onCompleteAll handler which is supposed to call when all is uploaded, but that handler is called by plugin when even a single file gets uploaded
98 2011-08-02T14:23:10 <sinha> s/is/yes
99 2011-08-02T14:23:30 <sinha> and thus here i am getting the problem
100 2011-08-02T14:23:37 <sinha> otherwise everything would have worked fine
101 2011-08-02T14:24:01 <dreimark> I see, another solution could be do allow only all to become uploaded
102 2011-08-02T14:24:20 <dreimark> and a remove button instead of start
103 2011-08-02T14:24:32 <dreimark> for a single one
104 2011-08-02T14:25:26 <dreimark> ThomasWaldmann: you have introduced index2 jfu, do you want on each file the upload start button?
105 2011-08-02T14:26:16 <dreimark> I dislike this a bit. Cancel for removing is ok, and a start all?
106 2011-08-02T14:28:56 <sinha> yes and on cancel i have to remove the respective entries
107 2011-08-02T14:29:29 <dreimark> yes, I think that makes the ui easier to understand
108 2011-08-02T14:35:09 <ThomasWaldmann> dreimark: yes, that might be enough
109 2011-08-02T14:35:58 <ThomasWaldmann> the only case when individual start buttons might make sense is if you upload rather large files. but then you still could drop them individually in any order you like
110 2011-08-02T14:37:58 <dreimark> i think you do that, because if it's really a big file it can take long time, and you can do also serialize it by opening more than once this index page
111 2011-08-02T14:38:31 <dreimark> (i am not sure if a internet explorer user gets that idea)
112 2011-08-02T14:39:26 <dreimark> sinha: simplify ui and solve that issue as discussed
113 2011-08-02T14:45:36 <Marchael> ThomasWaldmann; acl tokenizer now doesn't failing for preloaded items
114 2011-08-02T14:46:49 <ThomasWaldmann> just update on CR after your self-review
115 2011-08-02T14:46:57 <Marchael> ok
116 2011-08-02T14:53:10 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4808067/ patchset 3
117 2011-08-02T14:53:13 <Marchael> s/3/2/
118 2011-08-02T14:58:26 <ThomasWaldmann> looks ok. does it work?
119 2011-08-02T15:01:42 <Marchael> yes, but I see different tracebacks related with content indexing http://paste.pocoo.org/show/451176/
120 2011-08-02T15:02:36 <Marchael> so, content looking like 'content': u'ERROR [missing toplevel element]' or 'content': u'no element found: line 1, column 0'
121 2011-08-02T15:05:10 * ThomasWaldmann looks
122 2011-08-02T15:09:01 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 303:1b4842601c98 2.0/MoinMoin/converter/_util.py: decode_data: better exception msg
123 2011-08-02T15:09:11 <ThomasWaldmann> Marchael: maybe that is helpful ^^
124 2011-08-02T15:09:50 <Marchael> ok, I try
125 2011-08-02T15:10:26 *** raignarok
126 2011-08-02T15:11:02 <Marchael> > ... but we got %r" % data
127 2011-08-02T15:11:02 <Marchael> You think what I put non unicode text to content?
128 2011-08-02T15:12:30 <Marchael> ThomasWaldmann:
129 2011-08-02T15:19:29 <Marchael> mm, error is gone :)
130 2011-08-02T15:22:51 <Marchael> http://paste.pocoo.org/show/451191/ there is 4 others
131 2011-08-02T15:27:49 <Marchael> for contenttype text/hml
132 2011-08-02T15:31:35 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 304:bf0319451066 2.0/MoinMoin/converter/__init__.py: convert_to_indexable: also support direct conversion (not used yet)
133 2011-08-02T15:32:37 <ThomasWaldmann> Marchael: why is the error gone?
134 2011-08-02T15:32:58 *** raignarok
135 2011-08-02T15:33:12 <Marchael> you mean 303 fix?
136 2011-08-02T15:33:38 <ThomasWaldmann> i mean the TypeError you had
137 2011-08-02T15:35:07 <ThomasWaldmann> TypeError: data must be file-like or str (requires contenttype with charset) or unicode
138 2011-08-02T15:35:17 <Marchael> yes
139 2011-08-02T15:36:18 <ThomasWaldmann> did you fix it or why is it gone?
140 2011-08-02T15:36:36 <Marchael> I don't see any Type Errors now
141 2011-08-02T15:37:09 <ThomasWaldmann> start from an empty wiki
142 2011-08-02T15:37:10 <Marchael> no, I don't change anything
143 2011-08-02T15:37:49 <Marchael> I do rm -rf wiki/index* && moin but don't see TE
144 2011-08-02T15:39:08 <Marchael> You can see my latest traceback
145 2011-08-02T15:42:55 <ThomasWaldmann> hm, heisenbugs?
146 2011-08-02T15:46:52 <Marchael> bugs are hiding
147 2011-08-02T15:49:51 <Marchael> I don't know how, but now it's only 1 traceback at start up
148 2011-08-02T15:51:05 <dreimark> thats the meaning of heisenbugs?
149 2011-08-02T15:51:12 <dreimark> s/?//
150 2011-08-02T15:52:14 * Marchael clones repo and try againg
151 2011-08-02T15:52:17 <Marchael> *again
152 2011-08-02T16:07:19 <dreimark> bbl
153 2011-08-02T16:09:37 *** m4k3r
154 2011-08-02T16:11:46 *** m4k3r
155 2011-08-02T16:15:59 <ThomasWaldmann> Marchael: http://en.wikipedia.org/wiki/Unusual_software_bug
156 2011-08-02T16:16:57 * Marchael confused
157 2011-08-02T16:18:00 <Marchael> At first moin run, i don't see errors and noone document content was indexed, at second I see traceback and some documents were indexed
158 2011-08-02T16:18:44 <Marchael> http://paste.pocoo.org/show/451249/ there is second run
159 2011-08-02T16:25:57 <ThomasWaldmann> that is from link processing, you can ignore that for now
160 2011-08-02T16:26:31 <ThomasWaldmann> but you should check why it doesn't index on the first run
161 2011-08-02T16:31:16 <ThomasWaldmann> yay, opendocument converter works :)
162 2011-08-02T16:33:05 <Marchael> ThomasWaldmann: I found what indexing doesn't work for application/docbook+xml, text/x.moin.creole, text/x.moin.wiki
163 2011-08-02T16:33:14 <Marchael> for latest revisions
164 2011-08-02T16:33:21 <Marchael> for all revs working good
165 2011-08-02T16:39:16 <ThomasWaldmann> that shouldn't make a difference
166 2011-08-02T16:47:05 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 305:7bacf8dde354 2.0/MoinMoin/converter/__init__.py: convert_to_indexable: fix syntax error
167 2011-08-02T16:47:06 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 306:46fc28990137 2.0/MoinMoin/converter/opendocument_in.py: add OpenDocument Format (ODF) input converter (currently only for indexing)
168 2011-08-02T16:52:53 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 307:b64ccdece758 2.0/MoinMoin/ (3 files in 2 dirs): define type_text_plain in MoinMoin.util.mime and import it from there
169 2011-08-02T17:34:15 <Marchael> now, it isn't working only for text/x.moin.wiki
170 2011-08-02T17:39:17 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 308:0337d76bd420 2.0/MoinMoin/converter/ (opendocument_in.py xml_in.py): add generic text/xml input converter (for indexing only), reuse code from there in ODF converter
171 2011-08-02T17:39:17 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 309:1fb3bf63594b 2.0/MoinMoin/converter/opendocument_in.py: add support for old openoffice *.sx? formats (same code as we use for ODF)
172 2011-08-02T17:41:14 *** pkumar
173 2011-08-02T17:47:55 <Marchael> for some reason content indexing doesn't work for latest revisions, but I working on it
174 2011-08-02T17:50:38 <pkumar> ThomasWaldmann : please have a look: http://paste.pocoo.org/show/451315/
175 2011-08-02T17:51:13 <pkumar> ThomasWaldmann : what is argument.positional there in line 4
176 2011-08-02T17:51:35 <pkumar> 'positional' to be precise
177 2011-08-02T17:51:37 <pkumar> ?
178 2011-08-02T17:54:33 <ThomasWaldmann> positional arguments are identified by their position (not by their name)
179 2011-08-02T17:55:22 <ThomasWaldmann> that macro is a bit of a hack
180 2011-08-02T17:55:27 <pkumar> so is that code correct there?
181 2011-08-02T17:55:28 <pkumar> it is in macro.GetText
182 2011-08-02T17:55:52 <ThomasWaldmann> looks hackish, but correct
183 2011-08-02T17:56:07 <pkumar> ok, so how do I handle arguments there?
184 2011-08-02T17:56:13 <ThomasWaldmann> btw, meeting in 5 mins
185 2011-08-02T17:56:31 <pkumar> I mean what should I pass the value to arguments there for the tests?
186 2011-08-02T17:57:36 <pkumar> arguments variable *
187 2011-08-02T17:57:42 <ThomasWaldmann> well, maybe some words of a sentence that we have in the translation and that is unlikely to change
188 2011-08-02T17:58:49 <ThomasWaldmann> that "arguments" is the output of some arg parser, you maybe want to use that parser to create it
189 2011-08-02T17:59:53 <ThomasWaldmann> xorAxAx: you are here?
190 2011-08-02T17:59:57 <Marchael> oh, cool. /me increase indexing perfomance
191 2011-08-02T18:00:05 <Marchael> at start up
192 2011-08-02T18:00:45 <ThomasWaldmann> waldi: dreimark: you are here?
193 2011-08-02T18:01:14 *** raignarok
194 2011-08-02T18:02:05 <ThomasWaldmann> hmm, ok, let's begin with today's meeting
195 2011-08-02T18:02:17 <ThomasWaldmann> Marchael: you're first, your stage
196 2011-08-02T18:02:38 <Marchael> hm, I'm not ready yet
197 2011-08-02T18:02:59 <ThomasWaldmann> bad timing :)
198 2011-08-02T18:03:25 <ThomasWaldmann> ok, let's wait a bit until either some more mentors arrive or you are ready
199 2011-08-02T18:06:39 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 05657b355ce4 r368 moin-2.0/MoinMoin/search/ (_tests/test_analyzers.py analyzers.py indexing.py): Fix ACL indexing issue for preloaded items with acl field (thanks brunomartin and Thomas Waldmann)
200 2011-08-02T18:06:40 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 3a4d2982006f r369 moin-2.0/MoinMoin/storage/ (8 files in 3 dirs):
201 2011-08-02T18:06:40 <CIA-114> storage Revisions (NewRevision as well as StoredRevision) now support read/seek/tell
202 2011-08-02T18:06:40 <CIA-114> added test for read / seek / tell (for NewRevision as well as for StoredRevision)
203 2011-08-02T18:06:40 <CIA-114> sqlalchemy backend is a bit broken still, added a comment there.
204 2011-08-02T18:06:40 <CIA-114> fileserver and flatfile backends: added missing tell()
205 2011-08-02T18:06:41 <CIA-114> fs: set rev._datastart attr for NewRevision
206 2011-08-02T18:06:41 <CIA-114> fs2: fixed mode to wb+ so that read is also possible (after seek)
207 2011-08-02T18:06:42 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 1b4842601c98 r370 moin-2.0/MoinMoin/converter/_util.py: decode_data: better exception msg
208 2011-08-02T18:06:42 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * b54d70026e30 r371 moin-2.0/MoinMoin/ (9 files in 4 dirs): merged
209 2011-08-02T18:06:43 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * bf0319451066 r372 moin-2.0/MoinMoin/converter/__init__.py: convert_to_indexable: also support direct conversion (not used yet)
210 2011-08-02T18:06:43 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 7bacf8dde354 r373 moin-2.0/MoinMoin/converter/__init__.py: convert_to_indexable: fix syntax error
211 2011-08-02T18:06:58 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 46fc28990137 r374 moin-2.0/MoinMoin/converter/opendocument_in.py: add OpenDocument Format (ODF) input converter (currently only for indexing)
212 2011-08-02T18:06:58 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * b64ccdece758 r375 moin-2.0/MoinMoin/ (3 files in 2 dirs): define type_text_plain in MoinMoin.util.mime and import it from there
213 2011-08-02T18:06:58 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 1691f2cb863d r376 moin-2.0/MoinMoin/ (4 files in 2 dirs): merged
214 2011-08-02T18:06:58 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 14a9f545934d r377 moin-2.0/MoinMoin/ (search/revision_converter.py storage/backends/indexing.py): Fix issue with content indexing, improve indexing perfomance for runtime and start up
215 2011-08-02T18:07:26 <Marchael> ah
216 2011-08-02T18:09:54 *** raignarok
217 2011-08-02T18:15:12 <pkumar> ThomasWaldmann : how do I know, 'arguments' is the output of which arg parser. I'm not getting it
218 2011-08-02T18:16:53 <ThomasWaldmann> pkumar: look into the macro converter
219 2011-08-02T18:17:30 <pkumar> k, thanks. looking at it
220 2011-08-02T18:18:48 <ThomasWaldmann> pkumar: btw, did you look at that item counts thing from startup yet?
221 2011-08-02T18:21:06 <pkumar> ThomasWaldmann : yeah, will look at it soon once I complete adding tests. I'll swap the task if there is any such requirement. What do you suggest?
222 2011-08-02T18:21:08 *** m4k3r
223 2011-08-02T18:21:13 *** m4k3r
224 2011-08-02T18:22:17 <pkumar> or should I work on it in parallel?
225 2011-08-02T18:30:39 <ThomasWaldmann> pkumar: if a multitasking OS waits for I/O, it schedules another task. you can do the same (I/O = waiting for mentor reply :).
226 2011-08-02T18:31:13 <brunomartin> Marchael: ThomasWaldmann: Great job! :-) I will test load my data here with a fresh clone e give you feedback!
227 2011-08-02T18:31:23 <ThomasWaldmann> Marchael: are you still busy preparing your meeting post?
228 2011-08-02T18:31:43 <Marchael> I ready
229 2011-08-02T18:31:57 <ThomasWaldmann> brunomartin: do you have some documents in your data set?
230 2011-08-02T18:31:57 <pkumar> ThomasWaldmann : hehe, nice example. sure, will do it
231 2011-08-02T18:32:00 <pkumar> :)
232 2011-08-02T18:32:16 <ThomasWaldmann> Marchael: well, we are all waiting for you
233 2011-08-02T18:32:22 <Marchael> Last 2 days I'm working on content indexing and acl issue
234 2011-08-02T18:32:22 <Marchael> great thanks to Thomas Waldmann for writing converters and refactoring Access Control Lists, so I can use it "as is"
235 2011-08-02T18:32:23 <Marchael> Acl indexing working good
236 2011-08-02T18:32:23 <Marchael> Content indexing mostly works well, except some contenttypes.
237 2011-08-02T18:32:23 <Marchael> I don't test my stuff for rebuilding script yet, but do it after meeting.
238 2011-08-02T18:32:23 <Marchael> This week I will working on other issues on bb, showing found content on results page, highlighting and navigation
239 2011-08-02T18:32:23 <Marchael> blocker: none
240 2011-08-02T18:33:38 <ThomasWaldmann> ok, thanks. you should try to allocate more time than last week to catch up the time you lost.
241 2011-08-02T18:34:01 <Marchael> thanks you Thomas :)
242 2011-08-02T18:34:30 <ThomasWaldmann> dreimark: waldi: xorAxAx: someone here or do we have mentor fail this time? :)
243 2011-08-02T18:35:02 <ThomasWaldmann> looks like today's weather is too good in germany :D
244 2011-08-02T18:35:22 <pkumar> :D, here too
245 2011-08-02T18:35:34 <ThomasWaldmann> ok, let's try without them. pkumar, you're next.
246 2011-08-02T18:35:44 <pkumar> k
247 2011-08-02T18:35:50 <pkumar> This week:
248 2011-08-02T18:35:53 <pkumar> Worked on improvement of test coverage listed under hardy89. Added tests to the tests. Mostly required in Item module, as it is a very big code but with very low test coverage. This part of adding tests is over as per now.
249 2011-08-02T18:35:53 <pkumar> Now working on adding tests to the files which don't have any tests.
250 2011-08-02T18:35:53 <pkumar> have added few to macro module
251 2011-08-02T18:35:53 <pkumar> Blockers: None
252 2011-08-02T18:35:53 <pkumar>
253 2011-08-02T18:36:15 <ThomasWaldmann> you added tests to the tests? :)
254 2011-08-02T18:36:51 <pkumar> I meant tests to the files already having few of them
255 2011-08-02T18:37:32 <ThomasWaldmann> ah :) btw, which stuff is untested and on your list?
256 2011-08-02T18:38:05 <ThomasWaldmann> (you do make sure that the stuff is used before adding tests?)
257 2011-08-02T18:38:32 <pkumar> ThomasWaldmann : yeah, I'm tring to make sure that it is being used
258 2011-08-02T18:38:38 <pkumar> trying*
259 2011-08-02T18:39:00 <pkumar> files in macro have no tests I guess
260 2011-08-02T18:39:38 *** raignarok
261 2011-08-02T18:40:33 <ThomasWaldmann> the macro stuff is a bit crappy still anyway. there is a plan since long to unify macros and ... converters.
262 2011-08-02T18:41:09 <pkumar> though, there are lot more files in different modules but it seems a bit tricky to write tests for them
263 2011-08-02T18:41:10 <pkumar> like the tests which depends on users
264 2011-08-02T18:41:30 <pkumar> also, what about code in items.
265 2011-08-02T18:41:42 <pkumar> don't they need to be split?
266 2011-08-02T18:42:16 <ThomasWaldmann> well, one of the major things to do is to make a good tests framework
267 2011-08-02T18:42:36 <ThomasWaldmann> so, if you identified that the framework is lacking, you can put it on your todo :)
268 2011-08-02T18:44:17 <ThomasWaldmann> one of the ideas for this was that tested code runs in a rather similar environment as the code when it is used in production
269 2011-08-02T18:44:45 <xorAxAx> re
270 2011-08-02T18:44:58 <ThomasWaldmann> that includes that some user object is there (and likely a method to tell what kind of user, what user name etc. it is)
271 2011-08-02T18:45:59 <ThomasWaldmann> such general stuff is (IMHO) more important than fixing single tests
272 2011-08-02T18:46:44 <ThomasWaldmann> wb xorAxAx. your student now. :)
273 2011-08-02T18:47:24 <pkumar> ThomasWaldmann : k, also, I was thinking if tests in storage and datastruct need to be changed they way they run
274 2011-08-02T18:47:30 *** raignarok
275 2011-08-02T18:48:05 <pkumar> i.e. most of the files don't run their unique test files but a common one
276 2011-08-02T18:48:25 <pkumar> like test_backend in storage
277 2011-08-02T18:48:45 <ThomasWaldmann> well, if tests are common, that's not that way off
278 2011-08-02T18:49:03 <ThomasWaldmann> but iirc there are tests in there that can't be run on some limited backends
279 2011-08-02T18:49:59 <pkumar> hmm, so for some of the tests in there it seems like they should be separate
280 2011-08-02T18:50:58 <pkumar> xorAxAx : hi
281 2011-08-02T18:51:04 <xorAxAx> hi pkumar
282 2011-08-02T18:51:42 <pkumar> xorAxAx : already pasted my activities.
283 2011-08-02T18:52:00 <xorAxAx> i read it :)
284 2011-08-02T18:52:13 <pkumar> k :)
285 2011-08-02T18:56:53 <ThomasWaldmann> xorAxAx: pkumar: you are finished?
286 2011-08-02T18:57:01 <xorAxAx> yes
287 2011-08-02T18:57:13 <ThomasWaldmann> sinha: dreimark: you are here?
288 2011-08-02T18:57:23 <sinha> yes
289 2011-08-02T18:57:35 *** raignarok
290 2011-08-02T18:58:14 <sinha> i can wait for dreimark arrival
291 2011-08-02T18:58:46 <pkumar> gtg, bbl
292 2011-08-02T18:58:55 <ThomasWaldmann> as he's almost 1h late, I'ld say "just begin"
293 2011-08-02T18:59:17 *** pkumar
294 2011-08-02T18:59:32 <sinha> LAST: i) Worked on unifying the global_index and item index, now we have only 1 index in moin
295 2011-08-02T18:59:32 <sinha> Changeset: https://bitbucket.org/sinha/moin2/changeset/d20568493a93
296 2011-08-02T18:59:33 <sinha> ii) Made some modification in file upload script, now on can drop files in entire white area and also restricting multiple files getting uploaded.
297 2011-08-02T18:59:33 <sinha> Changeset: https://bitbucket.org/sinha/moin2/changeset/db121105bbc3 | https://bitbucket.org/sinha/moin2/changeset/391944573fc3
298 2011-08-02T18:59:33 <sinha> CURRENT: Still need to fix some issues in file upload script, in that part of allowing only unique files to get uploaded. (Will be done it by end of the day).
299 2011-08-02T18:59:33 <sinha> NEXT: Will work on multiple actions thing on index page, first will start with multiple download feature.
300 2011-08-02T19:00:14 <sinha> blocker: currently having this small blocker in this jfu script, i haved added line 3,4 in this http://paste.pocoo.org/show/451341/, dont know what is wrong with this
301 2011-08-02T19:00:56 <sinha> ThomasWaldmann: as we discussed earlier today, it is regarding the unique uploading of files
302 2011-08-02T19:01:23 <ThomasWaldmann> btw, we currently use a not quite current version of j.f-u
303 2011-08-02T19:02:07 <ThomasWaldmann> iirc i tried to update it a while ago, but ran into issues. so, if you have time to look at it, that'ld be welcome.
304 2011-08-02T19:02:39 <sinha> but he made lot of updation to it, and it is working fine for most of the cases
305 2011-08-02T19:02:44 <sinha> s/he/we
306 2011-08-02T19:03:01 <ThomasWaldmann> do you have a current screenshot about how stuff looks like currently?
307 2011-08-02T19:03:14 <sinha> the index page, yes
308 2011-08-02T19:04:41 <ThomasWaldmann> well, in that pastebin, indenting looks wrong
309 2011-08-02T19:05:18 <sinha> this is the current look of index page http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-07-30?action=AttachFile&do=get&target=index.png
310 2011-08-02T19:05:43 <ThomasWaldmann> and i can't comment much on js stuff, not my area of expertise
311 2011-08-02T19:06:05 <sinha> i tried that lines of code in separate function, it is working flawlessly
312 2011-08-02T19:06:22 <sinha> so i am not really getting the idea that why it is stopping there
313 2011-08-02T19:07:48 <ThomasWaldmann> tgz is different icon than tar?
314 2011-08-02T19:09:26 <sinha> i guess i missed that in mapping
315 2011-08-02T19:11:21 <ThomasWaldmann> but looks pretty :)
316 2011-08-02T19:11:49 <sinha> :)
317 2011-08-02T19:15:36 <ThomasWaldmann> btw, the semicolons are not consistent there. does that matter?
318 2011-08-02T19:16:37 <sinha> i dont guess so
319 2011-08-02T19:16:43 <ThomasWaldmann> i mean, should there be one in 8?
320 2011-08-02T19:17:18 <sinha> thats closing braces for "If" block
321 2011-08-02T19:17:39 <ThomasWaldmann> and what's 11? :)
322 2011-08-02T19:17:44 *** m4k3r
323 2011-08-02T19:18:21 <sinha> 11 is for the function getting assigned to that variable
324 2011-08-02T19:18:35 <sinha> its a expression
325 2011-08-02T19:19:09 <sinha> i mean there either we write function name, or just define the function there itslef
326 2011-08-02T19:19:33 * ThomasWaldmann is happy that one does not need ; in python usually
327 2011-08-02T19:19:55 <TheSheep> usually?
328 2011-08-02T19:19:59 <TheSheep> you never need it
329 2011-08-02T19:20:30 <ThomasWaldmann> you need it for one liners :P
330 2011-08-02T19:20:41 <TheSheep> you don't need oneliners
331 2011-08-02T19:20:50 <ThomasWaldmann> usually, yes :)
332 2011-08-02T19:20:51 <TheSheep> but in js semicolons matter a lot
333 2011-08-02T19:20:54 <TheSheep> and commas
334 2011-08-02T19:21:07 <TheSheep> if you miss or add some, it will stop working in msie
335 2011-08-02T19:21:35 <ThomasWaldmann> msie like in 6 or also current ones?
336 2011-08-02T19:22:11 <TheSheep> all of them
337 2011-08-02T19:22:29 <TheSheep> they basically use a different language, jscript
338 2011-08-02T19:22:40 <ThomasWaldmann> hmm, great :|
339 2011-08-02T19:22:47 <ThomasWaldmann> sinha: you test with IE?
340 2011-08-02T19:23:03 <TheSheep> which is very similar to javascript, but is not so forgiving for semicolons and extra commas
341 2011-08-02T19:23:28 <TheSheep> var x = [1, 3, 3,] <-- correct in js, fails in jscript
342 2011-08-02T19:23:39 <sinha> not usually, test for firefox, chrome actually i work on linux, so hard to find IE
343 2011-08-02T19:23:52 <TheSheep> ies4linux
344 2011-08-02T19:24:02 <sinha> maybe try on friend's Pc
345 2011-08-02T19:24:10 <TheSheep> or virtual machine
346 2011-08-02T19:24:26 <sinha> yeah that is also an option
347 2011-08-02T19:26:27 *** raignarok
348 2011-08-02T19:26:53 <ThomasWaldmann> http://moinmo.in/FeatureRequests/WindowsTestSystem see also there, if you can run a VM
349 2011-08-02T19:27:42 <ThomasWaldmann> btw, did someone try a pdf to text python lib recently?
350 2011-08-02T19:30:34 <ThomasWaldmann> http://www.unixuser.org/~euske/python/pdfminer/programming.html haha, see first sentence under "overview".
351 2011-08-02T19:44:11 <Marchael> ThomasWaldmann: http://i.imgur.com/ThsKW.png
352 2011-08-02T19:44:24 <CIA-114> Akash Sinha <akash2607@gmail.com> * 9059f9dedef2 r346 default/MoinMoin/ (3 files in 3 dirs): modification in file upload script, now duplicate files could only be uploaded when either all files in queue are uploaded or all are cancelled.
353 2011-08-02T19:44:58 <Marchael> it's rather draft, but you can see what that stuff working
354 2011-08-02T20:06:34 <Marchael> ThomasWaldmann: http://i.imgur.com/vFZzl.png
355 2011-08-02T20:07:37 *** greg_f
356 2011-08-02T20:12:15 *** m4k3r
357 2011-08-02T20:15:07 <Marchael> brunomartin: you still have this truble https://bitbucket.org/marchael/moin-2.0/issue/5/tiny-indent-bug ?
358 2011-08-02T20:15:17 <Marchael> *trouble
359 2011-08-02T20:15:25 <ThomasWaldmann> Marchael: nice
360 2011-08-02T20:16:18 <Marchael> ThomasWaldmann: as you can see what "docbook" second, but it should be first
361 2011-08-02T20:17:02 <Marchael> may be whoosh have some kind of sorting, I try to find out.
362 2011-08-02T20:17:21 <brunomartin> Marchael: I idented my code here... ;-) just filed to help you....
363 2011-08-02T20:18:23 <brunomartin> Marchael: I will test all these changes on my data tomorrow, and let you know what happens...
364 2011-08-02T20:18:50 <Marchael> brunomartin: hm, may you can help me to reproduce your issue?
365 2011-08-02T20:20:01 <Marchael> I see your traceback, but it doesn't make sense because that code working for me and I don't know what may cause of it.
366 2011-08-02T20:21:05 <brunomartin> Marchael: the command is in the traceback: moin index --for both --action build
367 2011-08-02T20:21:35 <Marchael> yep, I try this
368 2011-08-02T20:22:02 <Marchael> *tried
369 2011-08-02T20:22:10 <brunomartin> Marchael: the only way I could build the index was initializing the moin with rebuild_index=True on wiki config!
370 2011-08-02T20:22:53 <brunomartin> I think your load_data must have revisions on it to reproduce the error..... I think this is not the case of initial data!
371 2011-08-02T20:23:15 <Marchael> you don;t need to write rebuild_index=True in wikiconfig because it's already True
372 2011-08-02T20:24:47 <brunomartin> Marchael: Yeah... often it is set to False here...
373 2011-08-02T20:25:20 <Marchael> hm. I tried this code with load_xml/save_xml/index_rebuild = True/False but I don't saw any errors
374 2011-08-02T20:25:53 <Marchael> may I see your changes in wikiconfig?
375 2011-08-02T20:29:09 <brunomartin> Marchael: does the data you are loading has any version greater than 0?
376 2011-08-02T20:29:32 <Marchael> yep
377 2011-08-02T20:30:44 <brunomartin> Marchael: if you see the second if on MoinMoin/script/maint/index (line 70)
378 2011-08-02T20:34:16 <Marchael> and?
379 2011-08-02T20:35:26 <brunomartin> the variable "rev_no" is not assigned, unless it is inside that "for"
380 2011-08-02T20:37:16 <brunomartin> Marchael: I don't know to reproduce the bug with the initial_data that comes with moin2, but if it enter on that that "if" (if "latest_revisions_index" in indexnames), the exception raises!
381 2011-08-02T20:37:45 <Marchael> intresting
382 2011-08-02T20:39:43 <brunomartin> Marchael: I think the data you are loading hasn't any version greater than 0, cause it should pass there if there is, is that right?
383 2011-08-02T20:42:29 <brunomartin> Marchael: no, its wrong... seens to me that the command moin index --for both --action build should raise that error....
384 2011-08-02T20:42:52 * ThomasWaldmann plays with pdfminer
385 2011-08-02T20:46:59 <Marchael> brunomartin: all items have at least 1 revision, so item.list_revisions() should give at least [0], so rev_no can't be not initialized at 70
386 2011-08-02T20:48:45 * dreimark re
387 2011-08-02T20:49:08 <dreimark> sorry for missing the meeting, same reason for me than last time
388 2011-08-02T20:50:50 <brunomartin> yes, but the (if "latest_revisions_index" in indexnames:) is in the same level as the "for" on line 64, right?! so the rev_no isn't initialized on 70! the "if" on 70 shouldn´t be inside the 64 "for"?
389 2011-08-02T20:53:18 <sinha> dreimark: i tried working on the script for that Cancel thing, something wasnt working properly so tried a different alternative
390 2011-08-02T21:00:11 <dreimark> sinha: ok
391 2011-08-02T21:00:46 <Marchael> brunomartin: i already told you what rev_no initialized in 64, because all items have at least one revision. Seems for me, you use item where item.list_revisions() is []
392 2011-08-02T21:01:53 <Marchael> if you could print item.list_revisions() after 63 then may be we could find out that
393 2011-08-02T21:03:56 <brunomartin> Marchael: maybe its the users! I think the users have no revisions...
394 2011-08-02T21:04:13 <Marchael> ЖВ
395 2011-08-02T21:04:14 <Marchael> :D
396 2011-08-02T21:04:35 <Marchael> user is Item too?
397 2011-08-02T21:04:52 <brunomartin> Marchael: I think everything is an item!
398 2011-08-02T21:05:26 <brunomartin> Marchael: ;-) but I would appreciate to confirm this!!!!
399 2011-08-02T21:05:30 <dreimark> ThomasWaldmann: sinha: i have a general question for this uploading. Does it mean we have a file completly in memory copied before it becomes an item?
400 2011-08-02T21:06:25 <Marchael> hm, my wiki haven't users, so I create one
401 2011-08-02T21:08:46 <Marchael> brunomartin: yes, that's it
402 2011-08-02T21:10:23 <Marchael> hm, we shouldn't index users :)
403 2011-08-02T21:10:36 <brunomartin> Marchael: :-)
404 2011-08-02T21:10:49 <Marchael> ThomasWaldmann: or ?
405 2011-08-02T21:11:07 <Marchael> it can be helpful to find user
406 2011-08-02T21:11:38 <Marchael> we could index only nick
407 2011-08-02T21:12:12 <brunomartin> Marchael: maybe the alias too?
408 2011-08-02T21:12:39 <dreimark> what is the usecase? how is it searched?
409 2011-08-02T21:13:44 <Marchael> dreimark: for example search user:Michael and it search for username Michael and give link to him page
410 2011-08-02T21:14:15 <Marchael> *it seaching
411 2011-08-02T21:15:32 <dreimark> ok
412 2011-08-02T21:15:48 <Marchael> dreimark: we could use same schema, but most of fields will be empty
413 2011-08-02T21:15:57 <Marchael> except userid
414 2011-08-02T21:17:31 <Marchael> ThomasWaldmann: what you think?
415 2011-08-02T21:19:02 <Marchael> We indexed only userid and link to homepage
416 2011-08-02T21:28:16 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 310:41a22e9dae75 2.0/ (setup.py MoinMoin/converter/pdf_in.py): pdf indexable text content extraction using pdfminer
417 2011-08-02T21:29:10 * dreimark looks currently at a fork of mutagen
418 2011-08-02T21:29:29 <ThomasWaldmann> dreimark: i think werkzeug stores big stuff into temp files
419 2011-08-02T21:29:49 <ThomasWaldmann> but some moin code might read it into memory
420 2011-08-02T21:30:59 <ThomasWaldmann> Marchael: we'll need to index users. for internally searching them within moin code.
421 2011-08-02T21:31:19 <Marchael> ok
422 2011-08-02T21:31:49 <ThomasWaldmann> but stay away from users for now
423 2011-08-02T21:31:54 <Marchael> so for searching user we will use userid?
424 2011-08-02T21:32:31 <Marchael> I don't think what it take much time
425 2011-08-02T21:33:04 <ThomasWaldmann> we'll internally need all sort of lookups. e.g. using uid, name, email, ... to find the right user
426 2011-08-02T21:33:27 <ThomasWaldmann> you don't have item metadata indexing at all yet
427 2011-08-02T21:34:20 <Marchael> you mean content?
428 2011-08-02T21:34:23 <ThomasWaldmann> and I am not sure whether we want to keep users in item metadata or maybe rather store them into a single revision
429 2011-08-02T21:34:36 <dreimark> how does this meta indexing work
430 2011-08-02T21:34:38 <ThomasWaldmann> no, i mostly mean what i say :)
431 2011-08-02T21:35:01 <dreimark> e.g. if i read by something like mutagen on file upload some data and save it as meta
432 2011-08-02T21:35:08 <dreimark> can this then used to search for
433 2011-08-02T21:35:29 <dreimark> or is it fixed to the scheme we have currently
434 2011-08-02T21:35:57 <dreimark> currently i think about having the dimension of video and images in meta
435 2011-08-02T21:36:05 <Marchael> hm, if we have converter for that stuff, why not?
436 2011-08-02T21:36:15 <dreimark> the length im seconds for audio and video
437 2011-08-02T21:36:32 <dreimark> and some id tags of uploaded stuff
438 2011-08-02T21:37:33 <Marchael> ThomasWaldmann: then what metadata fields you mean exactly?
439 2011-08-02T21:41:18 <ThomasWaldmann> you don't have item metadata indexing yet, so you have none
440 2011-08-02T21:42:05 <ThomasWaldmann> (what you have is revision metadata (and data) indexing, in case that is still unclear)
441 2011-08-02T21:52:23 <Marchael> ThomasWaldmann: then what is item metadata?
442 2011-08-02T22:02:45 <Marchael> gn/bbl
443 2011-08-02T22:05:31 *** raignarok_
444 2011-08-02T22:09:34 *** raignarok
445 2011-08-02T22:16:08 <dreimark> sinha: do we need the green area?
446 2011-08-02T22:17:53 <sinha> dreimark: maybe not, but it just to show you can upload files there
447 2011-08-02T22:20:56 <dreimark> currently it looks ugly, i would prefer we don't need to show that. your file browser don't have that too
448 2011-08-02T22:21:17 <dreimark> sinha: ^
449 2011-08-02T22:21:36 <dreimark> and we are quite close from look and feel to something like this
450 2011-08-02T22:23:13 <dreimark> but it has also the functionality like a button
451 2011-08-02T22:23:26 <dreimark> so you are right we need that
452 2011-08-02T22:23:32 <dreimark> the blue color looks better
453 2011-08-02T22:23:47 <dreimark> sinha: may be later it can be moved to a menu
454 2011-08-02T22:23:52 <sinha> blue look consistent with Moin theme/color
455 2011-08-02T22:24:03 <sinha> the upload to menu ?
456 2011-08-02T22:24:48 <dreimark> to the edit bar
457 2011-08-02T22:25:27 <dreimark> where Index is also located
458 2011-08-02T22:28:13 *** brunomartin
459 2011-08-02T22:28:36 <dreimark> sinha: do you have checked non ascii chars in filenames to upload?
460 2011-08-02T22:31:11 <sinha> dreimark: there is something wrong in my last changeset
461 2011-08-02T22:31:28 <sinha> i have removed that "Start thing", and file isnt getting uploaded
462 2011-08-02T22:31:36 <sinha> i am fixing this asap
463 2011-08-02T22:31:44 <dreimark> ok. i wait for the fix, seeing that too
464 2011-08-02T22:33:18 <sinha> dreimark: actually the individual start was responsible for uploading the files, and that Start All is trigerring click on these individual Start button
465 2011-08-02T22:34:20 <dreimark> ouch, is hiding an option?
466 2011-08-02T22:36:26 <sinha> things arent working on hiding
467 2011-08-02T22:36:54 <dreimark> minimize?
468 2011-08-02T22:37:05 <dreimark> close to invisible
469 2011-08-02T22:37:22 <sinha> yes trying visibility as hidden
470 2011-08-02T22:44:27 <dreimark> ThomasWaldmann: another moin-1.9 problem, http://paste.pocoo.org/show/451504/
471 2011-08-02T22:45:25 <CIA-114> Akash Sinha <akash2607@gmail.com> * 47f7ae3ad658 r347 default/MoinMoin/ (themes/modernized/static/css/common.css templates/forms.html): restored Start button for individual files, but made it invisible
472 2011-08-02T22:53:04 <dreimark> ThomasWaldmann: where do we get md5crypt from ?
473 2011-08-02T23:11:42 *** raignarok_
474 2011-08-02T23:22:01 <ThomasWaldmann> dreimark: from MoinMoin.support, as usual?
475 2011-08-02T23:26:49 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5786:8cb5ab136b87 1.9/MoinMoin/_tests/test_user.py: fix trailing blanks
476 2011-08-02T23:27:15 <dreimark> ThomasWaldmann: then it did not work
477 2011-08-02T23:28:22 <ThomasWaldmann> ???
478 2011-08-02T23:28:30 <dreimark> it is not in search path of standalone
479 2011-08-02T23:29:28 <ThomasWaldmann> you are running some self-written migrate script in that traceback
480 2011-08-02T23:29:34 <dreimark> yes
481 2011-08-02T23:29:40 <dreimark> http://paste.pocoo.org/show/451526/
482 2011-08-02T23:29:58 <dreimark> i tried an example for that user on MM
483 2011-08-02T23:30:04 <dreimark> and it works in 1.9.3
484 2011-08-02T23:30:08 <dreimark> but not in current
485 2011-08-02T23:33:50 <ThomasWaldmann> * [[extended link]] other text
486 2011-08-02T23:33:50 <ThomasWaldmann> * other text [[extended link]]
487 2011-08-02T23:33:50 <ThomasWaldmann> * other text [[extended link]] other text
488 2011-08-02T23:34:02 <ThomasWaldmann> assert u'extended link other text' in members
489 2011-08-02T23:34:02 <ThomasWaldmann> assert u'other text extended link' in members
490 2011-08-02T23:34:02 <ThomasWaldmann> assert u'other text extended link other text' in members
491 2011-08-02T23:34:07 <ThomasWaldmann> sense?
492 2011-08-02T23:35:04 <dreimark> on all other "support" using files we explicity load from MoinMoin.support import ...
493 2011-08-02T23:35:46 <ThomasWaldmann> iirc we usually DON'T
494 2011-08-02T23:36:21 <ThomasWaldmann> it is just added to sys.path early in the normal usage scenario
495 2011-08-02T23:36:27 <dreimark> ThomasWaldmann: 1.9 we do
496 2011-08-02T23:36:53 *** sinha
497 2011-08-02T23:37:49 <dreimark> y
498 2011-08-02T23:38:10 <dreimark> at least on many places, i searched for that
499 2011-08-02T23:38:12 <ThomasWaldmann> from werkzeug import ...
500 2011-08-02T23:38:20 <ThomasWaldmann> that is also in support
501 2011-08-02T23:38:26 <dreimark> from MoinMoin.support import difflib
502 2011-08-02T23:38:39 <dreimark> from MoinMoin.support.python_compatibility import hash_new
503 2011-08-02T23:39:09 <dreimark> from MoinMoin.support.python_compatibility import set
504 2011-08-02T23:40:07 <ThomasWaldmann> it maybe depends on whether we expected it to be replaced by a package in site-packages (or other sys.path place) or not
505 2011-08-02T23:40:45 <ThomasWaldmann> like when moin is packaged for debian and depends on other python packages
506 2011-08-02T23:42:55 <dreimark> good that we have now virtualenv for testing. in 1.9 you can't be sure that moins support code is called if you don't explicit set the path
507 2011-08-02T23:44:21 * ThomasWaldmann deletes those tests
508 2011-08-02T23:54:55 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5787:00704da830ea 1.9/MoinMoin/ (3 files in 3 dirs):
509 2011-08-02T23:54:55 <CIA-114> Fixed bug in groups formatter which caused the last list item to be not in the group.
510 2011-08-02T23:54:55 <CIA-114> Removed some tests that didn't make sense for me, added some new to detect this bug.
