1 2011-08-08T00:04:14  <dreimark> sinha: http://paste.pocoo.org/show/454394/
   2 2011-08-08T00:05:14  <dreimark> this would work, but we should find a better one than text/plain
   3 2011-08-08T00:09:16  <sinha> dreimark: yes it will work, but all the items cant be said as text/plain(specially images, archives) others are ok
   4 2011-08-08T00:10:35  <dreimark> i know, i don't want this too.
   5 2011-08-08T00:12:19  <dreimark> this is annoying
   6 2011-08-08T00:14:03  <sinha> so ? i guess for this multiple download we should archive all of them together and then output it
   7 2011-08-08T00:14:11  <dreimark> no
   8 2011-08-08T00:14:16  <dreimark> this did not work
   9 2011-08-08T00:14:26  <sinha> okay
  10 2011-08-08T00:14:43  <dreimark> i have that implemented in 1.5/1.6 and we have lots of issues because zip is broken
  11 2011-08-08T00:15:04  <dreimark> ThomasWaldmann: do we need extensions for item names?
  12 2011-08-08T00:15:59  <dreimark> i guess we can't avoid
  13 2011-08-08T00:17:48  <ThomasWaldmann> moin does not need, but some browsers might need
  14 2011-08-08T00:18:00  <ThomasWaldmann> and some OSes
  15 2011-08-08T00:18:14  <dreimark> also if we don'r use it then a user can create a item with one
  16 2011-08-08T00:18:53  <dreimark> ThomasWaldmann: we recognized firefox is too clever, it ignores the passed mimetype and uses the extension
  17 2011-08-08T00:19:05  <dreimark> which is a bit problematic
  18 2011-08-08T00:20:04  <ThomasWaldmann> you mean it ignores the content-type header?
  19 2011-08-08T00:20:09  <dreimark> yes
  20 2011-08-08T00:20:15  <ThomasWaldmann> that's not our problem
  21 2011-08-08T00:20:34  <dreimark> sinha: ^
  22 2011-08-08T00:21:06  <ThomasWaldmann> consider filing a bug to firefox
  23 2011-08-08T00:21:17  <dreimark> so we can use our "application/x-moin" for downloading
  24 2011-08-08T00:21:21  <dreimark> sinha: ^^
  25 2011-08-08T00:21:23  <dreimark> yes
  26 2011-08-08T00:22:13  <ThomasWaldmann> and why it is not application/octet-stream? also firefox?
  27 2011-08-08T00:22:41  <ThomasWaldmann> application/x-moin is too unspecific and misleading
  28 2011-08-08T00:23:26  <sinha> dreimark: okay, ThomasWaldmann: we wanted it to be moin specific
  29 2011-08-08T00:23:53  <sinha> because once use set the default action for application/octet-stream it happens on other pages
  30 2011-08-08T00:24:52  <sinha> where user might not want to happen, so by setting it as /moin,  downloads on moin would go for that default action
  31 2011-08-08T00:25:03  <ThomasWaldmann> if a/o doesn't work, application/x.moin.download maybe
  32 2011-08-08T00:25:04  <sinha> ^^ s/use/user
  33 2011-08-08T00:25:16  <dreimark> yeah, thats better
  34 2011-08-08T00:25:43  <sinha> +1
  35 2011-08-08T00:30:27  <sinha> dreimark: i will push the changeset tomorrow morning, feels sleepy now, gn
  36 2011-08-08T00:31:05  *** sinha has quit IRC
  37 2011-08-08T00:31:05  <dreimark> sinha: i did the mistake to use the name mimetype, I guess it would be better to use always the name contenttype
  38 2011-08-08T00:35:18  <ThomasWaldmann> mimetype = x/y
  39 2011-08-08T00:35:39  <ThomasWaldmann> contenttype = x/y;param1=a
  40 2011-08-08T00:35:56  <ThomasWaldmann> that's the convention i used at other places
  41 2011-08-08T00:36:31  <ThomasWaldmann> so, if there can be params, it is contenttype. if there can not, it is mimetype.
  42 2011-08-08T00:36:50  <dreimark> ok, then it is correct used
  43 2011-08-08T01:01:38  <ThomasWaldmann> ok, moin-whoosh is approaching moin test failure counts
  44 2011-08-08T01:12:03  <dreimark> ThomasWaldmann: http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-08-07#comment
  45 2011-08-08T01:12:13  <dreimark> do you havve more wishes?
  46 2011-08-08T01:13:29  <dreimark> gn
  47 2011-08-08T02:22:01  *** MattMaker has quit IRC
  48 2011-08-08T02:48:03  *** MattMaker has joined #moin-dev
  49 2011-08-08T02:53:42  *** greg_f has quit IRC
  50 2011-08-08T02:54:10  *** greg_f has joined #moin-dev
  51 2011-08-08T05:04:41  *** MattMaker has quit IRC
  52 2011-08-08T05:05:15  *** MattMaker has joined #moin-dev
  53 2011-08-08T06:42:42  *** m4k3r has joined #moin-dev
  54 2011-08-08T06:58:33  *** m4k3r has quit IRC
  55 2011-08-08T07:05:04  *** m4k3r has joined #moin-dev
  56 2011-08-08T07:09:46  *** MattMaker has quit IRC
  57 2011-08-08T07:11:32  *** m4k3r_ has joined #moin-dev
  58 2011-08-08T07:13:11  *** m4k3r has quit IRC
  59 2011-08-08T07:20:00  *** raignarok has joined #moin-dev
  60 2011-08-08T07:22:51  *** m4k3r_ has quit IRC
  61 2011-08-08T07:30:07  *** m4k3r has joined #moin-dev
  62 2011-08-08T07:37:28  *** raignarok has quit IRC
  63 2011-08-08T07:39:18  *** m4k3r has quit IRC
  64 2011-08-08T07:39:32  *** m4k3r has joined #moin-dev
  65 2011-08-08T07:52:28  *** pkumar has joined #moin-dev
  66 2011-08-08T08:03:21  *** m4k3r has quit IRC
  67 2011-08-08T08:47:18  *** greg_f has quit IRC
  68 2011-08-08T08:48:11  *** greg_f has joined #moin-dev
  69 2011-08-08T10:00:52  <ThomasWaldmann> pkumar: hi. did you remove dependency on that counter already?
  70 2011-08-08T10:01:24  *** greg_f has quit IRC
  71 2011-08-08T10:01:54  <pkumar> yeah, I worked on it. would do it by today
  72 2011-08-08T10:02:50  *** greg_f has joined #moin-dev
  73 2011-08-08T10:03:08  <pkumar> little part of this test coverage part is still remaining, was working on that
  74 2011-08-08T10:06:59  <ThomasWaldmann> because (iirc), if that was gone, it think i could remove load_xml from moin startup.
  75 2011-08-08T10:08:42  <ThomasWaldmann> maybe you could also test how not loading xml at startup impacts your current tests
  76 2011-08-08T10:12:23  <pkumar> ThomasWaldmann : yeah, I commented the import_export_xml statement in create_app_ext and ran the tests.
  77 2011-08-08T10:13:55  <pkumar> and I think just two tests which I had already mentioned to you are effected
  78 2011-08-08T10:15:54  *** MattMaker has joined #moin-dev
  79 2011-08-08T10:16:08  <pkumar> will change those tests to remove the dependency by today
  80 2011-08-08T10:17:36  <ThomasWaldmann> ok, thanks
  81 2011-08-08T10:18:36  <pkumar> :)
  82 2011-08-08T10:30:36  *** m4k3r has joined #moin-dev
  83 2011-08-08T10:39:36  *** pkumar has quit IRC
  84 2011-08-08T11:38:28  *** greg_f has quit IRC
  85 2011-08-08T11:38:33  *** m4k3r has quit IRC
  86 2011-08-08T11:38:49  *** m4k3r has joined #moin-dev
  87 2011-08-08T11:39:16  *** greg_f has joined #moin-dev
  88 2011-08-08T11:49:00  *** m4k3r has quit IRC
  89 2011-08-08T11:50:55  *** m4k3r has joined #moin-dev
  90 2011-08-08T11:53:41  *** sinha has joined #moin-dev
  91 2011-08-08T11:54:10  <CIA-114> Akash Sinha <akash2607@gmail.com> * 49c749750d9b r350 default/setup.py: equalto sign missed in install_requires earlier in setup file, fixed now
  92 2011-08-08T11:54:10  <CIA-114> Akash Sinha <akash2607@gmail.com> * 9eb7d67addc3 r351 default/MoinMoin/ (templates/index.html themes/modernized/static/css/common.css): some css fix on index page for chrome
  93 2011-08-08T11:54:10  <CIA-114> Akash Sinha <akash2607@gmail.com> * 92cc4c7ea1c0 r352 default/MoinMoin/ (3 files in 3 dirs): mimetype parameter added in the download item link, such that we could set the contenttype of item being downloaded as desired.
  94 2011-08-08T12:03:17  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 0adc626b1036 r353 default/setup.py: setup.py: change requirement to werkzeug >= 0.6.2 after successful test with 0.7.1
  95 2011-08-08T12:03:17  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 07143bd03aed r354 default/MoinMoin/items/__init__.py: fix pygments converter call for new converter api
  96 2011-08-08T12:03:17  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * a50ded41a60d r355 default/setup.py: as long as xstatic api doesn't change in an incompatible way, we can just have minimum requirements for the packages
  97 2011-08-08T12:03:18  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * e8bd41ab7bdd r356 default/MoinMoin/ (9 files in 7 dirs): (log message trimmed)
  98 2011-08-08T12:03:18  <CIA-114> AccessControlList: do not require cfg object
  99 2011-08-08T12:03:18  <CIA-114> Giving the cfg to the ACL object caused some issues (for example, the AclTokenizer
 100 2011-08-08T12:03:18  <CIA-114> in the whoosh branch needed cfg and was part of the schema. whoosh tries to
 101 2011-08-08T12:03:19  <CIA-114> pickle the schema and that did not work for cfg).
 102 2011-08-08T12:03:19  <CIA-114> Refactored "auth_trusted" - this is now a user object attribute, so the ACL
 103 2011-08-08T12:03:19  <CIA-114> code does not need to know the list of trusted auth methods (which is still in
 104 2011-08-08T12:03:20  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 7ed1945aeb03 r357 default/ (setup.py MoinMoin/items/__init__.py): merged main
 105 2011-08-08T12:03:20  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 3a4d2982006f r358 default/MoinMoin/storage/ (8 files in 3 dirs):
 106 2011-08-08T12:03:21  <CIA-114> storage Revisions (NewRevision as well as StoredRevision) now support read/seek/tell
 107 2011-08-08T12:04:03  <CIA-114> added test for read / seek / tell (for NewRevision as well as for StoredRevision)
 108 2011-08-08T12:04:03  <CIA-114> sqlalchemy backend is a bit broken still, added a comment there.
 109 2011-08-08T12:04:03  <CIA-114> fileserver and flatfile backends: added missing tell()
 110 2011-08-08T12:04:03  <CIA-114> fs: set rev._datastart attr for NewRevision
 111 2011-08-08T12:04:03  <CIA-114> fs2: fixed mode to wb+ so that read is also possible (after seek)
 112 2011-08-08T12:04:03  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 1b4842601c98 r359 default/MoinMoin/converter/_util.py: decode_data: better exception msg
 113 2011-08-08T12:04:04  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * bf0319451066 r360 default/MoinMoin/converter/__init__.py: convert_to_indexable: also support direct conversion (not used yet)
 114 2011-08-08T12:04:04  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 7bacf8dde354 r361 default/MoinMoin/converter/__init__.py: convert_to_indexable: fix syntax error
 115 2011-08-08T12:04:05  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 46fc28990137 r362 default/MoinMoin/converter/opendocument_in.py: add OpenDocument Format (ODF) input converter (currently only for indexing)
 116 2011-08-08T12:04:11  <ThomasWaldmann> sinha: see the r355 comment
 117 2011-08-08T12:05:03  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * b64ccdece758 r363 default/MoinMoin/ (3 files in 2 dirs): define type_text_plain in MoinMoin.util.mime and import it from there
 118 2011-08-08T12:05:03  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 0337d76bd420 r364 default/MoinMoin/converter/ (xml_in.py opendocument_in.py): add generic text/xml input converter (for indexing only), reuse code from there in ODF converter
 119 2011-08-08T12:05:03  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 1fb3bf63594b r365 default/MoinMoin/converter/opendocument_in.py: add support for old openoffice *.sx? formats (same code as we use for ODF)
 120 2011-08-08T12:05:03  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 41a22e9dae75 r366 default/ (setup.py MoinMoin/converter/pdf_in.py): pdf indexable text content extraction using pdfminer
 121 2011-08-08T12:05:03  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 902378b07e99 r367 default/ (5 files in 5 dirs): (log message trimmed)
 122 2011-08-08T12:06:01  <sinha> ThomasWaldmann: do i need to take care of something ?
 123 2011-08-08T12:06:03  <CIA-114> simplify interwiki resolution, remove special case for 'Self' / own interwikiname
 124 2011-08-08T12:06:03  <CIA-114> Note: it is required now that the interwiki_map contains entries for our
 125 2011-08-08T12:06:03  <CIA-114> own wikiname and also for 'Self' (same url):
 126 2011-08-08T12:06:03  <CIA-114> interwiki_map = {
 127 2011-08-08T12:06:03  <CIA-114> 'Self': 'http://ourserver/ourpath/',
 128 2011-08-08T12:06:03  <CIA-114> 'OurInterWikiName': 'http://ourserver/ourpath/',
 129 2011-08-08T12:06:04  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 23a6a6b85d4c r368 default/MoinMoin/converter/__init__.py: convert_to_indexable: clarify that usage of rev.seek(0) might be needed
 130 2011-08-08T12:06:04  <CIA-114> (14 lines omitted)
 131 2011-08-08T12:13:47  <ThomasWaldmann> sinha: well, you maybe want to do the same for stuff you added
 132 2011-08-08T12:19:41  <sinha> okay
 133 2011-08-08T12:46:57  <ThomasWaldmann> hmm, where's marchael?
 134 2011-08-08T12:58:55  *** pkumar has joined #moin-dev
 135 2011-08-08T13:15:02  <dreimark> moin
 136 2011-08-08T13:15:13  * dreimark greets from an ice 
 137 2011-08-08T13:16:23  <ThomasWaldmann> huh?
 138 2011-08-08T13:16:37  <TheSheep> land?
 139 2011-08-08T13:17:31  * ThomasWaldmann imagines dreimark sitting on an ice shell next to a penguin
 140 2011-08-08T13:20:06  *** m4k3r has quit IRC
 141 2011-08-08T13:20:49  * dreimark no on the way to norddeich
 142 2011-08-08T13:22:21  <pkumar> xorAxAx : hi, regarding the import_export_xml, there is small fix I did after which import_export_app method is not required for those tests. will you please look at it if it is correct? http://paste.pocoo.org/show/454663/ line 21 and 22
 143 2011-08-08T13:23:59  <pkumar> 53 and 54(same fix) in test_test_environ
 144 2011-08-08T13:24:22  <dreimark> i guess on an ice shell umts is extremly bad compared to this here
 145 2011-08-08T13:24:22  <ThomasWaldmann> pkumar: maybe you could rather directly refer to the xml file?
 146 2011-08-08T13:25:55  <pkumar> ThomasWaldmann : there items are checked in the backend,so made it available there. I'm sorry but I'm not sure how to directly refer to xml file?
 147 2011-08-08T13:27:10  <pkumar> is there some syntax for that?
 148 2011-08-08T13:28:33  <pkumar> or basic method i.e read the file and get those items?
 149 2011-08-08T13:30:28  <xorAxAx> pkumar: hmm, whats unclear?
 150 2011-08-08T13:31:18  <pkumar> xorAxAx : I was just asking if those fixes seems fine to you?
 151 2011-08-08T13:31:31  <xorAxAx> pkumar: thats not a diff, so i dont know what you fixed
 152 2011-08-08T13:32:21  <pkumar> just a mom
 153 2011-08-08T13:33:41  <pkumar> xorAxAx : here - http://paste.pocoo.org/show/454672/
 154 2011-08-08T13:34:31  <pkumar> there items are checked in the backend, so made those items available there
 155 2011-08-08T13:35:30  <pkumar> xorAxAx : and we don't need import_export_xml there anymore
 156 2011-08-08T13:35:53  <xorAxAx> why not?
 157 2011-08-08T13:35:58  <xorAxAx> did you make the test fail?
 158 2011-08-08T13:37:09  <dreimark> sinha: give an estimation how much time you need for purposed changes
 159 2011-08-08T13:39:11  <sinha> dreimark: i wanted to discuss few things regarding that delete/destroy
 160 2011-08-08T13:39:18  <sinha> like how to present them
 161 2011-08-08T13:39:41  <pkumar> xorAxAx : yes, for the wikiutil ,as you had told earlier
 162 2011-08-08T13:39:53  <sinha> i mean similar to Download button i will put a Delete and when it is clicked i will present a popup box and ask for the comment
 163 2011-08-08T13:40:26  <sinha> dreimark: is this approach safe to follow ?
 164 2011-08-08T13:40:53  <xorAxAx> pkumar: what do you mean?
 165 2011-08-08T13:41:47  <sinha> when comment is entered and submitted, how should i send item name to backend, one by one or send all of them in a array or something ?
 166 2011-08-08T13:42:04  <pkumar> xorAxAx : yes, I made it fail for wikiutil  (the test is for wikiutil)
 167 2011-08-08T13:43:46  <xorAxAx> pkumar: why do you think the line of code is superfluous?
 168 2011-08-08T13:46:35  <pkumar> which one 'import_export_xml'? it loads the items from xml with every app creation i.e create_app_ext. so Thomas was suggesting to remove it so that tests can become faster
 169 2011-08-08T13:46:41  <pkumar> xorAxAx : ^
 170 2011-08-08T13:47:50  <pkumar> though loading of item is not required in all the tests
 171 2011-08-08T13:48:33  <xorAxAx> ah, and no other test fails?
 172 2011-08-08T13:49:19  <dreimark> sinha: also for upload a comment is an option
 173 2011-08-08T13:49:20  <pkumar> xorAxAx : I ran tests commenting that statement and only these two tests failed for me.
 174 2011-08-08T13:49:54  <pkumar> due to import_export_xml
 175 2011-08-08T13:50:16  <xorAxAx> ah, ok
 176 2011-08-08T13:50:18  <xorAxAx> makes sense
 177 2011-08-08T13:50:41  <pkumar> xorAxAx : all right, so should I commit those?
 178 2011-08-08T13:50:45  <dreimark> sinha: yes
 179 2011-08-08T13:51:50  <sinha> dreimark: so for upload where will a enter a comment, in items modify ?
 180 2011-08-08T13:51:52  <xorAxAx> pkumar: yes
 181 2011-08-08T13:51:57  <sinha> s/a/i
 182 2011-08-08T13:52:06  <pkumar> ok :)
 183 2011-08-08T13:52:09  <pkumar> thanx
 184 2011-08-08T13:53:12  <dreimark> sinha: it sould be on save possible give a comment, at least it is in the textform
 185 2011-08-08T13:54:44  <dreimark> i think sending an array is fine. it  reflects the action in one request
 186 2011-08-08T13:55:10  <sinha> dreimark: and i was seeing the function of delete, there is simply a item's delete function called and nothing is taken in return, so is it always assumed that the function executes well ( item.delete(comment))
 187 2011-08-08T13:58:34  <dreimark> try if the function in principle works
 188 2011-08-08T13:58:48  <dreimark> if it is broken file a bug to 2.0 repo tracker
 189 2011-08-08T13:59:34  <dreimark> after you have a plan what you need to do please give me an estimation how long the modifactions take
 190 2011-08-08T13:59:44  <dreimark> is it more than 2 days
 191 2011-08-08T14:00:21  <dreimark> ?
 192 2011-08-08T14:00:23  <dreimark> sinha: ^
 193 2011-08-08T14:05:37  <sinha> dreimark: i can do this 2 days
 194 2011-08-08T14:05:50  <sinha> by 10th Aug
 195 2011-08-08T14:09:08  <dreimark> ok,is tehre work on layout included
 196 2011-08-08T14:09:12  <dreimark> sinha: ^
 197 2011-08-08T14:09:46  <sinha> no, but i will try to do that in that time frame
 198 2011-08-08T14:18:01  <dreimark> ok
 199 2011-08-08T14:18:26  <dreimark> we should talk tom. about what you want to do in the 10 last days
 200 2011-08-08T14:18:52  <dreimark> or if we need that for good state of current work
 201 2011-08-08T14:22:36  <sinha> dreimark: yes what other area need improvement ?
 202 2011-08-08T14:24:20  <sinha> or i can write javascripts in existing places
 203 2011-08-08T14:28:37  <dreimark> on your list is meta displaying with ajax and diff
 204 2011-08-08T14:32:38  <dreimark> sinha: http://etherpad.osuosl.org/moin-2-ui
 205 2011-08-08T14:32:49  <dreimark> is one of them doable in this time
 206 2011-08-08T14:33:32  *** greg_f has quit IRC
 207 2011-08-08T14:34:15  *** greg_f has joined #moin-dev
 208 2011-08-08T14:49:56  *** pkumar has quit IRC
 209 2011-08-08T15:17:33  <sinha> dreimark: yes i will do that, displaying meta  on demand
 210 2011-08-08T15:18:15  <sinha> and then go for full diff thing
 211 2011-08-08T15:23:14  <dreimark> ok
 212 2011-08-08T15:23:47  <dreimark> sinha: good decision, as we have already some diff
 213 2011-08-08T15:24:10  <sinha> yes
 214 2011-08-08T15:40:42  *** Marchael has joined #moin-dev
 215 2011-08-08T15:41:10  <Marchael> moin
 216 2011-08-08T15:41:21  <Marchael> ThomasWaldmann: you could mail me on marchael@ya.ru
 217 2011-08-08T15:41:52  <Marchael> our sever in lab shut down due repairing lab
 218 2011-08-08T15:46:15  <Marchael> ThomasWaldmann: and also, seems like tomorrow I'll be unavailable most of time due my birth day.
 219 2011-08-08T15:55:28  <dreimark> bbl
 220 2011-08-08T15:56:17  *** sinha has quit IRC
 221 2011-08-08T15:58:01  <ThomasWaldmann> hi Marchael
 222 2011-08-08T15:58:28  <Marchael> hi ThomasWaldmann
 223 2011-08-08T15:58:29  <ThomasWaldmann> Marchael: ah, ok
 224 2011-08-08T15:59:00  *** sinha has joined #moin-dev
 225 2011-08-08T16:03:58  <ThomasWaldmann> Marchael: can you put the email on your wiki homepage?
 226 2011-08-08T16:04:22  <Marchael> of course
 227 2011-08-08T16:09:52  <Marchael> hm, what's happening with column "reported by" on bb issue tracker
 228 2011-08-08T16:09:52  <ThomasWaldmann> Marchael: does that email issues take longer?
 229 2011-08-08T16:11:03  <ThomasWaldmann> looks like they removed it for the prority/type columns
 230 2011-08-08T16:11:06  <Marchael> I try to switch on server in wednesday
 231 2011-08-08T16:12:00  <Marchael> could you point to issue on whoosh tracker where you add bugfix for wildcard search?
 232 2011-08-08T16:12:44  <ThomasWaldmann> what do you mean?
 233 2011-08-08T16:15:38  <Marchael> ThomasWaldmann: https://bitbucket.org/mchaput/whoosh/issue/157/with-fix-unicode-keywords-are-not
 234 2011-08-08T16:16:07  <Marchael> also, Matt fix that issue
 235 2011-08-08T16:16:40  <Marchael> *fixed
 236 2011-08-08T16:18:23  <ThomasWaldmann> ah, that one. yes, fixed in whoosh, but you have to be careful with that in your code also.
 237 2011-08-08T16:20:21  <Marchael> so, do we need that patch for supporting wildcards?
 238 2011-08-08T16:20:51  <Marchael> also, patch with highlighithing doesn't need anymore I guess
 239 2011-08-08T16:22:00  <ThomasWaldmann> i am not sure about what you are talking now
 240 2011-08-08T16:22:57  <ThomasWaldmann> btw, pull from my whoosh repo when you have a clean workdir
 241 2011-08-08T16:23:27  <ThomasWaldmann> and look at the changesets
 242 2011-08-08T16:25:29  <Marchael> hm, we have whoosh200-highlight-mode-fix.patch now, but we just use <b>...</b> for highlighting
 243 2011-08-08T16:25:40  <Marchael> document names
 244 2011-08-08T16:26:26  <Marchael> and btw, after applying that patch results still seems unhighlightable
 245 2011-08-08T16:28:03  <ThomasWaldmann> i didn't find why it doesn't highlight wildcard search results, I just reported a bug in the whoosh tracker
 246 2011-08-08T16:28:26  <Marchael> no I mean names of documents
 247 2011-08-08T16:29:26  <Marchael> for example if query is "Home" and found document name is "Home/something" whoosh highlights all string
 248 2011-08-08T16:29:47  <ThomasWaldmann> is there a bug for that?
 249 2011-08-08T16:30:46  <Marchael> mm, I already report bug with troubles highlighting for MultiFiler
 250 2011-08-08T16:30:57  <Marchael> in index and query mode
 251 2011-08-08T16:31:43  <ThomasWaldmann> why don't you fix some clear high-priority issues from your tracker (after pulling/merging). just click twice on that "!" column.
 252 2011-08-08T16:32:11  <ThomasWaldmann> highlighting item names is nice, but hasn't that high prio.
 253 2011-08-08T16:33:03  <Marchael> ok, so I should deal with test first?
 254 2011-08-08T16:33:39  <ThomasWaldmann> yes, read the comments there
 255 2011-08-08T16:36:28  <ThomasWaldmann> https://bitbucket.org/marchael/moin-2.0/issue/21/test-failures-massively-increased at the bottom
 256 2011-08-08T16:36:50  <Marchael> test_indexing doesn't fail anymore
 257 2011-08-08T16:37:05  <ThomasWaldmann> ok, then close it
 258 2011-08-08T16:37:10  <Marchael> test_analyzer failed due  RuntimeError: working outside of request context
 259 2011-08-08T16:40:18  <ThomasWaldmann> i suggest your first pull/merge
 260 2011-08-08T16:40:22  <ThomasWaldmann> -r
 261 2011-08-08T16:40:33  <Marchael> ok
 262 2011-08-08T16:41:17  <Marchael> brb
 263 2011-08-08T16:50:32  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 91b72ea6039e r419 moin-2.0/MoinMoin/search/indexing.py: indexing: misc src cosmetics
 264 2011-08-08T16:50:34  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * a64b59e52616 r418 moin-2.0/MoinMoin/search/indexing.py: reduce duplication in indexing schemas
 265 2011-08-08T16:50:35  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 0b400626bc93 r421 moin-2.0/MoinMoin/search/revision_converter.py: rev converter: misc src cosmetics
 266 2011-08-08T16:50:36  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * d49d08bb5f50 r414 moin-2.0/MoinMoin/ (3 files in 3 dirs): merged whoosh repo
 267 2011-08-08T16:50:37  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * ef401198ebf9 r413 moin-2.0/MoinMoin/storage/ (8 files in 3 dirs): storage: remove history() from storage backends api, only RouterBackend+IndexingMixIn now implements history()
 268 2011-08-08T16:50:38  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * e2d16dadf565 r417 moin-2.0/MoinMoin/search/analyzers.py: merged whoosh repo
 269 2011-08-08T16:50:39  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 2e8c562f7524 r416 moin-2.0/MoinMoin/storage/backends/indexing.py: indexing: clarify ItemIndex.update_item/remove_item, remove wrong code
 270 2011-08-08T16:50:41  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 8589afef0e6c r422 moin-2.0/MoinMoin/storage/backends/indexing.py: indexing storage mixin: misc src cosmetics
 271 2011-08-08T16:50:42  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * d755f798fe66 r412 moin-2.0/MoinMoin/ (8 files in 6 dirs):
 272 2011-08-08T16:50:42  <CIA-114> fix some tests
 273 2011-08-08T16:50:42  <CIA-114> make item name and contenttype constants unicode
 274 2011-08-08T16:50:42  <CIA-114> give cfg kwarg to RouterBackend
 275 2011-08-08T16:50:43  <CIA-114> delay tokenizer creation to test method call time, so that we're within a test
 276 2011-08-08T16:50:43  <CIA-114> request environment and app is available.
 277 2011-08-08T16:50:44  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 6119699cec2f r420 moin-2.0/MoinMoin/search/analyzers.py: analyzers: misc src cosmetics
 278 2011-08-08T16:50:44  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * e362e7abfda6 r415 moin-2.0/MoinMoin/search/ (analyzers.py _tests/test_indexing.py): merged whoosh repo
 279 2011-08-08T16:51:31  <Marchael> ThomasWaldmann: great thanks!
 280 2011-08-08T16:55:05  *** pkumar has joined #moin-dev
 281 2011-08-08T16:58:24  <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 348f20628eb8 r423 moin-2.0/MoinMoin/search/_tests/test_analyzers.py: Fixed acl analyzer test Fixes #21.
 282 2011-08-08T17:07:26  <Marchael> ThomasWaldmann: https://bitbucket.org/marchael/moin-2.0/issue/25/i18n-wtfs wtf? hm, why someone may want to translate document number?
 283 2011-08-08T17:07:36  <ThomasWaldmann> https://bitbucket.org/marchael/moin-2.0/changeset/6119699cec2f this is why import * is evil
 284 2011-08-08T17:08:26  <ThomasWaldmann> btw, please have a look at the changesets you merged. they are somehow examples what to do / what not to do that are better shown like this than with long explanations.
 285 2011-08-08T17:08:49  <Marchael> ok
 286 2011-08-08T17:09:02  <ThomasWaldmann> Marchael: what exactly is translatable there?
 287 2011-08-08T17:10:01  <ThomasWaldmann> docnum (if you meant that) is a name that must stay as is
 288 2011-08-08T17:10:02  <Marchael> may be I don't understand something, but that's number
 289 2011-08-08T17:10:31  <ThomasWaldmann> _("%(docnum)d.", docnum=result.pos + 1)
 290 2011-08-08T17:11:25  <ThomasWaldmann> that means: translate the string "%(docnum)d." through the translation system and THEN put the docnum value at the place where %(docnum)d is (instead of it).
 291 2011-08-08T17:12:23  <ThomasWaldmann> so the only thing "translatable" in that string would be the dot and I think that doesn't need translation as it is a dot everywhere anyway.
 292 2011-08-08T17:13:35  <Marchael> ok
 293 2011-08-08T17:14:21  <ThomasWaldmann> so, what you want there is just {{ result.pos + 1 }}
 294 2011-08-08T17:14:34  <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 0248b030a814 r424 moin-2.0/MoinMoin/templates/search_results.html: Fixes translation issue Fixes #25.
 295 2011-08-08T17:14:47  <Marchael> yep
 296 2011-08-08T17:16:57  <Marchael> ThomasWaldmann: so next https://bitbucket.org/marchael/moin-2.0/issue/15/wrong-links-in-search-results-farm-support ?
 297 2011-08-08T17:17:45  <ThomasWaldmann> yes
 298 2011-08-08T17:34:35  <Marchael> ThomasWaldmann: hm, that's happenig when I try {{ url_for_item(item_name=result['name'], wiki_name=wiki_name, rev=result['rev_no']) }} http://paste.pocoo.org/show/454766/
 299 2011-08-08T17:35:35  <Marchael> and if wiki could share same index, then may be print interwiki name to search results page with mtime and rev_no?
 300 2011-08-08T17:55:57  <Marchael> brb
 301 2011-08-08T18:03:39  <ThomasWaldmann> how about ... wiki_name=result['...'], ...
 302 2011-08-08T18:05:51  <ThomasWaldmann> the way do display items in other wikis is to use the css class for interwiki links and to put OtherWikiName:OtherItemName into the title attr of the link
 303 2011-08-08T18:07:09  <ThomasWaldmann> see how [[MoinMoin:RecentChanges]] markup gets rendered when you put that onto a local wiki page
 304 2011-08-08T18:18:55  <ThomasWaldmann> http://paste.pocoo.org/show/454766/ about that, there is obviously the usual logging stuff missing in interwiki.py, just copy the 2 lines from any other source file using logging
 305 2011-08-08T18:23:48  <ThomasWaldmann> Marchael: ^^
 306 2011-08-08T19:19:48  *** Marchael has quit IRC
 307 2011-08-08T19:25:43  *** raignarok has joined #moin-dev
 308 2011-08-08T19:47:23  *** greg_f has quit IRC
 309 2011-08-08T20:25:05  *** pkumar has quit IRC
 310 2011-08-08T20:59:35  *** moinBot` has joined #moin-dev
 311 2011-08-08T20:59:35  *** moinBot has quit IRC
 312 2011-08-08T21:22:01  <ThomasWaldmann> https://bitbucket.org/mchaput/whoosh/issue/164/no-highlighting-in-results-with-wildcard
 313 2011-08-08T22:28:15  *** raignarok has quit IRC
 314 

MoinMoin: MoinMoinChat/Logs/moin-dev/2011-08-08 (last edited 2011-08-07 22:45:03 by IrcLogImporter)