1 2012-03-20T00:04:30 *** bretonium
2 2012-03-20T00:17:25 *** bretonium|away
3 2012-03-20T00:21:55 *** bretonium
4 2012-03-20T00:24:01 *** MattMaker
5 2012-03-20T00:44:32 *** dwcramer
6 2012-03-20T01:05:07 *** brunomartin
7 2012-03-20T01:48:25 *** dwcramer
8 2012-03-20T02:02:16 *** dwcramer
9 2012-03-20T03:09:24 *** yufra_
10 2012-03-20T03:49:39 *** sudo_dirk
11 2012-03-20T04:56:05 *** dwcramer
12 2012-03-20T05:44:23 *** yufra_
13 2012-03-20T05:56:55 *** sudo_dirk
14 2012-03-20T06:10:11 *** kanha
15 2012-03-20T06:16:56 *** kanha
16 2012-03-20T06:30:19 *** surtani
17 2012-03-20T06:33:01 *** bretonium|away
18 2012-03-20T06:36:23 *** bretonium
19 2012-03-20T06:40:40 *** bretonium|away
20 2012-03-20T07:32:25 <dreimark> 22:12 < RogerHaase> I can't at home too.
21 2012-03-20T08:39:29 *** surtani
22 2012-03-20T09:25:38 *** in3xes
23 2012-03-20T09:33:47 *** in3xes
24 2012-03-20T10:42:45 *** greg_f
25 2012-03-20T11:50:01 <ThomasWaldmann> moin
26 2012-03-20T11:51:22 <ThomasWaldmann> waldi: you still need to add your name on the ideas page to project ideas that sound interesting / doable for you
27 2012-03-20T12:03:15 *** kanha_
28 2012-03-20T12:12:33 <kanha_> eSyr:moin
29 2012-03-20T12:19:15 *** brunomartin
30 2012-03-20T12:25:37 *** bretonium|away
31 2012-03-20T12:27:45 *** bretonium|away
32 2012-03-20T12:27:55 *** bretonium|away
33 2012-03-20T12:27:56 *** bretonium|away
34 2012-03-20T12:29:01 *** bretonium
35 2012-03-20T12:46:48 *** dwcramer
36 2012-03-20T12:54:48 *** bretonium
37 2012-03-20T12:56:59 <ThomasWaldmann> bretonium|away: nice, your flask-script changes got accepted
38 2012-03-20T13:08:07 *** bretonium|away
39 2012-03-20T13:10:35 <waldi> ThomasWaldmann: sure
40 2012-03-20T13:13:05 <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1304:4733e716e071 2.0/MoinMoin/storage/backends/fileserver.py: fileserver backend: fix for windows (handle backslashes in pathes)
41 2012-03-20T13:13:06 <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1305:770e06a34d09 2.0/setup.py: use Flask-Script repo version 0.3.3dev, which has the --threaded and --processes N options for the builtin server
42 2012-03-20T13:26:32 *** bretonium
43 2012-03-20T13:27:41 *** bretonium|away
44 2012-03-20T13:28:06 <bretonium> ThomasWaldmann: yep, got a notification
45 2012-03-20T13:31:38 <bretonium> moin code really misses comments :(
46 2012-03-20T13:31:40 *** kanha_
47 2012-03-20T13:36:30 <xorAxAx> comments are a good indicator to show which program points are faulty
48 2012-03-20T13:37:05 <xorAxAx> a higher comment density means more complex and more buggy code :)
49 2012-03-20T13:49:40 *** dave_largo
50 2012-03-20T13:52:55 <bretonium> what is meant under "offline editor wrapper"? A set of functions or API, which will be used by offline editor?
51 2012-03-20T13:53:04 *** brunomartin
52 2012-03-20T14:01:55 <ronny> xorAxAx: not necessaryly
53 2012-03-20T14:02:26 <xorAxAx> thou shalt not destroy jokes, ronny
54 2012-03-20T14:03:17 <ronny> then i shal destroy the world
55 2012-03-20T14:03:32 <xorAxAx> sha1'ing the world is forbidden!
56 2012-03-20T14:04:38 <ThomasWaldmann> bretonium: some people prefer not using the web browser to modify wiki items
57 2012-03-20T14:04:39 <dreimark> game over
58 2012-03-20T14:05:06 <xorAxAx> bretonium: have a look at the existing command line client for editing moin1 wikis
59 2012-03-20T14:05:08 <dreimark> bretonium: look at Load and editmoin
60 2012-03-20T14:05:21 <ThomasWaldmann> so, if there is a reasonable network api, a wrapper for whatever "editor" comes to mind
61 2012-03-20T14:06:02 <ThomasWaldmann> don't look too much at old hacks ...
62 2012-03-20T14:06:34 <ThomasWaldmann> rather think about powerful new clean ways :)
63 2012-03-20T14:06:53 *** dwcramer
64 2012-03-20T14:14:30 <xorAxAx> well, look at their use cases
65 2012-03-20T14:14:35 <xorAxAx> and not their implementation
66 2012-03-20T14:17:10 *** bretonium
67 2012-03-20T15:03:49 *** kanha_
68 2012-03-20T15:05:41 *** dwcramer
69 2012-03-20T15:11:12 *** RogerHaase
70 2012-03-20T15:39:08 *** surtani
71 2012-03-20T15:39:22 <ThomasWaldmann> RogerHaase: one problem less :)
72 2012-03-20T15:45:42 <surtani> ThomasWaldmann: Hello
73 2012-03-20T15:46:14 <surtani> ThomasWaldmann: I have gone through the Storage package
74 2012-03-20T15:48:57 <kanha_> eSyr:Hi
75 2012-03-20T15:59:03 *** kanha_
76 2012-03-20T15:59:57 *** surtani
77 2012-03-20T16:00:22 <ThomasWaldmann> surtani|brb: yeah, so? :)
78 2012-03-20T16:01:57 *** surtani|brb
79 2012-03-20T16:02:08 <surtani> ThomasWaldmann: :)
80 2012-03-20T16:02:26 <surtani> ThomasWaldmann: So, I wanted to discuss few things related to that
81 2012-03-20T16:03:03 <surtani> ThomasWaldmann: I have some idea how RPC can be implemented, and wanted to discuss that
82 2012-03-20T16:04:40 <ThomasWaldmann> sure, just begin
83 2012-03-20T16:05:37 <surtani> ThomasWaldmann: a user can have local instances on wiki also
84 2012-03-20T16:06:03 <surtani> ThomasWaldmann: which he can update offline
85 2012-03-20T16:07:05 <surtani> ThomasWaldmann: If he has the option to sync them
86 2012-03-20T16:07:19 *** kanha
87 2012-03-20T16:08:04 <surtani> ThomasWaldmann: He can create and update pages using command line
88 2012-03-20T16:10:26 <surtani> ThomasWaldmann: so what are you looking for to be done in this ?
89 2012-03-20T16:14:30 <dreimark> surtani: a user wants to edit in emacs
90 2012-03-20T16:14:47 <dreimark> and save to the wiki
91 2012-03-20T16:14:52 *** dwcramer
92 2012-03-20T16:14:59 <surtani> dreimark: ok
93 2012-03-20T16:15:59 <dreimark> and yes syncing of instances is also possible if the basics are done
94 2012-03-20T16:28:02 *** dwcramer
95 2012-03-20T16:28:21 <dreimark> that was just an example. we had several ways in m1 to edit pages
96 2012-03-20T16:31:25 <surtani> dreimark: ok. the user can merge the local copy to that on the server
97 2012-03-20T16:33:16 <surtani> dreimark: getDiff and mergeDiff will do that...?
98 2012-03-20T16:36:12 *** surtani
99 2012-03-20T16:37:48 <dreimark> something like this. also some stats and a dry feature would be interesting
100 2012-03-20T16:40:15 * ThomasWaldmann was distracted, sorry
101 2012-03-20T16:41:40 <ThomasWaldmann> surtani|brb: i am not sure that I understand you, maybe try to be more precise / better understandable.
102 2012-03-20T16:42:55 <ThomasWaldmann> (and maybe ask more specific questions)
103 2012-03-20T16:43:53 <ThomasWaldmann> also, keep in mind that we are talking about moin2 here. moin2 does not have any sync nor any rpc yet.
104 2012-03-20T17:16:00 <dreimark> bbl
105 2012-03-20T17:27:16 <RogerHaase> ThomasWaldmann: I looked at moving the call to mark_item_as_transclusion from include.py to visit_moinpage within html_out.py. imho, It will not work when the DOM has been mangled and page nodes have already been converted to span's or div's.
106 2012-03-20T17:29:20 <ThomasWaldmann> ehrm, but that conversion is done by html_out, right? so it would be just a matter of doing it inside html_out, but before pages get converted.
107 2012-03-20T17:30:30 <ThomasWaldmann> i guess we really need some docs for that stuff...
108 2012-03-20T17:30:49 <ThomasWaldmann> how it SHOULD work :)
109 2012-03-20T17:31:30 <ThomasWaldmann> (the DOM and conversions, transclusions, blocklevel, inline, etc.)
110 2012-03-20T17:33:49 <RogerHaase> hmm, I put a logging message inside visit_moinpage and did not see a call for things like "\ntext{{somePage}} more text\n" but did see calls for transclusions within tables.
111 2012-03-20T17:34:56 <RogerHaase> (after filtering out all the calls for not elem.tag.name=='page')
112 2012-03-20T17:36:03 <ThomasWaldmann> does it depend on context? inline vs. block?
113 2012-03-20T17:38:56 <RogerHaase> block within block (like transcluded pages within table cells) have a chance of working, but "\ntext{{somePage}} more text\n" does not
114 2012-03-20T17:40:26 <ThomasWaldmann> well, maybe we are just seeing other bugs
115 2012-03-20T17:41:07 <RogerHaase> I should have started this by posting my code and a trace, let me clean it up and start again...
116 2012-03-20T17:55:36 *** dwcramer
117 2012-03-20T18:11:44 *** sudo_dirk
118 2012-03-20T18:14:48 <RogerHaase> ThomasWaldmann: my code changes: http://codereview.appspot.com/5843075/ and test input with output logging messages: http://paste.pocoo.org/show/568616/
119 2012-03-20T18:16:33 * ThomasWaldmann looks
120 2012-03-20T18:18:24 <ThomasWaldmann> RogerHaase: btw, you know the +dom view?
121 2012-03-20T18:21:51 <RogerHaase> just learned about it: http://paste.pocoo.org/show/568623/
122 2012-03-20T18:21:54 *** greg_f
123 2012-03-20T18:23:52 <RogerHaase> I guess that suggests that I need to check for P's with that funny ns1:... stuff and it will work
124 2012-03-20T18:26:35 *** dave_largo
125 2012-03-20T18:32:45 *** kanha_
126 2012-03-20T18:37:49 *** kanha_
127 2012-03-20T18:55:56 <brunomartin> moin
128 2012-03-20T19:15:36 * ThomasWaldmann back (had to do other stuff)
129 2012-03-20T19:16:43 <ThomasWaldmann> RogerHaase: that "?" in the hrefs is also a bit strange
130 2012-03-20T19:16:48 <ThomasWaldmann> hi brunomartin
131 2012-03-20T19:18:12 <brunomartin> hi ThomasWaldmann! I'm backing to moin!! :-) trying to finish that task related with util/interwiki, do you remember?
132 2012-03-20T19:18:48 <ThomasWaldmann> yes, vaguely :)
133 2012-03-20T19:20:06 <brunomartin> the last thing was some naming convention....
134 2012-03-20T19:20:09 <brunomartin> http://codereview.appspot.com/5376052/
135 2012-03-20T19:20:36 <brunomartin> pointed by RogerHaase
136 2012-03-20T19:21:07 <brunomartin> should we user itemname or item_name? (I prefer the second one... )
137 2012-03-20T19:23:42 <ThomasWaldmann> i guess i used both. i am happy if it is locally consistent :)
138 2012-03-20T19:24:00 <ThomasWaldmann> review done
139 2012-03-20T19:24:54 <ThomasWaldmann> brunomartin: btw, are you working on current repo tip?
140 2012-03-20T19:26:20 <brunomartin> ThomasWaldmann: I'm working on namespace.... trying to merge tons of commits with my repo...
141 2012-03-20T19:28:36 <ThomasWaldmann> well, i mean "namespace branch head" to be precise
142 2012-03-20T19:29:20 <ThomasWaldmann> be careful when merging :)
143 2012-03-20T19:38:58 <brunomartin> ThomasWaldmann: yeah... I'm trying to use the rebase.... what do you think? the pull and merge ir messing everything... :-|
144 2012-03-20T19:39:36 <ThomasWaldmann> rebase can sometimes be simpler
145 2012-03-20T19:40:18 <ThomasWaldmann> (and of course, merging more often also helps)
146 2012-03-20T19:49:22 <brunomartin> ThomasWaldmann: rebase rocks! ;-)
147 2012-03-20T19:54:20 <RogerHaase> ThomasWaldmann: still looks like include.py runs before html_out.py to me: http://paste.pocoo.org/show/568662/
148 2012-03-20T19:58:42 <ThomasWaldmann> RogerHaase: hm? sure include runs before html_out
149 2012-03-20T19:59:49 <ThomasWaldmann> but maybe it should work a bit differently than now. if it leaves the indications of inclusion in the dom, html_out can create whatever html we want there
150 2012-03-20T20:02:55 <RogerHaase> I am wrong a lot, but on first call, the great-grand-child of the page being output looks like a span, not an include or page as would be expected if html_our ran before include.py
151 2012-03-20T20:03:37 <RogerHaase> html_our/html_out
152 2012-03-20T20:03:43 <brunomartin> ThomasWaldmann: we have 3 test failing in namespace branch, in test_frontend, is that right?
153 2012-03-20T20:08:18 *** surtani|brb
154 2012-03-20T20:09:33 <ThomasWaldmann> RogerHaase: html_out is the very last step
155 2012-03-20T20:10:02 <ThomasWaldmann> (aside from serializing the html tree)
156 2012-03-20T20:10:25 <ThomasWaldmann> brunomartin: yes, can be
157 2012-03-20T20:10:35 <ThomasWaldmann> didn't find out why yet
158 2012-03-20T20:11:50 <brunomartin> ThomasWaldmann: ok.... just to confirm... I found that erros running test on my repo, then I got a fresh repo and env and got the same errors....
159 2012-03-20T20:15:08 <RogerHaase> ThomasWaldmann: so conclusion is to leave call to mark_item_as_transclusion in include.py? (at least until some brave soul wants to make {{SomeItem}} either block or inline depending upon context and content)
160 2012-03-20T20:37:03 <ThomasWaldmann> i don't have a conclusion yet :)
161 2012-03-20T20:37:36 <ThomasWaldmann> just think it makes sense to do html specific stuff in html_out
162 2012-03-20T20:46:00 <brunomartin> please, review http://codereview.appspot.com/5376052/
163 2012-03-20T20:50:08 *** bretonium|away
164 2012-03-20T21:04:00 * ThomasWaldmann looks
165 2012-03-20T21:05:07 <ThomasWaldmann> that %2b stuff is an annoyance :|
166 2012-03-20T21:07:40 *** surtani
167 2012-03-20T21:11:37 <brunomartin> ThomasWaldmann: hehehe... I agree, but seens the newer flask version of url_for just return encode urls...
168 2012-03-20T21:13:04 <ThomasWaldmann> i reported that some months ago, but mitsuhiko seems undecided whether he wants + or %2B...
169 2012-03-20T21:15:24 <ThomasWaldmann> i guess i'ld prefer + very much - otherwise we have to search for something that looks less ugly
170 2012-03-20T21:15:57 <ThomasWaldmann> review done
171 2012-03-20T21:16:00 <brunomartin> I agree...
172 2012-03-20T21:17:15 *** MattMaker
173 2012-03-20T21:23:00 <brunomartin> ThomasWaldmann: I removed the port cause if I do: 'Self': 'http://localhost:8080', the url_for removes the port. This has to do with issue #96... but the tests does not cover any case where the port is not 80.
174 2012-03-20T21:31:37 <brunomartin> brb
175 2012-03-20T21:31:55 <RogerHaase> ThomasWaldmann: while the moin-transclusion class and data-href attribute is HTML specific, a guess is the DocBook, PDF, etc, outputters would also enjoy a sensible DOM structure. So the fix needs to be in include.py or before. Want me to open an issue?
176 2012-03-20T21:34:48 <ThomasWaldmann> with sensible you mean without html extras?
177 2012-03-20T21:35:54 <RogerHaase> No, just no p's within p's, div's within p's, etc.
178 2012-03-20T21:36:30 *** dwcramer
179 2012-03-20T21:37:40 <ThomasWaldmann> RogerHaase: yes, it should be valid. keep in mind that moin dom is not html dom, but likely we want similar rules i guess.
180 2012-03-20T21:37:43 <ThomasWaldmann> waldi: ^^
181 2012-03-20T21:39:01 *** in3xes
182 2012-03-20T21:40:08 <bretonium> I was thinking about that bms task and where it has to be implemented. All the branching stuff is already implemented in hg, git and other vcs if they are used as backend storage
183 2012-03-20T21:45:54 <ThomasWaldmann> no, that's not an option
184 2012-03-20T21:46:09 <ThomasWaldmann> (we already had that and killed it with reasons)
185 2012-03-20T21:46:39 <ThomasWaldmann> bretonium: ^^
186 2012-03-20T21:47:34 <bretonium> ThomasWaldmann: so, it has to be done on store-independent level? Knowing nothing about the store?
187 2012-03-20T21:52:11 <brunomartin> ThomasWaldmann: so, do you thing it's done, or should I put the port in the interwiki test?
188 2012-03-20T21:55:19 <ThomasWaldmann> brunomartin: yup
189 2012-03-20T21:55:23 <ThomasWaldmann> ehrm
190 2012-03-20T21:55:26 <ThomasWaldmann> bretonium: yup
191 2012-03-20T21:55:39 <ThomasWaldmann> brunomartin: i didn't run the code
192 2012-03-20T21:55:48 <dreimark> too much br names
193 2012-03-20T21:56:00 <brunomartin> rsrsrs
194 2012-03-20T21:56:27 * ThomasWaldmann looks at issue 96
195 2012-03-20T21:56:58 <brunomartin> ThomasWaldmann: I rum the test, but not the moin itself.... should I commit?
196 2012-03-20T21:58:12 <ThomasWaldmann> brunomartin: do you have SERVER_NAME in your wikiconfig(_local/*)?
197 2012-03-20T21:58:27 <dreimark> gn
198 2012-03-20T21:58:35 <ThomasWaldmann> brunomartin: better also try moin :)
199 2012-03-20T21:59:06 <bretonium> > Welcome to Whoosh.org. Birthplace of the International Association of Xena Studies. [...] The 12 Best Xena: Warrior Princess Episodes.
200 2012-03-20T21:59:40 <ThomasWaldmann> yeah!
201 2012-03-20T21:59:52 <ThomasWaldmann> bretonium: google whoosh bitbucket
202 2012-03-20T22:00:16 <bretonium> ThomasWaldmann: yes, found already. That Xena thing was the first result in google.
203 2012-03-20T22:00:38 <brunomartin> bretonium: whoosh python
204 2012-03-20T22:00:42 <brunomartin> ;-)
205 2012-03-20T22:03:43 <ThomasWaldmann> brunomartin: my changeseet for #96 says "Initially this was introduced to fix issue #96 (missing port in url_for(_item) output),
206 2012-03-20T22:03:46 <ThomasWaldmann> but it somehow does not happen any more. "
207 2012-03-20T22:14:24 <ThomasWaldmann> brunomartin: check how the code behaves in tests vs. how it behaves in the live wiki
208 2012-03-20T22:14:28 <brunomartin> ThomasWaldmann: ok, so I will put back the 8080, and test moin...
209 2012-03-20T22:14:56 * ThomasWaldmann suspects something, but not sure yet
210 2012-03-20T22:24:56 <ThomasWaldmann> brunomartin: the urls for atom feed are created with url_for_item(..., _external=False)
211 2012-03-20T22:25:18 <ThomasWaldmann> http://localhost:8080/+feed/atom < see there, the urls in the html have :8080 here
212 2012-03-20T22:29:41 * brunomartin checks
213 2012-03-20T22:39:23 *** dwcramer
214 2012-03-20T22:45:19 *** bretonium
215 2012-03-20T22:48:24 *** surtani
216 2012-03-20T22:50:33 <ThomasWaldmann> i guess i have something to make test run and devel server run more similar
217 2012-03-20T22:52:36 *** bretonium|away
218 2012-03-20T22:58:53 <brunomartin> ThomasWaldmann: if you run the server, it generate with the port, but in test, this does not ocour....
219 2012-03-20T22:59:10 <brunomartin> *occur
220 2012-03-20T23:02:31 <ThomasWaldmann> yeah, i am just fixing that
221 2012-03-20T23:03:15 <ThomasWaldmann> http://paste.pocoo.org/show/568751/ can you try that, brunomartin ?
222 2012-03-20T23:05:02 <ThomasWaldmann> (at least it doesn't break the tests in default branch :)
223 2012-03-20T23:05:17 <brunomartin> worked!!!
224 2012-03-20T23:05:21 <brunomartin> :-)
225 2012-03-20T23:05:29 <brunomartin> running all tests now...
226 2012-03-20T23:06:29 <brunomartin> success! \o/
227 2012-03-20T23:06:51 <brunomartin> should I include the conftest patch in my commit?
228 2012-03-20T23:08:10 <ThomasWaldmann> is it a merge commit?
229 2012-03-20T23:08:35 <brunomartin> I did a rebase...
230 2012-03-20T23:09:09 <brunomartin> https://bitbucket.org/brunomartin/moin-2.0/changesets
231 2012-03-20T23:09:30 <ThomasWaldmann> ok, include it
232 2012-03-20T23:09:34 <brunomartin> the today's changes are not commited yet...
233 2012-03-20T23:09:38 <brunomartin> ok...
234 2012-03-20T23:10:04 <ThomasWaldmann> ehrm, wait
235 2012-03-20T23:10:48 <ThomasWaldmann> i guess we need that in default branch also, so i guess we should commit it there and i can merge it into namespaces branch later (with all the other changes)
236 2012-03-20T23:11:28 <brunomartin> ok...
237 2012-03-20T23:15:11 <brunomartin> done... please check my repo to see if every thing is ok...
238 2012-03-20T23:15:14 <brunomartin> bbl
239 2012-03-20T23:18:22 <ThomasWaldmann> brunomartin: you have "merge" changesets which are not merges
240 2012-03-20T23:26:21 <ThomasWaldmann> brunomartin: you have empty changesets that tell that they in fact changed something
241 2012-03-20T23:26:24 *** RogerHaase
242 2012-03-20T23:28:54 <brunomartin> oh...
243 2012-03-20T23:29:29 <brunomartin> I think are side effects off rebase..
244 2012-03-20T23:30:40 <ThomasWaldmann> maybe review the changeset. i had a quick glance and the impression that they maybe should be collapsed into a few smaller ones.
245 2012-03-20T23:31:05 <ThomasWaldmann> esp. if stuff is changed forth and then back again
246 2012-03-20T23:32:00 <ThomasWaldmann> if you need to apply that test env change from me to successfully test, feel free
247 2012-03-20T23:34:36 *** MattMaker
248 2012-03-20T23:35:05 *** MattMaker
249 2012-03-20T23:52:33 *** dwcramer
250 2012-03-20T23:52:43 *** bretonium
251
