MoinMoin: MoinMoinChat/Logs/moin-dev/2012-09-20

   1 2012-09-20T00:14:49  *** brunomartin has quit IRC
   2 2012-09-20T00:21:35  *** RogerHaase has quit IRC
   3 2012-09-20T00:27:04  *** brunomartin has joined #moin-dev
   4 2012-09-20T00:58:19  *** dcramer_ has joined #moin-dev
   5 2012-09-20T01:04:42  *** technossomy has quit IRC
   6 2012-09-20T01:07:51  *** bilal has quit IRC
   7 2012-09-20T01:09:38  *** bilal has joined #moin-dev
   8 2012-09-20T04:39:35  *** dcramer_ has quit IRC
   9 2012-09-20T04:42:36  *** jek has quit IRC
  10 2012-09-20T04:42:54  *** jek has joined #moin-dev
  11 2012-09-20T04:45:21  *** jek has quit IRC
  12 2012-09-20T04:45:21  *** jek has joined #moin-dev
  13 2012-09-20T08:42:31  <dreimark> ThomasWaldmann: sorry for the dup report
  14 2012-09-20T08:42:33  <dreimark> moin
  15 2012-09-20T10:03:38  *** MattMaker has quit IRC
  16 2012-09-20T11:20:17  *** greg_f has joined #moin-dev
  17 2012-09-20T11:31:45  <ThomasWaldmann> moin
  18 2012-09-20T12:45:54  <eSyr> ThomasWaldmann: http://master19.moinmo.in/4ct10n/diff/HomepageGroupsTemplate?action=diff
  19 2012-09-20T12:48:34  <ThomasWaldmann> wb :)
  20 2012-09-20T13:01:05  <ThomasWaldmann> eSyr: yes, all these comments are not needed there. special case needed in the script, otherwise it will happen again.
  21 2012-09-20T13:05:46  * ThomasWaldmann brb
  22 2012-09-20T13:17:38  <eSyr> thanks.
  23 2012-09-20T13:44:28  *** MattMaker has joined #moin-dev
  24 2012-09-20T13:51:37  *** dwcramer has joined #moin-dev
  25 2012-09-20T14:59:26  *** MattMaker has quit IRC
  26 2012-09-20T15:06:35  <ThomasWaldmann> dwcramer: btw, FYI, the next moin release will have some docbook related changes (docbook export will use minidom now, not 4suite any more)
  27 2012-09-20T15:06:40  <ThomasWaldmann> or pyxml
  28 2012-09-20T15:35:08  *** dwcramer has quit IRC
  29 2012-09-20T16:44:15  *** dwcramer has joined #moin-dev
  30 2012-09-20T16:47:08  *** RogerHaase has joined #moin-dev
  31 2012-09-20T18:54:48  *** RogerHaase1 has joined #moin-dev
  32 2012-09-20T18:56:56  *** RogerHaase has quit IRC
  33 2012-09-20T19:18:26  *** MattMaker has joined #moin-dev
  34 2012-09-20T20:01:54  *** greg_f has quit IRC
  35 2012-09-20T21:08:13  <ThomasWaldmann> dreimark: there is a pull request from 2d ago for selenium stuff. did you review it, shall I accept it?
  36 2012-09-20T21:11:13  *** ChanServ has quit IRC
  37 2012-09-20T21:12:41  <dreimark> ThomasWaldmann: yes, this is the essence from the cr
  38 2012-09-20T21:14:36  <dreimark> I continue on the EP li yan asked for more ideas for the next tests
  39 2012-09-20T21:14:45  <dreimark> brb
  40 2012-09-20T21:17:50  *** ChanServ has joined #moin-dev
  41 2012-09-20T21:17:50  *** lindbohm.freenode.net sets mode: +o ChanServ
  42 2012-09-20T21:18:41  <ThomasWaldmann> well, there is one issue now: if you run "make tests" and you don't have the moin server running, it will crash in those ui_tests
  43 2012-09-20T21:20:58  <CIA-78> Hugh Perkins <hughperkins@gmail.com> default * 1782:f87d2e646c60 2.0/_ui_tests/ (6 files):
  44 2012-09-20T21:20:58  <CIA-78> created a first selenium test, specifically of adding subitems
  45 2012-09-20T21:20:58  <CIA-78> to an item
  46 2012-09-20T21:41:34  *** brunomartin has left #moin-dev
  47 2012-09-20T22:46:31  <dreimark> and we have to add selenium to extra requirement for these tests
  48 2012-09-20T22:49:57  <dreimark> we should skip the tests if the moin server is not running, or we have to starit
  49 2012-09-20T22:50:09  <ThomasWaldmann> or if selenium is not installed
  50 2012-09-20T22:50:48  <dreimark> yes, and request if the url exists
  51 2012-09-20T22:51:31  <dreimark> with a proper message what is needed to run these tests
  52 2012-09-20T23:10:52  <CIA-78> Matthijs Kooijman <matthijs@stdin.nl> default * 5889:e2754e834244 1.9/MoinMoin/ (action/edit.py config/multiconfig.py):
  53 2012-09-20T23:10:52  <CIA-78> add a require_comment configuration directive.
  54 2012-09-20T23:10:52  <CIA-78> This allows the comment to be made mandatory, with an appropriate save
  55 2012-09-20T23:10:52  <CIA-78> error when no comment is given.
  56 2012-09-20T23:10:54  <CIA-78> Matthijs Kooijman <matthijs@stdin.nl> default * 5890:6d5105a45257 1.9/MoinMoin/action/edit.py: (log message trimmed)
  57 2012-09-20T23:10:54  <CIA-78> on a save error, show the editor again and highlight the error as such
  58 2012-09-20T23:10:54  <CIA-78> Previously, the (unsaved) page would be shown again, with a small
  59 2012-09-20T23:10:54  <CIA-78> message with class="info" at the top. It is easy to miss the save error
  60 2012-09-20T23:10:55  <CIA-78> like this, especially since you get the page again instead of the
  61 2012-09-20T23:10:55  <CIA-78> editor. Also, browsers might not always preserve your editor contents
  62 2012-09-20T23:10:56  <CIA-78> after pressing the back button.
  63 2012-09-20T23:10:56  <CIA-78> Matthijs Kooijman <matthijs@stdin.nl> default * 5891:16f3285443ca 1.9/MoinMoin/ (action/edit.py config/multiconfig.py):
  64 2012-09-20T23:10:57  <CIA-78> rename require_comment option to comment_required
  65 2012-09-20T23:10:57  <CIA-78> Also improve the wording of the option help text.
  66 2012-09-20T23:24:49  *** dwcramer has quit IRC
  67