1 2013-07-14T00:03:57 *** ashutosh1461
2 2013-07-14T00:28:18 * ananasova says good night :)
3 2013-07-14T01:14:48 *** ashutosh1461
4 2013-07-14T01:17:43 *** ashutosh1461
5 2013-07-14T02:19:56 *** ashutosh1461
6 2013-07-14T02:36:10 *** ashutosh1461
7 2013-07-14T03:01:15 <sharky93> moin
8 2013-07-14T03:29:43 *** ashutosh1461
9 2013-07-14T03:42:37 *** ashutosh1461
10 2013-07-14T04:09:46 *** ashutosh1461
11 2013-07-14T04:10:40 *** ashutosh1461
12 2013-07-14T05:59:52 *** ashutosh1461
13 2013-07-14T06:12:31 *** ashutosh1461
14 2013-07-14T06:37:50 *** ashutosh1461
15 2013-07-14T06:57:57 <dreimark> moin
16 2013-07-14T07:00:21 <ananasova> moin
17 2013-07-14T07:06:49 <dreimark> spy_: no calendar entry, what have you done?
18 2013-07-14T07:15:58 <ThomasWaldmann> moin
19 2013-07-14T07:53:04 *** rciorba
20 2013-07-14T07:56:26 <spy_> dreimark: moin, I'm finally leaving Italy today and will be at the airport soon, so will make a meeting report later.
21 2013-07-14T08:49:07 * ThomasWaldmann bbl at meeting time
22 2013-07-14T09:10:51 *** ashutosh1461
23 2013-07-14T09:21:45 *** ashutosh1461
24 2013-07-14T10:01:48 <ananasova> start
25 2013-07-14T10:01:52 <ThomasWaldmann> moin :)
26 2013-07-14T10:02:01 <ananasova> moin
27 2013-07-14T10:02:05 <ThomasWaldmann> who's with us?
28 2013-07-14T10:02:29 <sharky93> present sir
29 2013-07-14T10:03:57 <ThomasWaldmann> dreimark: eSyr-ng: eSyr: spy_: TheSheep: waldi: xiaq: meeting time
30 2013-07-14T10:04:38 <ananasova> can i be not among the last to present (in the middle maybe)? i have to leave soon
31 2013-07-14T10:04:55 <ThomasWaldmann> maybe i can begin by pointing some stuff out ( ananasova: yes )
32 2013-07-14T10:05:16 <ThomasWaldmann> many of you didn't push anything yet to their public repositories.
33 2013-07-14T10:05:27 <ThomasWaldmann> this is bad in multiple ways:
34 2013-07-14T10:05:38 * eSyr here
35 2013-07-14T10:05:39 <ThomasWaldmann> you may have no backup
36 2013-07-14T10:05:49 <ThomasWaldmann> your mentor has no easy way to try your code
37 2013-07-14T10:06:14 <ThomasWaldmann> you risk producing huge changesets or have a lot of work splitting stuff into smaller ones
38 2013-07-14T10:06:28 * xiaq here
39 2013-07-14T10:06:50 <ThomasWaldmann> i know it is not easy, but try to work on small clean changesets and push daily.
40 2013-07-14T10:07:18 <ThomasWaldmann> and first concentrate on finishing almost-finished stuff before continuing to work on new stuff.
41 2013-07-14T10:07:46 <ThomasWaldmann> xiaq: eSyr: okay, looks like you are first, please start :)
42 2013-07-14T10:08:12 *** ashutosh1461
43 2013-07-14T10:08:15 <waldi> here
44 2013-07-14T10:08:24 <xiaq> (first of all, apologies for lack of work: i guess i'm a bit too relaxed at the beginning of vacation... i'll settle down and keep up from now on.)
45 2013-07-14T10:08:27 <xiaq> LAST: non-DataTables TicketIndex implementation
46 2013-07-14T10:08:30 <xiaq> BLOCKER: none
47 2013-07-14T10:08:32 <xiaq> NEXT: finish non-DataTables TicketIndex implementation
48 2013-07-14T10:09:36 <ThomasWaldmann> xiaq: did you think about using items vs. using views?
49 2013-07-14T10:10:38 <xiaq> ThomasWaldmann: yeah i have some thought about it. replying on cr after meeting :)
50 2013-07-14T10:10:50 <ThomasWaldmann> welcome back esyr, btw - seen you rarely recently
51 2013-07-14T10:11:19 <eSyr> yes :|
52 2013-07-14T10:11:41 * ThomasWaldmann just doesn't want to fall back to 1.9 like way of "making views with items and macros"
53 2013-07-14T10:12:09 <eSyr> hm, why not?
54 2013-07-14T10:12:37 <eSyr> i mean, i do not see anything bad in describing templates using wiki markup.
55 2013-07-14T10:12:44 <ThomasWaldmann> namespace pollution, markup + macro is less flexible than just creating a view with a template
56 2013-07-14T10:13:09 <eSyr> hm, ok.
57 2013-07-14T10:13:28 <ThomasWaldmann> just see those lots of system pages we had in 1.9 (and needed to maintain translated)
58 2013-07-14T10:13:36 <ThomasWaldmann> in 2, we don't have any yet
59 2013-07-14T10:14:15 <ThomasWaldmann> which makes global index much cleaner so wiki users will see their contents, not just a ton of sys pages
60 2013-07-14T10:14:31 <eSyr> mmm, it's question of presentation, i think.
61 2013-07-14T10:14:44 <eSyr> anyway, let's discuss it after meeting.
62 2013-07-14T10:14:59 <eSyr> *matter of
63 2013-07-14T10:15:09 <ThomasWaldmann> xiaq: what's left to do for ticket index? can you be more specific?
64 2013-07-14T10:16:20 <ThomasWaldmann> waldi: ananasova: please prepare, you are next after xiaq / esyr have finished.
65 2013-07-14T10:16:56 <xiaq> ThomasWaldmann: i'll do the "displaying widget" system. i have some code wip now, will upload to cr shortly.
66 2013-07-14T10:17:47 <ThomasWaldmann> so one displaying widget per metadata value type?
67 2013-07-14T10:18:45 <xiaq> ThomasWaldmann: no, most metadata value types just use the 'plain' widget, i.e. calling str() and put into the html.
68 2013-07-14T10:19:47 <ThomasWaldmann> ok. anything else for xiaq?
69 2013-07-14T10:20:37 <ThomasWaldmann> looks like not. ananasova: you're next :)
70 2013-07-14T10:20:43 <ananasova> DONE
71 2013-07-14T10:20:43 <ananasova> * Admin traceback emails - https://codereview.appspot.com/11139044/
72 2013-07-14T10:20:43 <ananasova> * Changes to user subscriptions: the user subscribe/unsubscribe, indexing subscriptions, determining subscriptions, validation of subscriptions, cleanup and simple updates - all the other crs
73 2013-07-14T10:20:47 <ananasova> * Created some sample static templates for user notifications
74 2013-07-14T10:20:58 <ananasova> TODO next week:
75 2013-07-14T10:20:58 <ananasova> * Make the appropriate changes after mentors' suggestions, commit and push
76 2013-07-14T10:20:59 <ananasova> * Notifications on item modification - signalling, determining the diff (metadiff and datadiff), rendering mail templates and sending mails
77 2013-07-14T10:21:13 <ananasova> BLOCKERS: none
78 2013-07-14T10:22:23 <ThomasWaldmann> https://codereview.appspot.com/11139044/ did you find out about how to access log level so you maybe can write it into subject?
79 2013-07-14T10:22:59 <ananasova> yes, second patch contains a get_log_level() function
80 2013-07-14T10:23:04 <waldi> my problem right now: I want to see small commits, and at least one every day. right now they are "lets do anything"
81 2013-07-14T10:24:50 <waldi> ananasova: this is not the log level of the event but the minimal log level
82 2013-07-14T10:25:03 <ananasova> i was mistaken about the workflow. my bad i thought a cr should be approved and just afterwords commited. since now i will push regularly
83 2013-07-14T10:25:42 <ThomasWaldmann> that wasn't mistaken
84 2013-07-14T10:25:53 <ThomasWaldmann> the problem is just never finishing something :)
85 2013-07-14T10:26:07 <ThomasWaldmann> so it grows and grows and grows...
86 2013-07-14T10:26:12 <dreimark> it it too much in the pipeline
87 2013-07-14T10:26:39 <ThomasWaldmann> btw, doing small stuff and making sure via unit test that it works might help
88 2013-07-14T10:27:03 <ananasova> i run the tests all the time.
89 2013-07-14T10:27:11 <waldi> you don't write any
90 2013-07-14T10:27:26 <waldi> not true, sorry
91 2013-07-14T10:27:28 <ananasova> waldi: i will fix the extracting of the log level
92 2013-07-14T10:27:29 <ThomasWaldmann> i have seen some for subscriptions
93 2013-07-14T10:28:13 <ThomasWaldmann> (just was thinking about code duplication there, but we can fix that in a later changeset)
94 2013-07-14T10:28:33 <dreimark> ananasova: you have to write tests for your contributions
95 2013-07-14T10:28:55 <ThomasWaldmann> ananasova: waldi: did you discuss/document ideas about bounce handling?
96 2013-07-14T10:29:05 <ananasova> no
97 2013-07-14T10:29:05 <waldi> nope
98 2013-07-14T10:29:37 <ThomasWaldmann> maybe start that early, as it likely will take some time until ideas have condensed enough for implementation
99 2013-07-14T10:30:29 <ThomasWaldmann> TheSheep: ashutosh1461: are you with us?
100 2013-07-14T10:30:47 <ashutosh1461> present
101 2013-07-14T10:31:27 <ThomasWaldmann> anything else for ananasova / waldi ?
102 2013-07-14T10:32:14 <waldi> not right now
103 2013-07-14T10:32:24 <ThomasWaldmann> ananasova: btw, check my "it even short-circuits" comment whether there is a iterator inside "any()", not a list
104 2013-07-14T10:32:51 <ananasova> yes, i will check all the comments and update
105 2013-07-14T10:32:54 <ThomasWaldmann> ok, ashutosh1461 is next
106 2013-07-14T10:34:13 * ThomasWaldmann is really happy that we'll have a more sane email/notification system in moin2 than in 1.x
107 2013-07-14T10:35:32 <ashutosh1461> DONE
108 2013-07-14T10:35:33 <ashutosh1461> mostly updated stuff done previously
109 2013-07-14T10:35:33 <ashutosh1461> finalized validation patches
110 2013-07-14T10:35:33 <ashutosh1461> updated code for /+deleted view, handling links and fqname support in middlewares
111 2013-07-14T10:35:33 <ashutosh1461> pending cr :- https://codereview.appspot.com/10707048/
112 2013-07-14T10:35:33 <ashutosh1461> Blockers:-
113 2013-07-14T10:35:35 <ashutosh1461> some UI stuff, that is causing problems due to my lack of experience in jquery.
114 2013-07-14T10:36:08 <ThomasWaldmann> xiaq: maybe we need __str__ (or __unicode__ rather) to get a plain text rendering and also __html__ for html rendering?
115 2013-07-14T10:36:26 * ThomasWaldmann just was thinking about how ananasova will render the metadata within notification emails
116 2013-07-14T10:37:28 <ThomasWaldmann> ashutosh1461: i can't help you much about javascript, but you can ask other mentors.
117 2013-07-14T10:38:03 <ashutosh1461> ananasova is helping me currently to get things done :)
118 2013-07-14T10:38:03 <xiaq> ThomasWaldmann: makes sense
119 2013-07-14T10:38:37 <ThomasWaldmann> ananasova: thanks. FOSS work is all about collaboration. :D
120 2013-07-14T10:39:22 <ThomasWaldmann> ashutosh1461: i'll look at the CR asap, somehow i miss sometimes that there was just a patch upload and no comment.
121 2013-07-14T10:40:09 <ThomasWaldmann> ashutosh1461: see also the stuff i said at the beginning of today's session, also applies to you.
122 2013-07-14T10:40:12 <ashutosh1461> ThomasWaldmann, no problems.
123 2013-07-14T10:41:02 <ThomasWaldmann> i also need your code on your public bb repo, so i can try it.
124 2013-07-14T10:41:06 *** sharky93|moin
125 2013-07-14T10:41:48 <ThomasWaldmann> ashutosh1461: NEXT?
126 2013-07-14T10:42:07 <ashutosh1461> fine i will finalize the pending stuff asap so that it all makes sense and is connected.
127 2013-07-14T10:42:15 <ThomasWaldmann> anything else for ashutosh1461 ?
128 2013-07-14T10:42:58 <ThomasWaldmann> ashutosh1461: so goal for next week is to finish current stuff and have small changesets pushed/committed?
129 2013-07-14T10:43:53 <ashutosh1461> ThomasWaldmann, yes finishing current stuff and making cr's for some changes done this week.
130 2013-07-14T10:43:53 <ThomasWaldmann> btw, i have seen some student looking into mercurial queues (mq) - maybe they could exchange experiences about how it is useful for GSOC work.
131 2013-07-14T10:44:14 * sharky93 looves mq
132 2013-07-14T10:44:14 <ThomasWaldmann> or even make a wiki page about it.
133 2013-07-14T10:44:44 <dreimark> +1 for a wiki page
134 2013-07-14T10:45:07 <ThomasWaldmann> mq - the basics :)
135 2013-07-14T10:45:33 <ThomasWaldmann> anything else for ashutosh1461 ?
136 2013-07-14T10:45:58 <ThomasWaldmann> sharky93: TheSheep: you're next
137 2013-07-14T10:46:32 <sharky93> DONE (review pending):
138 2013-07-14T10:46:32 <sharky93> Worked on layout.html, show.html
139 2013-07-14T10:46:32 <sharky93> Wiki name, image, username, login/logout. Settings
140 2013-07-14T10:46:32 <sharky93> Alerts
141 2013-07-14T10:46:32 <sharky93> Breadcrumbs
142 2013-07-14T10:46:34 <sharky93> Global Panel
143 2013-07-14T10:46:37 <sharky93> Local Panel and Tabs
144 2013-07-14T10:46:39 <sharky93> TODO:
145 2013-07-14T10:46:46 <sharky93> Implement other views
146 2013-07-14T10:47:09 <sharky93> one cr lists all @ https://codereview.appspot.com/11209044/
147 2013-07-14T10:47:10 <ThomasWaldmann> spy_: dreimark: you're next after sharky93 / TheSheep have finished (or alternatively after the meeting in case spy is travelling right now)
148 2013-07-14T10:47:42 <dreimark> ok
149 2013-07-14T10:48:08 <ThomasWaldmann> sharky93: that CR is broken, see https://codereview.appspot.com/11209044/diff/25001/MoinMoin/themes/basic/templates/show.html (that is ALL it will show)
150 2013-07-14T10:48:41 <ThomasWaldmann> usually patches on same CR should build upon each other, but you seem to have done it differently there
151 2013-07-14T10:49:25 <sharky93> Yeah, i thought of it as a way to display smaller changesets.
152 2013-07-14T10:50:12 <sharky93> it won't show others meaning?, one can download the diff i think ?
153 2013-07-14T10:50:42 <ThomasWaldmann> also, you and TheSheep need to decide whether to use bootstrap classes in templates or own classes, there seem to be pros and cons for both ways
154 2013-07-14T10:51:40 <sharky93> yes, we first thought of getting a basic functional theme ready and then build on top
155 2013-07-14T10:51:46 <ThomasWaldmann> a single code review should show one thing (and progress on that thing with subsequent patches)
156 2013-07-14T10:52:45 <sharky93> so any good way of displaying smaller changesets, rather than opening too many cr's ?
157 2013-07-14T10:53:37 <ThomasWaldmann> you just need to find a good size of work
158 2013-07-14T10:53:58 <ThomasWaldmann> if you are systematically changing rather easy stuff, you can do a lot in one
159 2013-07-14T10:54:18 <ThomasWaldmann> if it gets complicated, rather do smaller changes
160 2013-07-14T10:54:34 <sharky93> hmm, will need to discuss it with TheSheep , what works for us
161 2013-07-14T10:54:35 <ThomasWaldmann> and always have one specific idea per changeset
162 2013-07-14T10:55:14 <sharky93> yeah
163 2013-07-14T10:55:21 <ThomasWaldmann> TheSheep: you are with us now?
164 2013-07-14T10:56:33 <sharky93> TheSheep had mentioned about the last week being busier than xpected for him, this coming week should be more loose
165 2013-07-14T10:56:48 <ThomasWaldmann> ok, anyone else having question for sharky93 / about bootstrap and theming?
166 2013-07-14T10:57:55 <ThomasWaldmann> sharky93: at some time later, you maybe also can use xiaq's metadata rendering methods
167 2013-07-14T10:58:32 * sharky93 makes a note
168 2013-07-14T11:00:03 <ThomasWaldmann> btw, before you do "TODO implement other views", you also work on making clean changesets for what you already have done, get it reviewed by TheSheep and get some stuff committed and pushed to your public repo.
169 2013-07-14T11:01:05 <sharky93> hmm, sure
170 2013-07-14T11:01:41 <ThomasWaldmann> midterm is in 2 weeks and all students should have SOME good working code by then
171 2013-07-14T11:02:03 <sharky93> i have the changesets ready, hopefully push them Monday :)
172 2013-07-14T11:02:41 <ThomasWaldmann> ok, looks like TheSheep is busy otherwise. grab him later for codereview.
173 2013-07-14T11:02:48 <sharky93> willdo
174 2013-07-14T11:02:50 <ThomasWaldmann> anything else for sharky93 ?
175 2013-07-14T11:04:11 <ThomasWaldmann> ok, looks like we are finished for today. happy hacking! :)
176 2013-07-14T11:04:44 * ThomasWaldmann will be here for about 0.5h then working on some hw stuff
177 2013-07-14T11:05:54 * ananasova will appear in the evening and apply all the mentors recommentions, including pushing stuff to public repo
178 2013-07-14T11:09:01 *** sharky93|moin
179 2013-07-14T11:09:23 <ThomasWaldmann> ah, one more thing: after you have published your changes, you should also have your bb repo issue tracker enabled, so it can be used for the feedback you'll get :)
180 2013-07-14T11:11:30 * dreimark has to go soon
181 2013-07-14T11:16:53 <dreimark> bbl
182 2013-07-14T11:24:07 *** greg_f
183 2013-07-14T11:39:27 *** greg_f
184 2013-07-14T11:40:23 *** greg_f
185 2013-07-14T12:13:36 *** greg_f
186 2013-07-14T12:52:15 *** ashutosh1461
187 2013-07-14T14:19:11 <rciorba> ThomasWaldmann: PR here https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/174/367-add-email-verification-on-email-change/diff
188 2013-07-14T16:43:41 <TheSheep> ThomasWaldmann: I'm sorry, I forgot
189 2013-07-14T16:57:42 *** bilal
190 2013-07-14T19:15:20 <ThomasWaldmann> re
191 2013-07-14T19:20:31 <ThomasWaldmann> rciorba: pulled/pushed. thanks!
192 2013-07-14T19:21:45 <ThomasWaldmann> rciorba: this was issue #367, right?
193 2013-07-14T19:22:15 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/367/verify-change-of-email-address
194 2013-07-14T19:22:18 <ThomasWaldmann> dreimark: ^
195 2013-07-14T19:26:28 <dreimark> rciorba: :)
196 2013-07-14T21:09:54 <rciorba> yes it's 367
197 2013-07-14T21:11:06 <rciorba> my first patch.. sniff.. sniff.. a very emotional moment :)
198 2013-07-14T21:11:21 <ThomasWaldmann> \o/
199 2013-07-14T21:12:34 <rciorba> i started looking at lxml test failures
200 2013-07-14T21:15:27 <rciorba> i'll post a review request for what i've got now.. one issue is straight-forward(the uri schema in some tests is not a valid schema) but then there's the issue of how to deal with invalid schemas (one test explicitly testing for javascript:STUFF) that are now rendering as href="None"
201 2013-07-14T21:23:45 <rciorba> https://codereview.appspot.com/11254043/
202 2013-07-14T21:23:57 <rciorba> whenever anyone has the time
203 2013-07-14T21:44:30 <ThomasWaldmann> rciorba: done
204 2013-07-14T21:47:11 <rciorba> rationale: so that's the nasty part that i wanted some advice on
205 2013-07-14T21:47:28 <rciorba> javascript is not an allowed schema
206 2013-07-14T21:48:26 <rciorba> and the current handling is to not set the attribute, and i suspect at some point in the conversion a .get() supplies a None that gets rendered
207 2013-07-14T21:49:39 <rciorba> correction: href = element.get(..) is the point
208 2013-07-14T21:50:46 <rciorba> the alternative is to handle None attributes in the out converters
209 2013-07-14T21:53:06 <rciorba> the javascript schema is in this test: https://bitbucket.org/thomaswaldmann/moin-2.0/src/9c6013f454da2340be9586948c4b0aebd6f58e1d/MoinMoin/converter/_tests/test_docbook_in.py?at=default#cl-275
210 2013-07-14T21:59:25 * ThomasWaldmann looks...
211 2013-07-14T22:01:53 <ThomasWaldmann> rciorba: that js href must not work for docbook, would cause xss
212 2013-07-14T22:02:02 <rciorba> yes
213 2013-07-14T22:02:30 <rciorba> but the test fails because it expects href="" and gets href="None"
214 2013-07-14T22:02:49 <ThomasWaldmann> if your "" fixes that: add a comment why you do it and it's fine
215 2013-07-14T22:03:01 <rciorba> ok
216 2013-07-14T22:03:43 <rciorba> i was wondering if there's a better way to handle None's on the output converters
217 2013-07-14T22:04:55 <rciorba> this will convert one None value for one case, maybe there's a more generic place to handle None values
218 2013-07-14T22:06:10 <rciorba> anyway i'll clean the current patch up and if you have any suggestions for the above question please let me know
219 2013-07-14T22:06:21 <ThomasWaldmann> well, if it just happens in case someone tries to xss, we can live with anything except the real link :)
220 2013-07-14T22:11:31 <rciorba> also gopher exotic? it's one of the most conservative protocols out there :D
221 2013-07-14T22:22:08 <rciorba> updated https://codereview.appspot.com/11254043/ gonna follow up tomorrow, have a good night
222 2013-07-14T22:27:56 <ThomasWaldmann> gn rciorba
223 2013-07-14T22:57:17 *** bilal
224 2013-07-14T23:19:55 *** asingla
225 2013-07-14T23:23:22 *** asingla_
226 2013-07-14T23:25:39 *** rciorba
227 2013-07-14T23:27:51 *** asingla__
228 2013-07-14T23:28:01 *** asingla_1
229 2013-07-14T23:28:26 *** asingla_
230 2013-07-14T23:28:47 *** asingla_1
231 2013-07-14T23:29:38 *** asingla__
232 2013-07-14T23:42:55 <asingla> ThomasWaldmann: please review https://codereview.appspot.com/10707048/
