1 2014-05-20T01:22:16 *** magu_cic
2 2014-05-20T01:23:22 *** magu_cic_
3 2014-05-20T07:58:40 *** xiaq
4 2014-05-20T08:48:13 *** greg_f
5 2014-05-20T09:25:35 *** randomax
6 2014-05-20T09:41:15 *** skathpalia
7 2014-05-20T09:45:27 <skathpalia> moin
8 2014-05-20T09:45:46 <randomax> moin
9 2014-05-20T09:51:10 <dimazest> hello
10 2014-05-20T09:52:25 <skathpalia> dimazest, I have added my reply on etherpad
11 2014-05-20T09:52:47 <skathpalia> we decided that name should not be there in the meta of ticket item
12 2014-05-20T09:53:13 <skathpalia> as discussed with you and ThomasWaldmann
13 2014-05-20T09:53:25 <dimazest> but what is the point then for asking for a name
14 2014-05-20T09:53:44 <dimazest> we were discussing that name is not used for ticket (or item) identification and retrival
15 2014-05-20T09:54:00 <skathpalia> It is just used for item creation
16 2014-05-20T09:54:07 <dimazest> so you can ask moin api, give me a ticket named 'Some ticket'
17 2014-05-20T09:54:11 <skathpalia> it is not there in the meta
18 2014-05-20T09:54:23 <dimazest> instead you ask, give me a name with fname 'weihf49854ghahfsdofdghvaiuyfweuigrh32tg'
19 2014-05-20T09:54:35 <dimazest> ok
20 2014-05-20T09:54:47 <dimazest> how then are tickets made?
21 2014-05-20T09:55:17 <skathpalia> we just add some random name after 127.0.0.1
22 2014-05-20T09:55:41 <skathpalia> e.g. 127.0.0.1/someTicketName
23 2014-05-20T09:55:54 <dimazest> which is never stored
24 2014-05-20T09:55:58 <skathpalia> And then we select type of item to be ticket
25 2014-05-20T09:56:22 <skathpalia> Yeah the name is just temporarily stored until updation
26 2014-05-20T09:56:35 <dimazest> so it **is** stored
27 2014-05-20T09:56:43 <dimazest> but then deleted, when i update
28 2014-05-20T09:56:48 <skathpalia> yeah
29 2014-05-20T09:57:05 <dimazest> so, if i write a small comment after i created a ticket, it will loose it's name
30 2014-05-20T09:57:14 <skathpalia> yeah right
31 2014-05-20T09:57:16 <dimazest> which is rather strange
32 2014-05-20T09:57:27 <dimazest> how do other items deal with name?
33 2014-05-20T09:57:45 <skathpalia> in other items also name is not necessary
34 2014-05-20T09:58:05 <dimazest> right, i'm not saying that it's obligatory field
35 2014-05-20T09:58:16 <skathpalia> for example we can create some other item with some name and then while updating we can leave name as empty
36 2014-05-20T09:58:20 <dimazest> what i'm saying that once we got it, it's strange to forget it
37 2014-05-20T09:58:40 <skathpalia> Thats why I suggested that instructions part
38 2014-05-20T09:58:45 <skathpalia> for the user
39 2014-05-20T09:58:59 <skathpalia> so that he knows that how is it going to work
40 2014-05-20T09:59:08 <skathpalia> He should never rely on name
41 2014-05-20T09:59:34 <dimazest> should we make it the way users expect it to word, not instruct them
42 2014-05-20T09:59:37 <dimazest> ok
43 2014-05-20T09:59:53 <dimazest> let say i'm typed localhost:some_awesome_ticket
44 2014-05-20T10:00:09 <dimazest> entered all the fields
45 2014-05-20T10:00:20 <dimazest> pushed the create button
46 2014-05-20T10:00:35 <dimazest> what would be the link for the newly created item?
47 2014-05-20T10:01:16 <skathpalia> The link would be something like this 127.0.0.1/@itemid/some_ITEMID
48 2014-05-20T10:02:07 <skathpalia> In the ticket list also that I would make it would also have similar links of tickets
49 2014-05-20T10:02:12 <skathpalia> no name in the links
50 2014-05-20T10:02:25 <skathpalia> as each item can be accessed by both itemid and namr
51 2014-05-20T10:02:27 <skathpalia> *name
52 2014-05-20T10:02:58 <skathpalia> in this case name is a temporary so always we would make links having ITEMIDS
53 2014-05-20T10:04:26 <dimazest> hmmm
54 2014-05-20T10:04:34 <dimazest> i see
55 2014-05-20T10:04:40 <dimazest> why not to do the following
56 2014-05-20T10:06:02 <dimazest> once i enter, 127.0.0.1/someTicketName i'm redirected to 127.0.0.1/new_item (which is some default handler for creating new items)
57 2014-05-20T10:06:37 <dimazest> with a possible message, saying that the resource the user has requested doesn't exists, so a new can be created
58 2014-05-20T10:07:39 <dimazest> because it's a redirect, we don't care for the previous url, so name as such doesn't exist and the need of updating a ticket *and* removing it's name is unnecessary
59 2014-05-20T10:07:59 <dimazest> but this might be a rather radical redesign
60 2014-05-20T10:10:33 <skathpalia> So you are saying that when we go to create a new item by typing 127.0.0.1/somename then if we select ticket then we are redirected to 127.0.0.1/new_item where this new item is a default name
61 2014-05-20T10:10:35 <skathpalia> right?
62 2014-05-20T10:11:01 <dimazest> not exactly
63 2014-05-20T10:11:01 <skathpalia> I mean this new_item is a default name
64 2014-05-20T10:11:06 <dimazest> no
65 2014-05-20T10:11:10 <dimazest> forget about the name
66 2014-05-20T10:13:43 <skathpalia> so can you please explain it again?
67 2014-05-20T10:14:32 <dimazest> ok
68 2014-05-20T10:14:59 <dimazest> when a user enters an url 127.0.0.1/SOME_TEXT_DOESNT_MATTTER_WHAT
69 2014-05-20T10:15:07 <dimazest> this code handles the call
70 2014-05-20T10:15:07 <dimazest> 127.0.0.1/new_item
71 2014-05-20T10:15:18 <dimazest> https://bitbucket.org/thomaswaldmann/moin-2.0/src/4a997d9f5e26515b90c744582be8aa7393bb57d1/MoinMoin/apps/frontend/views.py?at=default#cl-400
72 2014-05-20T10:15:21 <dimazest> right
73 2014-05-20T10:15:39 <dimazest> (forget about the line 127... i've pasted a wrong thing)
74 2014-05-20T10:18:50 <skathpalia> Yeah this code handles that
75 2014-05-20T10:19:17 <dimazest> there is if
76 2014-05-20T10:19:32 <dimazest> which checks whether such an item exists
77 2014-05-20T10:19:54 <dimazest> if not, then it's created
78 2014-05-20T10:19:57 <dimazest> passing the name
79 2014-05-20T10:19:58 <dimazest> https://bitbucket.org/thomaswaldmann/moin-2.0/src/4a997d9f5e26515b90c744582be8aa7393bb57d1/MoinMoin/apps/frontend/views.py?at=default#cl-412
80 2014-05-20T10:20:08 <skathpalia> yeah
81 2014-05-20T10:20:50 <dimazest> sorry i need to go
82 2014-05-20T10:21:01 <dimazest> can we discuss it a bit later
83 2014-05-20T10:21:24 <dimazest> in the meantime, have a look inside of Item.create(item_name, rev_id=rev)
84 2014-05-20T10:21:25 <skathpalia> Ok then please post it here only even if I am not here
85 2014-05-20T10:21:32 <skathpalia> I will read the logs surely
86 2014-05-20T10:44:19 *** randomax
87 2014-05-20T11:00:50 *** derdon
88 2014-05-20T12:22:20 *** randomax
89 2014-05-20T13:43:40 *** skathpalia
90 2014-05-20T14:17:11 *** RogerHaase
91 2014-05-20T14:49:29 <ThomasWaldmann> moin
92 2014-05-20T15:25:45 <randomax> moin
93 2014-05-20T15:26:15 <dimazest> hello
94 2014-05-20T15:27:10 <dimazest> ThomasWaldmann: i don't see a reason, why ticket name has to be removed on update
95 2014-05-20T15:28:07 <dimazest> this code creates an item https://bitbucket.org/thomaswaldmann/moin-2.0/src/4a997d9f5e26515b90c744582be8aa7393bb57d1/MoinMoin/items/__init__.py?at=default#cl-297
96 2014-05-20T15:28:58 <dimazest> name is converted to fqname, and that's it
97 2014-05-20T15:29:08 <dimazest> or, am i looking to a wrong place
98 2014-05-20T15:32:16 <dimazest> and in the ticket forms, there is nothing about the name
99 2014-05-20T15:38:45 *** skathpalia
100 2014-05-20T15:39:59 <skathpalia> moin
101 2014-05-20T15:41:04 <dimazest> hello
102 2014-05-20T15:41:19 <dimazest> skathpalia: if you have a look here
103 2014-05-20T15:41:19 <dimazest> https://bitbucket.org/thomaswaldmann/moin-2.0/src/4a997d9f5e26515b90c744582be8aa7393bb57d1/MoinMoin/items/__init__.py?at=default#cl-297
104 2014-05-20T15:41:32 <dimazest> then the name is not actually stored there
105 2014-05-20T15:41:52 <dimazest> could it be a case that a name is set somewhere else?
106 2014-05-20T15:42:08 <dimazest> otherwise i don't see a reason, why it has to be deleted on update
107 2014-05-20T15:43:26 <skathpalia> yeah it seems that name is set somewhere else
108 2014-05-20T15:46:26 <skathpalia> dimazest, what exactly you were saying early regarding the workflow? can you explain it once again?
109 2014-05-20T15:48:01 <dimazest> i guess it's not really relevant
110 2014-05-20T15:48:11 <dimazest> because the current code doesn't depend on the name
111 2014-05-20T15:48:18 <skathpalia> According to me that the initial name thing seems Ok as we would always refer the ticket by ITEMID
112 2014-05-20T15:48:22 <dimazest> (the ticket creation code)
113 2014-05-20T15:49:43 <skathpalia> even in the ticket list also we will have the links of type 127.0.0.1/@itemid/ITEMID only
114 2014-05-20T15:49:53 <skathpalia> whether it has name or no name
115 2014-05-20T15:50:42 <skathpalia> what are your thoughts?
116 2014-05-20T15:50:44 <dimazest> look, i think the reason for the exception http://paste.ubuntu.com/7471496/
117 2014-05-20T15:51:07 <dimazest> /Users/dimazest/Documents/moin-2.0/MoinMoin/util/notifications.py:180
118 2014-05-20T15:51:29 <dimazest> def get_item_last_revisions(app, item_name):
119 2014-05-20T15:51:29 <dimazest> """ Get 2 or less most recent item revisions from the index
120 2014-05-20T15:51:29 <dimazest> :param app: local proxy app
121 2014-05-20T15:51:29 <dimazest> :param item_name: the name of the item
122 2014-05-20T15:51:29 <dimazest> :return: a list of revisions
123 2014-05-20T15:51:29 <dimazest> """
124 2014-05-20T15:51:32 <skathpalia> Yeah I also saw that part
125 2014-05-20T15:51:47 <skathpalia> and most probably I found the solution
126 2014-05-20T15:52:43 <skathpalia> Solution is that we send https://bitbucket.org/thomaswaldmann/moin-2.0/src/4a997d9f5e26515b90c744582be8aa7393bb57d1/MoinMoin/items/__init__.py?at=default#cl-620 here we send fqname as written in the comment above
127 2014-05-20T15:53:06 <skathpalia> Then we will fetch that name in the notifications.py
128 2014-05-20T15:53:31 <skathpalia> Actually this is currently reliable on item_name
129 2014-05-20T15:54:16 <skathpalia> so as we will now send fqname so we will be uniquely identify as fqname also has ITEMID
130 2014-05-20T15:54:33 <dimazest> ok
131 2014-05-20T15:54:40 <skathpalia> and then the notification can be sent containing fqname
132 2014-05-20T15:55:48 <skathpalia> This is very nice in the sense that suppose there are items with 2 names "foo" and "bar" then he will also be notified that which item was changed
133 2014-05-20T15:55:55 <skathpalia> I mean by which name
134 2014-05-20T15:56:17 <skathpalia> User will be notified of that
135 2014-05-20T15:57:01 <skathpalia> I think there should be some summarization
136 2014-05-20T15:57:05 <skathpalia> of this
137 2014-05-20T15:57:18 <skathpalia> I am writing about this on EP
138 2014-05-20T15:58:12 <dimazest> maybe make it more document like
139 2014-05-20T15:58:18 <dimazest> less than a chat
140 2014-05-20T16:02:53 <skathpalia> Yeah once I am done with the making ticket updation work properly I will add the desired information in the official docs
141 2014-05-20T16:03:06 <skathpalia> btw I have added summary on my EP
142 2014-05-20T16:06:00 <skathpalia> dimazest, ^^
143 2014-05-20T16:07:28 <dimazest> ok
144 2014-05-20T16:07:59 <dimazest> "User enters 127.0.0.1/some_name"
145 2014-05-20T16:08:16 <dimazest> some_name means any string, not exactly some_name
146 2014-05-20T16:08:23 <skathpalia> yeah
147 2014-05-20T16:08:26 <dimazest> it could be "other_name
148 2014-05-20T16:08:32 <dimazest> just to be clear :)
149 2014-05-20T16:08:37 <skathpalia> :)
150 2014-05-20T16:09:03 <skathpalia> So now I am working on ticket update work properly
151 2014-05-20T16:10:07 <skathpalia> I got a solution that in the fields Superseded By and Depends On, it tries to fetch the names of other tickets and since tickets have no name so it is causing error
152 2014-05-20T16:10:52 <dimazest> so it should not fetch names
153 2014-05-20T16:11:10 <skathpalia> also it tries to fetch ITEMID
154 2014-05-20T16:11:21 <skathpalia> Yeah I would make it fetch only ITEMID
155 2014-05-20T16:14:42 <skathpalia> gtg will be back in 20 minutes
156 2014-05-20T16:20:59 *** randomax
157 2014-05-20T16:30:09 *** sl33k_
158 2014-05-20T16:34:58 *** dave_largo
159 2014-05-20T16:35:31 <sl33k_> I am thinking of contributing to MoinMoin. But I have no relevant free software experience. Are there beginner tasks to get me up to speed?
160 2014-05-20T16:35:58 <skathpalia> ThomasWaldmann, I was going through my codereviews and I found 2 pending
161 2014-05-20T16:38:09 <RogerHaase> sl33k_: hi, the links you need for moin2 are here: http://moinmo.in/MoinMoin2.0
162 2014-05-20T16:38:47 <skathpalia> this one solves #424 https://codereview.appspot.com/80700049/
163 2014-05-20T16:38:56 <skathpalia> ThomasWaldmann, can you please review it
164 2014-05-20T16:39:20 <skathpalia> the patchset 2 is the revelant one
165 2014-05-20T16:39:27 <skathpalia> *relevant
166 2014-05-20T16:40:19 <RogerHaase> sl33k_: where are you in install process? installed hg? made a clone?
167 2014-05-20T16:50:08 <sl33k_> RogerHaase: Just cloned the repo. Also following install instructions from here http://moin-20.readthedocs.org/en/latest/admin/install.html
168 2014-05-20T16:54:37 <RogerHaase> sl33k_: great, after you get the server running and create or modify a page or 2, then continue with reading http://moin-20.readthedocs.org/en/latest/devel/development.html
169 2014-05-20T17:01:38 <RogerHaase> sl33k_: forgot to mention; the default theme (Basic) is currently broken in too many places. When you get your server running, you will better experience if you create a login ID and switch theme to Modernized.
170 2014-05-20T17:25:59 <sl33k_> Thanks. Going through the resource...
171 2014-05-20T17:55:32 *** greg_f
172 2014-05-20T17:57:55 *** skathpalia
173 2014-05-20T18:18:45 <sl33k_> Installing shows some error http://paste.ubuntu.com/7494085/
174 2014-05-20T18:19:43 <sl33k_> at line 535. Do I ignore it?
175 2014-05-20T18:24:31 *** derdon
176 2014-05-20T18:26:24 *** derdon
177 2014-05-20T18:26:26 <RogerHaase> sl33k_: iirc, that one can be ignored; if you do ./m log quickinstall to show complete detail, it will say it used pure python or something like that
178 2014-05-20T19:12:46 <ThomasWaldmann> dimazest: https://dudle.inf.tu-dresden.de/moin_gsoc2014_weekly/ update to UTC please (and also tell students)
179 2014-05-20T19:13:32 <ThomasWaldmann> RogerHaase: there are 2 new slots there, please state your availability for them
180 2014-05-20T19:13:44 <ThomasWaldmann> (2 per day)
181 2014-05-20T19:16:28 <RogerHaase> done
182 2014-05-20T19:20:50 <RogerHaase> ThomasWaldmann: did you review my changes to contrib/serialized/items.moin http://www.digitalrockart.org/moin2/ changes to moin, creole, rest, markdown, docbook, removed some todo's, added more examples
183 2014-05-20T19:21:42 <ThomasWaldmann> recent changes from last days?
184 2014-05-20T19:23:35 <RogerHaase> last was may 17, but minor changes since May 11
185 2014-05-20T19:24:01 * ThomasWaldmann looks
186 2014-05-20T19:25:26 <RogerHaase> size will go from 100k+ to 500k+ due to inclusion of video and audio that only works in docbook (as of now)
187 2014-05-20T19:26:58 <ThomasWaldmann> what TODO marker do we use for MediaWiki TODO?
188 2014-05-20T19:28:22 <RogerHaase> seems to rhyme with MoinWiki TODO :-D
189 2014-05-20T19:28:59 <ThomasWaldmann> http://www.digitalrockart.org/moin2/+diff/creole?rev2=7dd5b6e7fe8c4ce4bf4f0ef472c8adf3&rev1=5cba5667d886430db15bf0a247d8cb57
190 2014-05-20T19:29:39 <ThomasWaldmann> if i render that in FF the lower parts of [[ get truncated due to to little line spacing / line height
191 2014-05-20T19:30:05 <ThomasWaldmann> (when the green stuff wraps to a 2nd line)
192 2014-05-20T19:32:42 <ThomasWaldmann> http://www.digitalrockart.org/moin2/+diff/docbook?rev2=7d4b1da0b0a84382a6f72954b689e18a&rev1=97b055346ef344a8b23f1aefcdf53f6b
193 2014-05-20T19:33:14 <ThomasWaldmann> the +get/ stuff somehow seems a bit of a implementation detail, no?
194 2014-05-20T19:34:38 <ThomasWaldmann> the video.mp4 doesn't play by default with the ubuntu media player, it wants to install codecs first
195 2014-05-20T19:34:56 <dimazest> ThomasWaldmann: done
196 2014-05-20T19:36:24 <ThomasWaldmann> the video and audio file are free of (c)?
197 2014-05-20T19:36:28 <ThomasWaldmann> dimazest: thanks
198 2014-05-20T19:36:39 <RogerHaase> I am not sure what you mean by truncated [[, ff display of diff seems OK on windows.
199 2014-05-20T19:37:15 <RogerHaase> no copyright claimed on the pages I downloaded from
200 2014-05-20T19:37:18 <ThomasWaldmann> RogerHaase: the lower pixels of the glyhps are overlapped / overwritten by the next line
201 2014-05-20T19:38:11 <ThomasWaldmann> RogerHaase: well, (c) is by default. it needs to be stated that it is free to copy.
202 2014-05-20T19:38:33 <ThomasWaldmann> maybe use some stuff from wikimedia commons
203 2014-05-20T19:39:53 <RogerHaase> from video: "Feel free to use the following files for whatever you need:"
204 2014-05-20T19:40:07 <ThomasWaldmann> ah, good
205 2014-05-20T19:40:14 * ThomasWaldmann could watch it yet :)
206 2014-05-20T19:40:35 <ThomasWaldmann> +not
207 2014-05-20T19:40:47 <ThomasWaldmann> but the changes look good
208 2014-05-20T19:40:53 <RogerHaase> from audio: The audio test tones below are available for free download and use in your projects
209 2014-05-20T19:48:13 <RogerHaase> ThomasWaldmann: will change moin MWTODO to MOINTODO, then add a DBTODO for the +get; anything else?
210 2014-05-20T19:49:00 <ThomasWaldmann> RogerHaase: don't we have any such todo yet? maybe it is MMTODO?
211 2014-05-20T19:49:22 <ThomasWaldmann> or maybe that stuff should only live in the issue tracker...
212 2014-05-20T19:53:31 <RogerHaase> MMTODO it is. Some of these may be in issue tracker, but not all. Same as XXX and TODOs in source code.
213 2014-05-20T20:03:52 <ThomasWaldmann> sl33k_: hey :) thanks for considering.
214 2014-05-20T20:07:23 <sl33k_> :)
215 2014-05-20T20:07:47 <ThomasWaldmann> there is some stuff on EasyToDo wiki page also
216 2014-05-20T20:09:12 <ThomasWaldmann> of course "easy" is always relative :) can you tell your fields of interest or what kind of stuff you like to do?
217 2014-05-20T20:10:58 <sl33k_> I feel I could grasp wtforms, flask. I also know jQuery
218 2014-05-20T20:11:27 <ThomasWaldmann> we don't use wtforms, but flatland + jinja2 macros
219 2014-05-20T20:11:40 <ThomasWaldmann> but we use jquery
220 2014-05-20T20:13:11 <ThomasWaldmann> (and our javascript maybe could need some more eyes on it - i personally try to stay away from js somehow ;)
221 2014-05-20T20:14:08 <sl33k_> I would also love writing unit tests. I guess pytest is unit testing library like JUnit
222 2014-05-20T20:14:26 <ThomasWaldmann> yeah, pytest is pretty cool
223 2014-05-20T20:14:46 <ThomasWaldmann> a lot of tests could improve, also test coverage
224 2014-05-20T20:14:59 <ThomasWaldmann> we need that for supporting py3 some day also
225 2014-05-20T20:15:57 <sl33k_> Is this the todo page you were mentioning? moinmo.in/EasyToDo
226 2014-05-20T20:17:18 <sl33k_> If flask handles all low level stuff why is Werkzeug needed?
227 2014-05-20T20:17:29 <ThomasWaldmann> yes
228 2014-05-20T20:17:35 <ThomasWaldmann> flask is based on werkzeug
229 2014-05-20T20:17:53 <ThomasWaldmann> both fine stuff from pocoo
230 2014-05-20T20:23:38 <sl33k_> Which editor do you use? I saw Pycharm IDE recommended. Do you use it personally?
231 2014-05-20T20:26:40 <ThomasWaldmann> yeah, it's great
232 2014-05-20T20:27:13 <ThomasWaldmann> of course, IDE (or non-IDE) preferences are a matter of taste, so YMMV
233 2014-05-20T20:28:03 <ThomasWaldmann> if you like to try it, you can start either with the free open source license or with the "pro" test version
234 2014-05-20T20:28:47 <ThomasWaldmann> if you contribute to moin, you can get our project license key later
235 2014-05-20T20:29:36 * ThomasWaldmann gtg / bbl
236 2014-05-20T20:31:29 <sl33k_> see you and thanks for the tips
237 2014-05-20T21:09:25 *** dave_largo
238 2014-05-20T21:17:06 <ThomasWaldmann> re
239 2014-05-20T21:53:58 <RogerHaase> ThomasWaldmann: fyi, the video works on my ubuntu 13.10
240 2014-05-20T21:55:19 <ThomasWaldmann> was 12.04
241 2014-05-20T21:55:48 <ThomasWaldmann> and it wanted to install stuff and then ran into problems when trying :-X
242 2014-05-20T21:59:12 <ThomasWaldmann> video and audio works on 14.04
243 2014-05-20T21:59:24 <ThomasWaldmann> the audio is a bit simple ;)
244 2014-05-20T22:00:23 <RogerHaase> yes, I chose the smallest video and audio files I could find
245 2014-05-20T22:17:59 <ThomasWaldmann> yeah, good idea
246 2014-05-20T22:28:00 <RogerHaase> ThomasWaldmann: pushed and created pull request
247 2014-05-20T22:28:05 <RogerHaase> gtg
248 2014-05-20T22:28:09 *** RogerHaase
249
