1 2014-06-07T00:54:41 *** sl33k_
2 2014-06-07T01:19:47 *** derdon
3 2014-06-07T02:20:56 *** sl33k_
4 2014-06-07T02:31:45 *** sl33k_
5 2014-06-07T02:58:11 *** penguinRaider
6 2014-06-07T04:29:47 *** penguinRaider
7 2014-06-07T04:39:57 *** sl33k_
8 2014-06-07T04:49:58 *** sl33k_
9 2014-06-07T04:55:57 *** sl33k_
10 2014-06-07T05:04:28 *** sl33k_
11 2014-06-07T06:28:27 *** sl33k_
12 2014-06-07T06:34:39 *** sl33k_
13 2014-06-07T07:30:38 *** sl33k_
14 2014-06-07T08:53:47 *** randomax
15 2014-06-07T08:58:37 *** Cthulhux
16 2014-06-07T08:58:37 *** dimazest
17 2014-06-07T08:58:53 *** Cthulhux
18 2014-06-07T08:58:53 *** dimazest
19 2014-06-07T09:01:12 *** jek
20 2014-06-07T09:01:44 *** jek
21 2014-06-07T09:03:34 *** magu_cic
22 2014-06-07T09:04:25 *** Cthulhux
23 2014-06-07T09:04:25 *** dimazest
24 2014-06-07T09:11:19 *** Cthulhux
25 2014-06-07T09:11:19 *** dimazest
26 2014-06-07T10:11:25 *** randomax
27 2014-06-07T10:11:50 *** randomax
28 2014-06-07T10:15:50 *** skathpalia
29 2014-06-07T10:17:13 <skathpalia> ThomasWaldmann, I have updated the cr for ticket list https://codereview.appspot.com/102140045/
30 2014-06-07T10:23:18 *** greg_f
31 2014-06-07T10:26:43 *** skathpalia
32 2014-06-07T10:55:03 *** greg__
33 2014-06-07T10:57:53 *** greg_f
34 2014-06-07T11:30:28 *** greg__
35 2014-06-07T11:32:35 *** sl33k_
36 2014-06-07T12:26:04 *** derdon
37 2014-06-07T12:27:01 *** sl33k_
38 2014-06-07T12:38:59 *** RogerHaase
39 2014-06-07T13:15:30 *** greg_f
40 2014-06-07T13:17:18 *** derdon
41 2014-06-07T13:19:46 *** sl33k_
42 2014-06-07T13:21:36 <randomax> RogerHaase, Hi
43 2014-06-07T13:21:54 <randomax> sorry i cudnt come online yesterday.. my college network was down
44 2014-06-07T13:22:14 <randomax> i worked on acl visualisation in search results
45 2014-06-07T13:22:15 <randomax> http://picpaste.com/pics/acl_search-Jp6Ndf8d.1402147275.png
46 2014-06-07T13:22:52 <randomax> i have a doubt whether to use A, W, R, D for that
47 2014-06-07T13:23:12 <randomax> or write full names like admin, write, read
48 2014-06-07T13:23:27 <randomax> or to try to use some glyphs
49 2014-06-07T13:23:29 <randomax> ?
50 2014-06-07T13:27:10 *** derdon
51 2014-06-07T13:38:32 <randomax> here is one with full name - http://picpaste.com/pics/acl_fullname-raX8tUJz.1402148288.png
52 2014-06-07T13:43:52 *** magu_cic
53 2014-06-07T13:50:29 *** skathpalia
54 2014-06-07T14:04:06 <RogerHaase> randomax: What does admin and write do?
55 2014-06-07T14:04:59 <RogerHaase> Read is like show?
56 2014-06-07T14:06:15 <randomax> write - write (edit, modify) content
57 2014-06-07T14:06:22 <randomax> read - read content
58 2014-06-07T14:06:29 <randomax> admin - change (create, remove) ACLs for the item; to be given only to fully-trusted users
59 2014-06-07T14:06:34 <randomax> destroy - completely destroy revisions or items; to be given only to fully-trusted users
60 2014-06-07T14:08:35 <randomax> admin also has read, write, destroy capability apart from ability to change ACLs
61 2014-06-07T14:11:30 <RogerHaase> assuming read is the same as clicking on itemname, why have it?
62 2014-06-07T14:15:29 <randomax> Umm. I thought I'd keep it uniform.. Besides there is a provision already that whenever a user does not have read permissions for an item, instead of the content extract they'll see something like "You do not have permission to read this item"
63 2014-06-07T14:15:42 <randomax> I'll remove read then..
64 2014-06-07T14:17:16 <RogerHaase> looking at your EP and proposal, I do not see where you were adding these... what do you mean by uniform?
65 2014-06-07T14:21:58 <randomax> I didnt get you.. I have mentioned in both places about showing access rights.. by uniform i meant to show all possible options in the ACL list..
66 2014-06-07T14:23:14 *** greg_f
67 2014-06-07T14:26:57 <RogerHaase> OK, access rights... I what does clicking on admin do vs. clicking on write? and what about delete vs. destroy?
68 2014-06-07T14:29:16 *** greg_f
69 2014-06-07T14:30:39 <RogerHaase> randomax: show a CR so I can download and try it
70 2014-06-07T14:35:21 <RogerHaase> randomax: or maybe I do not understand, are admin/read/write/destroy clickable links?
71 2014-06-07T14:53:15 <randomax> ohh.. no actually they are meta data
72 2014-06-07T14:53:53 <randomax> as in the user can see what rights they have for a particular item
73 2014-06-07T14:53:59 <randomax> yeah i'll upload a cr
74 2014-06-07T14:54:40 <RogerHaase> randomax: ah, ok, are they somehow grayed or not shown if a user does not have the right?
75 2014-06-07T14:56:21 *** skathpalia
76 2014-06-07T15:02:15 <randomax> RogerHaase, i was thinking of not showing the rights one does not have
77 2014-06-07T15:06:00 <randomax> RogerHaase, besides i have another doubt regarding a 5th right that exists - the create right
78 2014-06-07T15:06:23 <randomax> in the docs it shows the definition as "create new items"
79 2014-06-07T15:06:38 <randomax> but would it apply to an existing item and if so what would it mean ?
80 2014-06-07T15:10:14 <RogerHaase> agree, showing authority to create an existing item is not useful
81 2014-06-07T15:17:17 <randomax> RogerHaase, cr - https://codereview.appspot.com/109730047
82 2014-06-07T15:34:46 <RogerHaase> randomax: assuming you show the text, in themes/__init__, you will need to translate Admin/Write...
83 2014-06-07T15:36:19 <RogerHaase> showing first letters of english words would not be useful for non-english speakers. Did you have ideas for icons?
84 2014-06-07T15:40:10 *** skathpalia
85 2014-06-07T15:40:30 <randomax> RogerHaase, yeah i looked at some icons.. i'll put up a screenshot with them.. too.. but i guess it is necessary to translate bcoz somehow we have to convey to the user about the meanings of the icons in case they dont get it at first
86 2014-06-07T15:42:17 *** sl33k_
87 2014-06-07T15:56:20 <ThomasWaldmann> moin
88 2014-06-07T15:56:41 <dimazest> hello
89 2014-06-07T15:56:58 <RogerHaase> moin
90 2014-06-07T15:59:16 <randomax> moin
91 2014-06-07T15:59:51 <ThomasWaldmann> skathpalia: are you with us?
92 2014-06-07T15:59:56 <skathpalia> yeah
93 2014-06-07T16:00:24 <ThomasWaldmann> ok, so welcome verybody to our weekly meeting!
94 2014-06-07T16:00:35 <ThomasWaldmann> randomax: can you begin this time?
95 2014-06-07T16:00:40 *** skathpalia
96 2014-06-07T16:00:46 <randomax> yep
97 2014-06-07T16:00:50 <randomax> done
98 2014-06-07T16:00:58 *** skathpalia
99 2014-06-07T16:01:14 <randomax> The quicklinks shortening
100 2014-06-07T16:01:22 <randomax> Improved search UI
101 2014-06-07T16:01:35 <randomax> * added more metadata
102 2014-06-07T16:01:58 <randomax> * colour coding stuff
103 2014-06-07T16:02:10 <ThomasWaldmann> do you have some current screenshots?
104 2014-06-07T16:02:26 <randomax> yeah - http://picpaste.com/pics/acl_fullname-raX8tUJz.1402148288.png
105 2014-06-07T16:02:48 <randomax> added ACL rights to the search UI
106 2014-06-07T16:03:08 <randomax> so the user can see what all rights they have for a particular item
107 2014-06-07T16:03:19 <ThomasWaldmann> search results look better, great
108 2014-06-07T16:03:28 <randomax> here is the cr for that - https://codereview.appspot.com/109730047
109 2014-06-07T16:03:34 <ThomasWaldmann> "search as you type" - means?
110 2014-06-07T16:03:44 <randomax> but i myself know some more changes to do in the cr
111 2014-06-07T16:04:02 <randomax> that is to make sure the user does not get confused
112 2014-06-07T16:04:11 *** magu_cic
113 2014-06-07T16:04:20 <ThomasWaldmann> i am confused, what does it mean?
114 2014-06-07T16:04:29 <randomax> as in there is no "Search" button
115 2014-06-07T16:04:41 <ThomasWaldmann> so?
116 2014-06-07T16:05:32 <RogerHaase> with just an input form, there is no way for a user to realize that just keying will trigger a search
117 2014-06-07T16:05:56 <randomax> so we thought that if the user does not know how the search would function, we could keep a small instruction
118 2014-06-07T16:06:04 <randomax> to help them
119 2014-06-07T16:06:06 <ThomasWaldmann> so does it update via ajax before hitting enter?
120 2014-06-07T16:06:16 <randomax> yeah
121 2014-06-07T16:06:46 <ThomasWaldmann> isn't that pretty obvious if the results change while one types?
122 2014-06-07T16:07:24 <ThomasWaldmann> also, move that "6 results found" down, it belongs to the results and should be near
123 2014-06-07T16:07:31 <RogerHaase> it was not obvious to me how to begin with no search button
124 2014-06-07T16:08:09 <randomax> ok.. i'll move that
125 2014-06-07T16:08:16 <ThomasWaldmann> a while ago, i thought we maybe should put that search button right of the entry box
126 2014-06-07T16:08:44 <ThomasWaldmann> just to say "this is search" and to give users who insist on a button something to click
127 2014-06-07T16:09:28 <ThomasWaldmann> if the results update dynamically, most will then realize than clicking that is optional and also that <enter> will trigger the default submit function
128 2014-06-07T16:10:40 <ThomasWaldmann> i somehow missed that permissions display discussion, can someone summarize it in 2 lines?
129 2014-06-07T16:11:04 <ThomasWaldmann> "Admin | Write | Read | Destroy" I mean
130 2014-06-07T16:11:26 <randomax> There is not much to say in that.. basically it shows what permissions a user has regarding a particular item
131 2014-06-07T16:11:46 <randomax> i had a doubt in the 5th permission that exists - "create" permission..
132 2014-06-07T16:12:02 <ThomasWaldmann> ok, I'ld consider that useful on the target item view. but display it in search results?
133 2014-06-07T16:12:42 <ThomasWaldmann> esp. since we of course only show search results where the user has read permission (otherwise it would be a security bug)
134 2014-06-07T16:13:11 <randomax> there is an existing provision in the search by which
135 2014-06-07T16:13:22 <randomax> the item's content extract is not shown
136 2014-06-07T16:13:56 <randomax> when they cant read it.. instead there will be a message saying "you dont have permission to read this"
137 2014-06-07T16:14:34 <randomax> i thought it would be better for the user to know what they can change and what they cant
138 2014-06-07T16:14:46 <ThomasWaldmann> ok, so what do you think, maybe rather move that permissions display to the item?
139 2014-06-07T16:15:30 <randomax> you mean besides the item title ?
140 2014-06-07T16:15:32 * ThomasWaldmann would not display too much information on the search results page, esp. if it is not that useful
141 2014-06-07T16:15:42 <ThomasWaldmann> somewhere, best place TBD
142 2014-06-07T16:16:36 <ThomasWaldmann> if one searches for something, the expectation is primarily to find and read it - and it only shows readable results anyway.
143 2014-06-07T16:16:52 <randomax> moreover i was thinking of implementing an extra search feature using this whereby user could search items they could write
144 2014-06-07T16:17:04 <randomax> or those which they can admin
145 2014-06-07T16:17:25 <RogerHaase> ThomasWaldmann: if a user does not have permission to view an item, should the item name be shown in the search results?
146 2014-06-07T16:17:32 <ThomasWaldmann> this is a rather special usecase, randomax
147 2014-06-07T16:18:16 <ThomasWaldmann> RogerHaase: i know moin 1.x did not show it at all then. for moin2, just keep current ("before randomax") behaviour
148 2014-06-07T16:19:37 <ThomasWaldmann> i don't remember precisely, but IF the names are shown, it maybe has a reason. it's not completely possible to hide the existance of some name anyway.
149 2014-06-07T16:19:59 <randomax> ThomasWaldmann, yeah i realise that
150 2014-06-07T16:20:24 <ThomasWaldmann> ok, so opinions please: have a search button right of the entry field that is triggered by <enter>?
151 2014-06-07T16:20:39 <ThomasWaldmann> kill the line below the entry field?
152 2014-06-07T16:21:11 <randomax> yeah can do that..
153 2014-06-07T16:21:46 <RogerHaase> having search button is better than having to explain what input box does
154 2014-06-07T16:22:00 <ThomasWaldmann> term suggestions are italic - did we have a special reason for that?
155 2014-06-07T16:23:06 <randomax> no not really.. i was just referring what google does.. so kept it that way
156 2014-06-07T16:23:33 *** magu_cic
157 2014-06-07T16:24:31 <ThomasWaldmann> right, "did you mean: xxx" xxx is also italic
158 2014-06-07T16:25:10 <RogerHaase> there was also an issue that checking/unchecking the SearchAllRevisions checkbox should trigger an ajax searh
159 2014-06-07T16:25:36 <ThomasWaldmann> that's solved now?
160 2014-06-07T16:25:36 <randomax> we had a doubt as to whether the revision id would be required to show in the search ?
161 2014-06-07T16:26:13 <randomax> No not yet.. i have to work on that
162 2014-06-07T16:26:17 <ThomasWaldmann> well, not necessarily if one only searches latests revs. but one needs it if one searches all revs.
163 2014-06-07T16:27:05 <ThomasWaldmann> iirc old moin used to show the revision number, we don't have that any more, it is revid now.
164 2014-06-07T16:27:19 <randomax> wouldnt the modified time be enough ?
165 2014-06-07T16:27:40 <ThomasWaldmann> and although such "cryptic" ids are not that informative, they help as identifier, e.g. if you want to talk about exactly that revision
166 2014-06-07T16:28:21 <ThomasWaldmann> if you are in different timezones, it might show different timestamps for same moment (iirc)
167 2014-06-07T16:28:32 <RogerHaase> I think timestamp is more useful than revision ID
168 2014-06-07T16:29:20 <randomax> ok
169 2014-06-07T16:29:43 <ThomasWaldmann> it also might show 5:00:00 pm for roger and 23:00:00 for me (e.g.)
170 2014-06-07T16:30:14 <randomax> yeah.. fine.. we'll let it be then
171 2014-06-07T16:30:17 <ThomasWaldmann> so, i think we should have both
172 2014-06-07T16:30:56 <randomax> yeah.. we already have both :D
173 2014-06-07T16:31:11 <ThomasWaldmann> normal people might rather use the timestamp (or try to), techies will rather use the id I think (see git, hg, ...)
174 2014-06-07T16:32:16 <randomax> yup
175 2014-06-07T16:32:23 <ThomasWaldmann> the content-type display should get less technical in the end, though. could be a filter telling just "text" or "image" and maybe the precise content-type in the mouseover bubble
176 2014-06-07T16:33:10 <randomax> ok.. i'll change that
177 2014-06-07T16:33:33 <RogerHaase> how would one get an image in the search results?
178 2014-06-07T16:34:28 <ThomasWaldmann> the links on search results at top right, are they now flushed right
179 2014-06-07T16:34:30 <ThomasWaldmann> ?
180 2014-06-07T16:35:00 <ThomasWaldmann> RogerHaase: if you search for vacation and you have some vacation-2014-xx.jpeg ...
181 2014-06-07T16:35:34 <ThomasWaldmann> using the exif metadata, you could even search for stuff from there
182 2014-06-07T16:35:40 <RogerHaase> ok, also works for tags
183 2014-06-07T16:36:35 <randomax> No i am currently waiting for skathpalia's pull regarding the shifted search bar to get merged
184 2014-06-07T16:36:59 <ThomasWaldmann> ok, i'll look at PRs later...
185 2014-06-07T16:37:26 <ThomasWaldmann> randomax: RogerHaase: how's progress compared to plan?
186 2014-06-07T16:38:21 <RogerHaase> behind, and not enough detailed planning. EP shows no plans for week 4
187 2014-06-07T16:39:46 <randomax> Umm i am left with the advanced search options for this week
188 2014-06-07T16:42:10 <randomax> but that should be over by monday i guess
189 2014-06-07T16:43:43 <ThomasWaldmann> ok, when catching up, try to parallelize to make use of mentor I/O wait time
190 2014-06-07T16:44:12 <ThomasWaldmann> also, always do first review yourself and remove issues you find yourself
191 2014-06-07T16:44:35 <ThomasWaldmann> ok, anything left for / from randomax ?
192 2014-06-07T16:44:39 <randomax> yeah.. i learnt to do that :)
193 2014-06-07T16:45:13 <randomax> nope
194 2014-06-07T16:47:29 <ThomasWaldmann> you didn't say "next" and "blockers", right?
195 2014-06-07T16:47:49 <randomax> i dont have any blockers
196 2014-06-07T16:48:09 <randomax> next is missing UI
197 2014-06-07T16:48:27 <randomax> and also fixing various bugs present in the UI currently
198 2014-06-07T16:49:05 <randomax> like the show section is supposed to highlight items
199 2014-06-07T16:49:20 <randomax> it has the css classes defined but there is no css defined for them
200 2014-06-07T16:49:33 <randomax> plus the item index is cluttered in the basic theme
201 2014-06-07T16:49:59 <ThomasWaldmann> ok. looks like we are through. thanks randomax and RogerHaase. skathpalia, your stage!
202 2014-06-07T16:50:14 <skathpalia> So Done:
203 2014-06-07T16:50:24 <skathpalia> Now Ticket Update is fully functional
204 2014-06-07T16:50:30 <skathpalia> Added fqname support to Notification Module, Made it independent of item_name
205 2014-06-07T16:50:39 <skathpalia> Also worked on having a very basic view of Ticket List
206 2014-06-07T16:50:46 <skathpalia> Here is the codereview for that https://codereview.appspot.com/102140045
207 2014-06-07T16:50:52 <skathpalia> Also the fixed the unit test which was earlier failing
208 2014-06-07T16:51:21 <skathpalia> Also Fixed #424 bug of searchbox dislocation
209 2014-06-07T16:51:55 <skathpalia> Blocked: None
210 2014-06-07T16:52:01 <skathpalia> TODO
211 2014-06-07T16:52:06 <skathpalia> Define css for the +tickets view
212 2014-06-07T16:52:12 <skathpalia> Add more features in this view such as sorting feature, filter by some tags etc
213 2014-06-07T16:52:26 <ThomasWaldmann> screenshot for ticket list?
214 2014-06-07T16:52:58 <ThomasWaldmann> hmm, ok, without css maybe not yet there ;)
215 2014-06-07T16:53:10 <dimazest> :)
216 2014-06-07T16:53:27 <skathpalia> Yeah I didn;t make any screenshot as the view is very simple
217 2014-06-07T16:54:32 <ThomasWaldmann> did you think / discuss / decide already about table sorting 3rd party code?
218 2014-06-07T16:55:06 <skathpalia> No I haven't decided upon it
219 2014-06-07T16:55:40 <dimazest> there was a library that is already used with moin 2.0
220 2014-06-07T16:55:47 <dimazest> should we try it first?
221 2014-06-07T16:55:51 <ThomasWaldmann> radomir recently packaged the mottie tablesorter for xstatic.
222 2014-06-07T16:55:55 <ThomasWaldmann> dimazest: which?
223 2014-06-07T16:56:07 <dimazest> though, i don't remember the name
224 2014-06-07T16:56:25 <skathpalia> Ok I will try to use that first
225 2014-06-07T16:56:34 <dimazest> did randomax suggested it last week?
226 2014-06-07T16:57:15 <dimazest> or RogerHaase (i don't really recall)
227 2014-06-07T16:57:20 * ThomasWaldmann already pointed to xstatic-tablesorter some days ago
228 2014-06-07T16:57:45 <dimazest> ok, than we go with it
229 2014-06-07T16:57:54 <skathpalia> yeah sure
230 2014-06-07T16:58:06 * ThomasWaldmann has no idea whether it is best suited for us. but i guess we could ask deshipu ("TheSheep") - if he packaged it he might have some experience with it.
231 2014-06-07T16:58:30 *** magu_cic
232 2014-06-07T16:58:31 <RogerHaase> i suggested mottie's, but thought it was xiaq that packaged it, as he also packaged tablesorter
233 2014-06-07T16:58:51 <ThomasWaldmann> for xstatic?
234 2014-06-07T17:00:15 <ThomasWaldmann> https://pypi.python.org/pypi/XStatic-DataTables/1.9.4.2
235 2014-06-07T17:00:42 <RogerHaase> https://pypi.python.org/pypi/XStatic-Tablesorter-Mottie/2.10.8.1
236 2014-06-07T17:00:48 <ThomasWaldmann> https://pypi.python.org/pypi/XStatic-JQuery.TableSorter/2.14.5.1
237 2014-06-07T17:01:14 <ThomasWaldmann> https://pypi.python.org/pypi/XStatic-Tablesorter-Mottie/2.10.8.1
238 2014-06-07T17:02:51 <ThomasWaldmann> looks like people first should search then package. the last 2 somehow look same!?
239 2014-06-07T17:03:37 <skathpalia> I will look to it and see which one suits the best for our purpose
240 2014-06-07T17:04:18 <RogerHaase> Yes, radomir's is more current
241 2014-06-07T17:04:27 <dimazest> exactly
242 2014-06-07T17:05:36 <ThomasWaldmann> guess i could update the other one
243 2014-06-07T17:05:53 * ThomasWaldmann will talk with TheSheep and then we'll see
244 2014-06-07T17:06:44 <ThomasWaldmann> did you think about sorting in python vs. in javascript (esp. in case there are a lot of tickets)?
245 2014-06-07T17:07:15 <skathpalia> I thought of using some javascript plugin
246 2014-06-07T17:08:34 <ThomasWaldmann> how will it work if we have 1000 tickets?
247 2014-06-07T17:09:07 <dimazest> will all 1000 be shown at once, or we need to paginate them?
248 2014-06-07T17:09:13 <skathpalia> Yeah may be it will be a bit slow in such case
249 2014-06-07T17:09:25 <dimazest> then we need to be able to sort on server side
250 2014-06-07T17:09:44 <skathpalia> Yeah I was thinking of having around 20 tickets per page
251 2014-06-07T17:09:52 * ThomasWaldmann likes to avoid pagination. such code is always a pain.
252 2014-06-07T17:10:11 <RogerHaase> I think js will always be fast enough, even for 1,000 or more tickets (have used with ~150 and is instant)
253 2014-06-07T17:10:48 <ThomasWaldmann> but that requires that we have the stuff we want in the table (-> make a good search and have the best hits)
254 2014-06-07T17:11:41 <skathpalia> Currently all information of tickets is passed to +tickets view
255 2014-06-07T17:11:45 <skathpalia> as per my cr
256 2014-06-07T17:12:35 <ThomasWaldmann> maybe we can have some ajaxy behaviour (like search results view) for tickets also
257 2014-06-07T17:12:40 <skathpalia> so js will be dealing with all information regarding tickets
258 2014-06-07T17:13:28 <skathpalia> Yeah we can have that also
259 2014-06-07T17:13:37 <ThomasWaldmann> we need: sort by prio, difficulty, severity, workamount, created / last modified
260 2014-06-07T17:13:51 <ThomasWaldmann> and: filter by tag(s)
261 2014-06-07T17:15:19 <ThomasWaldmann> ok, so lets try having all lookup results processed by js tablesorter first
262 2014-06-07T17:15:43 <skathpalia> Yeah we will see that first :)
263 2014-06-07T17:16:15 <ThomasWaldmann> you understood what i meant with the 1..5 scale?
264 2014-06-07T17:16:39 <skathpalia> in th cr?
265 2014-06-07T17:16:58 <ThomasWaldmann> (what I forgot to mention on the CR is that the issue even gets worse with translations to other languages)
266 2014-06-07T17:17:13 <skathpalia> Yeah I got your point regarding that
267 2014-06-07T17:18:05 <skathpalia> I have updated the cr accordingly and also made Summary, Difficulty, Severity, Priority, Effort necessary fields
268 2014-06-07T17:18:50 <ThomasWaldmann> important is that priority is arranged so it is somehow visible that it is a function of the others (and other stuff)
269 2014-06-07T17:19:33 <ThomasWaldmann> so Diff Sev Eff together, plus Prio right or left of that
270 2014-06-07T17:20:20 <ThomasWaldmann> btw, if you implement tags in a good way, we have an advantage over bitbucket
271 2014-06-07T17:20:32 <skathpalia> You mean clustering Diff, Eff, Sev in one column and priority in separate column of table?
272 2014-06-07T17:20:46 <ThomasWaldmann> no, separate cols, just nearby
273 2014-06-07T17:20:51 <skathpalia> Oh
274 2014-06-07T17:21:54 <skathpalia> Yeah the cr is according to that only
275 2014-06-07T17:22:01 <skathpalia> I mean the clustering part
276 2014-06-07T17:22:52 <skathpalia> How can we make Tags better?
277 2014-06-07T17:23:01 <ThomasWaldmann> bitbucket has no tags
278 2014-06-07T17:23:09 <ThomasWaldmann> and that really sucks
279 2014-06-07T17:23:30 <ThomasWaldmann> github only has tags. that's elegant on first glance, but practically sucks also. :D
280 2014-06-07T17:24:23 <ThomasWaldmann> additionally, bitbucket fscked up the "priority" wording
281 2014-06-07T17:24:35 <skathpalia> Yeah
282 2014-06-07T17:24:44 <ThomasWaldmann> there is a funny ticket on their tracker about it
283 2014-06-07T17:25:35 <ThomasWaldmann> the problem with such stuff is, that if different people understand it differently, you basically have no usable data in there.
284 2014-06-07T17:26:32 <ThomasWaldmann> ok, any more questions?
285 2014-06-07T17:26:42 <skathpalia> I have one
286 2014-06-07T17:26:45 <ThomasWaldmann> how about progress vs. plan?
287 2014-06-07T17:27:05 <skathpalia> Progress is Ok wrt to plan mentioned in EP
288 2014-06-07T17:27:22 <ThomasWaldmann> dimazest: ?
289 2014-06-07T17:28:41 <skathpalia> I think that there needs to be separate templates for tickets for different themes
290 2014-06-07T17:28:50 <dimazest> well
291 2014-06-07T17:29:03 <RogerHaase> bbl
292 2014-06-07T17:29:26 <ThomasWaldmann> skathpalia: that should be avoided
293 2014-06-07T17:29:36 <dimazest> so far the plan is respected, the simple +tickets view is there
294 2014-06-07T17:30:00 <dimazest> the coming week more features will be added
295 2014-06-07T17:30:19 <skathpalia> ThomasWaldmann, I will try to avoid that
296 2014-06-07T17:32:21 <ThomasWaldmann> maybe the tickets view could have some predefined widgets (like the tablesorter with the results), but also a flexible search line
297 2014-06-07T17:32:40 <ThomasWaldmann> that just gets a whoosh query that is considered additionally
298 2014-06-07T17:33:10 <ThomasWaldmann> at the beginning, that can even compensate for the lack of some more pretty/easy ui maybe
299 2014-06-07T17:33:58 <ThomasWaldmann> does that make sense? :)
300 2014-06-07T17:33:59 <skathpalia> Yeah will try to add search feature also
301 2014-06-07T17:34:36 <skathpalia> It would be helpful for users
302 2014-06-07T17:34:55 <ThomasWaldmann> maybe just do a very simple input field. maybe we can reuse some stuff from randomax later.
303 2014-06-07T17:35:27 <skathpalia> Yeah sure
304 2014-06-07T17:36:07 <ThomasWaldmann> ok, anything else ( skathpalia: I'ld like to discuss whoosh query after meeting, if possible)
305 2014-06-07T17:36:10 <ThomasWaldmann> ?
306 2014-06-07T17:36:18 <skathpalia> nope
307 2014-06-07T17:37:20 <ThomasWaldmann> dimazest: ?
308 2014-06-07T17:37:51 <dimazest> no, i don't have any questions
309 2014-06-07T17:38:09 <ThomasWaldmann> ok, then thanks for attending. happy hacking next week!
310 2014-06-07T17:38:27 <dimazest> see you!
311 2014-06-07T17:38:29 <ThomasWaldmann> skathpalia: can you point me to file / lineno of current ticket query?
312 2014-06-07T17:39:07 <skathpalia> query for getting all ticket items?
313 2014-06-07T17:39:16 <ThomasWaldmann> yes
314 2014-06-07T17:39:34 <skathpalia> https://codereview.appspot.com/102140045/patch/150001/160001
315 2014-06-07T17:40:57 <ThomasWaldmann> ok, so you have just one term and no limits
316 2014-06-07T17:41:22 <ThomasWaldmann> don't we have a constant for that u'ticket' btw?
317 2014-06-07T17:41:24 <skathpalia> Yeah for now I have kept no limit
318 2014-06-07T17:41:42 <skathpalia> It is not defined in constants/keys/py
319 2014-06-07T17:41:49 <skathpalia> *keys.py
320 2014-06-07T17:42:12 <ThomasWaldmann> itemtypes.py:ITEMTYPE_TICKET = u'ticket'
321 2014-06-07T17:42:15 <skathpalia> But in some files it is locally defined as ITEMTYPE_TICKET
322 2014-06-07T17:42:25 *** magu_cic
323 2014-06-07T17:42:34 <ThomasWaldmann> should be imported from there
324 2014-06-07T17:42:44 *** randomax
325 2014-06-07T17:42:46 <skathpalia> Okay will do that
326 2014-06-07T17:43:58 <ThomasWaldmann> ok, so if you have that term and the query input field, you know what to do then before you give it to whoosh?
327 2014-06-07T17:44:01 *** magu_cic
328 2014-06-07T17:44:46 <skathpalia> before giving to whoosh?
329 2014-06-07T17:45:25 <ThomasWaldmann> before calling searcher.search()
330 2014-06-07T17:45:34 <skathpalia> I mean if I am given some term and input field I can write query to search for it
331 2014-06-07T17:46:01 <ThomasWaldmann> the input field just gives you a unicode string, not a term
332 2014-06-07T17:47:10 <skathpalia> I think I need to check in all fields for that string
333 2014-06-07T17:47:20 <skathpalia> or the substring of that
334 2014-06-07T17:48:17 <ThomasWaldmann> maybe have a look at the "normal" search code. basically, you give the query text (unicode) to a query parser (see whoosh api).
335 2014-06-07T17:48:48 <skathpalia> Okay will look into it and try to apply it
336 2014-06-07T17:48:53 <ThomasWaldmann> as a result, you get that parsed into a query.
337 2014-06-07T17:49:24 <ThomasWaldmann> but you don't only have that query, you will still have to add that fixed term (that you only search for ticket items).
338 2014-06-07T17:49:54 <skathpalia> Yeah that will be fixed term
339 2014-06-07T17:50:06 <ThomasWaldmann> so, what logical operation do you need to couple these 2?
340 2014-06-07T17:50:20 <skathpalia> And
341 2014-06-07T17:51:01 <ThomasWaldmann> exactly. and then you have just 1 query and give it to search().
342 2014-06-07T17:51:24 *** magu_cic
343 2014-06-07T17:52:30 <ThomasWaldmann> maybe also have a "only open" vs. "all tickets" toggle. "only open" should be the default.
344 2014-06-07T17:52:41 *** magu_cic
345 2014-06-07T17:53:09 <skathpalia> Yeah will add that feature also
346 2014-06-07T17:53:20 <ThomasWaldmann> after a while, you have lots of closed tickets in a project (hopefully), so these can be filtered out early.
347 2014-06-07T17:54:42 <ThomasWaldmann> then the js will have less work sorting the stuff (same for browser not needing to render it).
348 2014-06-07T17:55:07 <ThomasWaldmann> ok, happy hacking :)
349 2014-06-07T17:55:14 <skathpalia> Thanks :)
350 2014-06-07T17:56:15 *** skathpalia
351 2014-06-07T17:57:17 *** magu_cic
352 2014-06-07T17:58:11 * ThomasWaldmann looks at PRs now
353 2014-06-07T18:16:48 *** magu_cic
354 2014-06-07T18:30:15 *** greg_f
355 2014-06-07T18:43:21 <RogerHaase> ThomasWaldmann: randomax's pull request is messed up. The PR does not match the CR https://codereview.appspot.com/95600044/ The PR also has a change to basic.css. That problem exists in current tip if you do a m css. After his PR, there is another commit that fixes same basic.css issue separately
356 2014-06-07T19:13:50 *** magu_cic
357 2014-06-07T19:28:37 *** magu_cic
358 2014-06-07T21:34:03 <ThomasWaldmann> RogerHaase: oops, already merged all stuff
359 2014-06-07T21:34:55 <ThomasWaldmann> RogerHaase: can you check whether the main repo code has a problem now?
360 2014-06-07T21:35:42 <RogerHaase> ThomasWaldmann: I did the same, I think it is OK, but will check again...
361 2014-06-07T21:37:02 <ThomasWaldmann> btw, merging is often having merge conflicts in basic.css. maybe we should remove that generated file from repo?
362 2014-06-07T21:39:32 <RogerHaase> no, the problem was caused by an older randomax commit. Looks like he updated basic.less and then did not do another ./m css
363 2014-06-07T21:41:26 <ThomasWaldmann> (I didn't mean only the current issue, rather the fundamental issue.)
364 2014-06-07T21:42:32 <RogerHaase> there is still a problem, doing ./m css on tip still changes basic.css
365 2014-06-07T21:44:02 <RogerHaase> I would say we still need to keep basic.css in repo. These problems should not happen as basic, modernized, and foobar are all compiled using ./m css
366 2014-06-07T21:44:42 <ThomasWaldmann> less 1.4.2 is that ok?
367 2014-06-07T21:45:58 <RogerHaase> afaik any recent version of lessc is OK, Stylus version must be 0.42.2
368 2014-06-07T21:46:43 <RogerHaase> With newer stylus, the --compress option compresses to 1 line
369 2014-06-07T21:49:01 <ThomasWaldmann> hmm, our docs don't say how to install 0.42.2
370 2014-06-07T21:49:51 <RogerHaase> sudo npm install stylus@0.42.2 -g
371 2014-06-07T21:52:53 <ThomasWaldmann> tw@tux:~/w/moin-2.0$ stylus -V
372 2014-06-07T21:52:53 <ThomasWaldmann> /usr/bin/env: node: No such file or directory
373 2014-06-07T21:52:53 <ThomasWaldmann> tw@tux:~/w/moin-2.0$ lessc -V
374 2014-06-07T21:52:53 <ThomasWaldmann> /usr/bin/env: node: No such file or directory
375 2014-06-07T21:53:07 <ThomasWaldmann> i installed both, no errors at install time, but now that ^
376 2014-06-07T21:54:45 <RogerHaase> oh, I hit that bug too. There is some xxx-legacy thing I had to install
377 2014-06-07T21:55:47 <ThomasWaldmann> nodejs-legacy - evented I/O for V8 javascript (legacy symlink)
378 2014-06-07T21:55:50 <ThomasWaldmann> that ?
379 2014-06-07T21:56:00 <RogerHaase> yes
380 2014-06-07T21:56:29 <RogerHaase> at least that sounds like what I installed
381 2014-06-07T21:56:35 <ThomasWaldmann> yup, worked
382 2014-06-07T21:57:49 * ThomasWaldmann updates docs
383 2014-06-07T22:02:42 <ThomasWaldmann> RogerHaase: and with older stylus --compress does ...?
384 2014-06-07T22:02:59 <ThomasWaldmann> and, is that that the only reason why we use the 0.42.2 one?
385 2014-06-07T22:04:36 <RogerHaase> older makes one line per rule, all spaces removed
386 2014-06-07T22:05:29 <ThomasWaldmann> ok and new is 1 line for whole output?
387 2014-06-07T22:05:55 <RogerHaase> yes, 1 line for whole output
388 2014-06-07T22:11:26 <ThomasWaldmann> ok, updated the css and docs.
389 2014-06-07T22:11:30 <ThomasWaldmann> and pushed
390 2014-06-07T22:13:57 <RogerHaase> ok! much better
391 2014-06-07T22:16:53 * ThomasWaldmann tries current code "live" now ...
392 2014-06-07T22:19:42 <RogerHaase> ThomasWaldmann: when you have time, still have docbook cr https://codereview.appspot.com/101960044/ and this if you want to view http://www.digitalrockart.org/moin2/docbook
393 2014-06-07T22:24:06 <ThomasWaldmann> updating tickets does not work for me
394 2014-06-07T22:24:27 <ThomasWaldmann> there is no way to create a nameless ticket (yet), so i created one with a name
395 2014-06-07T22:25:06 <ThomasWaldmann> when trying to update that, it suddenly says "item 'someticket' does not exist"
396 2014-06-07T22:27:17 <ThomasWaldmann> so, create with name works, update destroys the (already existing) name
397 2014-06-07T22:27:43 <ThomasWaldmann> ok, looking at CR now...
398 2014-06-07T22:34:06 <ThomasWaldmann> RogerHaase: comments on docbook stuff on CR
399 2014-06-07T22:34:51 <ThomasWaldmann> maybe the unicode char is easiest way to solve?
400 2014-06-07T22:37:36 <ThomasWaldmann> Unicode Character 'REGISTERED SIGN' (U+00AE)
401 2014-06-07T22:38:17 <ThomasWaldmann> Unicode Character 'COPYRIGHT SIGN' (U+00A9)
402 2014-06-07T22:38:38 <ThomasWaldmann> Unicode Character 'TRADE MARK SIGN' (U+2122)
403 2014-06-07T22:40:18 <ThomasWaldmann> https://en.wikipedia.org/wiki/List_of_XML_and_HTML_character_entity_references there is a bigger list
404 2014-06-07T22:53:16 <RogerHaase> there was not a char for service mark. If you create a char rather than put an element on the DOM, thern won't there be a problem trying to round-trip?
405 2014-06-07T22:56:10 <RogerHaase> also, in some examples I saw, they highlighted the trademark text, which is a possibility with the span
406 2014-06-07T23:00:51 <RogerHaase> ThomasWaldmann: ^^ must leave soon
407 2014-06-07T23:06:34 <ThomasWaldmann> yeah, roundtrip is a problem. we maybe do not want to look for all these chars to reverse-engineer docbook from them.
408 2014-06-07T23:07:14 <ThomasWaldmann> RogerHaase: ^
409 2014-06-07T23:09:15 <RogerHaase> so the span is OK?
410 2014-06-07T23:10:21 <RogerHaase> ThomasWaldmann: gtg
411 2014-06-07T23:10:26 *** RogerHaase
412 2014-06-07T23:11:34 <ThomasWaldmann> guess either span or creation of a "markup" node (or a unicode-text special purpose node for roundtripping)
