1 2014-06-17T02:35:03 *** penguinRaider
2 2014-06-17T02:41:06 *** derdon
3 2014-06-17T04:19:20 *** penguinRaider
4 2014-06-17T04:48:20 *** penguinRaider
5 2014-06-17T05:14:26 *** penguinRaider
6 2014-06-17T05:35:00 *** sl33k_
7 2014-06-17T06:15:12 *** sl33k_
8 2014-06-17T06:18:07 *** penguinRaider
9 2014-06-17T06:46:34 *** sl33k_
10 2014-06-17T06:53:36 *** magu_cic
11 2014-06-17T06:56:33 *** magu_cic_
12 2014-06-17T07:28:51 *** sl33k_
13 2014-06-17T07:44:51 *** skathpalia
14 2014-06-17T07:46:45 *** sl33k_
15 2014-06-17T07:56:54 <skathpalia> dimazest, I have made some changes in the cr
16 2014-06-17T07:58:39 <dimazest> looks good
17 2014-06-17T07:59:18 <skathpalia> Can I commit it now?
18 2014-06-17T08:00:38 <dimazest> yes you can, but the tests and the blog are on the todo list
19 2014-06-17T08:00:46 <skathpalia> Yeah sure
20 2014-06-17T08:04:11 *** magu_cic
21 2014-06-17T08:04:43 *** magu_cic
22 2014-06-17T08:16:35 *** sl33k_
23 2014-06-17T08:16:35 *** skathpalia
24 2014-06-17T08:16:36 *** jek
25 2014-06-17T08:16:37 *** dimazest
26 2014-06-17T08:16:37 *** waldi
27 2014-06-17T08:20:40 *** skathpalia
28 2014-06-17T08:20:57 *** sl33k_
29 2014-06-17T08:20:57 *** 1JTAAIS09
30 2014-06-17T08:20:57 *** jek
31 2014-06-17T08:21:16 *** dimazest
32 2014-06-17T08:21:16 *** waldi
33 2014-06-17T08:21:34 *** 1JTAAIS09
34 2014-06-17T08:21:47 <skathpalia> Wrote a blog post http://sksaurabhkathpalia.blogspot.in/2014/06/gsoc-update-finalized-tickets-view-with.html
35 2014-06-17T08:23:16 *** magu_cic
36 2014-06-17T08:23:50 <skathpalia> dimazest, ^^
37 2014-06-17T08:24:53 *** magu_cic
38 2014-06-17T08:30:35 *** skathpalia
39 2014-06-17T08:33:20 *** sl33k_
40 2014-06-17T08:33:21 *** jek
41 2014-06-17T08:34:54 *** magu_cic_
42 2014-06-17T08:37:57 *** magu_cic
43 2014-06-17T08:44:08 *** sl33k_
44 2014-06-17T08:44:08 *** jek
45 2014-06-17T08:45:06 *** skathpalia
46 2014-06-17T08:49:49 *** skathpalia
47 2014-06-17T09:07:25 <dimazest> nice
48 2014-06-17T09:10:00 *** greg_f
49 2014-06-17T10:28:25 *** magu_cic_
50 2014-06-17T10:29:06 *** magu_cic
51 2014-06-17T10:30:16 *** magu_cic_
52 2014-06-17T10:48:27 *** derdon
53 2014-06-17T11:11:52 *** magu_cic_
54 2014-06-17T11:13:06 *** magu_cic
55 2014-06-17T11:16:17 *** magu_cic
56 2014-06-17T12:02:51 *** sl33k_
57 2014-06-17T12:07:51 *** sl33k_
58 2014-06-17T12:19:50 *** skathpalia
59 2014-06-17T12:21:51 *** sl33k_
60 2014-06-17T12:29:29 *** sl33k_
61 2014-06-17T12:32:12 *** skathpalia
62 2014-06-17T12:49:04 *** RogerHaase
63 2014-06-17T14:25:35 *** Bernard2
64 2014-06-17T14:41:47 *** RogerHaase
65 2014-06-17T14:49:33 *** sl33k_
66 2014-06-17T14:56:46 *** randomax
67 2014-06-17T15:07:58 *** skathpalia
68 2014-06-17T15:09:32 <skathpalia> ThomasWaldmann, dimazest I tried making a ticket-create button in +tickets view and I found a simple way
69 2014-06-17T15:10:28 <skathpalia> First we can set fqname = None if the ticket is being created
70 2014-06-17T15:11:59 <skathpalia> Then we don't need to get the item which is done in this line https://bitbucket.org/thomaswaldmann/moin-2.0/src/1663ebfcb4c4a474f02673b1dbe5ac02f4a79012/MoinMoin/items/__init__.py?at=default#cl-538
71 2014-06-17T15:13:50 <skathpalia> Instead we use a temporary name = itemtype here just for creating item, this name won't ever remain with it, it is just used so that we can use store_revision
72 2014-06-17T15:14:25 <skathpalia> I mean replacing the above line with storage_item = backend[self.itemtype]
73 2014-06-17T15:15:17 <skathpalia> And also I have kept namespace to be u'' for tickets (this part may be changed afterwards)
74 2014-06-17T15:16:38 <skathpalia> I know it seems a work around kind of thing but this way we use the the old cycle of creating and editing items
75 2014-06-17T15:17:05 <skathpalia> Here is the cr https://codereview.appspot.com/106110043
76 2014-06-17T15:31:01 *** skathpalia
77 2014-06-17T15:38:38 *** Bernard2
78 2014-06-17T16:20:24 *** sl33k_
79 2014-06-17T16:24:52 *** sl33k_
80 2014-06-17T16:27:49 *** randomax
81 2014-06-17T16:36:59 *** sl33k_
82 2014-06-17T18:26:54 *** RogerHaase
83 2014-06-17T18:35:08 <RogerHaase> ThomasWaldmann: docbook audio and video https://codereview.appspot.com/101960044/
84 2014-06-17T18:36:23 <RogerHaase> ThomasWaldmann: mediawiki parser fixes: prevent traceback, add ins tag, remove ## style comment https://codereview.appspot.com/109000044/
85 2014-06-17T18:37:06 <ThomasWaldmann> moin
86 2014-06-17T18:39:23 *** greg_f
87 2014-06-17T18:41:21 <ThomasWaldmann> RogerHaase: first done
88 2014-06-17T18:43:46 <RogerHaase> ThomasWaldmann: right, no unicode character for Service Mark
89 2014-06-17T18:46:22 <ThomasWaldmann> done the other also
90 2014-06-17T19:05:51 *** sl33k_
91 2014-06-17T19:41:21 <RogerHaase> ThomasWaldmann: per your comment https://codereview.appspot.com/109000044/diff/1/MoinMoin/converter/mediawiki_in.py#newcode545: does that mean to use <s>, del>, <u>, and <ins> tags instead of <span> tags with text decoration? See line 487 also
92 2014-06-17T19:47:57 <RogerHaase> ThomasWaldmann: with the span tags, there can be no different rendering as text-decoration for s + del will be line-through and for u + ins text-decoration will be underline
93 2014-06-17T19:49:02 <ThomasWaldmann> RogerHaase: i don't remember how it is usually handled (or if we already have such code in other converters)
94 2014-06-17T19:52:42 <ThomasWaldmann> but i think we should be able to render differently
95 2014-06-17T19:52:55 <ThomasWaldmann> so we should not lose information early
96 2014-06-17T19:56:27 <RogerHaase> ok, will convert to s, del, u, and ins (better for round-tripping). fyi, other parsers use span with text decoration
97 2014-06-17T20:10:03 *** magu_cic
98 2014-06-17T20:19:13 *** jek
99 2014-06-17T20:19:43 <dimazest> skathpalia, this looks a bit hackish to me and can be problematic in the future (for some other developer, or even you)
100 2014-06-17T20:19:58 <dimazest> i would like to see a clean solution
101 2014-06-17T20:20:07 *** jek
102 2014-06-17T21:42:13 <RogerHaase> ThomasWaldmann: mediawiki with s, del, u, and ins tags https://codereview.appspot.com/109000044/
103 2014-06-17T22:06:15 *** RogerHaase
104 2014-06-17T22:48:11 *** derdon
105
MoinMoin: MoinMoinChat/Logs/moin-dev/2014-06-17 (last edited 2014-06-17 02:45:03 by IrcLogImporter)