1 2014-06-22T00:01:38 *** sl33k_
2 2014-06-22T02:40:17 *** sl33k_
3 2014-06-22T03:04:19 *** waldi
4 2014-06-22T03:04:26 *** waldi
5 2014-06-22T03:04:26 *** waldi
6 2014-06-22T06:04:02 *** sl33k_
7 2014-06-22T06:27:05 *** sl33k_
8 2014-06-22T07:23:33 *** sl33k_
9 2014-06-22T07:43:51 *** sl33k_
10 2014-06-22T10:14:13 *** sl33k_
11 2014-06-22T10:30:00 *** sl33k_
12 2014-06-22T10:38:06 *** sl33k_
13 2014-06-22T10:45:24 *** sl33k_
14 2014-06-22T10:55:19 *** sl33k_
15 2014-06-22T11:02:10 *** randomax
16 2014-06-22T11:08:36 *** sl33k_
17 2014-06-22T11:27:45 *** sl33k_
18 2014-06-22T11:43:56 *** sl33k_
19 2014-06-22T12:29:50 *** penguinRaider
20 2014-06-22T12:35:27 *** sl33k_
21 2014-06-22T13:36:42 *** derdon
22 2014-06-22T13:44:47 <ThomasWaldmann> moin
23 2014-06-22T13:44:58 * ThomasWaldmann is back
24 2014-06-22T13:47:06 *** penguinRaider
25 2014-06-22T14:15:33 *** RogerHaase
26 2014-06-22T14:24:50 <RogerHaase> ThomasWaldmann: mediawiki fixes https://codereview.appspot.com/109000044/
27 2014-06-22T14:25:26 <RogerHaase> ThomasWaldmann: 438 and 439 fixes https://codereview.appspot.com/107250045/
28 2014-06-22T14:27:51 <RogerHaase> ThomasWaldmann: revised serialized/items.moin http://www.digitalrockart.org/moin2/Home changed docbook, mediawiki, added Other Test Items , non-English items, tags
29 2014-06-22T14:29:03 <RogerHaase> ThomasWaldmann: randomax was looking for review on cr needed https://codereview.appspot.com/109730047
30 2014-06-22T15:08:12 <ThomasWaldmann> hi RogerHaase
31 2014-06-22T15:08:30 <RogerHaase> moin :)
32 2014-06-22T15:10:45 <ThomasWaldmann> about s/u/del/ins:
33 2014-06-22T15:11:45 <ThomasWaldmann> i somehow liked the span as representing both s and u by just saying "well, this is a span and it is (underlined|strikethrough)". no need to have 2 different tags for that imho.
34 2014-06-22T15:12:40 <ThomasWaldmann> what i didn't like is that ins was thrown together with underlined (and del together with strikethrough), mixing up semantics with styling
35 2014-06-22T15:13:04 <ThomasWaldmann> this is bad, ins could be also green and del could be red or whatever.
36 2014-06-22T15:13:25 <ThomasWaldmann> but, it's all somehow a span neverthelesss
37 2014-06-22T15:15:10 <ThomasWaldmann> so, maybe have another attribute to span, like semantics="(inserted|deleted)"?
38 2014-06-22T15:16:40 <ThomasWaldmann> (the output converter would then choose whatever is most appropriate to represent that in the output markup)
39 2014-06-22T15:20:23 <RogerHaase> ThomasWaldmann: that seems different from what we discussed here: http://moinmo.in/MoinMoinChat/Logs/moin-dev/2014-06-17#CA-3a52329d6593f977ba025a1db7741e8b974e31b6_91 why use a span when there is a tag that means exactly what is wanted? Using a span with text-decoration seems like mixing CSS into HTML
40 2014-06-22T15:25:45 <RogerHaase> seems like you are trying to do <span class="u">, <span class="ins">, span class="del">,...
41 2014-06-22T15:26:04 <ThomasWaldmann> i just said we should be able to render different and not lose info
42 2014-06-22T15:27:23 <ThomasWaldmann> yeah, somehow it is class. if class means semantics.
43 2014-06-22T15:28:04 <ThomasWaldmann> and some semantics could of course directly imply styling (like "underline that")
44 2014-06-22T15:29:09 <ThomasWaldmann> the problem with using "class=x" on that level might be that it will be associated too much with styling rather than semantics maybe?
45 2014-06-22T15:29:23 *** sl33k_
46 2014-06-22T15:30:46 <ThomasWaldmann> just my thoughts. we can also go with s u del ins for now and see how it works out.
47 2014-06-22T15:31:31 <RogerHaase> do you intend html_out to render those into s, u, ins, del tags or span tags with a class?
48 2014-06-22T15:34:55 <ThomasWaldmann> i don't know what's better currently. just keep as is?
49 2014-06-22T15:35:57 <ThomasWaldmann> the theme should be able to style ins/del however it wants.
50 2014-06-22T15:36:19 <ThomasWaldmann> so it shall not be harcoded ins --> underline and del --> strikethrough
51 2014-06-22T15:39:29 <RogerHaase> ok, using the u, s, ins, del tags seems better to me. It was my intent to change the other parsers to also use the s, u, ins, del tags later (where those are supported). Right now, no themes have CSS for those tags (other than reset). Can put a TODO for styling into serialized/items.moin
52 2014-06-22T15:41:54 <ThomasWaldmann> maybe rather issue tracker?
53 2014-06-22T15:42:16 <RogerHaase> ok
54 2014-06-22T15:42:24 <ThomasWaldmann> also check if we maybe have css rules, just for other tags (that were used for that before)
55 2014-06-22T15:45:10 <RogerHaase> will check, but I think it was <span text-decoration="underline/line-through"> everywhere
56 2014-06-22T15:50:27 <ThomasWaldmann> http://html5doctor.com/ins-del-s/ there is some discussion about this
57 2014-06-22T16:15:39 <ThomasWaldmann> RogerHaase: 2nd review done. need to go soon, though.
58 2014-06-22T16:20:46 <RogerHaase> gtg
59 2014-06-22T16:20:49 *** RogerHaase
60 2014-06-22T17:24:20 *** skathpalia
61 2014-06-22T17:26:34 *** penguinRaider
62 2014-06-22T17:47:24 *** penguinRaider
63 2014-06-22T18:17:35 *** sl33k_
64 2014-06-22T18:20:20 *** skathpalia
65 2014-06-22T18:35:15 *** randomax
66