MoinMoin: MoinMoinPatch/SetuidFixReplaceOsAccess/History

MoinMoinPatch/SetuidFixReplaceOsAccess

Historical Discussions

• bug: exception not handled

  • 2009-04-26 15:05:00

    • The above patch obviously does NOT work as intended by author

    • because of an IOError exception is raised.

  • Unw 2009-04-26 16:20:00

    • Thank you for prompt testing.
    • Can you provide replication details (such as some of the following) please?
      • distro and OS version?
      • Specific IOError message?
      • where is message seen? web browser? moin log? apache log?
      • python version?
      • web server and version?
      • data directory user? group? permissions?
      • (if known), failed file name? user? group? permissions?
      • moin.cgi user? group? permissions?
      • setuid wrapper name? user? group? permissions?
      • web agent user? group? umask (default permissions)?
      • what setuid wrapper?
      • runuser(8)?
        • custom?
          • is source code available?
      • if using apache, did you remember to restart apache, or send it SIGHUP

  • ThomasWaldmann 2009-04-26 17:32:48

    • I didn't use moin or your patch,
    • I just did this in an interactive python 2.4 interpreter on Linux:

    • open("/bin/ls", "a")

    • Your patch is obviously expecting to get a file object when writing/appending works
    • and something falsy, when it doesn't. This is just not the case,
    • you get an IOError when you can't write/append to the file due to mising permissions.

  • Unw 2009-04-26 19:20:00

    • Replaced object test with try/except block.
    • Testing successful.
• bug: extra parentheses

  • 2009-04-26 19:00:00 no need for additonal () here

    • What is the difference between (os.path.isdir(path_pages)) and os.path.isdir(path_pages)

  • Unw 2009-04-27 11:00:00

    • Thank you for the prompt review.
    • The extra parentheses have been removed from multiconfig.py .
    • Testing successful.