Can you please state where the PageEditor and PageGraphicalEditor classes are in your class hierarchy -- FlorianFesti
- They arent there because I dont believe they are in scope. Those two things are merely presentational layer for the page and should be kept loosely coupled. -- A
- Those two classes Fabi is talking about currently handle all storage related matters for normal pages (just writing, reading is done in Page). So you should somehow reference them.
- I know they do, if you can give good justification then I will, but to be honest I can't see any.
- Currently they directly operate on the file level. You need at least to refactor them. No idea if that qualifies them to appear in that image.
- Oh certainly, the adapter will sort that out for old code. New stuff would need to this implemented seperately.
As you dont want to monkey-path calls like file(), you have to modify the PageEditor class as well to use the new interface.
- Oh certainly, the adapter will sort that out for old code. New stuff would need to this implemented seperately.
- Currently they directly operate on the file level. You need at least to refactor them. No idea if that qualifies them to appear in that image.
- I know they do, if you can give good justification then I will, but to be honest I can't see any.
- Those two classes Fabi is talking about currently handle all storage related matters for normal pages (just writing, reading is done in Page). So you should somehow reference them.
- They arent there because I dont believe they are in scope. Those two things are merely presentational layer for the page and should be kept loosely coupled. -- A