1 2013-09-07T07:43:51 <ananasova> moin
2 2013-09-07T10:54:43 <sharky93> moin
3 2013-09-07T11:16:53 <TheSheep> sharky93: hey
4 2013-09-07T11:16:59 <TheSheep> sharky93: how did the exams go?
5 2013-09-07T11:30:21 <sharky93> TheSheep: hi, exams went well :)
6 2013-09-07T11:32:17 <TheSheep> \o/
7 2013-09-07T11:35:42 * sharky93 back to work, currently with proper placing of comments and transclusion buttons.
8 2013-09-07T11:37:50 <TheSheep> sharky93: remember about the docs for building the theme
9 2013-09-07T11:38:12 <sharky93> sure
10 2013-09-07T11:38:32 <TheSheep> so that people can keep on improving it
11 2013-09-07T11:40:37 <sharky93> TheSheep: btw, the recommended timeline for adding documentation and further scrubbing of the code is the last week of SoC, 16th-23rd should we do it then?
12 2013-09-07T11:44:57 <TheSheep> sharky93: no, you read it wrong
13 2013-09-07T11:45:10 <TheSheep> sharky93: it doesn't say that you should put off writing documentation
14 2013-09-07T11:45:18 <TheSheep> sharky93: it
15 2013-09-07T11:45:32 <TheSheep> sharky93: it's the emergency time slot for finishing up
16 2013-09-07T11:45:51 <sharky93> ah, hmm ..
17 2013-09-07T13:52:45 <sharky93> TheSheep: comments and transclusions within a dropdown with "Show" in the navbar makes sense?
18 2013-09-07T13:54:01 <sharky93> TheSheep: since we cannot have two triggers with a click, i think showing the drop-down onHover willdo, no?
19 2013-09-07T13:54:43 <sharky93> by two triggers i mean navigation to the hyperlink for "show" and showing the dropdown..
20 2013-09-07T13:58:14 <TheSheep> sharky93: can't you just have checkboxes?
21 2013-09-07T14:00:07 <sharky93> TheSheep: where do we place the checkbox?
22 2013-09-07T14:00:17 <TheSheep> in the place of the icon
23 2013-09-07T14:00:38 <TheSheep> in the right-hand menu
24 2013-09-07T14:06:27 <sharky93> TheSheep: oh, so the traditional checkbox? i was thinking of using the bootstrap version,like it is now, i.e a toggle.
25 2013-09-07T14:17:25 <sharky93> TheSheep: is there some disadvantage with the bootstrap version of checkbox?
26 2013-09-07T14:19:18 <TheSheep> if you can put it in the menu normally, then no
27 2013-09-07T14:48:22 *** xorAxAx
28 2013-09-07T14:49:23 *** xorAxAx
29 2013-09-07T18:04:31 <ananasova> ThomasWaldmann: does that look ok? should i commit? https://codereview.appspot.com/13418045/
30 2013-09-07T18:19:41 <ThomasWaldmann> ananasova: done
31 2013-09-07T18:22:17 <ananasova> ThomasWaldmann: i will change the interface of _get_data_diff_html, but i assume we don't need to change the _render methods.
32 2013-09-07T18:31:58 <ThomasWaldmann> only change what's necessariy to get consistence
33 2013-09-07T18:32:07 <ThomasWaldmann> -i
34 2013-09-07T19:22:50 <ananasova> ThomasWaldmann: there is a bit of a problem, _get_data_diff_html() requires rev objects for showing meta. therefore only data files are not enough
35 2013-09-07T19:25:39 <ThomasWaldmann> formatting stuff via html or via text is not fundamentally different regarding the contents you might want to show
36 2013-09-07T19:28:54 <ananasova> the method _get_data_diff_text is simply to get a text diff, nothing more. _get_data_diff_html is more of a rendering method, its output is used by the /+diff/ view
37 2013-09-07T19:32:02 <ananasova> i'd say the method name is a bit misleading, maybe we should change it?
38 2013-09-07T19:32:54 <ThomasWaldmann> it gets a data diff as html, what's misleading?
39 2013-09-07T19:35:15 <ananasova> it gets the data diff and the meta of 2 revisions also
40 2013-09-07T19:36:10 <ThomasWaldmann> if you display a diff, also displaying information what's what isn't that far fetched
41 2013-09-07T19:36:57 <ThomasWaldmann> but if you rather want to split that than to converge against it, you can do that, too
42 2013-09-07T19:38:23 <ananasova> probably split the getting of html diff and the rendering of the whole diff table + meta
MoinMoin: MoinMoinChat/Logs/moin-dev/2013-09-07 (last edited 2013-09-07 07:45:02 by IrcLogImporter)