1 2014-07-06T00:57:25 *** penguinRaider
2 2014-07-06T03:41:02 *** RogerHaase
3 2014-07-06T03:43:43 *** RogerHaase
4 2014-07-06T04:36:05 *** RogerHaase
5 2014-07-06T04:37:43 <RogerHaase> skathpalia: updated #421 with more info, no solution
6 2014-07-06T04:37:51 *** RogerHaase
7 2014-07-06T04:51:45 *** penguinRaider
8 2014-07-06T05:02:56 *** penguinRaider
9 2014-07-06T05:03:24 *** skathpalia
10 2014-07-06T05:07:59 *** skathpalia
11 2014-07-06T05:55:07 *** penguinRaider
12 2014-07-06T06:15:22 *** skathpalia
13 2014-07-06T07:18:45 *** penguinRaider
14 2014-07-06T07:35:04 *** penguinRaider
15 2014-07-06T08:47:36 *** randomax
16 2014-07-06T09:19:48 *** penguinRaider
17 2014-07-06T09:39:04 *** penguinRaider
18 2014-07-06T10:35:42 *** randomax
19 2014-07-06T10:39:04 *** penguinRaider
20 2014-07-06T11:28:01 *** penguinRaider
21 2014-07-06T11:37:58 *** randomax
22 2014-07-06T12:11:50 *** penguinRaider
23 2014-07-06T13:08:40 <ThomasWaldmann> moin
24 2014-07-06T13:17:15 *** skathpalia
25 2014-07-06T13:18:04 <randomax> moin
26 2014-07-06T13:20:49 *** penguinRaider
27 2014-07-06T13:21:07 <skathpalia> ThomasWaldmann, added modify, User Actions, Item Actions etc in blog's layout.html as pointed in https://bitbucket.org/thomaswaldmann/moin-2.0/issue/421/cannot-update-blog-or-blog-entry-items
28 2014-07-06T13:21:15 <skathpalia> cr: https://codereview.appspot.com/105590043/
29 2014-07-06T14:04:53 <ThomasWaldmann> dimazest: review done
30 2014-07-06T14:07:01 <dimazest> i saw it
31 2014-07-06T14:07:25 <dimazest> i'm writing replies
32 2014-07-06T14:15:49 <dimazest> yes, I need to compare the tests with and without tests
33 2014-07-06T14:16:12 <dimazest> also time required to run tests should be compared
34 2014-07-06T14:16:46 <dimazest> new tests setup might take more time because the application context is created for every test
35 2014-07-06T14:21:15 *** skathpalia
36 2014-07-06T14:41:55 *** randomax
37 2014-07-06T14:48:10 *** randomax
38 2014-07-06T14:56:14 *** greg_f
39 2014-07-06T15:01:47 *** RogerHaase
40 2014-07-06T15:06:17 <ThomasWaldmann> dimazest: maybe there could be different app fixtures with different scopes
41 2014-07-06T15:06:56 <dimazest> right, but i didn't try it yet
42 2014-07-06T15:09:24 <ThomasWaldmann> which py.test version did you use, btw?
43 2014-07-06T15:10:31 <dimazest> 2.5.2
44 2014-07-06T15:26:34 <randomax> ThomasWaldmann, updated crs
45 2014-07-06T15:26:35 <randomax> https://codereview.appspot.com/106390046/
46 2014-07-06T15:26:37 <ThomasWaldmann> dimazest: you could also remove the pytest-pep8 version requirement, see the comment right of it
47 2014-07-06T15:26:42 <randomax> https://codereview.appspot.com/106430043/
48 2014-07-06T15:26:52 <randomax> https://codereview.appspot.com/110210043/
49 2014-07-06T15:27:32 <ThomasWaldmann> dimazest: also watch out for tests that are skipped (e.g. due to library dependencies)
50 2014-07-06T15:27:44 <dimazest> ok, i'll do that
51 2014-07-06T15:27:58 * dimazest didn't notice the pytest.pep8 restriction
52 2014-07-06T15:32:52 <ThomasWaldmann> randomax: did you practically try may(fqname)?
53 2014-07-06T15:34:04 *** magu_cic
54 2014-07-06T15:34:10 <randomax> ThomasWaldmann, yes
55 2014-07-06T15:37:41 *** magu_cic_
56 2014-07-06T15:39:51 <randomax> ThomasWaldmann, regarding https://codereview.appspot.com/110210043/ ... I have already answered the question there itself
57 2014-07-06T15:40:13 <randomax> I want to show an link to an item as a valid link in case it does not belong to the local wiki. So thats why i check it and if it is not the local wiki, i set exists as true in case of a non-local wiki.
58 2014-07-06T15:42:13 *** magu_cic
59 2014-07-06T15:42:51 <ThomasWaldmann> no you didn't. read the question again.
60 2014-07-06T15:43:14 <ThomasWaldmann> and have a look at what the functions you call really do.
61 2014-07-06T15:43:42 *** magu_cic
62 2014-07-06T15:48:51 <randomax> ThomasWaldmann, it is not a generic "link_exists" functionality.. i made for the meta view only
63 2014-07-06T15:49:20 <randomax> i'll change the name to "meta_link_exists" if it is ambiguous
64 2014-07-06T16:12:49 <RogerHaase> randomax: if is_local_wiki(wikiname): is checking whether user name is local wiki, how is that related to whether link_itemname is also the local wiki?
65 2014-07-06T16:15:33 *** magu_cic
66 2014-07-06T16:16:53 *** magu_cic
67 2014-07-06T16:26:18 <randomax> RogerHaase, I am first trying to check if the user is in his home wiki or not.. if he is then i can check whether the item exists in the users wiki storage or not.. if he is not in his home wiki i guess we cannot check whether item exists in his wiki or not
68 2014-07-06T16:28:31 <RogerHaase> randomax: have you installed a wiki farm?
69 2014-07-06T16:28:53 <randomax> no..
70 2014-07-06T16:28:59 *** skathpalia_
71 2014-07-06T16:29:29 <randomax> i just saw the same method being everywhere else also in the code..
72 2014-07-06T16:29:43 <randomax> wherever they check for exists functionality
73 2014-07-06T16:30:55 <RogerHaase> randomax: hmm, I think checking user is irrelevant, but you want to check link_itemname is local
74 2014-07-06T16:35:07 *** skathpalia_
75 2014-07-06T16:35:18 <randomax> RogerHaase, how to create a wikifarm ?
76 2014-07-06T16:36:38 <RogerHaase> randomax: dk, I started trying to follow docs, but got interrupted and never finished. Seems not easy.
77 2014-07-06T16:38:15 <RogerHaase> Pointing a link to an interwiki site for a test should be easier.
78 2014-07-06T16:39:03 <skathpalia> RogerHaase, I added modify and other important links in the blog layout.html https://codereview.appspot.com/105590043/
79 2014-07-06T16:39:37 <skathpalia> as mentioned in #421
80 2014-07-06T16:45:22 <RogerHaase> skathpalia: I saw, Basic works better. I am still thinking the modernized/foobar problems lies within templates differences, but that is a guess
81 2014-07-06T16:46:55 <skathpalia> I am also trying to find the cause of this error
82 2014-07-06T16:49:21 *** magu_cic_
83 2014-07-06T16:49:32 <skathpalia> RogerHaase, what does the field element.raw signify?
84 2014-07-06T16:49:45 <skathpalia> I mean what is it used for?
85 2014-07-06T16:50:32 <RogerHaase> skathpalia: dk, seems to be some flatland magic
86 2014-07-06T16:52:10 *** magu_cic
87 2014-07-06T16:57:08 <RogerHaase> randomax: if you look at User tab, InterWiki Names link, you will see that MyMoinmoin is in the list. If you had a wiki farm, there would be other names in there for the farm wikis. So I think testing [[MeatBall:InterWiki]] link is testing for any other farm wiki
88 2014-07-06T16:57:40 <RogerHaase> ...at least I hope tat is true...
89 2014-07-06T16:58:10 <RogerHaase> I have to leave in a few minutes
90 2014-07-06T16:59:22 <RogerHaase> is testing/is same as testing
91 2014-07-06T17:01:07 *** RogerHaase
92 2014-07-06T17:05:40 <dimazest> ThomasWaldmann: here is the pytest output diff
93 2014-07-06T17:05:46 * dimazest looks at it
94 2014-07-06T17:15:45 *** skathpalia
95 2014-07-06T17:17:07 *** skathpalia
96 2014-07-06T17:28:56 *** magu_cic
97 2014-07-06T17:31:29 *** randomax
98 2014-07-06T17:32:06 *** magu_cic_
99 2014-07-06T18:20:12 *** greg_f
100 2014-07-06T18:22:25 *** skathpalia
101 2014-07-06T19:49:58 *** RogerHaase
102 2014-07-06T22:04:19 <RogerHaase> ThomasWaldmann: small fix for missing lineno attr in "moin item-put ..." https://codereview.appspot.com/104550045/
103 2014-07-06T22:23:20 *** RogerHaase
104