1 2015-01-23T01:15:45 *** vikramahuja1001
2 2015-01-23T01:23:31 *** yogicxl
3 2015-01-23T01:40:28 *** vikramahuja1001
4 2015-01-23T05:33:02 *** Kallor
5 2015-01-23T07:53:47 *** yogicxl
6 2015-01-23T08:31:21 *** vpv_
7 2015-01-23T09:39:06 *** greg_f
8 2015-01-23T09:49:11 *** aabs08
9 2015-01-23T09:57:12 <yogicxl> ThomasWaldmann, I have solved the issue 463, and have created a readonly view for it. Could you please review my code
10 2015-01-23T09:57:24 <yogicxl> The link is http://codereview.appspot.com/195380043
11 2015-01-23T10:03:19 *** pjoshi_
12 2015-01-23T10:05:11 *** pjoshi_
13 2015-01-23T10:05:39 *** pjoshi_
14 2015-01-23T10:06:39 <pjoshi_> ThomasWaldmann: HAve a look at code review https://codereview.appspot.com/139660043/#ps120001
15 2015-01-23T10:07:15 <pjoshi_> Here extra css is removed I don't know why...I have installed stylus also
16 2015-01-23T10:07:58 <pjoshi_> Otherwise the issue regarding https://bitbucket.org/thomaswaldmann/moin-2.0/issue/455/global-index-view-has-odd-link-to-anchor has been solved
17 2015-01-23T10:14:29 *** aabs08
18 2015-01-23T10:19:38 *** aabs08
19 2015-01-23T10:21:17 <pjoshi_> aabs08: are you working on https://bitbucket.org/thomaswaldmann/moin-2.0/issue/483/login-and-logout-redirection
20 2015-01-23T10:21:19 <pjoshi_> ?
21 2015-01-23T10:21:30 <aabs08> yes
22 2015-01-23T10:21:41 <pjoshi_> okay.
23 2015-01-23T10:21:44 <pjoshi_> :)
24 2015-01-23T10:26:59 <aabs08> yogicxl, why you added extra line in base.html?
25 2015-01-23T10:37:36 <aabs08> ThomasWaldmann, I got my patch 2 using next variable https://codereview.appspot.com/194330043/
26 2015-01-23T10:39:03 *** Kallor
27 2015-01-23T11:22:57 *** vikramahuja1001
28 2015-01-23T11:23:34 *** aabs08
29 2015-01-23T11:28:49 <yogicxl> aabs08, so that it is easy to read
30 2015-01-23T12:03:38 *** pjoshi_
31 2015-01-23T12:53:13 *** dave_largo
32 2015-01-23T13:11:03 *** vikramahuja1001
33 2015-01-23T13:40:46 *** pjoshi_
34 2015-01-23T13:55:45 *** Kallor
35 2015-01-23T13:58:17 *** artista
36 2015-01-23T14:05:09 *** aabs08
37 2015-01-23T14:06:38 <pjoshi_> ThomasWaldmann: Please review https://codereview.appspot.com/139660043/
38 2015-01-23T14:07:59 <ThomasWaldmann> link to issue tracker issue?
39 2015-01-23T14:08:17 <ThomasWaldmann> (always give that in CR description)
40 2015-01-23T14:08:43 <pjoshi_> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/455/global-index-view-has-odd-link-to-anchor
41 2015-01-23T14:10:22 *** aabs08
42 2015-01-23T14:13:38 <ThomasWaldmann> pjoshi_: you link to show, not to index
43 2015-01-23T14:15:42 <pjoshi_> ThomasWaldmann: Oh.. So we need the url on the sign to be /+index/that_item_name
44 2015-01-23T14:15:43 <pjoshi_> ?
45 2015-01-23T14:16:01 <pjoshi_> rather than /that_item_name
46 2015-01-23T14:18:10 <ThomasWaldmann> pjoshi_: that's what I read in the issue
47 2015-01-23T14:18:29 <pjoshi_> hmm
48 2015-01-23T14:35:31 <yogicxl> ThomasWaldmann, I have solved the issue 463, and have created a readonly view for it. Could you please review my code. The link is http://codereview.appspot.com/195380043
49 2015-01-23T15:05:04 *** pjoshi_
50 2015-01-23T15:11:41 *** aabs08
51 2015-01-23T15:14:13 <aabs08> ThomasWaldmann, Issue #483 regarding login/logout redirection and codereview https://codereview.appspot.com/194330043/
52 2015-01-23T15:25:07 *** sl33k_
53 2015-01-23T15:32:47 *** yogicxl
54 2015-01-23T15:33:39 *** artista
55 2015-01-23T16:47:03 *** pjoshi_
56 2015-01-23T16:48:00 <ThomasWaldmann> aabs08: done
57 2015-01-23T16:48:12 * ThomasWaldmann needs to go now, bbl
58 2015-01-23T16:50:07 *** aabs08
59 2015-01-23T16:53:34 *** pjoshi_
60 2015-01-23T16:54:12 *** pjoshi_
61 2015-01-23T16:54:27 <pjoshi_> ThomasWaldmann: Please review the code https://codereview.appspot.com/139660043/
62 2015-01-23T16:54:50 <pjoshi_> The issue was 455 https://bitbucket.org/thomaswaldmann/moin-2.0/issue/455/global-index-view-has-odd-link-to-anchor
63 2015-01-23T16:57:58 *** skathpalia
64 2015-01-23T17:10:07 *** pjoshi_
65 2015-01-23T17:17:32 *** sl33k_
66 2015-01-23T17:32:49 *** yogicxl
67 2015-01-23T17:34:36 <yogicxl> ThomasWaldmann, Please review http://codereview.appspot.com/195380043
68 2015-01-23T17:45:19 *** aabs08
69 2015-01-23T17:49:24 *** skathpalia
70 2015-01-23T17:51:01 *** grvanm
71 2015-01-23T18:02:43 *** pjoshi_
72 2015-01-23T18:03:41 <pjoshi_> ThomasWaldmann: Please review the code for issue 455 https://codereview.appspot.com/139660043/
73 2015-01-23T18:27:31 *** greg_f
74 2015-01-23T18:41:48 <aabs08> ThomasWaldmann, issue #483 ,new patch without session variable https://codereview.appspot.com/194330043/
75 2015-01-23T18:50:07 *** pjoshi_
76 2015-01-23T18:53:45 *** aabs08
77 2015-01-23T19:07:59 *** RogerHaase
78 2015-01-23T19:11:52 <yogicxl> RogerHaase, i was working on issue #463 and have fixed it. Here's link to my code. http://codereview.appspot.com/195380043 Could you advise?
79 2015-01-23T19:30:33 *** vikramahuja1001
80 2015-01-23T19:39:11 <RogerHaase> yo done
81 2015-01-23T19:39:18 <RogerHaase> yogicxl: done
82 2015-01-23T19:41:35 *** aabs08
83 2015-01-23T19:42:09 <yogicxl> RogerHaase, Actually when you use show in tabs you are checking at current revision here no revision id is passed. It is CURRENT. When you use one in dropup for particular history item you are viewing historical revisions, so revid is passed
84 2015-01-23T19:43:21 <aabs08> hi RogerHaase , whats the easiest and efficient way to check whether a user is logged in or not in frontend/views.py ?
85 2015-01-23T19:44:04 <yogicxl> RogerHaase, In the do_show of items/ticket.py if revid != CURRENT it gives 403 message, and there was TODO for readonly page construstion for such views
86 2015-01-23T19:44:17 <yogicxl> RogerHaase, Hence I created one
87 2015-01-23T19:45:35 <RogerHaase> yogicxl: yes, I saw that, so now I am trying to view a non-current version of a ticket (so I can see your read-only view)
88 2015-01-23T19:46:38 <yogicxl> RogerHaase, yes exactly
89 2015-01-23T19:47:45 *** skathpalia
90 2015-01-23T19:49:45 <RogerHaase> aabs08: a guess is test flaskg.user.valid for true
91 2015-01-23T19:50:18 <aabs08> flaskg.user.valid is right thanx :)
92 2015-01-23T19:51:46 <aabs08> RogerHaase, should I get my codereview by ThomasWaldmann only as he reviewed previous patches or you can also review it ?
93 2015-01-23T19:52:14 <yogicxl> RogerHaase, how do i proceed?
94 2015-01-23T19:52:15 <RogerHaase> aabs08: I can look, but tw reviews my changes as well
95 2015-01-23T19:52:50 *** skathpalia
96 2015-01-23T19:53:33 <RogerHaase> yogicxl: ah, I found the show link
97 2015-01-23T19:53:50 <aabs08> sure , issue #483 and codereview link https://codereview.appspot.com/194330043/
98 2015-01-23T19:53:54 <yogicxl> RogerHaase, ok?
99 2015-01-23T19:53:58 *** pjoshi_
100 2015-01-23T19:58:14 <aabs08> RogerHaase, by tw you meant Thomas Waldmaan right ?
101 2015-01-23T19:58:24 <RogerHaase> yes
102 2015-01-23T19:59:03 <aabs08> I was searching for internet slangs :D and found this lol http://onlineslangdictionary.com/meaning-definition-of/tw
103 2015-01-23T19:59:56 <aabs08> my brains clicked after a while
104 2015-01-23T20:00:59 <yogicxl> RogerHaase, what do i do now?
105 2015-01-23T20:03:53 <RogerHaase> explain changes to ticket.css and revert the blank line in base.html
106 2015-01-23T20:05:14 <RogerHaase> yogicxl: and run ./m coding-std to see complaints about indention
107 2015-01-23T20:05:47 <yogicxl> RogerHaase, the changes in ticket.css were due to the fact that everything below MetaData floated right. besides the comment box. So its width had to be increased.
108 2015-01-23T20:09:57 <RogerHaase> yogicxl: see https://moin-20.readthedocs.org/en/latest/devel/development.html#add-more-tools-exercise-tools under set options on your favorite editor or IDE -- convert tabs to 4 spaces
109 2015-01-23T20:10:28 <yogicxl> RogerHaase, ok i ll do that. No prob :)
110 2015-01-23T20:21:07 <RogerHaase> yogicxl: is your monitor 1600 pixels wide?
111 2015-01-23T20:23:00 <yogicxl> RogerHaase, nopes y?
112 2015-01-23T20:24:15 *** vikramahuja1001
113 2015-01-23T20:27:34 <RogerHaase> yogicxl: at ~1620 pixels the meta data still floats to the right of issue text. Other than requiring a higher resolution, I don not see a difference caused by your css change
114 2015-01-23T20:30:10 <yogicxl> RogerHaase, hmm ok.. so what do I do about it?
115 2015-01-23T20:36:25 <RogerHaase> are you objecting to the metadata being floated to right of issue text?
116 2015-01-23T20:38:32 <yogicxl> RogerHaase, sry i didn't understand. but yes the metadata floats to right when theres one comment. the case i checked
117 2015-01-23T20:41:11 <RogerHaase> I don't understand prior comment: yogicxl: RogerHaase, the changes in ticket.css were due to the fact that everything below MetaData floated right. besides the comment box. So its width had to be increased.
118 2015-01-23T20:43:06 <yogicxl> RogerHaase, ok the metadata and everything below shifted right, next to the comment box. So in order to bring it down I increased widt of its div tag such that both dont fit side by side and metadata floats down
119 2015-01-23T20:44:25 <RogerHaase> but it still floats to right at windows width of ~1620+
120 2015-01-23T20:46:41 <RogerHaase> are you saying it is OK to float right at 1650 and not at 1400?
121 2015-01-23T20:47:17 <yogicxl> RogerHaase, no, I ll fix that.
122 2015-01-23T20:52:27 <yogicxl> RogerHaase, actually how do we fix that?
123 2015-01-23T20:55:17 <aabs08> ThomasWaldmann, in case you look into logs , #483 issue and new codereview https://codereview.appspot.com/194330043/
124 2015-01-23T20:55:26 *** aabs08
125 2015-01-23T20:55:40 <RogerHaase> I would just revert the css changes. If you feel the metadata floating is a problem, it is at least a different problem.
126 2015-01-23T21:01:41 <pjoshi_> RogerHaase: It works
127 2015-01-23T21:01:42 <pjoshi_> https://codereview.appspot.com/139660043/
128 2015-01-23T21:02:48 <yogicxl> RogerHaase, ok i ll revert the change in css file. Should I put the code for review then?
129 2015-01-23T21:03:27 <RogerHaase> yes, but also take care of the blank line
130 2015-01-23T21:06:19 *** dave_largo
131 2015-01-23T21:06:31 <yogicxl> RogerHaase, yes i will take care of that.
132 2015-01-23T21:15:33 <yogicxl> RogerHaase, please review https://codereview.appspot.com/195380043
133 2015-01-23T21:37:01 <RogerHaase> yogicxl: now you have added 2 blank lines to base.html with no other changes?
134 2015-01-23T21:39:29 <pjoshi_> RogerHaase: is that okay https://codereview.appspot.com/139660043/
135 2015-01-23T21:42:48 <RogerHaase> pjoshi_: looks OK to me, ask tw for review
136 2015-01-23T21:48:58 <pjoshi_> RogerHaase: Okay thanks.
137 2015-01-23T21:50:24 <yogicxl> RogerHaase, sry, please review this https://codereview.appspot.com/195380043/
138 2015-01-23T21:50:50 <yogicxl> RogerHaase, base.html as it was before and changes in ticket.css removed
139 2015-01-23T21:58:17 <yogicxl> RogerHaase, is it done?
140 2015-01-23T21:59:21 <RogerHaase> yogicxl: still busy with other stuff, try ThomasWaldmann or waldi, else I will look tomorrow
141 2015-01-23T21:59:48 *** aabs08
142 2015-01-23T22:01:52 <yogicxl> RogerHaase, ok thanks
143 2015-01-23T22:02:06 *** randomax
144 2015-01-23T22:09:50 *** pjoshi_
145 2015-01-23T22:11:57 <RogerHaase> if any of you installed less version 2.2.0, it causes problems when compiling CSS with the command "./m css". See bottom of https://bitbucket.org/thomaswaldmann/moin-2.0/issue/484/lessc-220-omits-comments-from-basic-static for how to install version 1.7.5
146 2015-01-23T22:12:28 <RogerHaase> gtg
147 2015-01-23T22:12:31 *** RogerHaase
148 2015-01-23T22:17:04 <randomax> ThomasWaldmann, moin.. i was wondering if i would be eligible for mentorship..
149 2015-01-23T22:29:33 *** aabs08
150 2015-01-23T22:31:33 *** grvanm
151 2015-01-23T22:31:55 *** yogicxl
152
